Hi all,
I've been working on a Clojure package for MXNet. Since Clojure is a JVM
language, the package leverages the great work of the existing Scala
package.
I would appreciate any feedback and testing.
Here is the original issue:
https://github.com/apache/incubator-mxnet/issues
packages with almost zero effort?
2018-06-01 21:58 GMT+01:00 Carin Meier :
> Hi all,
>
> I've been working on a Clojure package for MXNet. Since Clojure is a JVM
> language, the package leverages the great work of the existing Scala
> package.
>
> I would appreciate any feed
It is always a good thing to consider the cost with the benefit. I'll do my
best to explain what I see the tradeoffs to be.
First, I wanted to clarify that it took significant development effort to
get the Clojure package and the interop working properly despite my simple
looking design o
work in Clojure.
I am in support of a MXNet-Clojure package, I request you to add more unit
tests and integration tests that can be ported to CI.
Thanks for your efforts.
-Naveen
On Fri, Jun 1, 2018 at 6:16 PM, Carin Meier wrote:
> It is always a good thing to consider the cost with
ty of making Scala
> work in Clojure.
>
> I am in support of a MXNet-Clojure package, I request you to add more unit
> tests and integration tests that can be ported to CI.
>
> Thanks for your efforts.
>
> -Naveen
>
>
>
> On Fri, Jun 1, 2018 at 6:16 PM, Carin Meier
understand the complexity of making Scala
> > work in Clojure.
> >
> > I am in support of a MXNet-Clojure package, I request you to add more
> unit
> > tests and integration tests that can be ported to CI.
> >
> > Thanks for your efforts.
> >
> > -Nav
>>> Hi Carin,
>>>
>>> This is great effort and very nicely documented. When I surveyed at my
>> day
>>> job on the interest for Scala packages there were a few people who
>>> specifically were interested in the Clojure packages, I think those ar
Thanks for the feedback everyone.
I agree on the contrib option. I think it's a great path forward and would
allow it time for feedback, contribution by others, and stabilization.
If I'm understanding correctly, that would mean putting the source code in:
~/mxnet/contrib/clojure-pa
d mean putting the source code in:
> ~/mxnet/contrib/clojure-package
>
> and having the artifact jar named
> `org.apache.contrib.clojure-mxnet/clojure-mxnet`
>
> I would recommend not having the individual namespaces of the files have
> contrib embedded in them, so that if it gradua
ing correctly, that would mean putting the source code
> in:
> > ~/mxnet/contrib/clojure-package
> >
> > and having the artifact jar named
> > `org.apache.contrib.clojure-mxnet/clojure-mxnet`
> >
> > I would recommend not having the individual namespaces of th
~/mxnet/contrib/clojure-package good place for the code.
the package name org.apache.mxnet.contrib.clojure ? do you need mxnet again?
I forgot to request to run some benchmarks and document. One of the reasons
users use MXNet is because of its performance and we want to ensure that we
maintain
I would suggest using code generators in case upstream library adding the
functions for arrays.
It seems that cpp binding is using a code generator and works fine.
2018-06-05 7:59 GMT+01:00 Naveen Swamy :
> ~/mxnet/contrib/clojure-package good place for the code.
>
> the pac
generator and works fine.
>
> 2018-06-05 7:59 GMT+01:00 Naveen Swamy :
>
> > ~/mxnet/contrib/clojure-package good place for the code.
> >
> > the package name org.apache.mxnet.contrib.clojure ? do you need mxnet
> > again?
> >
> > I forgot to reques
ine.
> >
> > 2018-06-05 7:59 GMT+01:00 Naveen Swamy :
> >
> > > ~/mxnet/contrib/clojure-package good place for the code.
> > >
> > > the package name org.apache.mxnet.contrib.clojure ? do you need mxnet
> > > again?
> > >
> > > I
rary adding
> the
> > > functions for arrays.
> > > It seems that cpp binding is using a code generator and works fine.
> > >
> > > 2018-06-05 7:59 GMT+01:00 Naveen Swamy :
> > >
> > > > ~/mxnet/contrib/clojure-package good place for the
ogether a PR with your feedback
> > and
> > > post it here.
> > >
> > > On Tue, Jun 5, 2018 at 4:05 AM, Chen HY wrote:
> > >
> > > > I would suggest using code generators in case upstream library adding
> > the
> > > > functions for
:
>
>> I would suggest using code generators in case upstream library adding the
>> functions for arrays.
>> It seems that cpp binding is using a code generator and works fine.
>>
>> 2018-06-05 7:59 GMT+01:00 Naveen Swamy :
>>
>> > ~/mxnet/contr
;> functions for arrays.
>>> It seems that cpp binding is using a code generator and works fine.
>>>
>>> 2018-06-05 7:59 GMT+01:00 Naveen Swamy :
>>>
>>> > ~/mxnet/contrib/clojure-package good place for the code.
>>> >
>>> > t
wrote:
>>>
>>>> I would suggest using code generators in case upstream library adding the
>>>> functions for arrays.
>>>> It seems that cpp binding is using a code generator and works fine.
>>>>
>>>> 2018-06-05 7:59 GMT+01:00 Naveen S
> >> - Carin
> >>
> >>
> >> On Tue, Jun 5, 2018 at 11:40 AM, Carin Meier
> wrote:
> >>
> >>> Thanks everyone. I'll work on getting together a PR with your feedback
> >>> and post it here.
> >>>
> >>
I personally think that is the reason the clojure package should use more
code generator.
It makes easier to build everything align with scala package.
2018-06-10 12:45 GMT+01:00 Naveen Swamy :
> I have called for contribution within my organization to help with the
> review, some of the
a confluence page of the general state of what is working and needs
help.
https://cwiki.apache.org/confluence/display/MXNET/Clojure+Package+Contribution+Needs.
Feel free to edit.
Chen,
I added the code generator use on the page as well. I don't fully
understand what you are proposing, but I
an make it
> work, it will be the best way for it to grow along with the MXNet project
> and be a good fit with its goals and ecosystem long term.
>
> I added a confluence page of the general state of what is working and needs
> help.
> https://cwiki.apache.org/confluence/display/MX
it with its goals and ecosystem long term.
> >
> > I added a confluence page of the general state of what is working and
> needs
> > help.
> > https://cwiki.apache.org/confluence/display/MXNET/
> > Clojure+Package+Contribution+Needs.
> > Feel free to edit.
t
>>> and be a good fit with its goals and ecosystem long term.
>>>
>>> I added a confluence page of the general state of what is working and
>> needs
>>> help.
>>> https://cwiki.apache.org/confluence/display/MXNET/
>>> Clojure+Package+Contrib
e the best way for it to grow along with the MXNet
> project
> >>> and be a good fit with its goals and ecosystem long term.
> >>>
> >>> I added a confluence page of the general state of what is working and
> >> needs
> >>> help.
> >&
ere are some
> challenges
> > >> in
> > >>> trying to bring in a new language package, but I think if we can make
> > it
> > >>> work, it will be the best way for it to grow along with the MXNet
> > project
> > >>> and be a good fit w
; > > >>> work, it will be the best way for it to grow along with the MXNet
> > > project
> > > >>> and be a good fit with its goals and ecosystem long term.
> > > >>>
> > > >>> I added a confluence page of the general sta
> > >>
> > > > >> My guess is Chen is recommending generation of Clojure code from
> > > Scala.
> > > > >>
> > > > >>> On Sun, Jun 10, 2018 at 2:55 PM, Carin Meier <
> carinme...@gmail.com
> > >
> > &g
t; >> can make features available iteratively. I understand you alone
> > > can't
> > > > > have
> > > > > >> everything in one go, I am hoping more contributors will join
> the
> > > > > effort.
> > > > > >>
gt; > > > >> this is fantastic, thanks for being a champ. I am glad to have
> > you
> > > > > join
> > > > > > us
> > > > > > >> :). Yes, we would love to make it work and be available for
> our
> > >
ce page to help with
transparency and give everyone a better idea where the level of testing is
currently.
https://cwiki.apache.org/confluence/display/MXNET/Clojure+Package+Contribution+Needs
On Mon, Jun 11, 2018 at 6:24 PM, Marco de Abreu <
marco.g.ab...@googlemail.com> wrote:
>
Kovas Boguta https://twitter.com/kovasb, from the Clojure/AI community,
graciously took some time to review the PR for the clojure package.
He had some insightful feedback and high level questions that I thought
might be of interest to the larger dev mailing list.
https://github.com/apache
Carin,
Thanks for contributing so much to MXNet!
I just went through the planned MXNet v1.3 release scope [1], and did not
see the Clojure package. I think it would be a great addition to MXNet, and
initially can be marked as experimental.
Did you consider adding it to MXNet 1.3 as an
[1], and did not
> see the Clojure package. I think it would be a great addition to MXNet, and
> initially can be marked as experimental.
>
> Did you consider adding it to MXNet 1.3 as an experimental feature?
>
> Hagay
>
> [1]
> https://cwiki.apache.org/confluence/disp
I'd like to announce the introduction of CI integration tests for the
Clojure package. This is a big win for stability and maturity thanks to the
efforts of contributor Nicolas Modrzyk, (@hellonico).
https://github.com/apache/incubator-mxnet/pull/13624
Also thanks to Marco and Pedro thank
36 matches
Mail list logo
