[COMMUNITY] Welcome Mike Kienenberger

2005-11-23 Thread Martin Marinschek
Hi *, please welcome Mike to our team. Mike has been providing many patches over the very long time he has been active with Apache MyFaces, and has donated invaluable help to all users of Apache MyFaces - most of you can confirm this from your own experience. For the record - Mike would have

[jira] Commented: (MYFACES-705) Overflow problem with InputSuggestAjax

2005-11-23 Thread Volker Weber (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-705?page=comments#action_12358352 ] Volker Weber commented on MYFACES-705: -- I just did a fresh checkout and revert my changes. the problem in IE still occurs, so it must something other. I will look for

Re: Recent javadoc updates

2005-11-23 Thread Sean Schofield
Documentation is our single biggest weakness right now IMO (especially the code documentation but javadoc is not far behind.) So if you are reasonably certain your docs are right don't hesitate to add them! For every 1 mistake you make you will be adding 99 pieces of valuable documentation and

[jira] Created: (MYFACES-867) myfaces examples support for JSP 1.2 / Servlet 2.3 containers

2005-11-23 Thread vijay garla (JIRA)
myfaces examples support for JSP 1.2 / Servlet 2.3 containers - Key: MYFACES-867 URL: http://issues.apache.org/jira/browse/MYFACES-867 Project: MyFaces Type: Bug Components: General Versions: 1.1.1

[jira] Created: (MYFACES-868) dataList treatment inside panelGrid

2005-11-23 Thread Tony Czupryna (JIRA)
dataList treatment inside panelGrid --- Key: MYFACES-868 URL: http://issues.apache.org/jira/browse/MYFACES-868 Project: MyFaces Type: Improvement Components: Tomahawk Versions: 1.1.1, Nightly Environment: 11/22/2005

[jira] Created: (MYFACES-869) radio does no function within dataList

2005-11-23 Thread Tony Czupryna (JIRA)
radio does no function within dataList -- Key: MYFACES-869 URL: http://issues.apache.org/jira/browse/MYFACES-869 Project: MyFaces Type: Bug Components: Tomahawk Versions: 1.1.1, Nightly Environment: 11/22/05 Nightly

Re: Defaulting to forceId=true

2005-11-23 Thread Sean Schofield
Simon, There are a few very long threads on this in the archives (when forceId first came about.) Not only is it awkward to add form1:subview2 etc to every reference in your javascript but if you change your JSF form structure all of your javascript needs to change too! (NOTE: Its not always

Re: Defaulting to forceId=true

2005-11-23 Thread Martin Marinschek
Additionally, the colon is a reserved character in CSS - for pseudo-selectors. You can run into major problems with CSS and the standard client-ids. regards, Martin On 11/23/05, Sean Schofield [EMAIL PROTECTED] wrote: Simon, There are a few very long threads on this in the archives (when

Re: Plan for 1.1.2?

2005-11-23 Thread Sean Schofield
What if someone reported with affects [Nightly]. If we rename Nightly to 1.1.x on releasing, the issue would now have the property affects 1.1.x, which is wrong. Because the bug was actually FIXED in 1.1.x. Then the issue was found and fixed in the same version. That just means it was

Nonstandard HTML attribute support

2005-11-23 Thread chemeia
A couple days ago our project ran into the need to emit nonstandard HTML attributes to support a certain security-related feature. We ended up subclassing HtmlInputTextTag to add a setter/getter for the attribute. While it's not a lot of code, a standard method for adding these sorts of attributes

[jira] Created: (MYFACES-870) IE6: NPE in JavaScript when using t:calendarInput

2005-11-23 Thread Roland Huss (JIRA)
IE6: NPE in JavaScript when using t:calendarInput --- Key: MYFACES-870 URL: http://issues.apache.org/jira/browse/MYFACES-870 Project: MyFaces Type: Bug Versions: 1.1.1 Environment: Windows XP SP2 IE6

RE: Nonstandard HTML attribute support

2005-11-23 Thread Korhonen, Kalle
Doesn't look too clean to me.. If you need those non-standard attributes for specific tags (possibly with certain values), why not just write a filter that would do an XSL transformation and add them to the response? Kalle From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent:

Re: Recent javadoc updates

2005-11-23 Thread Mike Kienenberger
On 11/23/05, Sean Schofield [EMAIL PROTECTED] wrote: For every 1 mistake you make you will be adding 99 pieces of valuable documentation and someone will eventually catch the 1 mistake! I agree. In fact, this is my practice in answering emails too. I answer them even when I'm unsure, because

[jira] Commented: (MYFACES-869) radio does no function within dataList

2005-11-23 Thread Mike Kienenberger (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-869?page=comments#action_12358398 ] Mike Kienenberger commented on MYFACES-869: --- I read something recently that seemed to indicate that h:panelGroup might affect finding components. Try removing the

Re: [jira] Commented: (MYFACES-868) dataList treatment inside panelGrid

2005-11-23 Thread Tony Czupryna
Apologies. I thought the bug yesterday was not opened because JIRA timed out as it was posting. I noticed the email this morning after creating this enhancement request. I also realized this morning before requesting this enhancement that this was working as intended. Since dataList is a component

Re: [jira] Commented: (MYFACES-869) radio does no function within dataList

2005-11-23 Thread Tony Czupryna
I reduced the jsp to the following and get the same error: t:selectOneRadio id=test forceId=true layout=spread f:selectItems value=#{tonyTester.selectItems}/ /t:selectOneRadio t:dataList var=helper value=#{tonyTester.helpers} rowIndexVar=index t:radio for="" index=#{index}/ /t:dataList

Re: [jira] Commented: (MYFACES-869) radio does no function within dataList

2005-11-23 Thread Mike Kienenberger
Tony, What happens if you take out the forceId from test? My understanding of forceId is that it changes the namespace of the id value, so using it might break the non-forceId radio below it. I've never use radio buttons with JSF, so I'm no authority on them. I remember seeing posts in the

Re: [jira] Commented: (MYFACES-868) dataList treatment inside panelGrid

2005-11-23 Thread Mike Kienenberger
dataList is an iterating tag. But it's going to iterate at render time and output html. c:forEach is an iterating jsp tag that iterates at component tree building time and can output components, at least when used with facelets (not sure how it works with the standard JSF JSP view handler.)

[jira] Closed: (MYFACES-870) IE6: NPE in JavaScript when using t:calendarInput

2005-11-23 Thread Bruno Aranda (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-870?page=all ] Bruno Aranda closed MYFACES-870: Fix Version: Nightly Resolution: Fixed I've fixed that in the sources following your solution. Thanks Roland! I cannot try it since I only have a

Re: Plan for 1.1.2?

2005-11-23 Thread Manfred Geiler
2005/11/23, Sean Schofield [EMAIL PROTECTED]: What if someone reported with affects [Nightly]. If we rename Nightly to 1.1.x on releasing, the issue would now have the property affects 1.1.x, which is wrong. Because the bug was actually FIXED in 1.1.x. Then the issue was found and fixed

Re: [jira] Created: (MYFACES-868) dataList treatment inside panelGrid

2005-11-23 Thread Tony Czupryna
I believe the radio bug is actually a problem. This is the bug I intended to respond to: Sorry, I didn't think my bug yesterday got logged because I got a timeout error when I posted it. I realized this morning that it was expected behavior since t:dataList is a component and should all be in one

Re: svn eol?

2005-11-23 Thread Mike Kienenberger
Ok. Looks like it's just a client issue. The diff shown in my commit message seems fine. On 11/23/05, Mike Kienenberger [EMAIL PROTECTED] wrote: I'm doing a pre-commit diff of contributors.xml in (Windows) Eclipse with subeclipse, and I'm seeing that every line is different, unless I turn

Re: svn eol?

2005-11-23 Thread Martin Cooper
On 11/23/05, Mike Kienenberger [EMAIL PROTECTED] wrote: I'm doing a pre-commit diff of contributors.xml in (Windows) Eclipsewith subeclipse, and I'm seeing that every line is different, unless Iturn on the ignore-whitespace option.I'm guessing I need to somehow configure my svn eof setting for

Re: svn eol?

2005-11-23 Thread Mike Kienenberger
Thanks, Martin. It didn't affect my current situation, but it needed to be done for new files. I've borrowed your words and added them to our wiki :) On 11/23/05, Martin Cooper [EMAIL PROTECTED] wrote: On 11/23/05, Mike Kienenberger [EMAIL PROTECTED] wrote: I'm doing a pre-commit diff of

Re: Some Ajax updates

2005-11-23 Thread Travis Reeder
There is a full set of examples in the sandbox under AJAX Form Components or directly at inputAjax.jsf. Travis On 11/22/05, Grant Smith [EMAIL PROTECTED] wrote: Good work Travis! Any chance of creating some examples for these ? -- Grant Smith

Re: Reconnecting UIComponentTag instances with the corresponding UIComponent

2005-11-23 Thread Travis Reeder
Does anyone have any comment on whether this is a bug or not: As you can see UIComponentTag.doEndTag calls internalRelease(). But strangely, members _id, _rendered and _binding are cleared only in release(), not internalRelease(). Maybe that's a bug?

[jira] Resolved: (MYFACES-868) dataList treatment inside panelGrid

2005-11-23 Thread Mike Kienenberger (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-868?page=all ] Mike Kienenberger resolved MYFACES-868: --- Fix Version: Nightly Resolution: Won't Fix Assign To: Mike Kienenberger Problem needs to be solved using other means: dataTable

closing invalid/won't fix jira issues

2005-11-23 Thread Mike Kienenberger
Should I be closing invalid or won't fix jira issues at the same time I resolve them?

[jira] Closed: (MYFACES-858) Documentation on myFaces site has typo in code.

2005-11-23 Thread Mike Kienenberger (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-858?page=all ] Mike Kienenberger closed MYFACES-858: - Fix Version: Nightly Resolution: Fixed Assign To: Mike Kienenberger Fixed. Thanks, Jeff. You'll need to find the answers to your

[jira] Closed: (MYFACES-868) dataList treatment inside panelGrid

2005-11-23 Thread Mike Kienenberger (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-868?page=all ] Mike Kienenberger closed MYFACES-868: - dataList treatment inside panelGrid --- Key: MYFACES-868 URL:

tree2 and JFSAttr org.apache.myfaces.tree2.* attributes (MYFACES-760)

2005-11-23 Thread Mike Kienenberger
Is there a reason why we can't change all of these org.apache.myfaces.tree2.xyz attributes to xyz? // Tree2 attributes public static final String SHOW_NAV= org.apache.myfaces.tree2.SHOW_NAV; public static final String SHOW_LINES =

Re: Reconnecting UIComponentTag instances with the corresponding UIComponent

2005-11-23 Thread Adam Winer
Sounds like it is a bug, though that's a very quick impression without serious thought. Re: what happens if the number of tags change from one request to the next: this is why JSF tags inside of c:if are required to have an explicitly set ID (think this is stated explicitly in the JSF spec).

Re: tld documentation for standard HTML attributes

2005-11-23 Thread Simon Kitching
Hi Steve, [EMAIL PROTECTED] wrote: Both tomahawk/tld/myfaces_ext.dl and tomahawk/tld/tomahawk.tld will need some additional external entities added to pick up the standard HTML stuff that I have in my patch. I had a look at your patch. To summarise for others: The patch moves definitions

Re: Defaulting to forceId=true

2005-11-23 Thread Adam Winer
I think Simon's question is not about why forceId exists in the first place, but why AJAX would *require* its use. The former was discussed long ago. The latter is a new question which deserves careful consideration. -- Adam On 11/23/05, Sean Schofield [EMAIL PROTECTED] wrote: Simon, There

Re: closing invalid/won't fix jira issues

2005-11-23 Thread Simon Kitching
Hi Mike, Mike Kienenberger wrote: Should I be closing invalid or won't fix jira issues at the same time I resolve them? I would personally have marked this particular issue invalid rather than wontfix. invalid: the report is not a bug. wontfix: it's agreed that it is a bug or misfeature

Re: [COMMUNITY] Welcome Mike Kienenberger

2005-11-23 Thread Simon Kitching
Martin Marinschek wrote: Hi *, please welcome Mike to our team. Congrats Mike. And welcome from a fellow MyFaces newbie committer :-) Cheers, Simon

Re: closing invalid/won't fix jira issues

2005-11-23 Thread Mike Kienenberger
Yeah, the other projects I've been on that use JIRA mark bugs closed after a public release is made. I did a quick search and only Thomas was marking things resolved but not closed, so I went ahead and closed it.Since the second report was submitted as an improvment, WON'T FIX is probably

AJAX and ids (was Defaulting to forceId=true)

2005-11-23 Thread Simon Kitching
I haven't used AJAX, but isn't the javascript concerned *generated* by JSF tags? If so, the generated javascript should be able to create document.getElementById(form1:subview2:button1) Or is it that AJAX is commonly combined with user-provided javascript that manipulates the same DOM

[jira] Created: (MYFACES-871) scripts from script.aculo.us needs updated

2005-11-23 Thread Volker Weber (JIRA)
scripts from script.aculo.us needs updated -- Key: MYFACES-871 URL: http://issues.apache.org/jira/browse/MYFACES-871 Project: MyFaces Type: Bug Components: Sandbox Versions: Nightly Reporter: Volker Weber

[jira] Commented: (MYFACES-705) Overflow problem with InputSuggestAjax

2005-11-23 Thread Volker Weber (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-705?page=comments#action_12358429 ] Volker Weber commented on MYFACES-705: -- The problem seems because somone has commited a updated version of prototype.js without also updateing the control.js. Is

[jira] Updated: (MYFACES-871) scripts from script.aculo.us needs updated

2005-11-23 Thread Volker Weber (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-871?page=all ] Volker Weber updated MYFACES-871: - Attachment: relocate.bmp Attached screenshot to illustrate the new IE problem scripts from script.aculo.us needs updated

Release method in UIComponentTag (was Reconnecting UIComponentTag instances ...)

2005-11-23 Thread Simon Kitching
I see that originally _id etc were reset in internalRelease, and they were moved to the release method by this commit: r166747 | manolito | 2004-04-27 00:01:39 +1200 (Tue, 27 Apr 2004) | 2 lines more reluctant releasing

Re: tree2 and JFSAttr org.apache.myfaces.tree2.* attributes (MYFACES-760)

2005-11-23 Thread Sean Schofield
Mike, I don't know much about facelets but I'm curious to know what is causing the problem. If facelets doesn't support attribute properties with '.' characters in the name then IMO that is really the source of the problem. Its considered good practice to have fully qualifies names in your

Re: Defaulting to forceId=true

2005-11-23 Thread Sean Schofield
Well, if Simon's point is that Ajax should not *require* forceId then I agree with him (or whoever is making that point.) We're not requiring it right now but I think that is what Travis is suggesting (with the reasoning be that you almost always want to use it anyways.) As for why you would

Re: Reconnecting UIComponentTag instances with the corresponding UIComponent

2005-11-23 Thread Simon Kitching
Adam Winer wrote: Re: what happens if the number of tags change from one request to the next: this is why JSF tags inside of c:if are required to have an explicitly set ID (think this is stated explicitly in the JSF spec). This whole mess is why I proposed JspIdConsumer for JSP 2.1, which lets

SVN and eol-style: native

2005-11-23 Thread Simon Kitching
Hi, I've recently fixed a couple of files without any svn:eol-style setting and it has generated big diffs. I think what's happening is that when svn:eol-style gets set on a file that didn't have it, the file gets normalised before committing. And normalisation happens to mean convert to

RE: Plan for 1.1.2?

2005-11-23 Thread Abrams, Howard A
-Original Message- From: Sean Schofield [mailto:[EMAIL PROTECTED] Sent: Wednesday, November 23, 2005 8:14 AM To: MyFaces Development Subject: Re: Plan for 1.1.2? [Snip] I'm not wild about multiple nightly versions, etc. Perhaps we could use the roadmap as is being suggested

Re: SVN and eol-style: native

2005-11-23 Thread Wendy Smoak
On 11/23/05, Simon Kitching [EMAIL PROTECTED] wrote: So if the file was originally committed without svn:eol-style, but from a unix machine, then setting svn:eol-style doesn't cause any diffs. If the file was originally committed from a Windows machine (or Mac), however, then every line in

RE: Plan for 1.1.2?

2005-11-23 Thread Abrams, Howard A
-Original Message- From: Manfred Geiler [mailto:[EMAIL PROTECTED] Sent: Wednesday, November 23, 2005 11:23 AM To: MyFaces Development Subject: Re: Plan for 1.1.2? 2005/11/23, Sean Schofield [EMAIL PROTECTED]: What if someone reported with affects [Nightly]. If we rename

[jira] Updated: (MYFACES-866) Updates to standard tag TLD documentation

2005-11-23 Thread Steve Peterson (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-866?page=all ] Steve Peterson updated MYFACES-866: --- Attachment: new_files.tar This attachment contains new files that were not included in the patch. They are necessary to make the patch work. Thanks

[jira] Updated: (MYFACES-866) Updates to standard tag TLD documentation

2005-11-23 Thread Steve Peterson (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-866?page=all ] Steve Peterson updated MYFACES-866: --- Attachment: tomahawk.tld.patch This patch updates tomahawk/tld/tomahawk.tld to work with the first patch. Updates to standard tag TLD documentation

Re: tld documentation for standard HTML attributes

2005-11-23 Thread chemeia
I submitted 2 more files: a tar that contains the new files that were missing from the .patch, and a patch for tomahawk/tld/tomahawk.tld that brings it up to date with the first patch. SteveOn 11/23/05, Simon Kitching [EMAIL PROTECTED] wrote: Hi Steve,[EMAIL PROTECTED] wrote: Both

Re: Nonstandard HTML attribute support

2005-11-23 Thread chemeia
Here's the specific scenario that led me down this path. The app I'm working on is used by call center reps to enter orders, which include credit card numbers. The autocomplete feature in most modern browsers will cache previous entries in fields. We didn't (for obvious reasons) want this to

Re: tld documentation for standard HTML attributes

2005-11-23 Thread Simon Kitching
Thanks very much Steve. As this patch is a reasonably significant change, I'd like to wait at least 24 hours for other MyFaces committers to have a look at least at my summary of this patch (see below). If there are no objections during that period I'll then test and commit your patch as soon

Re: tld documentation for standard HTML attributes

2005-11-23 Thread Martin Marinschek
I've looked at it. forget about the one time performance hit at build time, I'd say. for me, this is ok. regards, Martin On 11/24/05, Simon Kitching [EMAIL PROTECTED] wrote: Thanks very much Steve. As this patch is a reasonably significant change, I'd like to wait at least 24 hours for

Re: Release method in UIComponentTag (was Reconnecting UIComponentTag instances ...)

2005-11-23 Thread Martin Marinschek
Manolito would be Manfred Geiler. I suppose that release is called when the tag is given back to the ServletContainer anyways? regards, Martin On 11/24/05, Simon Kitching [EMAIL PROTECTED] wrote: I see that originally _id etc were reset in internalRelease, and they were moved to the release

[jira] Commented: (MYFACES-705) Overflow problem with InputSuggestAjax

2005-11-23 Thread Martin Marinschek (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-705?page=comments#action_12358448 ] Martin Marinschek commented on MYFACES-705: --- Thanks Volker for this evaluation! That must have been me with the prototype.js update. I tried to update

Re: [jira] Created: (MYFACES-869) radio does no function within dataList

2005-11-23 Thread Tony Czupryna
Sorry, I didn't think my bug yesterday got logged because I got a timeout error when I posted it. I realized this morning that it was expected behavior since t:dataList is a component and should all be in one column of a panelGrid. However, I'd like to propose extending dataList to support the

Re: Recent javadoc updates

2005-11-23 Thread Martin Marinschek
I'd say that for you, Mike, it's that 1% or much lesser ;) regards, Martin On 11/23/05, Mike Kienenberger [EMAIL PROTECTED] wrote: On 11/23/05, Sean Schofield [EMAIL PROTECTED] wrote: For every 1 mistake you make you will be adding 99 pieces of valuable documentation and someone will

Re: Defaulting to forceId=true

2005-11-23 Thread Martin Marinschek
Right. I would never, ever want to force users to use forceId for working with AJAX. So, my opinion is on record ;) regards, Martin On 11/24/05, Sean Schofield [EMAIL PROTECTED] wrote: Well, if Simon's point is that Ajax should not *require* forceId then I agree with him (or whoever is

Re: closing invalid/won't fix jira issues

2005-11-23 Thread Martin Marinschek
+1 for closing immediately. We can always reopen later ;). The last time I closed Thomas bugs, I'll talk to him to use close instead of resolve as well. regards, Martin On 11/23/05, Mike Kienenberger [EMAIL PROTECTED] wrote: Yeah, the other projects I've been on that use JIRA mark bugs

Re: Nonstandard HTML attribute support

2005-11-23 Thread Martin Marinschek
Hmm, in fact, the autocomplete attribute is supported during rendering of components - we needed that for customized drop-down lists. So you could do a component binding, and add the autocomplete attribute to the componentAttributesMap, and the renderer will render the corresponding attribute, if

[Tobago] Change the groupId of Tobago to follow the naming conventions of maven

2005-11-23 Thread Bernd Bohmann
Hello, I would like to change the groupId of Tobago to follow the naming convention of maven. Change from groupIdtobago/groupId to groupIdorg.apache.myfaces.tobago/groupId See http://maven.apache.org/guides/mini/guide-naming-conventions.html I think myfaces should follow this naming