Re: [VOTE] Add MyfacesBuilderPlugin to buildtools branch and use it on myfaces 1.1

2008-04-23 Thread Sochor Zdeněk
Hi, +1 for (a) and for component class generation: Annotated class is a private class that is used as template (never instantiated, just the code is copied inside the generated class) (to not lose typeof checking in deeper trees - using abstract class in the middle would lose it for

Re: nasty problem in server side state saving

2008-04-03 Thread Sochor Zdeněk
Hi, Mario Ivankovits napsal(a): ... with serialize in state disabled. I've create a small test case which shows that the attributes map is just copied over into the state. Which means that each and every Component shares exactly the same map. Any change to this map will be reflected in ALL

Re: nasty problem in server side state saving

2008-04-03 Thread Sochor Zdeněk
Hi, [EMAIL PROTECTED] napsal(a): Sochor Zdeněk schrieb: Hi, Mario Ivankovits napsal(a): ... with serialize in state disabled. I've create a small test case which shows that the attributes map is just copied over into the state. Which means that each and every Component shares

Re: [Tomahawk] Commit of component generation and 1.2 modules to trunk

2008-03-18 Thread Sochor Zdeněk
Hi all, comments inline. [EMAIL PROTECTED] napsal(a): The myfaces-builder-plugin stuff is an experiment/proof-of-concept at the current time, That's why the code is in a branches directory. No vote has been taken on using this approach; it was necessary to show that this would work before

Re: [Tomahawk] Commit of component generation and 1.2 modules to trunk

2008-03-18 Thread Sochor Zdeněk
i ignore constructive and inspiring comments?? Regards, Zdenek The issue with state-saving will need to be saved another way. regards, Martin On 3/18/08, Sochor Zdeněk [EMAIL PROTECTED] wrote: Hi all, comments inline. [EMAIL PROTECTED] napsal(a): The myfaces-builder-plugin

Re: [Tomahawk] Commit of component generation and 1.2 modules to trunk

2008-03-18 Thread Sochor Zdeněk
Hi, [EMAIL PROTECTED] napsal(a): Sochor Zdeněk schrieb: Generally extending components by adding whole bucket of local property/getter/setter seems not right for me because it's meant to provide just another feature not used by many people. Wouldn't it be more cleaner to just use

Re: myfaces template structure [was: svn commit: r627191 - in /myfaces/tomahawk/branches/1_2_0/core/src/main/java/...]

2008-02-15 Thread Sochor Zdeněk
Hi, Mario Ivankovits napsal(a): Hi! Being on vacation it is hard to follow the actual discussions, so, sorry if I missed something along the lines. While the fact that Leonardo flipped the object hierarchy can be treated as genious idea (kudos!), I am not fully convinced that this is what we

Re: [Trinidad] tr:chart New API for displaying rotated horizontal labels

2008-02-13 Thread Sochor Zdeněk
Hi, i'd suggest something like labelRotateAngle attribute (degree based, int from -180 to 180, default 0) to let users specify angle of rotation than having fixed angle set by code. Also to suppress label overlapping a new attribute labelGapSize (int, default 0) could be added to render only

Re: [Myfaces Wiki] Update of Code Generation

2008-02-08 Thread Sochor Zdeněk
Hi, 1. to JDK bug: it's not a bug according to Java language Specification: http://java.sun.com/docs/books/jls/third_edition/html/classes.html#23530 2. to attributes: JSF specification states that components have properties (so called renderkit independend), which are getter/setter based AND

Re: [Myfaces Wiki] Update of Code Generation by SimonKitching

2008-02-01 Thread Sochor Zdeněk
Hi all, some clarifications from my side: Quote 1: One of the last developers to work on the old code-generation framework commented that it was very painful. Not sure whether this comment was about the basic concept of this approach, or just the implementation. It was about changes made

Re: [Myfaces Wiki] Update of Code Generation by SimonKitching

2008-02-01 Thread Sochor Zdeněk
Hi, Simon Kitching napsal(a): Martin Marinschek [EMAIL PROTECTED] schrieb: Hi Simon, And this approach is not possible for uicomponent classes defined in the standard as these have defined hierarchies that cannot be modified. does this stem from actually trying it out? I

Re: [Myfaces Wiki] Update of Code Generation by SimonKitching

2008-02-01 Thread Sochor Zdeněk
Hi, Martin Marinschek napsal(a): Hi Zdenek, A question was raised about why state isn't retrieved from the attributes map - this cannot be used, however, cause it would use reflection internally and call the getter of the method, if a value is not directly stored in the attributes map. As

Re: myfaces-faces-plugin - architecture

2008-01-30 Thread Sochor Zdeněk
Hi all, Mario Ivankovits napsal(a): Hi Simon! First, my intention was/is to find a solution. I don't think that we manage to create an all new generator stuff. We had plenty of time in the past to make this thing fly, but failed. I was probably last to play with old generator (in Tomahawk

Fresh MyFaces 1.1 build error

2008-01-30 Thread Sochor Zdeněk
Hi all, today i tried to build whole MyFaces 1.1 + Tomahawk after ages. I started by new SVN checkout (myfaces-current), but something is going wrong :( Using JDK 1.4 + Maven2 on Win XP, clean install goals. Error i got is (in Tomahawk Core project): [INFO] Using default encoding to copy

Re: Fresh MyFaces 1.1 build error

2008-01-30 Thread Sochor Zdeněk
Hi all, Sochor Zdeněk napsal(a): Hi all, today i tried to build whole MyFaces 1.1 + Tomahawk after ages. I started by new SVN checkout (myfaces-current), but something is going wrong :( Using JDK 1.4 + Maven2 on Win XP, clean install goals. Error i got is (in Tomahawk Core project): [INFO

Re: [result][vote] start up the MyFaces Commons project

2007-11-29 Thread Sochor Zdeněk
Hi, just my few ideas about this ;) What about reversing the flow by answering the 'simple question': What code is specific to render kit? By answering this question we can really begin discussion about the way of putting remaining classes to so called 'commons'. - My current view

Re: [result][vote] start up the MyFaces Commons project

2007-11-29 Thread Sochor Zdeněk
Hi, Matthias Wessendorf napsal(a): sure, no dependency to -impl. Wouldn't make sense, if there were. Convertors and validators are quite different matter - they should get into 'commons' BUT if and only if they use only crucial attributes from (server-side) converters and

Re: [jira] Resolved: (MYFACES-1700) each h:form generated an input with same id=javax.faces.ViewState

2007-11-19 Thread Sochor Zdeněk
Hi, Manfred Geiler (JIRA) napsal(a): Therefore I added a (MyFaces specific) config parameter: org.apache.myfaces.RENDER_VIEWSTATE_ID The default value is false for backwards compatibility. I think this name is misleading - when set to false it IS rendering id and when true it's NOT.

Re: [research] resource dependency framework

2007-10-26 Thread Sochor Zdeněk
Hi, quite interesting ideas, but they have few glitches (inside). Mario Ivankovits napsal(a): Hi! Sorry for the lenghty mail!! Maybe something for the upcoming MyFaces Commons project. To get rid of the AddResource oddities I thought about introducing a new resource dependency framework.

Re: Renderer and encodeChildren

2007-10-24 Thread Sochor Zdeněk
Hi, as to why does it work, the answer should be simple - almost all renderers in MyFaces do ALL encoding work in encodeEnd method (including rendering children). But what do i wonder more is why page's component tree contains ALL previously rendered/encoded components. Wouldn't it make

Re: Renderer and encodeChildren

2007-10-24 Thread Sochor Zdeněk
Hi Simon, comments inside. Simon Kitching napsal(a): Sochor Zdeněk [EMAIL PROTECTED] schrieb: Hi, as to why does it work, the answer should be simple - almost all renderers in MyFaces do ALL encoding work in encodeEnd method (including rendering children). To be more

Re: facelets taglib for tomahawk and sandbox

2007-10-23 Thread Sochor Zdeněk
Hi, a year ago i was playing with OLD generator to make it work again for Tomahawk's core components - see https://issues.apache.org/jira/browse/TOMAHAWK-819 - attachment tomahawk(no roleSelectionMode).patch I withdrove the issue mainly because it become invalid in a matter of weeks AND in

Re: possible bug for tabbedPane ? http://www.irian.at/myfaces/tabbedPane.jsf

2007-09-04 Thread Sochor Zdeněk
Hi Dennis, i came accross this bug several months ago and i had even asked here in list. Subject: [tabbedPane example] bug confirmation???* * excerpt I tried to run example several times (both locally built and on irian.at night build), but i'm getting several results WITHOUT