Re: [Core] FacesConfigurator.sortRelativeOrderingList() algorithm is broken

2010-02-05 Thread Curtiss Howard
On Thu, Feb 4, 2010 at 10:26 PM, Leonardo Uribe lu4...@gmail.com wrote: Hi I could not resist the temptation to try another algorithm. I committed an alternative using a topological sorting algorithm extracted from

[Core] FacesConfigurator.sortRelativeOrderingList() algorithm is broken

2010-02-04 Thread Curtiss Howard
Hi, Our testers are currently running against Sun's CTS tests and the relative ordering algorithm in FacesConfigurator.sortRelativeOrderingList() is failing on a rather simple case: A after B B before C C before A The expected faces-config ordering is B-C-A, but instead

Re: [Core] FacesConfigurator.sortRelativeOrderingList() algorithm is broken

2010-02-04 Thread Leonardo Uribe
Hi I did the algorithm proposed there. For me it is ok if we can find a simpler one, as long as all tests proposed pass. Anyway, I'll check why it is failing. regards, Leonardo Uribe 2010/2/4 Curtiss Howard curtiss.how...@gmail.com Hi, Our testers are currently running against Sun's CTS

Re: [Core] FacesConfigurator.sortRelativeOrderingList() algorithm is broken

2010-02-04 Thread Curtiss Howard
On Thu, Feb 4, 2010 at 11:06 AM, Leonardo Uribe lu4...@gmail.com wrote: Hi I did the algorithm proposed there. For me it is ok if we can find a simpler one, as long as all tests proposed pass. Anyway, I'll check why it is failing. regards, Leonardo Uribe Thanks Leonardo. If you're

Re: [Core] FacesConfigurator.sortRelativeOrderingList() algorithm is broken

2010-02-04 Thread Leonardo Uribe
Hi The algorithm proposed fails because it is not able to process the nodes in the correct order (the algorithm assign a weight equal to all nodes, so it fails when try to order them in a psedo postorder form). I don't see a quick solution for that one, so I think is better and faster try another

Re: [Core] FacesConfigurator.sortRelativeOrderingList() algorithm is broken

2010-02-04 Thread Curtiss Howard
On Thu, Feb 4, 2010 at 12:08 PM, Leonardo Uribe lu4...@gmail.com wrote: Hi The algorithm proposed fails because it is not able to process the nodes in the correct order (the algorithm assign a weight equal to all nodes, so it fails when try to order them in a psedo postorder form). I don't

Re: [Core] FacesConfigurator.sortRelativeOrderingList() algorithm is broken

2010-02-04 Thread Leonardo Uribe
Hi I could not resist the temptation to try another algorithm. I committed an alternative using a topological sorting algorithm extracted from https://svn.apache.org/repos/asf/excalibur/trunk/fortress/container-api/src/java/org/apache/avalon/fortress/util/dag/ Since this one is in apache