Re: [MyFaces 2.0] / [JSF 2.0] SPEC not too clear on setParent() description = MYFACES-2389 review request

2009-10-27 Thread Matthias Wessendorf
On Mon, Oct 26, 2009 at 8:48 PM, Martin Marinschek mmarinsc...@apache.org wrote: Hi Matthias, that has not been discussed on the EG, so I can't confirm your version of the code. However, it seems reasonable to me. OK, yeah, I just did refactoring :-) not added anything (wild). thanks for the

[MyFaces 2.0] / [JSF 2.0] SPEC not too clear on setParent() description = MYFACES-2389 review request

2009-10-26 Thread Matthias Wessendorf
Hi, some of the hidden secrets of the new spec have been forgotten to be spec'd out :-( While checking on MyFaces's setParent() implementation, I decided to do a little clean up. Please see the patch here: https://issues.apache.org/jira/browse/MYFACES-2389 Generally I am wondering about the

Re: [MyFaces 2.0] / [JSF 2.0] SPEC not too clear on setParent() description = MYFACES-2389 review request

2009-10-26 Thread Martin Marinschek
Hi Matthias, that has not been discussed on the EG, so I can't confirm your version of the code. However, it seems reasonable to me. As I see from the issue tracker, Ed already responded (he's been faster there than with other MyFaces team issues recently ;), so I guess there is no need for