Re: [Trinidad] [API] Making XhtmlConstants (from IMPL module) a public API

2009-10-21 Thread Matthias Wessendorf
On Mon, Oct 19, 2009 at 7:25 AM, Simon Lessard simon.lessar...@gmail.com wrote: Hi all, Personally, I would prefer to see that class divided in more specialized classes like : XhtmlElements {     public static final String DIV = div; (or could be DIVISION)     public static final String

Re: [Trinidad] [API] Making XhtmlConstants (from IMPL module) a public API

2009-10-19 Thread Scott O'Bryan
Why is this being done again? Sent from my iPhone On Oct 18, 2009, at 10:32 PM, Blake Sullivan blake.sulli...@oracle.com wrote: +1 -- Blake Sullivan On Oct 18, 2009, at 9:11 PM, Matthias Wessendorf wrote: Maybe we should also rename the old XhtmlConstants class ? Would make sense, as

Re: [Trinidad] [API] Making XhtmlConstants (from IMPL module) a public API

2009-10-19 Thread Simon Lessard
Hi all, Personally, I would prefer to see that class divided in more specialized classes like : XhtmlElements { public static final String DIV = div; (or could be DIVISION) public static final String TABLE = table; public static final String TABLE_BODY = tbody; public static

Re: [Trinidad] [API] Making XhtmlConstants (from IMPL module) a public API

2009-10-18 Thread Matthias Wessendorf
Maybe we should also rename the old XhtmlConstants class ? Would make sense, as all the (x)html stuff is about to be moved to API. Since this class is containing misc things, like HTML (gone), events, params and other rendering stuff (e.g. the * for the inputText (secret:true)), we could be

Re: [Trinidad] [API] Making XhtmlConstants (from IMPL module) a public API

2009-10-16 Thread Matthias Wessendorf
On Thu, Oct 15, 2009 at 6:12 PM, Blake Sullivan blake.sulli...@oracle.com wrote: Matthias Wessendorf said the following On 10/15/2009 5:48 PM PT: Hi, I'd like to move the XhtmlConstants class to the API. The only dependency on another IMPL class is very simple. It is a constant, that

Re: [Trinidad] [API] Making XhtmlConstants (from IMPL module) a public API

2009-10-16 Thread Blake Sullivan
+1 -- Blake Sullivan Matthias Wessendorf said the following On 10/16/2009 11:12 AM PT: On Thu, Oct 15, 2009 at 6:12 PM, Blake Sullivan blake.sulli...@oracle.com wrote: Matthias Wessendorf said the following On 10/15/2009 5:48 PM PT: Hi, I'd like to move the XhtmlConstants class to

[Trinidad] [API] Making XhtmlConstants (from IMPL module) a public API

2009-10-15 Thread Matthias Wessendorf
Hi, I'd like to move the XhtmlConstants class to the API. The only dependency on another IMPL class is very simple. It is a constant, that resolves to a String (portlet). If nobody disagrees, I will move on with the move. Yeah, just on trunk (Trinidad 1.2.x) Thx, Matthias -- Matthias

Re: [Trinidad] [API] Making XhtmlConstants (from IMPL module) a public API

2009-10-15 Thread Blake Sullivan
Matthias Wessendorf said the following On 10/15/2009 5:48 PM PT: Hi, I'd like to move the XhtmlConstants class to the API. The only dependency on another IMPL class is very simple. It is a constant, that resolves to a String (portlet). If nobody disagrees, I will move on with the move. Yeah,