Re: [Trinidad] Branch for 1.0.3 core ?

2007-09-25 Thread Matthias Wessendorf
anyone else that has some changes to commit ? Otherwise I start the branch tomorrow morning (German time) -Matthias On 9/25/07, Adam Winer [EMAIL PROTECTED] wrote: OK, I've fixed 735, and checked in the patches for 674 and 676. -- Adam On 9/24/07, Adam Winer [EMAIL PROTECTED] wrote:

Re: [Trinidad] Branch for 1.0.3 core ?

2007-09-25 Thread Adam Winer
I think Danny still has some things? -- Adam On 9/25/07, Matthias Wessendorf [EMAIL PROTECTED] wrote: anyone else that has some changes to commit ? Otherwise I start the branch tomorrow morning (German time) -Matthias On 9/25/07, Adam Winer [EMAIL PROTECTED] wrote: OK, I've fixed 735,

Re: [Trinidad] Branch for 1.0.3 core ?

2007-09-25 Thread Danny Robinson
I'd like some quick eyes on the patch I've attached to *TRINIDAD-37https://issues.apache.org/jira/browse/TRINIDAD-37 *which I'd like to commit if there are no issues.* ** * On 9/25/07, Adam Winer [EMAIL PROTECTED] wrote: I think Danny still has some things? -- Adam On 9/25/07, Matthias

Re: [Trinidad] Branch for 1.0.3 core ?

2007-09-25 Thread Danny Robinson
If anyone could take a peek at the plugin issue with attributes such as xOffset/yOffset, then we could revert the attribute names in panelPopup before the release goes out so they stay the same between releases. On 9/25/07, Danny Robinson [EMAIL PROTECTED] wrote: I'd like some quick eyes on the

Re: [Trinidad] Branch for 1.0.3 core ?

2007-09-25 Thread Adam Winer
This looks like it fails if validation is set to alert mode; _autoSubmit always calls _validateInput, which calls _validateInline. Also, if immediate is true, the _autoSubmit param validateForm is true? That seems weird... I think I've seen this code: + if (_agent.isIE) + { +// in many

Re: [Trinidad] Branch for 1.0.3 core ?

2007-09-25 Thread Danny Robinson
This looks like it fails if validation is set to alert mode; _autoSubmit always calls _validateInput, which calls _validateInline. Thanks, fixed. Also, if immediate is true, the _autoSubmit param validateForm is true? That seems weird... BodyRenderer actually uses the snippet below, so

Re: [Trinidad] Branch for 1.0.3 core ?

2007-09-25 Thread Adam Winer
On 9/25/07, Danny Robinson [EMAIL PROTECTED] wrote: This looks like it fails if validation is set to alert mode; _autoSubmit always calls _validateInput, which calls _validateInline. Thanks, fixed. Also, if immediate is true, the _autoSubmit param validateForm is true? That seems

Re: [Trinidad] Branch for 1.0.3 core ?

2007-09-25 Thread Danny Robinson
Both should go into a common method, I think. Maybe we could start to use some polymorphism on the agent object, so you could just call event = _agent.getEvent(event)? That would be no bad thing, there's also addEventHandler/removeEventHandler stuff we could also add there. Given the

Re: [Trinidad] Branch for 1.0.3 core ?

2007-09-25 Thread Adam Winer
Sure, no prob. :) -- Adam On 9/25/07, Danny Robinson [EMAIL PROTECTED] wrote: Both should go into a common method, I think. Maybe we could start to use some polymorphism on the agent object, so you could just call event = _agent.getEvent(event)? That would be no bad thing, there's

[Trinidad] Branch for 1.0.3 core ?

2007-09-24 Thread Matthias Wessendorf
Hi, I'd like to branch today for the upcoming 1.0.3-core release of Trinidad. Does one need to commit something before ? thx, Matthias -- Matthias Wessendorf further stuff: blog: http://matthiaswessendorf.wordpress.com/ mail: matzew-at-apache-dot-org

Re: [Trinidad] Branch for 1.0.3 core ?

2007-09-24 Thread Danny Robinson
Did I miss the conversation leading up to this, or is this it? To Do * resolve the current xOffset/yOffset conversation and fix the plugins * Update AutoSubmitUtils to output ' TrPage._autoSubmit()' as the onchange handler Danny On 9/24/07, Matthias Wessendorf [EMAIL PROTECTED] wrote: Hi,

Re: [Trinidad] Branch for 1.0.3 core ?

2007-09-24 Thread Danny Robinson
Also, TRINIDAD-735 - '_checkLoad is not defined' error opening lightweight dialog in FireFox ... but need someone elses eyes on that one. On 9/24/07, Danny Robinson [EMAIL PROTECTED] wrote: Did I miss the conversation leading up to this, or is this it? To Do * resolve the current

Re: [Trinidad] Branch for 1.0.3 core ?

2007-09-24 Thread Matthias Wessendorf
Sounds good to me, this email was just a heads-up ;-) On 9/24/07, Simon Lessard [EMAIL PROTECTED] wrote: I need to commit the patch for statusIndicator. I'll do that later today, we should not release until it's done. On 9/24/07, Matthias Wessendorf [EMAIL PROTECTED] wrote: one more.

Re: [Trinidad] Branch for 1.0.3 core ?

2007-09-24 Thread Simon Lessard
Ok, commit is done on my side. On 9/24/07, Matthias Wessendorf [EMAIL PROTECTED] wrote: Sounds good to me, this email was just a heads-up ;-) On 9/24/07, Simon Lessard [EMAIL PROTECTED] wrote: I need to commit the patch for statusIndicator. I'll do that later today, we should not

Re: [Trinidad] Branch for 1.0.3 core ?

2007-09-24 Thread Adam Winer
We've also got patches available for TRINIDAD-718 and TRINIDAD-665 (actually looks like TRINIDAD-718 has already been checked in, but the JIRA wasn't closed). TRINIDAD-735 would be nice, but isn't critical. I'll check in the fixes for TRINIDAD-674 and TRINIDAD-676 ASAP - straightforward fixes

Re: [Trinidad] Branch for 1.0.3 core ?

2007-09-24 Thread Matthias Wessendorf
Going forward, I don't think we need to have a strict release the plugins, then release core rule - I think we can mostly get away with just releasing core, when it's ready. Which is good. :) yeah, unless the CORE depends on them ;-) I also think the unified plugins, will help also to avoid

Re: [Trinidad] Branch for 1.0.3 core ?

2007-09-24 Thread Adam Winer
OK, I've fixed 735, and checked in the patches for 674 and 676. -- Adam On 9/24/07, Adam Winer [EMAIL PROTECTED] wrote: We've also got patches available for TRINIDAD-718 and TRINIDAD-665 (actually looks like TRINIDAD-718 has already been checked in, but the JIRA wasn't closed).