Re: [Trinidad] Patches! Fresh patches! Patches anybody?

2007-10-14 Thread Stephen Friedrich
Thanks for your answer, Adam. I'll try to be more careful in keeping formatting and not changing unrelated code. I am just so used to act on Idea's inspection warning's to keep the code status green. I'll provide some separate patches to clean up the code a little: Unused imports, missorted

Re: [Trinidad] Patches! Fresh patches! Patches anybody?

2007-10-13 Thread Adam Winer
Hey, Stephen, a couple of comments: - The patch for 755 includes a lot of changes that aren't specific to your work (removing unnecessary imports, whitespace adjustments, etc.) If you want to create separate, minor issues of Unnecessary imports, and attach a separate patch there, that's

[Trinidad] Patches! Fresh patches! Patches anybody?

2007-10-12 Thread myfaces-dev
What is the best way to contribute to Trinidad? I went ahead and supplied two patches for issues I was having with missing skinning features: TRINIDAD-755, TRINIDAD-745 Right now, I am missing another feature (putting labels _above_ fields). I am a little hesitant to supply yet another patch