>> > in
>> >>> >>>> >> > myfaces-bundle).
>> >>> >>>> >> >
>> >>> >>>> >> > @Leo: From my point of view, the branch is complete. In
>> >>> >>>> >> >
b) dependency plugin to unpack shared-impl-sources.jar in
>>> >>>> >> > myfaces-impl and build-helper-plugin to add these sources as a
>>> >>>> >> > new
>>> >>>> >> > source folder
>>> >>>> &g
gt; >>>> >>
>> >>>> >> >>>> >> Leo, SpringDM does much more work usually to tweak
>> >>>> >> >>>> >> something
>> >>>> >> >>>> >> for
>> >>>
gt;> >> >>>> >> > From: Leonardo Uribe
>>>> >> >>>> >> > Subject: Re: Use maven-shade-plugin to prevent duplicate code
>>>> >> >>>> >> > -
>>>> >> >>>> >> > revisite
> >> Leonardo Uribe
>>> >> >>
>>> >> >> 2011/7/8 Gerhard Petracek :
>>> >> >>> hi leo,
>>> >> >>> right - there are no entries in the manifest. they will be
>>> >> >>> generated
>
ld
>> >> >>> config).
>> >> >>> regards,
>> >> >>> gerhard
>> >> >>> http://www.irian.at
>> >> >>>
>> >> >>> Your JSF powerhouse -
>> >> >>> JSF Consulting, Development and
&g
so, shouldn't we remove
>> >>>> OSGi entries on the manifests in myfaces-api and impl jars? just to
>> >>>> prevent possible confusions about that.
>> >>>>
>> >>>> regards,
>> >>>>
>> >>>&
gt;>
> >>>> 2011/7/8 Gerhard Petracek :
> >>>> > +1!
> >>>> > regards,
> >>>> > gerhard
> >>>> >
> >>>> > http://www.irian.at
> >>>> >
> >>>> > Your JSF powerh
g.html
>>>> >> >
>>>> >> > I don't see very clear the "benefits" of the change. I
>>>> >> > suppose it
>>>> >> > enhance debugging in some way, but is that true? can I do a
>>>> >> >
> > regards,
>>> >> >
>>> >> > Leonardo Uribe
>>> >> >
>>> >> > 2011/7/8 Gerhard Petracek mailto:gerhard.petra...@gmail.com>>:
>>> >> > > hi mark,
>>> >
t; http://myfaces.apache.org/core21/myfaces-impl/webconfig.html
> >>> >> >
> >>> >> > I don't see very clear the "benefits" of the change. I
> >>> >> > suppose it
> >>> >> > enhance debugging in some w
re work usually to tweak something for their
>>> >> needs!
>>> >> They can just use the myfaces-bundle.jar as each and every other OSGi
>>> >> user
>>> >> does too.
>>> >>
>>> >> What I meant was more: we shall _
ak something for their
>> >> needs!
>> >> They can just use the myfaces-bundle.jar as each and every other OSGi
>> >> user
>> >> does too.
>> >>
>> >> What I meant was more: we shall _not_ do something ugly just to make
>>
t; >> does too.
> >>
> >> What I meant was more: we shall _not_ do something ugly just to make
> OSGi
> >> happy ^^
> >>
> >> So using the maven-shade-plugin is perfectly fine and will be a big
> >> benefit for cleaning up the shared
will be a big
>> benefit for cleaning up the shared project!
>>
>> LieGrue,
>> strub
>>
>> --- On Fri, 7/8/11, Leonardo Uribe wrote:
>>
>> > From: Leonardo Uribe
>> > Subject: Re: Use maven-shade-plugin to prevent duplicate code -
>> &
project!
>
> LieGrue,
> strub
>
> --- On Fri, 7/8/11, Leonardo Uribe wrote:
>
> > From: Leonardo Uribe
> > Subject: Re: Use maven-shade-plugin to prevent duplicate code - revisited
> > To: "MyFaces Development"
> > Date: Friday, July 8, 2011
fine and will be a big benefit for
cleaning up the shared project!
LieGrue,
strub
--- On Fri, 7/8/11, Leonardo Uribe wrote:
> From: Leonardo Uribe
> Subject: Re: Use maven-shade-plugin to prevent duplicate code - revisited
> To: "MyFaces Development"
> Date: Friday, July
old!). It is not possible to use a MyFaces-impl with a
> >> mojarra-api and vice versa, because methods like
> >> FacesContext#getCurrentInstance() (and similar) access impl classes from
> the
> >> API package. This makes it pretty hard to work OSGi.
> >>
&g
from the
>> API package. This makes it pretty hard to work OSGi.
>>
>> LieGrue,
>> strub
>>
>> --- On Fri, 7/8/11, Jakob Korherr wrote:
>>
>> > From: Jakob Korherr
>> > Subject: Re: Use maven-shade-plugin to prevent duplicate code -
xt#getCurrentInstance() (and
> similar) access impl classes from the API package. This makes it pretty hard
> to work OSGi.
>
> LieGrue,
> strub
>
> --- On Fri, 7/8/11, Jakob Korherr wrote:
>
> > From: Jakob Korherr
> > Subject: Re: Use maven-shade-plugin to preven
makes it pretty hard to
work OSGi.
LieGrue,
strub
--- On Fri, 7/8/11, Jakob Korherr wrote:
> From: Jakob Korherr
> Subject: Re: Use maven-shade-plugin to prevent duplicate code - revisited
> To: "MyFaces Development"
> Date: Friday, July 8, 2011, 1:09 PM
> Hi Leo,
>
i agree with jakob.
regards,
gerhard
http://www.irian.at
Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German
Professional Support for Apache MyFaces
2011/7/8 Jakob Korherr
> Hi Leo,
>
> Yes, I remember that you did some work related to this stuff. Some
> com
Hi Leo,
Yes, I remember that you did some work related to this stuff. Some
comments about your problems:
1) If you use myfaces-impl, the packages really are *.shared_impl.*
(shade does the relocation on the classes). But a part of this
statement is still true - we need to check config files with
Hi
I haven't look the code provided in deep, but long time ago I tried
it. In that time I saw the following problems:
1. There are some classes on shared that are used outside it. For
example, see org.apache.myfaces.shared.webapp.webxml.DelegatedFacesServlet.
We need to detect all similar cases a
hi jakob,
great - thx!
regards,
gerhard
http://www.irian.at
Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German
Professional Support for Apache MyFaces
2011/7/7 Jakob Korherr
> Hi guys,
>
> I committed a working draft to the branch at [1]. However, there ar
Hi guys,
I committed a working draft to the branch at [1]. However, there are
some issues with the javadoc-plugin (see [2]) that must be fixed first
in order to get the expected javadoc. The other stuff (shading of
shared and impl-ee6) already works as expected!
Feel free to try it out yourself.
Excellent news ++1, the shared as we have it is a bad design decision I
hope shade will get rid of our debugging issues we have with our current
shared.
Werner
Am 07.07.11 11:04, schrieb Jakob Korherr:
Hi Gerhard,
Thx for (re-)opening this thread. I already created a jira issue [1]
and a c
Hi Gerhard,
Thx for (re-)opening this thread. I already created a jira issue [1]
and a core-branch [2] for prototyping.
Currently I am struggling a little bit with the javadoc-plugin, but
this stuff should be fixed soon (maybe even today).
I'll let you guys know when I am done with the configura
hi @ all,
the goal (as we discussed before) is to get rid of the shared-impl module
and move to the shade-plugin for maven.
issues with javadoc and osgi bundles prevented us from doing this step.
however, with codi v1 we have a project(-configuration) which fixes all the
issues we had with the sha
29 matches
Mail list logo
