Re: Use maven-shade-plugin to prevent duplicate code - revisited

2011-07-28 Thread Jakob Korherr
, Leonardo Uribe lu4...@gmail.com wrote: From: Leonardo Uribe lu4...@gmail.com Subject: Re: Use maven-shade-plugin to prevent duplicate code - revisited To: MyFaces Development dev@myfaces.apache.org Date: Friday, July 8, 2011, 3:20 PM

Re: Use maven-shade-plugin to prevent duplicate code - revisited

2011-07-27 Thread Leonardo Uribe
--- On Fri, 7/8/11, Leonardo Uribe lu4...@gmail.com wrote: From: Leonardo Uribe lu4...@gmail.com Subject: Re: Use maven-shade-plugin to prevent duplicate code - revisited To: MyFaces Development dev@myfaces.apache.org Date: Friday, July 8, 2011

Re: Use maven-shade-plugin to prevent duplicate code - revisited

2011-07-25 Thread Leonardo Uribe
...@gmail.com Subject: Re: Use maven-shade-plugin to prevent duplicate code - revisited To: MyFaces Development dev@myfaces.apache.org Date: Friday, July 8, 2011, 3:20 PM Hi I don't think the OSGi mention is off-topic. In theory

Re: Use maven-shade-plugin to prevent duplicate code - revisited

2011-07-23 Thread Leonardo Uribe
: Re: Use maven-shade-plugin to prevent duplicate code - revisited To: MyFaces Development dev@myfaces.apache.org Date: Friday, July 8, 2011, 3:20 PM Hi I don't think the OSGi mention is off-topic. In theory it is possible to setup myfaces-api and myfaces

Re: Use maven-shade-plugin to prevent duplicate code - revisited

2011-07-13 Thread Leonardo Uribe
and will be a big benefit for cleaning up the shared project! LieGrue, strub --- On Fri, 7/8/11, Leonardo Uribe lu4...@gmail.com wrote: From: Leonardo Uribe lu4...@gmail.com Subject: Re: Use maven-shade-plugin to prevent duplicate code - revisited

Re: Use maven-shade-plugin to prevent duplicate code - revisited

2011-07-11 Thread Jakob Korherr
, strub --- On Fri, 7/8/11, Jakob Korherr jakob.korh...@gmail.com wrote: From: Jakob Korherr jakob.korh...@gmail.com Subject: Re: Use maven-shade-plugin to prevent duplicate code - revisited To: MyFaces Development dev@myfaces.apache.org Date: Friday, July 8

Re: Use maven-shade-plugin to prevent duplicate code - revisited

2011-07-11 Thread Gerhard Petracek
...@gmail.com Subject: Re: Use maven-shade-plugin to prevent duplicate code - revisited To: MyFaces Development dev@myfaces.apache.org Date: Friday, July 8, 2011, 3:20 PM Hi I don't think the OSGi mention is off-topic. In theory it is possible to setup myfaces-api

Re: Use maven-shade-plugin to prevent duplicate code - revisited

2011-07-11 Thread Werner Punz
, 7/8/11, Leonardo Uribe lu4...@gmail.com mailto:lu4...@gmail.com wrote: From: Leonardo Uribe lu4...@gmail.com mailto:lu4...@gmail.com Subject: Re: Use maven-shade-plugin to prevent duplicate code - revisited To: MyFaces Development dev

Re: Use maven-shade-plugin to prevent duplicate code - revisited

2011-07-11 Thread Leonardo Uribe
...@gmail.com Subject: Re: Use maven-shade-plugin to prevent duplicate code - revisited To: MyFaces Development dev@myfaces.apache.org Date: Friday, July 8, 2011, 3:20 PM Hi I don't think the OSGi mention is off-topic. In theory it is possible to setup myfaces-api and myfaces

Re: Use maven-shade-plugin to prevent duplicate code - revisited

2011-07-11 Thread Gerhard Petracek
! LieGrue, strub --- On Fri, 7/8/11, Leonardo Uribe lu4...@gmail.com wrote: From: Leonardo Uribe lu4...@gmail.com Subject: Re: Use maven-shade-plugin to prevent duplicate code - revisited To: MyFaces Development dev@myfaces.apache.org Date: Friday, July 8, 2011, 3:20 PM

Re: Use maven-shade-plugin to prevent duplicate code - revisited

2011-07-11 Thread Leonardo Uribe
the maven-shade-plugin is perfectly fine and will be a big benefit for cleaning up the shared project! LieGrue, strub --- On Fri, 7/8/11, Leonardo Uribe lu4...@gmail.com wrote: From: Leonardo Uribe lu4...@gmail.com Subject: Re: Use maven-shade-plugin to prevent

Re: Use maven-shade-plugin to prevent duplicate code - revisited

2011-07-11 Thread Jakob Korherr
! LieGrue, strub --- On Fri, 7/8/11, Leonardo Uribe lu4...@gmail.com wrote: From: Leonardo Uribe lu4...@gmail.com Subject: Re: Use maven-shade-plugin to prevent duplicate code - revisited To: MyFaces Development dev@myfaces.apache.org Date: Friday, July 8

Re: Use maven-shade-plugin to prevent duplicate code - revisited

2011-07-08 Thread Jakob Korherr
Hi Leo, Yes, I remember that you did some work related to this stuff. Some comments about your problems: 1) If you use myfaces-impl, the packages really are *.shared_impl.* (shade does the relocation on the classes). But a part of this statement is still true - we need to check config files with

Re: Use maven-shade-plugin to prevent duplicate code - revisited

2011-07-08 Thread Gerhard Petracek
i agree with jakob. regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2011/7/8 Jakob Korherr jakob.korh...@gmail.com Hi Leo, Yes, I remember that you did some work related to

Re: Use maven-shade-plugin to prevent duplicate code - revisited

2011-07-08 Thread Mark Struberg
it pretty hard to work OSGi. LieGrue, strub --- On Fri, 7/8/11, Jakob Korherr jakob.korh...@gmail.com wrote: From: Jakob Korherr jakob.korh...@gmail.com Subject: Re: Use maven-shade-plugin to prevent duplicate code - revisited To: MyFaces Development dev@myfaces.apache.org Date: Friday, July

Re: Use maven-shade-plugin to prevent duplicate code - revisited

2011-07-08 Thread Gerhard Petracek
) access impl classes from the API package. This makes it pretty hard to work OSGi. LieGrue, strub --- On Fri, 7/8/11, Jakob Korherr jakob.korh...@gmail.com wrote: From: Jakob Korherr jakob.korh...@gmail.com Subject: Re: Use maven-shade-plugin to prevent duplicate code - revisited To: MyFaces

Re: Use maven-shade-plugin to prevent duplicate code - revisited

2011-07-08 Thread Leonardo Uribe
: Use maven-shade-plugin to prevent duplicate code - revisited To: MyFaces Development dev@myfaces.apache.org Date: Friday, July 8, 2011, 1:09 PM Hi Leo, Yes, I remember that you did some work related to this stuff. Some comments about your problems: 1) If you use myfaces-impl

Re: Use maven-shade-plugin to prevent duplicate code - revisited

2011-07-08 Thread Gerhard Petracek
classes from the API package. This makes it pretty hard to work OSGi. LieGrue, strub --- On Fri, 7/8/11, Jakob Korherr jakob.korh...@gmail.com wrote: From: Jakob Korherr jakob.korh...@gmail.com Subject: Re: Use maven-shade-plugin to prevent duplicate code - revisited

Re: Use maven-shade-plugin to prevent duplicate code - revisited

2011-07-08 Thread Mark Struberg
fine and will be a big benefit for cleaning up the shared project! LieGrue, strub --- On Fri, 7/8/11, Leonardo Uribe lu4...@gmail.com wrote: From: Leonardo Uribe lu4...@gmail.com Subject: Re: Use maven-shade-plugin to prevent duplicate code - revisited To: MyFaces Development dev

Re: Use maven-shade-plugin to prevent duplicate code - revisited

2011-07-08 Thread Gerhard Petracek
, strub --- On Fri, 7/8/11, Leonardo Uribe lu4...@gmail.com wrote: From: Leonardo Uribe lu4...@gmail.com Subject: Re: Use maven-shade-plugin to prevent duplicate code - revisited To: MyFaces Development dev@myfaces.apache.org Date: Friday, July 8, 2011, 3:20 PM Hi I don't think the OSGi

Re: Use maven-shade-plugin to prevent duplicate code - revisited

2011-07-08 Thread Leonardo Uribe
, Leonardo Uribe lu4...@gmail.com wrote: From: Leonardo Uribe lu4...@gmail.com Subject: Re: Use maven-shade-plugin to prevent duplicate code - revisited To: MyFaces Development dev@myfaces.apache.org Date: Friday, July 8, 2011, 3:20 PM Hi I don't think the OSGi mention is off-topic

Re: Use maven-shade-plugin to prevent duplicate code - revisited

2011-07-08 Thread Gerhard Petracek
and will be a big benefit for cleaning up the shared project! LieGrue, strub --- On Fri, 7/8/11, Leonardo Uribe lu4...@gmail.com wrote: From: Leonardo Uribe lu4...@gmail.com Subject: Re: Use maven-shade-plugin to prevent duplicate code - revisited To: MyFaces Development dev

Re: Use maven-shade-plugin to prevent duplicate code - revisited

2011-07-08 Thread Leonardo Uribe
for cleaning up the shared project! LieGrue, strub --- On Fri, 7/8/11, Leonardo Uribe lu4...@gmail.com wrote: From: Leonardo Uribe lu4...@gmail.com Subject: Re: Use maven-shade-plugin to prevent duplicate code - revisited To: MyFaces Development dev@myfaces.apache.org Date

Use maven-shade-plugin to prevent duplicate code - revisited

2011-07-07 Thread Gerhard Petracek
hi @ all, the goal (as we discussed before) is to get rid of the shared-impl module and move to the shade-plugin for maven. issues with javadoc and osgi bundles prevented us from doing this step. however, with codi v1 we have a project(-configuration) which fixes all the issues we had with the

Re: Use maven-shade-plugin to prevent duplicate code - revisited

2011-07-07 Thread Jakob Korherr
Hi Gerhard, Thx for (re-)opening this thread. I already created a jira issue [1] and a core-branch [2] for prototyping. Currently I am struggling a little bit with the javadoc-plugin, but this stuff should be fixed soon (maybe even today). I'll let you guys know when I am done with the

Re: Use maven-shade-plugin to prevent duplicate code - revisited

2011-07-07 Thread Werner Punz
Excellent news ++1, the shared as we have it is a bad design decision I hope shade will get rid of our debugging issues we have with our current shared. Werner Am 07.07.11 11:04, schrieb Jakob Korherr: Hi Gerhard, Thx for (re-)opening this thread. I already created a jira issue [1] and a

Re: Use maven-shade-plugin to prevent duplicate code - revisited

2011-07-07 Thread Jakob Korherr
Hi guys, I committed a working draft to the branch at [1]. However, there are some issues with the javadoc-plugin (see [2]) that must be fixed first in order to get the expected javadoc. The other stuff (shading of shared and impl-ee6) already works as expected! Feel free to try it out yourself.

Re: Use maven-shade-plugin to prevent duplicate code - revisited

2011-07-07 Thread Gerhard Petracek
hi jakob, great - thx! regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2011/7/7 Jakob Korherr jakob.korh...@gmail.com Hi guys, I committed a working draft to the branch at

Re: Use maven-shade-plugin to prevent duplicate code - revisited

2011-07-07 Thread Leonardo Uribe
Hi I haven't look the code provided in deep, but long time ago I tried it. In that time I saw the following problems: 1. There are some classes on shared that are used outside it. For example, see org.apache.myfaces.shared.webapp.webxml.DelegatedFacesServlet. We need to detect all similar cases