proposed: myfaces jsf.js refactorings

2010-05-10 Thread Werner Punz
Hello everyone, I have started somewhat of a cleanup regarding the jsf.js codebase which will be done in the following weeks. First of all after fixing the bugs (which I will commit today), I came to the conclusion that our utils classes are somewhat in need of a fixup and generally some struc

Re: proposed: myfaces jsf.js refactorings

2010-05-10 Thread Ganesh
This is cool! Isn't the exception handling another place to clean up? Best regards, Ganesh Werner Punz schrieb: Hello everyone, I have started somewhat of a cleanup regarding the jsf.js codebase which will be done in the following weeks. First of all after fixing the bugs (which I will commit

Re: proposed: myfaces jsf.js refactorings

2010-05-10 Thread Werner Punz
Yes definitely, the exception handling can be done better, but one step after the other... I already cleaned up some exception handling stuff in the utils classes, there are no more direct references to our impl exception delegation code. There are several things which can be improved, but c

Re: proposed: myfaces jsf.js refactorings

2010-05-11 Thread Jakob Korherr
Sounds great, Werner! Regards, Jakob 2010/5/10 Werner Punz > Yes definitely, the exception handling can be done better, but one step > after the other... > > I already cleaned up some exception handling stuff in the utils classes, > there are no more direct references to our impl exception dele

Re: proposed: myfaces jsf.js refactorings

2010-05-11 Thread Werner Punz
Hi Jakob, the namespacing, dom and inheritance features might be useful also for Tomahawk 2.0. I am however not sure how we can manage it buildwise to get it in. We might drop some of our files buildwise from the api also into tomahawk. A double include is not really that bad because due to the

Re: proposed: myfaces jsf.js refactorings

2010-05-11 Thread Jakob Korherr
Yes, sure. However it is important to have these refactorings on core first. Then we can adopt them to Tomahawk 2.0! I am sure we will find a way ;) Regards, Jakob 2010/5/11 Werner Punz > Hi Jakob, the namespacing, dom and inheritance features might be useful > also for Tomahawk 2.0. > I am how

Re: proposed: myfaces jsf.js refactorings

2010-05-11 Thread Werner Punz
No worries the first part of the refactorings is almost done however I need to run additional tests (I am low on unit tests here for the javascripts, only a couple of pages testing the protocol on http level) So the commit probably will happen tomorrow. Werner Am 11.05.10 14:48, schrieb Jakob

Re: proposed: myfaces jsf.js refactorings

2010-05-11 Thread Werner Punz
Hia I now have moved about 90% of the codebase to the new class structure here is an example: http://www.pastebin.org/222860 For everyone familiar with dojo, this looks very familiar. Werner Am 11.05.10 14:48, schrieb Jakob Korherr: Yes, sure. However it is important to have these refact

Re: proposed: myfaces jsf.js refactorings

2010-05-12 Thread Werner Punz
Ok I have everything up and running, but I have not finished my tests yet. The commit has to be postponed to friday. For Mark Li, the good news is I have now the dialog example fully up and running with the latest codebase: http://pastebin.com/TmFGtQyv Werner Am 12.05.10 00:36, schrieb Wern

Re: proposed: myfaces jsf.js refactorings

2010-05-14 Thread Werner Punz
Ok guys it is done for now. I ran a load of new tests on the codebase and I hope I have caught most if not all errors. I think our _Runtime.js is now solid enough to be reused by Tomahawk and co. What you can do with it: a) Real prototype inheritance dojo style b) Namespacing c) some smaller he

Re: proposed: myfaces jsf.js refactorings

2010-05-14 Thread Jakob Korherr
That's great news, Werner! Regards, Jakob 2010/5/14 Werner Punz > Ok guys it is done for now. I ran a load of new tests on the codebase and I > hope I have caught most if not all errors. > > I think our _Runtime.js is now solid enough to be reused by Tomahawk and > co. > > What you can do with

Re: proposed: myfaces jsf.js refactorings - finally done

2010-05-17 Thread Werner Punz
Ok I am now done with the Javascript refactorings, there is probably still some room for improvement, but I think the code now is a solid foundation for the next enhancements. Here is a full list of what has been done a) Namespace cleanup b) Introduction of a base _Runtime class which provides