[Trinidad] Casablanca skin

2010-07-23 Thread Marius Petoi
Hello, Apparently there have been some naming conventions that have not been respected in defining the aliases in the Casablanca skin. I was wondering whether there is anyone that extended this skin. I'm trying to determine the impact that changing the names to the appropriate ones would have.

[jira] Commented: (TRINIDAD-1860) Rename wrong style names in casablanca skin

2010-07-23 Thread Marius Petoi (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12891495#action_12891495 ] Marius Petoi commented on TRINIDAD-1860: Hi Jeanne, I've noticed now that there

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Matthias Wessendorf
I just tested 2.0.2-SNAPSHOT with our internal version of ADF Faces, that runs on JSF2. My jetty powered environment gives me no errors with our latest trunk... -Matthias On Thu, Jul 22, 2010 at 9:36 PM, Werner Punz werner.p...@gmail.com wrote: Btw. one issue about this, check if your fix does

Re: [GSOC] State saving status after first improvements

2010-07-23 Thread Marius Petoi
Hi Martin, The state of a typical input text contains the following 4 attributes (both the keys and the values): valid, value, localValueSet and submittedValue. Value and submittedValue may be null, in this case only the keys are contained in the state. Valid and localValueSet are boolean

[jira] Commented: (MYFACES-2753) Trivial multi-level templating does not work if ui:include is used

2010-07-23 Thread Jakob Korherr (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12891509#action_12891509 ] Jakob Korherr commented on MYFACES-2753: Hi Leo, The current response is the

Re: [GSOC] State saving status after first improvements

2010-07-23 Thread Martin Marinschek
Hi Marius, The state of a typical input text contains the following 4 attributes (both the keys and the values): valid, value, localValueSet and submittedValue. Value and submittedValue may be null, in this case only the keys are contained in the state. Valid and localValueSet are boolean

AW: [Trinidad] Casablanca skin

2010-07-23 Thread Mathias Walter
Hi Marius, I did extend some minor parts, just a few lines. A change would not make much effort. -- Kind regards, Mathias -Ursprüngliche Nachricht- Von: Marius Petoi [mailto:marius.pe...@codebeat.ro] Gesendet: Freitag, 23. Juli 2010 08:53 An: MyFaces Development; MyFaces Discussion

[jira] Commented: (MYFACES-2836) HtmlResponseWriterImpl does not check if a CDATA section is already opened when writing the content of a script

2010-07-23 Thread Bruno Aranda (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-2836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12891536#action_12891536 ] Bruno Aranda commented on MYFACES-2836: --- Werner said this in the mailing list:

[jira] Resolved: (MYFACES-2836) HtmlResponseWriterImpl does not check if a CDATA section is already opened when writing the content of a script

2010-07-23 Thread Bruno Aranda (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-2836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-2836. --- Assignee: Bruno Aranda Fix Version/s: 2.0.2-SNAPSHOT Resolution: Fixed The

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Bruno Aranda
Hi, But the patch had not been checked it yet? Or did you patch it before trying the tests? In any case, I have committed it just now, all myfaces tests pass. Cheers! Bruno On 23 July 2010 08:26, Matthias Wessendorf mat...@apache.org wrote: I just tested 2.0.2-SNAPSHOT with our internal

[jira] Updated: (MYFACES-2831) Avoid neested CDATA section for PPR e.g. with Primefaces

2010-07-23 Thread Bruno Aranda (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-2831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda updated MYFACES-2831: -- Status: Resolved (was: Patch Available) Assignee: Bruno Aranda Fix

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Jakob Korherr
On my machine those tests fail now: Failed tests: teststandardNestingTest(org.apache.myfaces.context.PartialResponseWriterImplTest) testIllegalNestingResolvementTest(org.apache.myfaces.context.PartialResponseWriterImplTest)

[jira] Reopened: (MYFACES-2836) HtmlResponseWriterImpl does not check if a CDATA section is already opened when writing the content of a script

2010-07-23 Thread Jakob Korherr (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-2836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Korherr reopened MYFACES-2836: sorry, again there are a lot of test failures: Failed tests:

Re: [GSOC] State saving status after first improvements

2010-07-23 Thread Martin Marinschek
+1! tell us how much this changes... best regards, Martin On Fri, Jul 23, 2010 at 12:23 PM, Marius Petoi marius.pe...@codebeat.ro wrote: Hello, These values are written by default in the processDecodes() and updateModel() methods. This is before the state is written. One thing that we

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Werner Punz
Hi I have to add my 2c to the entire issue. The main issue still is mainly at Primefaces and here is the reason, primefaces uses an xml response type protocol in the background but does not escape the cdata blocks like we and mojarra do in the ppr part. Instead it just uses the standard

[jira] Commented: (MYFACES-2836) HtmlResponseWriterImpl does not check if a CDATA section is already opened when writing the content of a script

2010-07-23 Thread Bruno Aranda (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-2836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12891551#action_12891551 ] Bruno Aranda commented on MYFACES-2836: --- Uhm, you are right... I probably ran the

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Bruno Aranda
The tests failed after my commit because a silly mistake on my part re-using existing constants in HtmlResponseWriterImpl for the CDATA strings, which contained a line return... hence breaking the tests assertions for the PartialReponseWriterImpl. I am having some trouble with some corrupt SVN,

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Matthias Wessendorf
I get the build failure as well... LEt's revert the commit and ask Primefaces guy(s) to fix it BTW It is not the first issues that users find when running the lib with MyFaces... Honestly, I don't understand why he does not even bother to test against MyFaces, especially since he is a

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Matthias Wessendorf
On Fri, Jul 23, 2010 at 12:46 PM, Matthias Wessendorf mat...@apache.org wrote: I get the build failure as well... LEt's revert the commit and ask Primefaces guy(s) to fix it BTW It is not the first issues that users find when running the lib with MyFaces... Honestly, I don't understand

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Bruno Aranda
No please, it is passing now!! Forgive my mistake of re-using a constant with a line return in it! It was a possible bug with MyFaces, really, because the methods to add CDATA in the comments where not relying on startCDATAs or checking nested CDATAs, which can be a potential bug in my opinion.

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Matthias Wessendorf
On Fri, Jul 23, 2010 at 12:50 PM, Bruno Aranda brunoara...@gmail.com wrote: No please, it is passing now!! Forgive my mistake of re-using a constant with a line return in it! :-) It was a possible bug with MyFaces, really, because the methods to add CDATA in the comments where not relying

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Matthias Wessendorf
re-tested; works fine with your patch as well On Fri, Jul 23, 2010 at 11:37 AM, Bruno Aranda brunoara...@gmail.com wrote: Hi, But the patch had not been checked it yet? Or did you patch it before trying the tests? In any case, I have committed it just now, all myfaces tests pass. Cheers!

[jira] Resolved: (MYFACES-2836) HtmlResponseWriterImpl does not check if a CDATA section is already opened when writing the content of a script

2010-07-23 Thread Bruno Aranda (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-2836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Aranda resolved MYFACES-2836. --- Resolution: Fixed Everything is passing. Checked and double-checked :)

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Werner Punz
Hi I have written a load of tests for the PPR responsewriter to have it covered, but I will do some additional testing mid next week (and will commit those tests) if the ppr responsewriter still behaves as it should after the patch. Since we are not in the middle of another release I can guess

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Bruno Aranda
Yeah Werner, you should take holidays seriously :) Thanks! Bruno On 23 July 2010 13:28, Werner Punz werner.p...@gmail.com wrote: Hi I have written a load of tests for the PPR responsewriter to have it covered, but I will do some additional testing mid next week (and will commit those tests)

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Werner Punz
No worries I have not coded a single line of code this week :-) That does not prevent me to read the mailinglist if there is something which affects part of the stuff I am working on. Werner Am 23.07.10 14:30, schrieb Bruno Aranda: Yeah Werner, you should take holidays seriously :) Thanks!

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Matthias Wessendorf
On Fri, Jul 23, 2010 at 2:30 PM, Bruno Aranda brunoara...@gmail.com wrote: Yeah Werner, you should take holidays seriously :) +1 Thanks! Bruno On 23 July 2010 13:28, Werner Punz werner.p...@gmail.com wrote: Hi I have written a load of tests for the PPR responsewriter to have it covered,

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Martin Marinschek
On Fri, Jul 23, 2010 at 2:40 PM, Matthias Wessendorf mat...@apache.org wrote: On Fri, Jul 23, 2010 at 2:30 PM, Bruno Aranda brunoara...@gmail.com wrote: Yeah Werner, you should take holidays seriously :) +1 ESPECIALLY this kind of holidays - a honeymoon ;) best regards, Martin On 23 July

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Werner Punz
The honeymoon is over already, unfortunately, since we have a small boy of 19 months we only could get away for four days to one of the local lakes. Werner Am 23.07.10 14:41, schrieb Martin Marinschek: On Fri, Jul 23, 2010 at 2:40 PM, Matthias Wessendorfmat...@apache.org wrote: On Fri, Jul

[jira] Created: (MYFACES-2837) jsf.js 2.0 reva new functions

2010-07-23 Thread Werner Punz (JIRA)
jsf.js 2.0 reva new functions - Key: MYFACES-2837 URL: https://issues.apache.org/jira/browse/MYFACES-2837 Project: MyFaces Core Issue Type: Improvement Affects Versions: 2.1.0 Reporter: Werner

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Mark Struberg
that means you are now awarded not only with 'Master of JavaScript' but also with the title 'Gelsinator' :) LieGrue, strub - Original Message From: Werner Punz werner.p...@gmail.com To: dev@myfaces.apache.org Sent: Fri, July 23, 2010 2:48:17 PM Subject: Re: Fixing

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Jakob Korherr
lol, Mark. Werner, I don't believe you: No worries I have not coded a single line of code this week :-) - impossible :D Regards, Jakob 2010/7/23 Mark Struberg strub...@yahoo.de that means you are now awarded not only with 'Master of JavaScript' but also with the title 'Gelsinator' :)

[jira] Commented: (MYFACES-2836) HtmlResponseWriterImpl does not check if a CDATA section is already opened when writing the content of a script

2010-07-23 Thread Jakob Korherr (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-2836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12891583#action_12891583 ] Jakob Korherr commented on MYFACES-2836: Great, I hope we can finally close this

[jira] Created: (TOMAHAWK-1529) ConcurrentModificationException when using t:selectManyPickList and h:selectOneMenu

2010-07-23 Thread suresh t (JIRA)
ConcurrentModificationException when using t:selectManyPickList and h:selectOneMenu --- Key: TOMAHAWK-1529 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1529

[jira] Created: (ORCHESTRA-53) Access Scope doesn't account for network latency (or other network events).

2010-07-23 Thread Jose Luis Freire (JIRA)
Access Scope doesn't account for network latency (or other network events). --- Key: ORCHESTRA-53 URL: https://issues.apache.org/jira/browse/ORCHESTRA-53 Project: MyFaces

[jira] Created: (TOBAGO-902) Simplify the HTML represantation of the Label tag.

2010-07-23 Thread Udo Schnurpfeil (JIRA)
Simplify the HTML represantation of the Label tag. -- Key: TOBAGO-902 URL: https://issues.apache.org/jira/browse/TOBAGO-902 Project: MyFaces Tobago Issue Type: Improvement

[GSoC] where to commit ?

2010-07-23 Thread Matthias Wessendorf
Hey, I though about a proper location for the Google Summer of Code projects. What about this: https://svn.apache.org/repos/asf/myfaces/gsoc/projectXYZ/trunk/ Once the code is ready (stable) we can also relocate it, IMO. Like: https://svn.apache.org/repos/asf/myfaces/html5-lib/...

Re: [VOTE] Release MyFaces Portlet Bridge 2.0.0-beta

2010-07-23 Thread Scott O'Bryan
+1 On 07/22/2010 04:41 AM, Matthias Wessendorf wrote: +1 On Wed, Jul 21, 2010 at 10:18 PM, Michael Freedman michael.freed...@oracle.com wrote: +1 On 7/20/2010 2:09 PM, Michael Freedman wrote: Please vote on the proposed release of MyFaces Portlet Bridge 2.0.0-beta. This is the

Re: [GSoC] where to commit ?

2010-07-23 Thread Gerhard Petracek
+1 for #1 (https://svn.apache.org/repos/asf/myfaces/gsoc/*) @relocation after gsoc finished: some time ago we decided that we won't add a lot of top-level modules. - imo we should decide about the final location of every gsoc-project later on. regards, gerhard http://www.irian.at Your JSF

Re: [GSoC] where to commit ?

2010-07-23 Thread Matthias Wessendorf
On Fri, Jul 23, 2010 at 8:22 PM, Gerhard Petracek gerhard.petra...@gmail.com wrote: +1 for #1 (https://svn.apache.org/repos/asf/myfaces/gsoc/*) @relocation after gsoc finished: some time ago we decided that we won't add a lot of top-level modules. - imo we should decide about the final

[jira] Commented: (MYFACES-2753) Trivial multi-level templating does not work if ui:include is used

2010-07-23 Thread Leonardo Uribe (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12891733#action_12891733 ] Leonardo Uribe commented on MYFACES-2753: - Hi Jakob The idea behind the test is

[jira] Resolved: (MYFACES-2837) jsf.js 2.0 reva new functions

2010-07-23 Thread Werner Punz (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Werner Punz resolved MYFACES-2837. -- Fix Version/s: 2.1.0 Resolution: Won't Fix Ok it seems like an error in the spec, the

Re: Fixing ResponseWriter.startCDATA/endCDATA

2010-07-23 Thread Werner Punz
Mark you probably have been to often to the Burgenland, there are lakes in Austria which are not flooded with those dreaded insects. I really can recommend one of the mountain lakes where we have been. No Gelsen there just Pferdebremsen :-D Am 23.07.10 15:05, schrieb Mark Struberg: that

Re: [GSoC] where to commit ?

2010-07-23 Thread Ali Ok
+1 from me too. /gsoc folder can also be used for next years. On Fri, Jul 23, 2010 at 9:44 PM, Matthias Wessendorf mat...@apache.orgwrote: On Fri, Jul 23, 2010 at 8:22 PM, Gerhard Petracek gerhard.petra...@gmail.com wrote: +1 for #1 (https://svn.apache.org/repos/asf/myfaces/gsoc/*)

[jira] Created: (TRINIDAD-1863) trinidad requeststatemap does not preserve its state between action and render

2010-07-23 Thread Scott O'Bryan (JIRA)
trinidad requeststatemap does not preserve its state between action and render -- Key: TRINIDAD-1863 URL: https://issues.apache.org/jira/browse/TRINIDAD-1863 Project: MyFaces