[jira] Resolved: (TOBAGO-924) tc:menuSeparator still displayed despite rendered=false

2010-10-20 Thread Bernd Bohmann (JIRA)
[ https://issues.apache.org/jira/browse/TOBAGO-924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bernd Bohmann resolved TOBAGO-924. -- Resolution: Fixed tc:menuSeparator still displayed despite rendered=false

[jira] Resolved: (TOBAGO-925) MenuBarRenderer should consider the rendered attribute of the children

2010-10-20 Thread Bernd Bohmann (JIRA)
[ https://issues.apache.org/jira/browse/TOBAGO-925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bernd Bohmann resolved TOBAGO-925. -- Resolution: Fixed MenuBarRenderer should consider the rendered attribute of the children

Re: [jira] Commented: (TRINIDAD-1940) Problems with the tr:forEach

2010-10-20 Thread Andrew Robinson
okay, yes thanks, that is what I meant (I was thinking of the example where the key was a string), thanks for the clarification. On Tue, Oct 19, 2010 at 2:29 PM, Blake Sullivan blake.sulli...@oracle.com wrote:  If keyPassThru is true, I think that the id will be the stringified version of the

Re: Fw: [ANNOUNCE] Apache OpenWebBeans 1.0.0

2010-10-20 Thread Werner Punz
Hi Marc Congratulations... Werner Am 19.10.10 17:26, schrieb Mark Struberg: Hi folks! OWB-1.0.0 officially out now! LieGrue, strub --- On Tue, 10/19/10, Mark Strubergstrub...@apache.org wrote: From: Mark Strubergstrub...@apache.org Subject: [ANNOUNCE] Apache OpenWebBeans 1.0.0 To:

[Trinidad] tr:commandbutton issue

2010-10-20 Thread Adam R Rice
I have been trying to use the Trinidad command button to call a method in a bean but it doesn't seem to recognise that the method is there. index.jsp f:view html head meta http-equiv=Content-Type content=text/html; charset=ISO-8859-1 meta content=no-cache

[jira] Created: (TOBAGO-926) tc:popup transparent

2010-10-20 Thread Guido Dubois (JIRA)
tc:popup transparent -- Key: TOBAGO-926 URL: https://issues.apache.org/jira/browse/TOBAGO-926 Project: MyFaces Tobago Issue Type: Bug Components: Core Affects Versions: 1.5.0-alpha-2 Environment:

[jira] Created: (TOBAGO-927) Cursor tc:toolBarCommand

2010-10-20 Thread Guido Dubois (JIRA)
Cursor tc:toolBarCommand -- Key: TOBAGO-927 URL: https://issues.apache.org/jira/browse/TOBAGO-927 Project: MyFaces Tobago Issue Type: Bug Components: Core Affects Versions: 1.5.0-alpha-2

[jira] Created: (MYFACES-2949) I think that MyFaces should use JSF 2 resource handling instead of directly write script resources to the output stream

2010-10-20 Thread Hampus Wingren (JIRA)
I think that MyFaces should use JSF 2 resource handling instead of directly write script resources to the output stream --- Key: MYFACES-2949 URL:

[jira] Commented: (TOBAGO-926) tc:popup transparent

2010-10-20 Thread Guido Dubois (JIRA)
[ https://issues.apache.org/jira/browse/TOBAGO-926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12922904#action_12922904 ] Guido Dubois commented on TOBAGO-926: - ...and buttons, links in background are

Problem facing in Trinidad

2010-10-20 Thread Meghna Bharadwaj
Hi dev, I want the following functionality: I am using trinidad table where there is a list of values displayed, out of this i want to display only 8 rows rest of the rows should be hidden, and when i click on some link like 'Show All' it should display the remaining rows also. Please help me

Re: Problem facing in Trinidad

2010-10-20 Thread Cédric Durmont
Hi Meghna, You can do the following to achieve this : tr:table rows=#{someBean.viewAll == true ? 0 : 8} f:facet name=actions tr:commandLink text=View all tr:setActionListener from=#{true} to=#{someBean.viewAll}/ /tr:commandLink /f:facet ... /tr:table viewAll is a boolean you

[core] performance: TagAttributeImpl and composite component EL detection

2010-10-20 Thread Martin Koci
Hi, a issue to consider in org.apache.myfaces.view.facelets.tag.TagAttributeImpl: Methods TagAttributeImpl.getMethodExpression and TagAttributeImpl.getValueExpression use CompositeComponentELUtils.isCompositeComponentXYZ methods to detect if current #{} contains cc expression. But consider

[jira] Commented: (TRINIDAD-1942) ViewDeclarationLanguageFactoryImpl implementation should cache physical URI for the current viewId on the ViewMap

2010-10-20 Thread Max Starets (JIRA)
[ https://issues.apache.org/jira/browse/TRINIDAD-1942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12922970#action_12922970 ] Max Starets commented on TRINIDAD-1942: --- +1 for the patch, but the second

Re: [core] performance: TagAttributeImpl and composite component EL detection

2010-10-20 Thread Werner Punz
Just my 2c without looking into the code, but I assume speed improvements already can be gained by replacing the pattern matches, if possible with a direct ll comparison. Regexps often are heavier than simple parsing or string operations. Another thing might be that we add some caching

Re: Is it possible to make those xml digest class serializable ?

2010-10-20 Thread Ivan
Hi, devs, I posted some initial ideas to MYFACES-2945, and very appriciated with any comment :-) Once we have final result, I will try to create a patch. thanks. 2010/10/19 Jakob Korherr jakob.korh...@gmail.com Hi Ivan, Great to hear from the Geronimo team :) If you need some more than the

Re: Is it possible to make those xml digest class serializable ?

2010-10-20 Thread Leonardo Uribe
Hi Some answers to your post below: IV Just some ideas for the integration improvment, please help to give some comments. IV a. Create a new SPI provider and a provider factory, might name FacesConfigurationProvider/ IV FacesConfigurationProviderFactory, which has a method IV FacesConfig

Fwd: [jira] Updated: (TRINIDAD-1942) ViewDeclarationLanguageFactoryImpl implementation should cache physical URI for the current viewId on the ViewMap

2010-10-20 Thread Pavitra Subramaniam
Thanks for the review Max! Can you commit the changes if there are no other concerns? Thanks Pavitra Original Message Subject: [jira] Updated: (TRINIDAD-1942) ViewDeclarationLanguageFactoryImpl implementation should cache physical URI for the current viewId on the ViewMap

[jira] Updated: (MYFACES-2946) composite:attribute targets property does not match with ViewDeclarationLanguage.retargetMethodExpressions

2010-10-20 Thread Leonardo Uribe (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-2946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonardo Uribe updated MYFACES-2946: Resolution: Fixed Fix Version/s: 2.0.3-SNAPSHOT Status: Resolved (was:

[jira] Created: (MYFACES-2950) ActionSourceRule does not take into account action MethodExpression could return Object or Enum

2010-10-20 Thread Leonardo Uribe (JIRA)
ActionSourceRule does not take into account action MethodExpression could return Object or Enum - Key: MYFACES-2950 URL:

[jira] Resolved: (MYFACES-2950) ActionSourceRule does not take into account action MethodExpression could return Object or Enum

2010-10-20 Thread Leonardo Uribe (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-2950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonardo Uribe resolved MYFACES-2950. - Resolution: Fixed Fix Version/s: 2.0.3-SNAPSHOT ActionSourceRule does not take

Re: Fwd: [jira] Updated: (TRINIDAD-1942) ViewDeclarationLanguageFactoryImpl implementation should cache physical URI for the current viewId on the ViewMap

2010-10-20 Thread MAX STARETS
No problem, Pavitra. I am planning to commit the patch today unless there are objections from anybody on this list. Max On 10/20/2010 12:47 PM, Pavitra Subramaniam wrote: Thanks for the review Max! Can you commit the changes if there are no other concerns? Thanks Pavitra

[jira] Commented: (MYFACES-2942) Memory Leak in MyFaces 2.0.1 probably as well in 2.0.2

2010-10-20 Thread Leonardo Uribe (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-2942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12923068#action_12923068 ] Leonardo Uribe commented on MYFACES-2942: - I reverted the code on FlashELResolver

Re: [core] performance: TagAttributeImpl and composite component EL detection

2010-10-20 Thread Jakob Korherr
Hi Kočičák, There might be some ways to improve this, but we have to be very careful in making changes to that area, because the whole composite components + EL domain is not that easy. Actually the CompositeComponentELUtils.isCompositeComponentXYZ methods were introduced by myself when fixing

Re: EL method invocation performance

2010-10-20 Thread Jakob Korherr
Please note that uel.dev.java.net API suffers from classic leaking classloader problem too - it uses Class instance as key in static Map : see MYFACES-2942 for details. Maybe we should put a warning about these two issues at http://wiki.apache.org/myfaces/HowToEnableEl22 ? Huge +1 - please do

[jira] Commented: (MYFACES-2949) I think that MyFaces should use JSF 2 resource handling instead of directly write script resources to the output stream

2010-10-20 Thread Jakob Korherr (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-2949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12923134#action_12923134 ] Jakob Korherr commented on MYFACES-2949: Could you please specify which script

[jira] Commented: (MYFACES-2942) Memory Leak in MyFaces 2.0.1 probably as well in 2.0.2

2010-10-20 Thread Jakob Korherr (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-2942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12923145#action_12923145 ] Jakob Korherr commented on MYFACES-2942: Hi Leo, Sorry for the late answer. I

[jira] Commented: (MYFACES-2942) Memory Leak in MyFaces 2.0.1 probably as well in 2.0.2

2010-10-20 Thread Leonardo Uribe (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-2942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12923158#action_12923158 ] Leonardo Uribe commented on MYFACES-2942: - Hi Jakob Yes, you're right. Since

[jira] Created: (MYFACES-2951) [PERF] enhance scanning for #{cc} expressions

2010-10-20 Thread Leonardo Uribe (JIRA)
[PERF] enhance scanning for #{cc} expressions - Key: MYFACES-2951 URL: https://issues.apache.org/jira/browse/MYFACES-2951 Project: MyFaces Core Issue Type: Improvement Components:

Re: [core] performance: TagAttributeImpl and composite component EL detection

2010-10-20 Thread Leonardo Uribe
Hi I have an idea: why don't evaluate that condition on construction time? In that case, EL will be scanned only once (when the Facelet or Abstract Syntax Tree (AST) is build) and not when the view is build, like is happening now. I have created an issue

Re: [core] performance: TagAttributeImpl and composite component EL detection

2010-10-20 Thread Jakob Korherr
Hi Leo, Hehe, yes, great idea!! I am wondering why we did not think of that in the first place... However one question - why are you using the approach with one integer instead of three booleans? I know it's only a question about code style, but it kinda seems odd. Regards, Jakob 2010/10/20

Re: [core] performance: TagAttributeImpl and composite component EL detection

2010-10-20 Thread Leonardo Uribe
Hi Jakob 2010/10/20 Jakob Korherr jakob.korh...@gmail.com Hi Leo, Hehe, yes, great idea!! I am wondering why we did not think of that in the first place... However one question - why are you using the approach with one integer instead of three booleans? I know it's only a question about

[jira] Commented: (MYFACES-2951) [PERF] enhance scanning for #{cc} expressions

2010-10-20 Thread Jakob Korherr (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-2951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12923176#action_12923176 ] Jakob Korherr commented on MYFACES-2951: We can still also try to implement the

Re: [core] performance: TagAttributeImpl and composite component EL detection

2010-10-20 Thread Martin Koci
hehe, I was writing something similar: in production stage TagAttributeImpl is only created once and then facelets cache mechanism keep this instance alive as part of Facelet memory structure. Thus if user did request to all Facelet instances (all *xhtml) in JSF application, it creates forest of

[jira] Commented: (MYFACES-2951) [PERF] enhance scanning for #{cc} expressions

2010-10-20 Thread Leonardo Uribe (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-2951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12923185#action_12923185 ] Leonardo Uribe commented on MYFACES-2951: - I committed these lines: private

[jira] Commented: (MYFACES-2951) [PERF] enhance scanning for #{cc} expressions

2010-10-20 Thread Jakob Korherr (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-2951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12923187#action_12923187 ] Jakob Korherr commented on MYFACES-2951: In theory you're right, but I think if

[jira] Commented: (MYFACES-2944) Make those add*** methods public in WebXml

2010-10-20 Thread Jakob Korherr (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12923190#action_12923190 ] Jakob Korherr commented on MYFACES-2944: Ivan, I just committed a (IMO more

[jira] Commented: (MYFACES-2945) Make a way to get the FacesConfig from a provider

2010-10-20 Thread Jakob Korherr (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12923193#action_12923193 ] Jakob Korherr commented on MYFACES-2945: The suggestion seems ok to me. We will

[jira] Created: (TOMAHAWK-1554) CollapsiblePanel CSS Question

2010-10-20 Thread Oliver Bayer (JIRA)
CollapsiblePanel CSS Question - Key: TOMAHAWK-1554 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1554 Project: MyFaces Tomahawk Issue Type: Improvement Affects Versions: 1.1.11-SNAPSHOT

[jira] Commented: (MYFACES-2944) Make those add*** methods public in WebXml

2010-10-20 Thread Ivan (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12923272#action_12923272 ] Ivan commented on MYFACES-2944: --- It is better that you guys could help to work on it :-) I

Fwd: Is it possible to make those xml digest class serializable ?

2010-10-20 Thread Ivan
Forgot to use reply all :-) Thanks, please help to check my comments below. 2010/10/20 Leonardo Uribe lu4...@gmail.com Hi Some answers to your post below: IV Just some ideas for the integration improvment, please help to give some comments. IV a. Create a new SPI provider and a provider