[jira] [Commented] (MYFACES-3786) Web Container injection support should be provided for additional lifecycle artifacts (not just managed beans)

2013-10-14 Thread Dora Rajappan (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794076#comment-13794076 ] Dora Rajappan commented on MYFACES-3786: MYFACES-3786-2.patch is very good. No

[VOTE] svn-keywords and @author tags

2013-10-14 Thread Gerhard Petracek
hi @ all, we already had a discussion as well as an agreement about it (starting point: [1]). in several modules the cleanup is finished. however, since we still have (even new) parts which contain svn-keywords and/or @author tags, i start this formal vote. please vote with

Re: [VOTE] svn-keywords and @author tags

2013-10-14 Thread Jakob Korherr
+1 Regards, Jakob 2013/10/14 Gerhard Petracek gpetra...@apache.org: hi @ all, we already had a discussion as well as an agreement about it (starting point: [1]). in several modules the cleanup is finished. however, since we still have (even new) parts which contain svn-keywords and/or

Re: [VOTE] svn-keywords and @author tags

2013-10-14 Thread Mike Kienenberger
+1 for removing author tags. +1 for removing most svn tags There's value in having the svn version tag as you can't tell what version of the file you are working with once the file is used outside of svn. On the other hand, having the svn version tag can make diffing changes more difficult. So

[jira] [Commented] (MYFACES-3786) Web Container injection support should be provided for additional lifecycle artifacts (not just managed beans)

2013-10-14 Thread Leonardo Uribe (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794127#comment-13794127 ] Leonardo Uribe commented on MYFACES-3786: - @Gerhard unfortunately the change you

Re: [VOTE] svn-keywords and @author tags

2013-10-14 Thread Leonardo Uribe
+0 for removing author tags. Note there is code licensed under ASL that was originally taken from other sources, and it is a good idea to keep the references of where that code came from. For example:

Re: [VOTE] svn-keywords and @author tags

2013-10-14 Thread Werner Punz
+0 from my side, I simply do not care, I can live with both solutions. Werner Am 14.10.13 16:18, schrieb Leonardo Uribe: +0 for removing author tags. Note there is code licensed under ASL that was originally taken from other sources, and it is a good idea to keep the references of where that

[jira] [Commented] (MYFACES-3786) Web Container injection support should be provided for additional lifecycle artifacts (not just managed beans)

2013-10-14 Thread Gerhard Petracek (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794207#comment-13794207 ] Gerhard Petracek commented on MYFACES-3786: --- @leo: the change itself works.

[jira] [Commented] (MYFACES-3786) Web Container injection support should be provided for additional lifecycle artifacts (not just managed beans)

2013-10-14 Thread Leonardo Uribe (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794219#comment-13794219 ] Leonardo Uribe commented on MYFACES-3786: - @Gerhard : I see. We could try pass

[jira] [Created] (TOBAGO-1321) NPE in UserAgent.hasCapability

2013-10-14 Thread Volker Weber (JIRA)
Volker Weber created TOBAGO-1321: Summary: NPE in UserAgent.hasCapability Key: TOBAGO-1321 URL: https://issues.apache.org/jira/browse/TOBAGO-1321 Project: MyFaces Tobago Issue Type: Bug

[jira] [Created] (TOBAGO-1322) Input elements behind Popup are not reenabled if popup was reloaded before closing

2013-10-14 Thread Volker Weber (JIRA)
Volker Weber created TOBAGO-1322: Summary: Input elements behind Popup are not reenabled if popup was reloaded before closing Key: TOBAGO-1322 URL: https://issues.apache.org/jira/browse/TOBAGO-1322

Re: [VOTE] svn-keywords and @author tags

2013-10-14 Thread Gerhard Petracek
@imported code: please never import code without ip clearance. if there is an issue with the imported code, the @author tag won't help you at all. (if you would like to have the information for other reasons, just add it to the commit-message.) regards, gerhard 2013/10/14 Leonardo Uribe

[jira] [Commented] (MYFACES-3786) Web Container injection support should be provided for additional lifecycle artifacts (not just managed beans)

2013-10-14 Thread Gerhard Petracek (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794246#comment-13794246 ] Gerhard Petracek commented on MYFACES-3786: --- yes - that's the 2nd option i had

[jira] [Commented] (TOBAGO-1321) NPE in UserAgent.hasCapability

2013-10-14 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/TOBAGO-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794258#comment-13794258 ] Hudson commented on TOBAGO-1321: FAILURE: Integrated in tobago-trunk #1130 (See

[jira] [Commented] (TOBAGO-1322) Input elements behind Popup are not reenabled if popup was reloaded before closing

2013-10-14 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/TOBAGO-1322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794257#comment-13794257 ] Hudson commented on TOBAGO-1322: FAILURE: Integrated in tobago-trunk #1130 (See

[jira] [Commented] (MYFACES-3786) Web Container injection support should be provided for additional lifecycle artifacts (not just managed beans)

2013-10-14 Thread Leonardo Uribe (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794263#comment-13794263 ] Leonardo Uribe commented on MYFACES-3786: - I would prefer only one abstract

[jira] [Commented] (MYFACES-3786) Web Container injection support should be provided for additional lifecycle artifacts (not just managed beans)

2013-10-14 Thread Gerhard Petracek (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794281#comment-13794281 ] Gerhard Petracek commented on MYFACES-3786: --- the disadvantage of #2 and #3 is

[jira] [Commented] (MYFACES-3786) Web Container injection support should be provided for additional lifecycle artifacts (not just managed beans)

2013-10-14 Thread Leonardo Uribe (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794325#comment-13794325 ] Leonardo Uribe commented on MYFACES-3786: - In this case, since all injected

[jira] [Commented] (MYFACES-3786) Web Container injection support should be provided for additional lifecycle artifacts (not just managed beans)

2013-10-14 Thread Gerhard Petracek (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794407#comment-13794407 ] Gerhard Petracek commented on MYFACES-3786: --- to avoid something like:

[jira] [Commented] (MYFACES-3786) Web Container injection support should be provided for additional lifecycle artifacts (not just managed beans)

2013-10-14 Thread Gerhard Petracek (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794412#comment-13794412 ] Gerhard Petracek commented on MYFACES-3786: --- @my last comment: it's easier to

[jira] [Comment Edited] (MYFACES-3786) Web Container injection support should be provided for additional lifecycle artifacts (not just managed beans)

2013-10-14 Thread Gerhard Petracek (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794412#comment-13794412 ] Gerhard Petracek edited comment on MYFACES-3786 at 10/14/13 8:12 PM:

[jira] [Comment Edited] (MYFACES-3786) Web Container injection support should be provided for additional lifecycle artifacts (not just managed beans)

2013-10-14 Thread Gerhard Petracek (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794407#comment-13794407 ] Gerhard Petracek edited comment on MYFACES-3786 at 10/14/13 8:16 PM:

[jira] [Commented] (MYFACES-3786) Web Container injection support should be provided for additional lifecycle artifacts (not just managed beans)

2013-10-14 Thread Leonardo Uribe (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794427#comment-13794427 ] Leonardo Uribe commented on MYFACES-3786: - Use: public void inject(Object

[jira] [Comment Edited] (MYFACES-3786) Web Container injection support should be provided for additional lifecycle artifacts (not just managed beans)

2013-10-14 Thread Gerhard Petracek (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794407#comment-13794407 ] Gerhard Petracek edited comment on MYFACES-3786 at 10/14/13 8:23 PM:

[jira] [Commented] (MYFACES-3786) Web Container injection support should be provided for additional lifecycle artifacts (not just managed beans)

2013-10-14 Thread Gerhard Petracek (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794468#comment-13794468 ] Gerhard Petracek commented on MYFACES-3786: --- if we ever need to support custom

[jira] [Commented] (MYFACES-3786) Web Container injection support should be provided for additional lifecycle artifacts (not just managed beans)

2013-10-14 Thread Leonardo Uribe (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794609#comment-13794609 ] Leonardo Uribe commented on MYFACES-3786: - Let's be clear about this.

[jira] [Commented] (MYFACES-3786) Web Container injection support should be provided for additional lifecycle artifacts (not just managed beans)

2013-10-14 Thread Gerhard Petracek (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794717#comment-13794717 ] Gerhard Petracek commented on MYFACES-3786: --- no - maybe it wasn't clear

[jira] [Comment Edited] (MYFACES-3786) Web Container injection support should be provided for additional lifecycle artifacts (not just managed beans)

2013-10-14 Thread Gerhard Petracek (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794717#comment-13794717 ] Gerhard Petracek edited comment on MYFACES-3786 at 10/15/13 12:56 AM:

[jira] [Commented] (MYFACES-3786) Web Container injection support should be provided for additional lifecycle artifacts (not just managed beans)

2013-10-14 Thread Gerhard Petracek (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794746#comment-13794746 ] Gerhard Petracek commented on MYFACES-3786: --- however, since we don't need it

[jira] [Commented] (MYFACES-3786) Web Container injection support should be provided for additional lifecycle artifacts (not just managed beans)

2013-10-14 Thread Leonardo Uribe (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794804#comment-13794804 ] Leonardo Uribe commented on MYFACES-3786: - Let's try the solution using the