Re: MyFaces 1.0.9: how old? how stable? what's next?

2005-07-27 Thread Grant Smith
-1 for a new release until HtmlDataTable works again (see my question in the dev list). I unfortunately am swamped at the moment so I don't have time to delve into it.

[jira] Commented: (MYFACES-366) _SharedRendererUtils does not create the correct type of array, which causes a bind error

2005-07-26 Thread Grant Smith (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-366?page=comments#action_12316787 ] Grant Smith commented on MYFACES-366: - Looks like Bruno and I pounced on this simultaneously :) Note though that theMYFACES-366: _SharedRendererUtils does not create

[jira] Commented: (MYFACES-366) _SharedRendererUtils does not create the correct type of array, which causes a bind error

2005-07-26 Thread Grant Smith (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-366?page=comments#action_12316788 ] Grant Smith commented on MYFACES-366: - Patched the other _SharedRendererUtils.java (there are two :) _SharedRendererUtils does not create the correct type of array

Re: Automated website build

2005-07-25 Thread Grant Smith
The way I understand it is we will have complete control of everything except SVN. Yes, each zone is a virtual server, so it will have its own IP address and DNS. Sean Schofield wrote: Well since I just joined, maybe you can fill me (and the rest of us) in on what's going on with the

Re: [proposal] use EasyMock for mocking

2005-07-21 Thread Grant Smith
+1 for EasyMock and it's dependencies. While we're at it, don't we need junit.jar too ? Also, I would recommend only downloading the dependencies if you run the 'test-all' (or 'test' for a subproject) target, not if you run the usual 'dist-all' that most people will be doing. Thanks for doing

[jira] Closed: (MYFACES-340) x:inputCalendar does not allow '-' as separator in date pattern

2005-07-20 Thread Grant Smith (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-340?page=all ] Grant Smith closed MYFACES-340: --- Fix Version: Nightly Build Resolution: Fixed Fixed. Thanks for the report. x:inputCalendar does not allow '-' as separator in date pattern

Status of testing framework

2005-07-20 Thread Grant Smith
Bill, The current testing setup is great for objects that are container-independent. Any indication when we'll be able to test things that need to live in a container, like FacesContextImpl ? I assume we'll need cactus for that, although if you know of any tricks to test container-dependent

[jira] Commented: (MYFACES-341) Problem with Spring v1.2 and MyFaces 1.0.9

2005-07-20 Thread Grant Smith (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-341?page=comments#action_12316267 ] Grant Smith commented on MYFACES-341: - As a data point, I'm using it too without problems. Sounds like a user configuration problem. Problem with Spring v1.2

[jira] Closed: (MYFACES-341) Problem with Spring v1.2 and MyFaces 1.0.9

2005-07-20 Thread Grant Smith (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-341?page=all ] Grant Smith closed MYFACES-341: --- Resolution: Invalid Not a Myfaces problem Problem with Spring v1.2 and MyFaces 1.0.9 -- Key: MYFACES

[jira] Closed: (MYFACES-169) h:datatable with nested UIData not working

2005-07-13 Thread Grant Smith (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-169?page=all ] Grant Smith closed MYFACES-169: --- Fix Version: Nightly Build Resolution: Fixed Thanks Mathias h:datatable with nested UIData not working

[jira] Closed: (MYFACES-326) facesContext.renderResponse not skipping validation when immediate event submitted twice

2005-07-13 Thread Grant Smith (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-326?page=all ] Grant Smith closed MYFACES-326: --- Resolution: Invalid facesContext.renderResponse not skipping validation when immediate event submitted twice

Re: [proposal] unit testing

2005-07-12 Thread Grant Smith
Bill, This is great, thanks for your efforts with this! I have a few comments. 1. Do we need /java/ in the test path structure? 2. I don't think the tests should run as part of dist, but I do think they should run as part of the nightlies, and viewable as a daily report. Why ? Beacause we

Re: [jira] Updated: (MYFACES-322) Clean up source code

2005-07-12 Thread Grant Smith
Sean Schofield wrote: Its nice to have one of the Struts gurus on board. Thanks for an excellent first patch. Wait... he's a struts guru ? Reverse patch! Abort!! Abort!!

[jira] Commented: (MYFACES-304) FacesContext.getClientIdsWithMessages() fails to return null

2005-07-12 Thread Grant Smith (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-304?page=comments#action_12315637 ] Grant Smith commented on MYFACES-304: - Fixed. If you wouldn't mind re-testing, that would be a great help. I will add unit tests for this class as soon as our testing

Re: SVN Reorg (Update)

2005-07-11 Thread Grant Smith
, when it clearly does. *sigh* Sorry for false alarm. Grant Smith wrote: Sean, The tlddoc-all target of the main buildfile (which calls all the nested buildfiles) is choking on: tlddoc: [java] Error: File/directory not found: /home/grant/IdeaProjects/Myfaces/current/build/../sandbox

Re: SVN Reorg (Update)

2005-07-11 Thread Grant Smith
Doh! Bruno, thanks. OK, so now it looks like it's trying to find a file called *.tld (i.e. the wildcard isnt being interpretted). That is where I'm focussing my investigation on now :) Bruno Aranda wrote: I think you are missing the temp in ls -la

Re: SVN Reorg (Update)

2005-07-11 Thread Grant Smith
from the first property read and does not override it, HTH, Bruno 2005/7/11, Grant Smith [EMAIL PROTECTED]: Doh! Bruno, thanks. OK, so now it looks like it's trying to find a file called *.tld (i.e. the wildcard isnt being interpretted). That is where I'm focussing my investigation

[jira] Commented: (MYFACES-264) Cast to Number instead of Integer for component properties which expects a int value

2005-07-11 Thread Grant Smith (JIRA)
In-Reply-To: [EMAIL PROTECTED] Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable [ http://issues.apache.org/jira/browse/MYFACES-264?page=3Dcomments#acti= on_12315510 ]=20 Grant Smith commented on MYFACES-264

build.xml

2005-07-11 Thread Grant Smith
I need some help understanding how the current build systems works. Are all the individual build.xml files actually svn_externals of the main build.xml file ? That would explain why I can't make modifications to each one, and commit them. Any insight would be greatly appreciated. Thanks,

[jira] Closed: (MYFACES-313) UISaveState component can use saveAttachedState to allow the user implement StateHolder for values

2005-07-08 Thread Grant Smith (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-313?page=all ] Grant Smith closed MYFACES-313: --- Fix Version: Nightly Build Resolution: Fixed Patched. Thanks Mathias. UISaveState component can use saveAttachedState to allow the user implement

[jira] Commented: (MYFACES-310) HtmlLinkRendererBase does not work with custom components that do not extend HtmlCommandLink

2005-07-08 Thread Grant Smith (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-310?page=comments#action_12315324 ] Grant Smith commented on MYFACES-310: - I'm going to err on the side of safety and go with Steven's original modifications. When we have the new unit testing framework

Re: proposal: consolodate examples/standard examples/simple

2005-07-08 Thread Grant Smith
+1 for consolidation, yet with separate areas for non-jsCookMenu-cluttered stuff. Sean Schofield wrote: Can we get a few more +1's for this? sean On 7/7/05, Bill Dudney [EMAIL PROTECTED] wrote: yes now the cobwebs are clearing... if we get agreement I'd be up for getting rid

Re: SVN Reorg (Update)

2005-07-07 Thread Grant Smith
new TilesViewHandler for my day job. Also, I am hoping to add a failure message if you accidentally run a 'foo-all' target from subproject build dir instructing you to run from the top-level. HTH, sean On 7/6/05, Grant Smith [EMAIL PROTECTED] wrote: Sean, The tlddoc-all target

Re: build.default.properties

2005-07-07 Thread Grant Smith
Grant Smith wrote: I would propose that anyone committing a change that causes a test to fail be put in a small interrogation room with the Manfred Geiler Bad Cop. Be very afraid. And don't think you'll go undetected. Sgt Schofield's Subversion Blame Tool will root you out in an instant!

[jira] Commented: (MYFACES-304) FacesContext.getClientIdsWithMessages() fails to return null

2005-07-06 Thread Grant Smith (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-304?page=comments#action_12315152 ] Grant Smith commented on MYFACES-304: - I modified ServletFacesContextImpl: 1. getClientIdsWithMessages() now returns an Iterator of a HashSet built from

Re: UIData...

2005-07-06 Thread Grant Smith
I took the liberty of assigning MYFACES-305 to Sean, as he applied the first patch (and it's about TIME he did some work... yeah, right). Mathias, please upload this new patch to the JIRA too. I will help out with the testing once it's all in SVN. We use UIData extensively, and if there are

Re: Proposal: Make tomahawk stuff 100% RI compliant

2005-07-06 Thread Grant Smith
Great idea regarding moving the non-compliant Tamahawk components into the sandbox. From my quick scan of open JIRA items, there are a few that relate to conformance. Sean Schofield wrote: Remember, I like the Tiles support too (and said it was a key to my discovering MyFaces) ;-) So I'm

[jira] Commented: (MYFACES-304) FacesContext.getClientIdsWithMessages() fails to return null

2005-07-06 Thread Grant Smith (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-304?page=comments#action_12315167 ] Grant Smith commented on MYFACES-304: - Good point. OK, I swiched to LinkedHashSet and patched HtmlMessagesRendererBase. Test it out a bit and let me know if I can close

Re: SVN Reorg (Update)

2005-07-06 Thread Grant Smith
Sean, The tlddoc-all target of the main buildfile (which calls all the nested buildfiles) is choking on: tlddoc: [java] Error: File/directory not found: /home/grant/IdeaProjects/Myfaces/current/build/../sandbox/build/temp/tlds/*.tld for each of the subprojects. I didn't want to touch

[jira] Closed: (MYFACES-289) valueChangeListener doesn't work inside of x:dataList

2005-07-05 Thread Grant Smith (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-289?page=all ] Grant Smith closed MYFACES-289: --- Fix Version: Nightly Build Resolution: Fixed Closed per request valueChangeListener doesn't work inside of x:dataList

[jira] Closed: (MYFACES-287) Wrong declaration of column tag in myfaces_html.tld

2005-07-05 Thread Grant Smith (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-287?page=all ] Grant Smith closed MYFACES-287: --- Resolution: Won't Fix Not a bug... Closed. Wrong declaration of column tag in myfaces_html.tld

Re: Could use some help debugging sandbox

2005-07-01 Thread Grant Smith
I think you basically have to implement getClientId(FacesContext context) with somthing that doesn't include a colon for the new component. As Matt says, we're probably being more spec-compliant lately. Sean Schofield wrote: I've set up the sandbox with a separate sandbox webapp. The new

Re: Could use some help debugging sandbox

2005-07-01 Thread Grant Smith
be a klundge until I understand things better. Let me know if it works Grant Smith wrote: I think you basically have to implement getClientId(FacesContext context) with somthing that doesn't include a colon for the new component. As Matt says, we're probably being more spec-compliant lately. Sean

Re: Could use some help debugging sandbox

2005-07-01 Thread Grant Smith
Hmm.. Does this mean that section 3.2.2 of the spec directly contradicts section 3.3.1 ? Craig ? Bruno Aranda wrote: Hey, stop, the colon is what the NamingContainer uses, as stated in section 3.2.2 of the spec. 'NamingContainer defines a public static final character constant,

Re: Could use some help debugging sandbox

2005-07-01 Thread Grant Smith
3.1.1 I mean.. Grant Smith wrote: Hmm.. Does this mean that section 3.2.2 of the spec directly contradicts section 3.3.1 ? Craig ? Bruno Aranda wrote: Hey, stop, the colon is what the NamingContainer uses, as stated in section 3.2.2 of the spec. 'NamingContainer defines a public static

Re: Could use some help debugging sandbox

2005-07-01 Thread Grant Smith
. I tend to favor the latter as it would be a simple change. Thoughts ? Craig McClanahan wrote: On 7/1/05, Grant Smith [EMAIL PROTECTED] wrote: Hmm.. Does this mean that section 3.2.2 of the spec directly contradicts section 3.3.1 ? Craig ? There's a difference between the value

Re: Could use some help debugging sandbox

2005-07-01 Thread Grant Smith
I posted that a minute before Craig explained why (:) should NOT be allowed, so please ignore my previous suggestion. Grant Smith wrote: Thanks Craig. Based on what Craig (and the spec :-) ) says, I think we need to reconsider how we use UIComponentBase.setId(). If a component's ID

Re: Proposal: Elimiante jar files from SVN

2005-06-29 Thread Grant Smith
If I may interject before this gets too ugly... Oliver, the ASF does not require a formal vote on a matter such as this. The discussion in this thread clearly shows more people in favor of removing jars from svn. This thread is in itself an informal vote. You voiced your objections, and those

Re: SVN Reorg

2005-06-21 Thread Grant Smith
Korhonen, Kalle wrote: For MyFaces unit testing, just throwing out the idea for others to think about. I think this is a great idea, Kalle. +1 Kalle

Re: MyFaces Reorg

2005-05-31 Thread Grant Smith
Sean Schofield wrote: Here is a revised summary of the bundles and their contents. Key changes: 1) the addition of a sandbox distribution (nightly only); includes javadoc; jar file includes tld and faces-config stuff 2) myfaces-all will include sandbox stuff in the nightly (and local ant

Re: MyFaces Reorg

2005-05-27 Thread Grant Smith
Sounds reasonable. However, just to be clear... Will new components start off in the sandbox, then get promoted to tomahawk, and then finally to myfaces ? I guess I don't understand the need for the intermediate step. +1 for myfaces-all.jar, although I don't think it should contain sandbox

Re: JIRA maintenance

2005-05-20 Thread Grant Smith
+1 for keeping it Nightly build, then renaming it when we release 1.0M10 (we're at 1.0M9 now, right ? I thought we all agreed on the M...) Sean Schofield wrote: Yes I suggest we keep it Nightly Build as well because we actually have a nightly build that users can grab and the issue will be

[jira] Reopened: (MYFACES-243) ClientId not used, so JSCookMenu fires multiple actions in tables

2005-05-18 Thread Grant Smith (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-243?page=all ] Grant Smith reopened MYFACES-243: - This patch breaks JSCookMenu navigation completely. I had to reverse it to get the faces-examples to work properly again. Unfortunately I don't have

Re: myfaces-examples: problem with navigation in nightly build

2005-05-18 Thread Grant Smith
Found the problem. - MYFACES-243's patch. I reversed it locally and navigation works again. I reopened the JIRA, but unfortunately dont have the time right now to delve into this. Neal ?! :-) Grant Smith wrote: I just deployed the myfaces-examples from the latest SVN version, and it appears

Re: [jira] Commented: (MYFACES-214) TabbedPane : wrong validation behavior

2005-05-12 Thread Grant Smith
Hi Phillip, Your patch basically reverses a patch made as a suggestion to MYFACES-187. Could you test to see if your patch produces the same problem that MYFACES-187 describes ? I do see a small difference between your code and the original code, so it's possible that your patch fixes both,

Re: $Log$ in source files

2005-05-11 Thread Grant Smith
OK, it's done... sorry Manfred... if it's any consolation, it was painful for me too - but only due to the repetitive-stress injury suffered by pressing CTRL-Y seven million times... Manfred Geiler wrote: Oliver, I fear you are right. Here is my sad +1 for removing $Log$ -Manfred

Sandbox

2005-05-11 Thread Grant Smith
I'd like to kick off the whole sandbox debate again. Yes, I'm a sucker for punishment.. If I recall correctly, the consensus was to have a sandbox subproject for new components. I would like to propose a simpler solution: Why not have the sandbox as a subdirectory of the existing project. Then

Re: Vote for new displayValueOnly attribute

2005-05-10 Thread Grant Smith
Before casting a vote, I would like to seek clarity on one issue this seems to raise: If the displayValueOnly attibute is set, does the underlying component change ? for example, if I have: x:someComponent binding="#{someBean.methodReturningComponent}"/ And I directly manipulate the

Re: $Log$ in source files

2005-05-09 Thread Grant Smith
+1 from me too, they make the javadocs look terrible. Sean Schofield wrote: +1 for removing them. Subversion (and CVS) keeps the same history and they just clutter up the source code and documentation. On 5/9/05, Manfred Geiler [EMAIL PROTECTED] wrote: SVN experts, is there really no

[jira] Closed: (MYFACES-217) Programmatically created UIViewRoot not rendered correctly

2005-05-06 Thread Grant Smith (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-217?page=all ] Grant Smith closed MYFACES-217: --- Assign To: Grant Smith Resolution: Won't Fix Programmatically created UIViewRoot not rendered correctly

Re: Nightly build

2005-05-03 Thread Grant Smith
: * automatically build docs in ${project.dir}/../site * SVN commit it automatically * sftp it to minotaur -Manfred 2005/5/3, Grant Smith [EMAIL PROTECTED]: We probably now need to urgently update the nightly build script to send everything to Subversion instead of CVS. Sean ? :) .

Re: When will SVN conversion happen?

2005-05-02 Thread Grant Smith
Manfred Geiler wrote: http://issues.apache.org/jira/browse/INFRA-311 All we can do is sit and wait... -M I commented on the JIRA, asking how long it would take, and if there was anything we could do to help. I also voted for the issue. I would recommend that as many of us vote for it as

SVN Conversion Status

2005-05-02 Thread Grant Smith
There is now a SVN repository at http://svn.apache.org/repos/test/myfaces for us to test, experiment with and review. This is a conversion of the CVS repository as of this morning. Please let me know when everyone is comfortable with it, and that it works to everyone's expectations. At that

Re: SVN Conversion Status

2005-05-02 Thread Grant Smith
To avoid checking out all tags and branches, just check out http://svn.apache.org/repos/test/myfaces/trunk Grant Smith wrote: There is now a SVN repository at http://svn.apache.org/repos/test/myfaces for us to test, experiment with and review. This is a conversion of the CVS repository

CVS Repository now locked

2005-05-02 Thread Grant Smith
As of now, the CVS repository is READ-ONLY. We're in the process of creating the LIVE SVN repository now..

SVN Repository now live

2005-05-02 Thread Grant Smith
The new official Subversion repository for Myfaces is now ready. https://svn.apache.org/repos/asf/myfaces This holds: site/ (The website) branches/ (All the old branches we had in the CVS repository) tags/ (All the old tags we had in the CVS repository) trunk/ (Where all the current action is!)

Nightly build

2005-05-02 Thread Grant Smith
We probably now need to urgently update the nightly build script to send everything to Subversion instead of CVS. Sean ? :)

[jira] Closed: (MYFACES-187) UIInput.getValue can return wrong (old) value

2005-04-29 Thread Grant Smith (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-187?page=all ] Grant Smith closed MYFACES-187: --- UIInput.getValue can return wrong (old) value - Key: MYFACES-187 URL: http

Re: When will SVN conversion happen?

2005-04-28 Thread Grant Smith
I second the motion to get this done as soon as possible. I guess we'll need a code freeze while the conversion takes place ? For those of you using Intellij IDEA, the latest EAP build (3311) handles Subversion perfectly and also runs under JDK 1.5.0_02. Sean Schofield wrote: When are we

Re: Cactus tests - HOWTO

2005-04-27 Thread Grant Smith
. If I inadvertently broke something I'm happy to try and help fix it ;-) sean On 4/26/05, Grant Smith [EMAIL PROTECTED] wrote: Sean, The original build/foo/build.xml files did some processing based on the value of the tomcat.pre.5.5.version property. Is this not required anymore

Re: cvs commit: incubator-myfaces/build build.xml

2005-04-26 Thread Grant Smith
Sean, Please don't revert the change. the file named ${sign.script} was probably there from when you ran the build before I made my change. My change FIXES the problem you describe. The line: property file="sign.script" location="${release.dir}/sign.sh"/ is definitely invalid. it MUST be:

Documentation strategy

2005-04-26 Thread Grant Smith
Are there any guidelines for documentation we should be following ? I would like to improve our documentation; the extended components in particular. Should everything be done through Forrest ? Thanks, Grant.

Re: Cactus tests - HOWTO

2005-04-26 Thread Grant Smith
we could also take this approach with cactus. I haven't used cactus in a long time so I'm probably not the best person to do this. sean On 4/26/05, Grant Smith [EMAIL PROTECTED] wrote: Oliver Rossmueller wrote: Thanks for the info, Oliver. I was able to get a little further

Cactus tests - HOWTO

2005-04-25 Thread Grant Smith
OK, So I thought I'd start being productive, and attack a simple JIRA issue. I zoned in on MYFACES-187, as it had a simple solution of removing some code. I commented out the code, then decided to run all-tests from the main build file. Firstly, ant complained about not having access to junit,

[jira] Closed: (MYFACES-194) inputCalendar throws IllegalArguementException when a ConversionException is supposed to be thrown

2005-04-20 Thread Grant Smith (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-194?page=all ] Grant Smith closed MYFACES-194: --- Resolution: Fixed Fix Version: Nightly Build inputCalendar throws IllegalArguementException when a ConversionException is supposed to be thrown

Re: [Vote] release candidate2 for Apache MyFaces

2005-03-30 Thread Grant Smith
+1 On Tuesday 29 March 2005 13:10, Matthias Wessendorf wrote: Hi folks, after some changes and fixes, the Apache MyFaces project is proud to be next to provide the first release as a top level project inside of ASF. This would be the 1.0.9-beta. Beta, because we haven't passed the TCK yet.

Re: A few more suggestions

2005-01-18 Thread Grant Smith
As an Intellij user, I will also have to go with a -1 for now. The current EAP version of IDEA does have SVN integrated, but it is currently too unstable for production use. As a Linux user, Tortoise is not an option for me. On Tuesday 18 January 2005 06:11, Sean Schofield wrote: Tortoise

Re: CVSROOT

2005-01-07 Thread Grant Smith
On Friday 07 January 2005 08:32, Joshua White wrote: What is the current CVSROOT? :pserver:[EMAIL PROTECTED]:2401/home/cvspublic/incubator-myfaces isn't working. Try :pserver:[EMAIL PROTECTED]:/home/cvs/incubator-myfaces -- Grant S. Smith Marathon Computer Systems 503-582-8445

<    1   2   3   4   5   6