Re: problem creating patch

2005-10-16 Thread Simon Kitching
sharath reddy wrote: Hello, I was trying to create a patch against the file 'examples/dataList.jsp'. My patch file contained the following message: Cannot display: file marked as a binary type. svn:mime-type = application/octet-stream I browsed the SVN repository and noticed that this file

New table row selection feature [was Re: Tiles standalone]

2005-10-18 Thread Simon Kitching
I need a checkbox-based equivalent (select multiple rows from a table) within the next week or so. So if someone implements this I'm happy to test. If not, I hope to be able to submit code for this soon (corporate CLA is in the post :-). Regards, Simon Sean Schofield wrote: I believe there

Re: Time for RC3?

2005-10-18 Thread Simon Kitching
Sean Schofield wrote: There have been a few more changes to the branch lately. What do people think about pushing out an RC3 and then an official release shortly thereafter? Should we get the ball rolling on the RC3? I'm +1 as long as there as people have tested RC2 for the basics. Right now

HtmlDateRendererTest failed - how to see unit test output?

2005-10-18 Thread Simon Kitching
Hi, I've run the myfaces unit tests using ant unit-test-all from the main build dir (current/build). I'm seeing one test case in tomahawk fail: unit-test: [junit] Running org.apache.myfaces.custom.date.HtmlDateRendererTest [junit] Tests run: 8, Failures: 5, Errors: 0, Time elapsed: 0.585

Re: HtmlDateRendererTest failed - how to see unit test output?

2005-10-18 Thread Simon Kitching
Simon Kitching wrote: Hi, I've run the myfaces unit tests using ant unit-test-all from the main build dir (current/build). I'm seeing one test case in tomahawk fail: unit-test: [junit] Running org.apache.myfaces.custom.date.HtmlDateRendererTest [junit] Tests run: 8, Failures: 5, Errors: 0

RC3: dependency on commons-lang

2005-10-18 Thread Simon Kitching
Hi, Class org.apache.myfaces.custom.calendar.HtmlCalendarRenderer.java has had a dependency on commons-lang added. This means that my app which previously worked fine now fails with a NoClassDefFoundError. The dependency was introduced by r289859 (mmarinschek) on 2005-09-18. I would

Re: RC3: dependency on commons-lang

2005-10-18 Thread Simon Kitching
. sean On 10/18/05, Bill Dudney [EMAIL PROTECTED] wrote: I respectfully disagree, there is no way I want us copying functionality from commons-lang into myfaces. -bd- On Oct 18, 2005, at 6:47 PM, Simon Kitching wrote: Hi, Class org.apache.myfaces.custom.calendar.HtmlCalendarRenderer.java has had

Re: HtmlDateRendererTest failed - how to see unit test output?

2005-10-18 Thread Simon Kitching
Hi Bill, Thanks for your reply. I've now found the output. Incidentally, the API subproject's build.properties has: temp.dir = ${basedir}/temp test.reports.dir = ${temp.dir}/tests/reports but the tomahawk subproject's build.properties has: tests.dir=

Re: RC3: dependency on commons-lang

2005-10-19 Thread Simon Kitching
Werner Punz wrote: The main problem I see is if there is some kind of version interface break, you could end up with two different incompatible versions. How do the commons people handle that. I recently had a very similar situation, I ended up giving the commons-http with all its dependencies

Re: RC3 Status

2005-10-24 Thread Simon Kitching
Sean Schofield wrote: Are we satisified that there are no major issues in RC3? Again, I have not had time to test so I am relying on the my fellow committers and the rest of the developer community. Any true show stopper bugs that affect the basic implementation? jar files? Everything else

Re: RC3 Status

2005-10-24 Thread Simon Kitching
Sean Schofield wrote: IMO that is NOT a blocker for the 1.1.1 release. There are lots of little issues with Tomahawk components. If we waited to get every last one done we would never release. The main thing is to get this out so we can fix the problem with myfaces-all.jar in 1.1.0 (a

Re: RC3 Status

2005-10-24 Thread Simon Kitching
bits only. Regards, Simon sean On 10/24/05, Simon Kitching [EMAIL PROTECTED] wrote: Sean Schofield wrote: IMO that is NOT a blocker for the 1.1.1 release. There are lots of little issues with Tomahawk components. If we waited to get every last one done we would never release

Re: RC3 Status

2005-10-24 Thread Simon Kitching
is *also* present in the 1_1_1 branch. Regards, Simon On 10/24/05, Simon Kitching [EMAIL PROTECTED] wrote: See comments inline... Sean Schofield wrote: I haven't investigated this issue very closely but I doubt that changes in the 1.1.1 branch caused this bug. Its certainly possible

Re: RC3 Status

2005-10-24 Thread Simon Kitching
in R291992, so the change is *also* present in the 1_1_1 branch. Regards, Simon On 10/24/05, Simon Kitching [EMAIL PROTECTED] wrote: See comments inline... Sean Schofield wrote: I haven't investigated this issue very closely but I doubt that changes in the 1.1.1 branch caused this bug. Its

Re: [VOTE] Release MyFaces 1.1.1

2005-10-25 Thread Simon Kitching
Sean Schofield wrote: I think this has dragged on long enough. Apparently there was a bug introduced in one of the Tomahawk components but I don't think its worth another prolonged release candidate cycle to address it. So my proposal is to tag the RC3 release as 1.1.1, rebuild, release. Then

Re: Recent change causes pages to be emitted twice [Tomahawk AddResource problem]

2005-10-27 Thread Simon Kitching
Simon Kitching wrote: I've just updated to latest HEAD code in SVN, built jars and deployed. With these latest jars, I now get the contents of every page *duplicated*, ie: html full response output full response output again /html It's quite a neat effect, actually :-) This also happens

javascriptLocation attribute

2005-10-30 Thread Simon Kitching
Hi, The following classes use javascriptLocation. However they never prefix the emitted URL with the context path: * HtmlAccordionPanelRenderer * InputSuggestAjaxRenderer * EffectRenderer * AutoUpdateDataTableRenderer * HtmlTreeRenderer * InputSuggestRenderer * HtmlJSCookMenuRenderer I

SVN problem: files replaced rather than updated in R328404

2005-10-30 Thread Simon Kitching
Hi, A number of commits were made in the directory tomahawk/trunk/src/java/org/apache/myfaces/component/html/util as a part of commit R328404. Unfortunately rather than *updating* files, this commit has *deleted* the old files and added new ones with the same names in their places. This

ReducedHTMLParser broken

2005-10-30 Thread Simon Kitching
ReducedHTMLParser (used by AddResource class) appears to be totally broken. I found that my script references were getting inserted right into the middle of the body of my html page. After inserting some debug code, I have found that closedStartTag is being called every time that //-- is

Re: ReducedHTMLParser issues

2005-10-31 Thread Simon Kitching
ReducedHTMLParser issues Key: MYFACES-768 URL: http://issues.apache.org/jira/browse/MYFACES-768 Project: MyFaces Type: Bug Reporter: Simon Kitching Fix For: Nightly Attachments: ReducedHTMLParser.java, ReducedHTMLParser.java

Re: ReducedHTMLParser issues

2005-10-31 Thread Simon Kitching
Martin Marinschek wrote: Don't stress yourself - it's just the nightly build, so not to big of a problem. Thanks, but it's hopefully done anyway. changes: * Handle DOCTYPE and Processing Instruction commands in input HTML * Track line# of input for error messages * Remove some debugging

HtmlCollapsiblePanel

2005-10-31 Thread Simon Kitching
Hi, I've started getting problems with HtmlCollapsiblePanel in the SVN TRUNK code. 13:15:11,509 ERROR [[jsp]] Servlet.service() for servlet jsp threw exception java.lang.NoSuchMethodError: org.apache.myfaces.custom.collapsiblepanel.HtmlCollapsiblePanelTag.doAfterBody()I at

Re: HtmlCollapsiblePanel

2005-11-01 Thread Simon Kitching
Martin Marinschek wrote: Well, I am changing a lot within the collapsible panel in the moment - and I changed its inheritance hierarchy, so this problem stems from this. I wonder why I don't get the problem in the examples, though! Anyways, I changed the hierarchy, so it should work again.

Re: JavaScript in jsCookMenu component?

2005-11-08 Thread Simon Kitching
] Sent: Thursday, November 03, 2005 5:57 PM To: MyFaces Development Cc: Simon Kitching; [EMAIL PROTECTED]; Barbalace, Richard Subject: Re: JavaScript in jsCookMenu component? Can you send me a final verion for cmItemMouseUp? I will patch the current version. Thomas On 11/2/05, Barbalace, Richard

Re: svn commit: r332361 - /myfaces/api/trunk/src/java/javax/faces/component/UIData.java

2005-11-10 Thread Simon Kitching
Hi Martin, [EMAIL PROTECTED] wrote: Author: mmarinschek Date: Thu Nov 10 11:49:38 2005 New Revision: 332361 URL: http://svn.apache.org/viewcvs?rev=332361view=rev Log: fix for MYFACES-782. Thanks to Simon Kitching. Modified: myfaces/api/trunk/src/java/javax/faces/component/UIData.java

HtmlInputDate change breaks unit test

2005-11-10 Thread Simon Kitching
Hi, In directory tomahawk/test, the class org.apache.myfaces.custom.date.HtmlDateRenderCactus currently fails to compile. Command ant unit-test will show this, but not ant dist. r332339 (fix for MYFACES-238) for class HtmlInputDate appears to have caused this problem. Regards, Simon

Re: HtmlInputDate change breaks unit test

2005-11-10 Thread Simon Kitching
Simon Kitching wrote: Hi, In directory tomahawk/test, the class org.apache.myfaces.custom.date.HtmlDateRenderCactus currently fails to compile. Command ant unit-test will show this, but not ant dist. r332339 (fix for MYFACES-238) for class HtmlInputDate appears to have caused this problem

Re: Defaulting to forceId=true

2005-11-19 Thread Simon Kitching
Travis Reeder wrote: Working on this ajax stuff, I got to wondering why we don't just have id's implemented like forceId = true? Is there any reason why we can't just have all id's set to the id the user specifies without prepending stuff to them? The spec allows ids to be duplicated as long

Re: svn commit: r345590 - /myfaces/api/trunk/src/java/javax/faces/component/_ComponentUtils.java

2005-11-20 Thread Simon Kitching
[EMAIL PROTECTED] wrote: Author: prophecy Date: Fri Nov 18 14:39:47 2005 New Revision: 345590 URL: http://svn.apache.org/viewcvs?rev=345590view=rev Log: - Made t:message elements work with Ajax errors - fixed UIComponent.findComponent to actually work. Modified:

Re: svn commit: r345590 - /myfaces/api/trunk/src/java/javax/faces/component/_ComponentUtils.java

2005-11-21 Thread Simon Kitching
_ComponentUtils class is not public? And is there any problem with making it public so I can add a second findComponent method that will traverse the entire tree? Travis On 11/20/05, Simon Kitching [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] wrote: Author: prophecy Date: Fri Nov 18 14:39:47 2005 New

Re: Defaulting to forceId=true

2005-11-22 Thread Simon Kitching
Hi Travis, I don't know anything about the AJAX compoents so please excuse me if this is a silly question. But why are the AJAX components requiring forceId in the first place? If a component's true id at the back end is form1:subview2:table3, then why not use that id in all the AJAX stuff

Re: Use of JSF RI Javadocs in myfaces

2005-11-22 Thread Simon Kitching
Bruno Aranda wrote: Hi devs, I've talked with Ed Burns in the ##jsf irc channel and he has got a final answer on the question whether or not we can use the RI javadocs. He has said that we CAN'T use the JSF 1.1 Javadocs because it is not under the CDDL, but we CAN use the javadocs for JSF 1.2,

Reconnecting UIComponentTag instances with the corresponding UIComponent

2005-11-22 Thread Simon Kitching
Hi, As part of my investigations of http://issues.apache.org/jira/browse/MYFACES-856 I have found that I need to understand how a UIComponentTag finds its corresponding component. When a JSP page is processed, each time a jsf tag is encountered a UIComponentTag instance is created,

Re: Reconnecting UIComponentTag instances with the corresponding UIComponent

2005-11-22 Thread Simon Kitching
) and i output getId on the tag. The second occurence of the message tag had the previous occurences id at this point. Is it supposed to be reused? Travis On 11/22/05, Simon Kitching [EMAIL PROTECTED] wrote: Hi, As part of my investigations of http://issues.apache.org/jira/browse/MYFACES

Recent javadoc updates

2005-11-22 Thread Simon Kitching
Hi All, Sorry for the flood of javadoc commits; this is some stuff I've had sitting around for a while. For the changes to the api/impl classes, I've checked the JSP1.2 javadoc, and what I've got is a bit different in flavour from the spec so I've committed it for you to look at. If you

tld documentation for standard HTML attributes

2005-11-22 Thread Simon Kitching
Hi, It's bugging me that when I look at the tomahawk TLDDOC I see lots of No Description lines, most of which are for standard HTML attributes (with the occasional JSF or Tomahawk attribute mixed in). I know it's trivial, but nevertheless I would like to add basic descriptions to the

Re: tld documentation for standard HTML attributes

2005-11-23 Thread Simon Kitching
Hi Steve, [EMAIL PROTECTED] wrote: Both tomahawk/tld/myfaces_ext.dl and tomahawk/tld/tomahawk.tld will need some additional external entities added to pick up the standard HTML stuff that I have in my patch. I had a look at your patch. To summarise for others: The patch moves definitions

Re: closing invalid/won't fix jira issues

2005-11-23 Thread Simon Kitching
Hi Mike, Mike Kienenberger wrote: Should I be closing invalid or won't fix jira issues at the same time I resolve them? I would personally have marked this particular issue invalid rather than wontfix. invalid: the report is not a bug. wontfix: it's agreed that it is a bug or misfeature

Re: [COMMUNITY] Welcome Mike Kienenberger

2005-11-23 Thread Simon Kitching
Martin Marinschek wrote: Hi *, please welcome Mike to our team. Congrats Mike. And welcome from a fellow MyFaces newbie committer :-) Cheers, Simon

AJAX and ids (was Defaulting to forceId=true)

2005-11-23 Thread Simon Kitching
for more on the reasoning. It was a pretty lively debate with lots of good points raised on all sides. sean On 11/22/05, Simon Kitching [EMAIL PROTECTED] wrote: Hi Travis, I don't know anything about the AJAX compoents so please excuse me if this is a silly question. But why are the AJAX

Release method in UIComponentTag (was Reconnecting UIComponentTag instances ...)

2005-11-23 Thread Simon Kitching
I see that originally _id etc were reset in internalRelease, and they were moved to the release method by this commit: r166747 | manolito | 2004-04-27 00:01:39 +1200 (Tue, 27 Apr 2004) | 2 lines more reluctant releasing

Re: Reconnecting UIComponentTag instances with the corresponding UIComponent

2005-11-23 Thread Simon Kitching
Adam Winer wrote: Re: what happens if the number of tags change from one request to the next: this is why JSF tags inside of c:if are required to have an explicitly set ID (think this is stated explicitly in the JSF spec). This whole mess is why I proposed JspIdConsumer for JSP 2.1, which lets

SVN and eol-style: native

2005-11-23 Thread Simon Kitching
Hi, I've recently fixed a couple of files without any svn:eol-style setting and it has generated big diffs. I think what's happening is that when svn:eol-style gets set on a file that didn't have it, the file gets normalised before committing. And normalisation happens to mean convert to

Re: tld documentation for standard HTML attributes

2005-11-23 Thread Simon Kitching
as I can find the necessary time. Cheers, Simon [EMAIL PROTECTED] wrote: I submitted 2 more files: a tar that contains the new files that were missing from the .patch, and a patch for tomahawk/tld/tomahawk.tld that brings it up to date with the first patch. Steve On 11/23/05, *Simon

Re: svn commit: r348838 [1/2] - in /myfaces/impl/trunk: src/java/org/apache/myfaces/application/ src/java/org/apache/myfaces/application/jsp/ src/java/org/apache/myfaces/lifecycle/ tld/ tld/entities/

2005-11-24 Thread Simon Kitching
Hi, Just FYI, I accidentally committed 3 unrelated files (ApplicationImpl, JspStateManagerImpl, LifecycleImpl) with this patch. However those changes won't do any harm; two are just comment changes and one improves logging a bit. I might tidy up the logging one later.. Cheers, Simon

ALT attribute on standard JSF components

2005-11-27 Thread Simon Kitching
Hi, I've noticed that the following JSF JSP tags *do* have an ALT attribute defined in myfaces, but do *not* have an ALT attribute in the Sun RI: * h:selectBooleanCheckbox * h:selectManyCheckbox * h:selectOneRadio See: http://myfaces.apache.org/tlddoc/core/

Re: Continuous integration and myfaces

2005-11-27 Thread Simon Kitching
Hi, On this topic, I have noticed the following: * Unit tests aren't run as part of the standard dist target; they must be run separately via ant unit-test-all * The unit tests in share/src/test aren't run by ant unit-test-all because they aren't one of the subprojects api, impl, tomahawk,

Fetching model for read-only tables

2005-11-27 Thread Simon Kitching
Hi, Currently a UIData's DataModel is fetched (via a value-binding) during the decode phase, even when the children of the table are all read-only. This is caused by UIData.processDecodes. When the data model is fetched from a database this isn't very nice. What do people think of checking

UIData: does _rowState get serialized with view?

2005-11-28 Thread Simon Kitching
Hi, The UIData uses the flyweight pattern so that a single set of component children for a single row are enough to implement a table with any number of rows. The state for each row is stored in _rowState. When a view is serialized, the state for ordinary components is stored. I presume

Re: Javadoc problems on non-ascii char

2005-11-29 Thread Simon Kitching
Wessendorf wrote: Simon, well I'll convert the german umlaut (ß) into its equal (ss) HTH, Matthias On 11/29/05, Simon Kitching [EMAIL PROTECTED] wrote: Hi, When building the javadoc I get lots of warnings reported for occurrences of Matthias Wessendorf's name, presumably because of the use

UIComponent tag (attn: Manfred Geiler)

2005-11-29 Thread Simon Kitching
Hi Manfred, A long time ago class UIComponentTag was altered so that _id, _binding and _rendered were only cleared in release, not in internalRelease. Commit r166747 (by manolito) indicates that it was something to do with Resin. I believe manolito is you... Do you have any more info

Re: svn commit: r349809 - /myfaces/sandbox/trunk/tld/myfaces_sandbox.tld

2005-11-29 Thread Simon Kitching
Mike Kienenberger wrote: Simon, I had to merge in the myfaces_sandbox.tld file changes I made, and it looks like it may have missed some of your whitespace changes. Sorry about that, but it's very difficult under Windows to detect whitespace changes, since SVN whitespace differs from the

Re: svn commit: r349809 - /myfaces/sandbox/trunk/tld/myfaces_sandbox.tld

2005-11-29 Thread Simon Kitching
Mike Kienenberger wrote: I think the problem is that compares against SVN aren't taking EOL into account. The file in Eclipse on my windows box has windows line-endings, and the file being compared against in the repository has unix (native) line-endings. Whatever the reason, diffs in Eclipse

Re: svn commit: r349852 - /myfaces/build/trunk/build.xml [ATTN: Mike Kienenberger]

2005-11-29 Thread Simon Kitching
Hi Mike, Mike Kienenberger wrote: Yeah, looks like SVN commits work differently than CVS commits in Subclipse.In SVN, you have to manually reselect each new file to commit them. How annoying. In CVS, when a file is added, it is immediately committed to the repository. However SVN has

Re: Struts-Tiles and Maven

2005-11-30 Thread Simon Kitching
Sean Schofield wrote: OK I am cautiously wading into the Maven waters ... I'm having trouble using the standalone Struts in an m2 project. Here is the dependency I am using: dependency groupIdstruts/groupId artifactIdstruts-tiles/artifactId version1.1/version

Re: UIData: does _rowState get serialized with view?

2005-11-30 Thread Simon Kitching
please disclose your rationale to drop this?! Thanks, Manfred 2005/11/29, Simon Kitching [EMAIL PROTECTED]: Hi, The UIData uses the flyweight pattern so that a single set of component children for a single row are enough to implement a table with any number of rows. The state for each row

Re: UIData: does _rowState get serialized with view?

2005-11-30 Thread Simon Kitching
Adam Winer wrote: On 11/30/05, Mathias Brökelmann [EMAIL PROTECTED] wrote: the rowstate is not serialized with the view. If validation fails the submitted value of any input component is rendered in the response. IMO it is not necessary to save the sate of each row if validation fails since the

Re: svn commit: r350265 - /myfaces/api/trunk/src/java/javax/faces/component/UIComponent.java

2005-12-01 Thread Simon Kitching
[EMAIL PROTECTED] wrote: Author: mkienenb Date: Thu Dec 1 07:59:09 2005 New Revision: 350265 URL: http://svn.apache.org/viewcvs?rev=350265view=rev Log: Copied JSF RI 1.2 javadoc for setParent(UIComponent) Do we really have the all clear to copy JSF1.2 javadoc to MyFaces? I know that one of

Missing documentation in tomahawk.tld for some components

2005-12-01 Thread Simon Kitching
Hi, I have noticed that the following tomahawk components have no description of their purpose in the tomahawk.tld file: * panelTab * panelTabbedPane * tabChangeListener * treeSelectionListener * iconProvider * swapImage It would be nice if people who know these components could add some

Re: Require ordering of for loading META-INF/faces-config.xml files from component jar

2005-12-05 Thread Simon Kitching
Hi, I struck this problem when I had to override the renderer for tomahawk's JSCookMenu component. My jar's faces-config.xml needs to be processed after the tomahawk one in order for my renderer to override the tomahawk one. I believe that MyFaces processes files in the order returned by

Re: Require ordering of for loading META-INF/faces-config.xml files from component jar

2005-12-05 Thread Simon Kitching
Adam Winer wrote: Yes, the desire for a real solution and the permanence of anything that does get into the spec was the reason why we deep-sixed any hacky fix. A lot of times - in the world of long-living specs - doing nothing is by far the best solution. I do think that Ed has a point that

Re: Require ordering of for loading META-INF/faces-config.xml files from component jar

2005-12-05 Thread Simon Kitching
Mike Kienenberger wrote: In the jar's MANIFEST.MF file, create two new attributes, similar to the standard jar Class-Path: attribute. These as-of-yet-unnamed attributes would represent the two relationships above. For those jars that don't specify a dependency order, JSF would fall back to

Re: svn commit: r355353 - /myfaces/api/trunk/src/java/javax/faces/component/EditableValueHolder.java

2005-12-08 Thread Simon Kitching
Hi All, I'd appreciate someone proofreading the documentation I've just added for EditableValueHolder. Regards, Simon [EMAIL PROTECTED] wrote: Author: skitching Date: Thu Dec 8 19:55:46 2005 New Revision: 355353 URL: http://svn.apache.org/viewcvs?rev=355353view=rev Log: Add javadoc.

Milestone builds?

2005-12-08 Thread Simon Kitching
Hi, What do people think about releasing a binary milestone build? Currently the SVN head is pretty stable. There are *many* great fixes and enhancements since the 1.1.1 release, but people may be (rightly) wary of trying to use SVN head as there's no guarantee it's workable at any

Re: Milestone builds?

2005-12-12 Thread Simon Kitching
Sean Schofield wrote: I think we all have somewhat similar positions then. The milestone builds are not official releases and therefore aren't subject to the TCK. My position would be that we do not announce them other then updating a wiki or a webpage that lists the version and its status as

Re: Loggers in API Components

2005-12-14 Thread Simon Kitching
Travis Reeder wrote: S, can we have a quick vote on this? I'd like to be able to check in logging changes, and we can always change which logging facility we use later with the good ol' search and replace. +1 java.util.logging -1 on using java.util.logging in MyFaces 1.1.x. That is a

Re: Loggers in API Components

2005-12-14 Thread Simon Kitching
Martin Marinschek wrote: -1 java.util.logging +1 commons-logging - cause this is used right now all over the codebase. If we want to change to use log4j directly, this would be another issue, another vote. I would prefer to see some myfaces logging API that would be a facade, avoiding a

Javadoc problems with GraphicImage changes

2005-12-14 Thread Simon Kitching
Hi, Could people please avoid adding non-ascii characters in javadoc? Entities like ouml; or szlig; can be used to generate non-ascii characters in the html pages if desired. [javadoc]

Re: Loggers in API Components

2005-12-14 Thread Simon Kitching
subprojects, though. Also for Tobago, also for the eventual Cherokee, etc. So our fellow co-committers get a say in this as well. regards, Martin On 12/15/05, Simon Kitching [EMAIL PROTECTED] wrote: Martin Marinschek wrote: -1 java.util.logging +1 commons-logging - cause this is used right now

Re: Loggers in API Components

2005-12-15 Thread Simon Kitching
Hi Mario, Mario Ivankovits wrote: Why wouldnt you create this wrapper library under the umbrella of commns-logging? Different commons-logging libraries using static linking instead of the dynamic behaviour. Say: commons-logging-log4j, commons-logging-jdklogger This sort of thing is under

Re: svn commit: r357270 - in /myfaces/tomahawk/trunk/src/java/org/apache/myfaces/custom/navmenu: ./ htmlnavmenu/

2005-12-17 Thread Simon Kitching
Hi Tom, Just a couple of notes on the recent navmenu changes: On Sat, 2005-12-17 at 02:02 +, [EMAIL PROTECTED] wrote: public class HtmlCommandNavigationItemTag extends HtmlCommandLinkTag { +private static final String OPEN_ATTR = open.intern(); +private static final String

Re: svn commit: r357582 - in /myfaces/build/trunk: facelets-build.xml tools/ tools/build-tools.jar tools/src/

2005-12-18 Thread Simon Kitching
to the binary. Where is the source used to generate this build-tools.jar file, and how is that compiled? Regards, Simon Thomas Spiegl wrote: It's just a 9kb file. On 12/19/05, *Simon Kitching* [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] wrote: [EMAIL PROTECTED] mailto:[EMAIL PROTECTED

Re: Validation Errors for selectItems in SelectOneMenu

2005-12-18 Thread Simon Kitching
Hi Reiner, I believe that a select component requires that when the picked value is not null, it must be one of the values in the associated options. You're not using javascript to change the value of the 2nd and 3rd menus into something that isn't in their associated options are you?

Re: [JavaDoc] javax.faces.** clazzes

2005-12-20 Thread Simon Kitching
Hi Matthias, I'm against your patch that removed all the javadoc that I carefully wrote and added to these classes, and I would like to see this patch reverted. The documentation that *was* on these classes is *not* copied from the Sun stuff. It's cleanly reverse-engineered from the

Re: [JavaDoc] javax.faces.** clazzes

2005-12-20 Thread Simon Kitching
Matthias Wessendorf wrote: Simon, I am very sorry, that I removed your documentation. I will revert all classes, which containted stuff. On these classes I'll add the aditional link to SUN RI stuff, if any one is interested. And of course, I haven't said, that you copied! This was a fast

Abstracting JSF presentation from HTML?

2005-12-21 Thread Simon Kitching
Korhonen, Kalle wrote: -Original Message- From: Adam Winer [mailto:[EMAIL PROTECTED] Sent: Thursday, December 15, 2005 11:23 AM Subject: Re: svn commit: r356552 - in Hope I'm not coming off as insulting any of the committers here. Especially 'cause I *totally* agree that abstracting

Re: Moving forward on the Oracle donation

2005-12-30 Thread Simon Kitching
Hi All, I just wanted to say that however it works out, I'm very happy to see Oracle looking at releasing the source to the ADF library. When Obsidium were starting the current JSF-based project I looked around for JSF libraries and came across the ADF stuff. It has many excellent-looking

Re: Proposal: Switch to Maven(2)

2005-12-30 Thread Simon Kitching
Wendy Smoak wrote: On 12/29/05, Sean Schofield [EMAIL PROTECTED] wrote: I am proposing we switch to Maven2. I think we now have enough people who are ready willing and able to sustain the Maven effort. +1

Re: Javascript-code doesn't appear in html file

2006-01-01 Thread Simon Kitching
On Mon, 2006-01-02 at 00:00 +0100, Jürgen Avian wrote: Hi! A friend of mine told me to address this issue to Simon Kitching: I've added some javascript code to my jspx source file like this: ... t:div id=tabbody forceId=true forceIdIndex=true script type=text/javascript

Re: svn commit: r365751 - /myfaces/examples/trunk/simple/src/main/java/org/apache/myfaces/examples/listexample/SimpleCountryList.java

2006-01-03 Thread Simon Kitching
[EMAIL PROTECTED] wrote: Author: werpu Date: Tue Jan 3 13:52:40 2006 New Revision: 365751 URL: http://svn.apache.org/viewcvs?rev=365751view=rev Log: fixed a bug, which caused the jdk 1.4 to fail on the BigDecimal constructors Modified:

Re: [maven] Latest maven changes

2006-01-05 Thread Simon Kitching
Hi, Sooner or later, the MyFaces core will stabilise while tomahawk charges ahead. So at *some* time the release cycles will have to separate. I think it's beneficial to split them sooner rather than later, so I'd like to see a structure set up now that makes that easier. Sooner or later, real

Re: [maven] Revised Reorg Proposal -- Was: [maven] Latest maven changes

2006-01-05 Thread Simon Kitching
Sean Schofield wrote: Do we really end up with everything from the top level in the lib dir? What I'm thinking is something like this being in a 'user' project. dependency groupidorg.apache.myfaces/groupId artifactIdtomahawk/artifactId /depdency This will cause the transitive

maven: how to generate tlddoc files?

2006-01-07 Thread Simon Kitching
Hi, With the ant build, myfaces_core.tld and myfaces_html.tld were converted into .html documentation that appeared in the impl/build/temp/tlddoc directory. Does anyone know how to build the same files in the new maven setup? I've tried mvn and mvn site and that doesn't seem to generate the

Javascript namespacing (was Re: ADF Source drop is available!)

2006-01-09 Thread Simon Kitching
Adam Winer wrote: One of the items already on our todo list is moving all the functions, classes, and variables inside a single top level object. Using a single top-level object is something I've been considering suggesting for a while. MyFaces could create a single myfaces object for

Re: Packaging, public vs. private (was: ADF source drop is available)

2006-01-09 Thread Simon Kitching
Adam Winer wrote: @Matthias, I'd rather not have any wrappers - the plan here is to repackage in line with MyFaces rules. I would, however, strongly like to keep the high-level concept of separating our public APIs - like component classes - from private internal implementation details - like

Running unit tests under maven2?

2006-01-09 Thread Simon Kitching
Hi, I'm trying to run tomahawk unit tests. In current/tomahawk/tomahawk I enter: mvn test However the output indicates: [INFO] [surefire:test] [INFO] Tests are skipped. Any suggestions? I do see this earlier in the output: [WARNING] Artifact junit:junit:jar:3.8.1 retains local scope

Re: Running unit tests under maven2?

2006-01-09 Thread Simon Kitching
Simon Kitching wrote: I do see this earlier in the output: [WARNING] Artifact junit:junit:jar:3.8.1 retains local scope 'test' overriding broader scope 'compile' given by a dependency. If this is not intended, modify or remove the local scope. hmm.. in ~/.m2/repository, commons

Re: Running unit tests under maven2?

2006-01-09 Thread Simon Kitching
Wendy Smoak wrote: On 1/9/06, Bill Dudney [EMAIL PROTECTED] wrote: I've tried -Dmaven.test.skip=false and still the tests are skipped. I also did a quick find/grep and I could find no instance of skiptrue/skip in any pom except the api/pom.xml. Weird, I'm still digging... That's the one...

Re: Packaging, public vs. private (was: ADF source drop is available)

2006-01-09 Thread Simon Kitching
On Tue, 2006-01-10 at 07:30 +0100, Martin Marinschek wrote: +1 if someone does the work ;) Ok, I'm willing to do the shuffling around. Won't be immediately, but sometime in the next few weeks. First, though, we need to agree on a package structure - which should also be shared with the ADF

Proposed new components for sandbox/tomahawk

2006-01-10 Thread Simon Kitching
continue on with that spirit. Colin Young IT Director Obsidium Limited Quoting Simon Kitching [EMAIL PROTECTED]: Hi Colin, We have a couple of custom JSF components that I think would be accepted into the MyFaces library. If you are willing for these components to be donated, I'm happy to do

Re: Questions regarding client validators

2006-01-11 Thread Simon Kitching
Manfred Geiler wrote: This is more than just a nice feature - it's architecturally very important that web applications always have client-side validation as a subset of server-side validation (maybe equals, but never ever more); so it's dangerous to let people get in the habit of separately

Re: Loggers in API Components

2006-01-11 Thread Simon Kitching
Adam Winer wrote: On 1/11/06, Manfred Geiler [EMAIL PROTECTED] wrote: 2006/1/10, Korhonen, Kalle [EMAIL PROTECTED]: If one really wants to combine java logging to log4jLogs, I'd think you should be able to fairly easily write a java log handler using log4j logger (don't know how the

Re: Welcome!

2006-01-11 Thread Simon Kitching
Great news! Bernd, Volker: thanks very much for all your work so far. I'm sure the MyFaces project will benefit greatly from having you as committers. Cheers, Simon Martin Marinschek wrote: Bernd, Volker, the MyFaces PMC has decided (due to your continuing help in making Apache MyFaces

Re: Nightlys and 1.1.2

2006-01-11 Thread Simon Kitching
Abrams, Howard A wrote: 1. How close are we to having nightly builds up and running again? I don't know, but with the new maven setup it's **really** easy to compile the source for yourself. Once the code is downloaded, and maven 2.0.1 is installed, it's just a matter of going to the right

Re: Nightlys and 1.1.2

2006-01-11 Thread Simon Kitching
Korhonen, Kalle wrote: Huh? No need for nightly builds? Even if we forget the minor details that you need to have SVN, Java and Maven set-up) the nightly builds are still extremely useful. Often you *don't* want to run the latest, but stay with an officially released version or the first patched

Re: How can I redirect from a servlet to a JSF page (that is backed by a bean)?

2006-01-11 Thread Simon Kitching
I think Volker's suggestion of duplicating the tobago NonFacesRequestServlet into tomahawk or myfaces-commons is a good idea. It is very useful for performing pre-processing of any sort before forwarding to a JSF page. I've added the code to the myfaces wiki for the moment, but having a class

Re: Proposed new components for sandbox/tomahawk

2006-01-11 Thread Simon Kitching
Hi, Obsidium has filled out a corporate CLA. It was mailed to Apache in September last year. I have no idea about where I would look to confirm it's been received. I did email Jim (Apache Foundation secretary) to ask, but got no response. I don't wish to ask anyone here to complete further

Re: Build failed due to StateUtilsTestCase

2006-01-12 Thread Simon Kitching
On Thu, 2006-01-12 at 22:17 +0100, Manfred Geiler wrote: 2006/1/12, Sean Schofield [EMAIL PROTECTED]: i think matze has already added the license. Maybe a checkstyle report can check this in the future. +1 for a checkstyle to check for license I have one problem the

Re: Build failed due to StateUtilsTestCase

2006-01-13 Thread Simon Kitching
. Arvid is member of the tobago team. Regards Bernd Simon Kitching schrieb: I'm confused. Could someone please explain what this xls/dtd issues is actually about, and what Arvid's suggestions mean (BTW, who is Arvid?). What is the problem that is actually occurring

Re: Build failed due to StateUtilsTestCase

2006-01-13 Thread Simon Kitching
Drat - accidentally pressed send before email was complete. Please see changes inline... On Fri, 2006-01-13 at 23:46 +1300, Simon Kitching wrote: Hmm.. The original files (eg impl/src/main/tld/myfaces_core.tld) don't have any xmlns declaration in them. It does have this: !DOCTYPE taglib

  1   2   3   4   5   6   >