Re: [GSOC] State saving status after first improvements

2010-08-01 Thread Martin Marinschek
Hi guys, stateHelper.remove() doesn't remove the value but replaces it with null. And also, as I understand, saving the null values in the state helper can't be removed. why is this? best regards, Martin On Fri, Jul 23, 2010 at 1:27 PM, Martin Marinschek mmarinsc...@apache.orgwrote:

Re: [GSOC] State saving status after first improvements

2010-07-23 Thread Marius Petoi
Hi Martin, The state of a typical input text contains the following 4 attributes (both the keys and the values): valid, value, localValueSet and submittedValue. Value and submittedValue may be null, in this case only the keys are contained in the state. Valid and localValueSet are boolean

Re: [GSOC] State saving status after first improvements

2010-07-23 Thread Martin Marinschek
Hi Marius, The state of a typical input text contains the following 4 attributes (both the keys and the values): valid, value, localValueSet and submittedValue. Value and submittedValue may be null, in this case only the keys are contained in the state. Valid and localValueSet are boolean

Re: [GSOC] State saving status after first improvements

2010-07-23 Thread Martin Marinschek
+1! tell us how much this changes... best regards, Martin On Fri, Jul 23, 2010 at 12:23 PM, Marius Petoi marius.pe...@codebeat.ro wrote: Hello, These values are written by default in the processDecodes() and updateModel() methods. This is before the state is written. One thing that we

Re: [GSOC] State saving status after first improvements

2010-07-22 Thread Marius Petoi
Hello, So, for MyFaces, the state sizes of the basic components are: - without partial state saving: - HtmlOutputLabel: 760 B - HtmlInputText: 582 B - HtmlCommandButton: 1057 B - UIDebug: 606 B - HtmlDataTable: 1275 B (regardless of the number of lines the table has) -

Re: [GSOC] State saving status after first improvements

2010-07-22 Thread Leonardo Uribe
Hi Marius 2010/7/22 Marius Petoi marius.pe...@codebeat.ro Hello, So, for MyFaces, the state sizes of the basic components are: - without partial state saving: - HtmlOutputLabel: 760 B - HtmlInputText: 582 B - HtmlCommandButton: 1057 B - UIDebug: 606 B -

Re: [GSOC] State saving status after first improvements

2010-07-22 Thread Martin Marinschek
Hi guys, Unfortunately, try to save the state directly on the child components is not possible. The problem is the datatable is the one who know about the rows, so the right place for save this information (at least the delta information) is there. But the initial state could be saved on the

Re: [GSOC] State saving status after first improvements

2010-07-21 Thread Marius Petoi
Hi Martin, On Tue, Jul 20, 2010 at 6:03 PM, Martin Marinschek mmarinsc...@apache.orgwrote: For me, the UIData and UIRepeat need to descend from the same component - and this is actually something which is being discussed on the EG right now. -- Right now, UIRepeat does not have the partial

Re: [GSOC] State saving status after first improvements

2010-07-21 Thread Martin Marinschek
Hi Marius -- Full state saving means setting the context parameter javax.faces.PARTIAL_STATE_SAVING to false. This is all, right? I've noticed that just by doing this, the xhtml pages don't work anymore...only the jsp-s. There is no state saved in xhtml-s. Am I missing something? Oh my.

Re: [GSOC] State saving status after first improvements

2010-07-21 Thread Marius Petoi
Hello, As I see, in JspStateManagerImpl.saveSerializedView (actually in the isWritingState() method), there is a check whether the JSP_IS_WRITING_STATE_ATTR is set in the FacesContext. But this attribute is set in ViewHandlerImpl.setWritingState() if there is no StateWriter defined (if the

Re: [GSOC] State saving status after first improvements

2010-07-21 Thread Martin Marinschek
Hi Marius, ok, Leonardo will hopefully take a look - for you to continue: just post the partial state values for typical pages right now (you can also take the pages of the sample as a base if you want). best regards, Martin On Wed, Jul 21, 2010 at 3:23 PM, Marius Petoi

Re: [GSOC] State saving status after first improvements

2010-07-21 Thread Leonardo Uribe
Hi Marius, Martin Yes, it is a bug. The problem is related to some changes done on MYFACES-2754. I think that this changes was tested against jsp but not against facelets. I reverted the changes so you can test now. regards, Leonardo Uribe 2010/7/21 Martin Marinschek mmarinsc...@apache.org

Re: [GSOC] State saving status after first improvements

2010-07-20 Thread Marius Petoi
Hi Leonardo, So you are working on UIData at the moment. What about UIRepeat? I see that partial state saving is not implemented in UIRepeat components. We could improve the _childState table (which is included in the saved state) to save only the states which are different from an initial state

Re: [GSOC] State saving status after first improvements

2010-07-20 Thread Martin Marinschek
For me, the UIData and UIRepeat need to descend from the same component - and this is actually something which is being discussed on the EG right now. When we have this, the solution should be the same. Marius, can you go in the profiling mode again, and share with us the state sizes for a

Re: [GSOC] State saving status after first improvements

2010-07-19 Thread Marius Petoi
Hi Martin, Regarding state saving in tables, here are my observations and comments: - there is no state saved in relation to the UIData objects. - the states saved for the children of the UIData objects (the components in the tables) are irrelevant. They are not used afterwards, as the components

Re: [GSOC] State saving status after first improvements

2010-07-19 Thread Leonardo Uribe
Hi Marius Right now I'm working on MYFACES-2616 Fix UIData state saving model (spec issue 153). I hope to attach some new patches, a example and a better documentation in that issue soon, so we can review it and make comments. regards, Leonardo Uribe 2010/7/19 Marius Petoi

[GSOC] State saving status after first improvements

2010-07-14 Thread Marius Petoi
Hello, After the improvements we discussed in previous threads, here is what the state looks like for some of the components: - the org.apache.myfaces.view.facelets.MARK_ID (ComponentSupport.MARK_CREATED) attribute is present in almost all the components, but that is put in the attributes map

Re: [GSOC] State saving status after first improvements

2010-07-14 Thread Martin Marinschek
Hi Marius, you are sounding a bit unsure about this - did you really check what is in the partial state at the end of the lifecycle? best regards, Martin On 7/14/10, Marius Petoi marius.pe...@codebeat.ro wrote: Hello, After the improvements we discussed in previous threads, here is what the

Re: [GSOC] State saving status after first improvements

2010-07-14 Thread Marius Petoi
Hi Martin, I think you mean for the attributes that I say are added before the call to markInitialState(). So, as I see, the org.apache.myfaces.view.facelets.MARK_ID, locale, uniqueIdCounter, renderKitId, rendererType are not present in the partial state at the end of the lifecycle, although they

Re: [GSOC] State saving status after first improvements

2010-07-14 Thread Martin Marinschek
Hi Marius, as I see means you see it, or you think it is like this ;) ? best regards, Martin On 7/14/10, Marius Petoi marius.pe...@codebeat.ro wrote: Hi Martin, I think you mean for the attributes that I say are added before the call to markInitialState(). So, as I see, the