Re: [MyFaces 2.0] how to handle _SystemEventServletRequest and _SystemEventServletResponse classes (attn:Werner)

2009-12-02 Thread Bernhard Huemer
Hello, well, of course you could as well just pass the proxy, it would work. The difference is just that in my version the proxy actually will never be called, i.e. there's definitely no performance impact. It's just as I've mentioned a workaround for the not-null-check in the constructor of

Re: [MyFaces 2.0] how to handle _SystemEventServletRequest and _SystemEventServletResponse classes (attn:Werner)

2009-12-01 Thread Leonardo Uribe
2009/12/1 Matthias Wessendorf mwessend...@gmail.com Sent from my iPod. On 01.12.2009, at 22:48, Michael Concini mconc...@gmail.com wrote: I need some help with the best way to handle updating the dummy request/response objects that we use for system event listeners kicked off when

Re: [MyFaces 2.0] how to handle _SystemEventServletRequest and _SystemEventServletResponse classes (attn:Werner)

2009-12-01 Thread Jakob Korherr
I'd also prefer 2) Regards, Jakob Korherr 2009/12/2 Leonardo Uribe lu4...@gmail.com 2009/12/1 Matthias Wessendorf mwessend...@gmail.com Sent from my iPod. On 01.12.2009, at 22:48, Michael Concini mconc...@gmail.com wrote: I need some help with the best way to handle updating the

Re: [MyFaces 2.0] how to handle _SystemEventServletRequest and _SystemEventServletResponse classes (attn:Werner)

2009-12-01 Thread Scott O'Bryan
I'm not sure number 2 would work, you should try it out.  I know that when I tried to do this for Trinidad, it complained that I was not implementing the right version of the interfaces, even though the methods were there.  If this is the case then perhaps you should use a Proxy Object.  We

Re: [MyFaces 2.0] how to handle _SystemEventServletRequest and _SystemEventServletResponse classes (attn:Werner)

2009-12-01 Thread Bernhard Huemer
Hello, regarding the 1st solution: According to the JavaDocs the ServletRequestWrapper throws an IllegalArgumentException if you pass null as delegate, so this won't work (I'll come back to that later though). However, given that you're worried about NullPointerExceptions in case someone

Re: [MyFaces 2.0] how to handle _SystemEventServletRequest and _SystemEventServletResponse classes (attn:Werner)

2009-12-01 Thread Michael Concini
Thanks for the thorough analysis Bernhard. Sounds like the 2nd option that I and others were leaning towards won't work out. Based on this, and assuming there are no objections from the community, I'll work on a a fix using your recommendations below. Bernhard Huemer wrote: Hello,

Re: [MyFaces 2.0] how to handle _SystemEventServletRequest and _SystemEventServletResponse classes (attn:Werner)

2009-12-01 Thread Scott O'Bryan
I don't know why you couldn't just pass the proxy, and just throw IllegalOperationExceptions for unrecognized methods. But this one may be a bit cleaner. Don't know. Sent from my iPhone On Dec 1, 2009, at 6:21 PM, Bernhard Huemer bernhard.hue...@gmail.com wrote: Hello, regarding the