Re: [TRINIDAD] Code modifications :ISSUE -1836 Define public apis for org.apache.myfaces.trinidadinternal.menu

2010-07-05 Thread venkata guddanti
I reviewed the code and it looks good to me. Thanks, Venkata On Mon, Jun 21, 2010 at 2:52 AM, Simarpal Singh simar@gmail.com wrote: Hi, The following JIRA issue for the change in public APIs need approval: https://issues.apache.org/jira/browse/TRINIDAD-1836 *Need for this change:*

Re: [TRINIDAD] Code modifications :ISSUE -1836 Define public apis for org.apache.myfaces.trinidadinternal.menu

2010-06-29 Thread Simarpal Singh
Hi Matthias As per the process, I created a JIRA (Issue-1836) that I mentioned in this thread and also attached the patch. This email thread was started for discussion or objection if any that can be raised. Thanks, Simarpal Khaira On Sun, Jun 27, 2010 at 11:06 PM, Matthias Wessendorf

Re: [TRINIDAD] Code modifications :ISSUE -1836 Define public apis for org.apache.myfaces.trinidadinternal.menu

2010-06-27 Thread Matthias Wessendorf
Hi Simarpal, thanks for using Trinidad. If you want to make a change like that the process would be the following: -start a discussion on the change, here on the dev@ list and propose (and explain) the change; including asking for any concerns about the actual possible change etc. -create a

[TRINIDAD] Code modifications :ISSUE -1836 Define public apis for org.apache.myfaces.trinidadinternal.menu

2010-06-21 Thread Simarpal Singh
Hi, The following JIRA issue for the change in public APIs need approval: https://issues.apache.org/jira/browse/TRINIDAD-1836 *Need for this change:* As mentioned in the issue description - Some consumers use myfaces trinidad internal private APIs as there are no corresponding public APIs to