[Fwd: Re: [orchestra] minor issues]

2007-08-19 Thread simon
Forwarded Message From: simon [EMAIL PROTECTED] To: MyFaces Development dev@myfaces.apache.org Subject: Re: [orchestra] minor issues Date: Sat, 11 Aug 2007 14:46:08 +0200 On Sat, 2007-08-11 at 13:50 +0200, Mario Ivankovits wrote: Hi! AFAIK there is no way in readObject to get

Re: [orchestra] minor issues

2007-08-11 Thread Mario Ivankovits
Hi! MockFrameworkAdapter is checked in twice * core/src/test/java/org/apache/myfaces/orchestra/frameworkAdapter * core/src/main/java/org/apache/myfaces/orchestra/frameworkAdapter This causes Eclipse to complain (as it should). Thanks for the heads up. I'll remove it. There are a number

Re: [orchestra] minor issues

2007-08-11 Thread simon
On Sat, 2007-08-11 at 09:52 +0200, Mario Ivankovits wrote: There are a number of classes that are Serializable but do not declare a serialVersionUID value. Serializable classes really should, so that later changes which don't break serializable compatibility but do change the class

Re: [orchestra] minor issues

2007-08-11 Thread Mario Ivankovits
Hi! AFAIK there is no way in readObject to get the serialVersionUID of the stored object, is there a way? I'm not sure. Why would you want to? I'd generate the serialVersionUID with any number and use a second local version which will be written first to the the stream. That way,

[orchestra] minor issues

2007-08-10 Thread simon
Hi, Here are a few minor things I noticed about the Orchestra code: = MockFrameworkAdapter is checked in twice * core/src/test/java/org/apache/myfaces/orchestra/frameworkAdapter * core/src/main/java/org/apache/myfaces/orchestra/frameworkAdapter This causes Eclipse to