Hi!
In NavigationHandlerImpl around line 145 there is the following code
ViewHandler viewHandler = facesContext.getApplication().getViewHandler();
//create new view
String newViewId = navigationCase.getToViewId();
UIViewRoot viewRoot = viewHandler.createView(facesContext, newViewId);
This is very strange code, IMO. ViewHandler.createView() should
return a UIViewRoot with the viewId already set; that last statement
(viewRoot.setViewId(newViewId)) should be a no-op.
-- Adam
On 12/22/05, Mario Ivankovits [EMAIL PROTECTED] wrote:
Hi!
In NavigationHandlerImpl around line 145
This is the comment in viewHandler.createView():
// as of JSF spec page 7-16:
// It is the callers responsibility to ensure that setViewId() is called
// on the returned view, passing the same viewId value.
// so we do not set the viewId here
// ok, but the RI does so,
viewRoot.setViewId(viewRoot.getViewId());
Silly code, indeed, might have too much Punch today ;-)
So can we remove the setViewId() at this place at all?
---
Mario
Martin Marinschek wrote:
That's what I've done.
Thanks!
Merry Christmas to you all !!
Ciao,
Mario
BTW: Are you and your fellows subscribed to [EMAIL PROTECTED] Maybe we can
organize meetings in austria/vieanna from time to time in the new year?
[EMAIL PROTECTED]
there is something like this? didn't know that ;)
regards,
Martin
On 12/22/05, Mario Ivankovits [EMAIL PROTECTED] wrote:
Martin Marinschek wrote:
That's what I've done.
Thanks!
Merry Christmas to you all !!
Ciao,
Mario
BTW: Are you and your fellows subscribed to
On 12/22/05, Martin Marinschek [EMAIL PROTECTED] wrote:
This is the comment in viewHandler.createView():
// as of JSF spec page 7-16:
// It is the callers responsibility to ensure that setViewId() is called
// on the returned view, passing the same viewId value.
// so we
