Re: Proposed changes to t:dataTable regarding the new EL specification

2007-02-28 Thread Martin Marinschek
Yeah, looks good - go ahead. regards, Martin On 2/28/07, Jeff Bischoff [EMAIL PROTECTED] wrote: JSFAttr class has the following attributes incompatible with Facelets: // dataTable (extended) attributes String ROW_ID = org.apache.myfaces.dataTable.ROW_ID;

Re: Proposed changes to t:dataTable regarding the new EL specification

2007-02-28 Thread Jeff Bischoff
JSFAttr class has the following attributes incompatible with Facelets: // dataTable (extended) attributes String ROW_ID = org.apache.myfaces.dataTable.ROW_ID; String ROW_STYLECLASS_ATTR = org.apache.myfaces.dataTable.ROW_STYLECLASS; String

Re: Proposed changes to t:dataTable regarding the new EL specification

2007-02-28 Thread Mike Kienenberger
Jeff, In the future, it would be better to add patches to an existing JIRA issue when one exists rather than opening a new one. On 2/28/07, Jeff Bischoff [EMAIL PROTECTED] wrote: JSFAttr class has the following attributes incompatible with Facelets: // dataTable (extended) attributes

Re: Proposed changes to t:dataTable regarding the new EL specification

2007-02-28 Thread Jeff Bischoff
Hi Mike, Sorry! I forgot about TOMAHAWK-523. I remembered there were the similar JIRA issues that affected Tree2, but didn't remember this one existed. I see you already marked it as part of TOMAHAWK-914, thank you!! Regards, Jeff Bischoff Kenneth L Kurz Associates, Inc. Mike Kienenberger

Re: Proposed changes to t:dataTable regarding the new EL specification

2007-02-23 Thread Jeff Bischoff
If there's no objections, I'll open a JIRA and submit a patch. :) Mike Kienenberger wrote: This change looks good to me. It's probably more important that the value binding be able to default to null than to output an empty string css style. On 2/22/07, Jeff Bischoff [EMAIL PROTECTED] wrote:

Proposed changes to t:dataTable regarding the new EL specification

2007-02-22 Thread Jeff Bischoff
Greets, After converting my application from JSP to Facelets, I set out to make my rowStyleClass attribute on t:dataTable work like it used to. First, I had to get the attribute working in Facelets. With considerable discussion on the user list (see [1] and [2]) and a lot of help from Mike,

Re: Proposed changes to t:dataTable regarding the new EL specification

2007-02-22 Thread Mike Kienenberger
This change looks good to me. It's probably more important that the value binding be able to default to null than to output an empty string css style. On 2/22/07, Jeff Bischoff [EMAIL PROTECTED] wrote: Greets, After converting my application from JSP to Facelets, I set out to make my