Re: Question regarding adding a new verification task

2007-02-07 Thread Matthias Wessendorf
I bet ;) On 2/7/07, Cagatay Civici [EMAIL PROTECTED] wrote: Which ASs do this BTW? I'm not sure but it may be weblogic. Cagatay On 2/7/07, Dennis Byrne [EMAIL PROTECTED] wrote: You want to have a test to that would fail for non String class TLD attributes? It may be a good idea for us

Re: Question regarding adding a new verification task

2007-02-07 Thread Werner Punz
Dennis Byrne schrieb: You want to have a test to that would fail for non String class TLD attributes? It may be a good idea for us in terms of interoperability. Which ASs do this BTW? Weblogic, I stumbled over it and over the non linked attributes because of a user report in a users list. I

Question regarding adding a new verification task

2007-02-06 Thread Werner Punz
Hi Since I am currently working on fixing a lot of missing references in the sandbox Taglib classes. (Some people including me used a lot of includes from entities resulting in several missing attribute implementations) I am going to write, since this seems to be the most obvious way, a program

Re: Question regarding adding a new verification task

2007-02-06 Thread Martin Marinschek
There was someone who wrote an automatic test to check for this - I don't remember who and when that was, though. Can you have a look into the test directories and check? Maybe you can extend one of the test-classes instead of writing a new utility? regards, Martin On 2/6/07, Werner Punz

Re: Question regarding adding a new verification task

2007-02-06 Thread Dennis Byrne
You may want to let this do the work for you. http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/test/java/org/apache/myfaces/shared/taglib/UIComponentTagUtilsTest.java?view=log Dennis Byrne On 2/6/07, Werner Punz [EMAIL PROTECTED] wrote: Hi Since I am currently working on fixing a

Re: Question regarding adding a new verification task

2007-02-06 Thread Dennis Byrne
You may want to let this do the work for you. http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/test/java/org/apache/myfaces/shared/taglib/UIComponentTagUtilsTest.java?view=log Dennis Byrne On 2/6/07, Martin Marinschek [EMAIL PROTECTED] wrote: There was someone who wrote an

Re: Question regarding adding a new verification task

2007-02-06 Thread Paul Spencer
I believe this is what Martin is referring to the Tomahawk test MyFacesTagLibTestCase[1]. BTW: It looks like the verification of the sandbox taglibs was commented out. Paul Spencer

Re: Question regarding adding a new verification task

2007-02-06 Thread Dennis Byrne
When it came time to commit it, including the sandbox wasn't realistic. There were a lot of failures. Dennis Byrne On 2/6/07, Paul Spencer [EMAIL PROTECTED] wrote: I believe this is what Martin is referring to the Tomahawk test MyFacesTagLibTestCase[1]. BTW: It looks like the verification of

Re: Question regarding adding a new verification task

2007-02-06 Thread Dennis Byrne
Oops, I meant this. http://svn.apache.org/viewvc/myfaces/tomahawk/trunk/core/src/test/java/org/apache/myfaces/test/AbstractTagLibTestCase.java?revision=491515view=markup Dennis Byrne On 2/6/07, Dennis Byrne [EMAIL PROTECTED] wrote: You may want to let this do the work for you.

Re: Question regarding adding a new verification task

2007-02-06 Thread Paul Spencer
IMHO Tomahawk should NOT require the sandbox tld passes the test, thus 1) do not uncomment the line 2) do remove the TODO 3) Configure tomahawk's maven to create at test jar 4) Configure sandbox's maven to use tomahawk's test jar. 5) Create an sandbox test that extends AbstractTagLibTestCase

Re: Question regarding adding a new verification task

2007-02-06 Thread Werner Punz
Thanks a lot Dennis this was exactly what I was looking for! Dennis Byrne schrieb: You may want to let this do the work for you. http://svn.apache.org/viewvc/myfaces/shared/trunk/core/src/test/java/org/apache/myfaces/shared/taglib/UIComponentTagUtilsTest.java?view=log

Re: Question regarding adding a new verification task

2007-02-06 Thread Werner Punz
Ok guys, especially Dennis and Martin thanks to you I finally could nail down and fix or mark the missing attributes. The sandbox now should work in way more containers than it used to (commit follows in a few minutes) Werner Werner Punz schrieb: Thanks a lot Dennis this was exactly what I

Re: Question regarding adding a new verification task

2007-02-06 Thread Dennis Byrne
Hi Werner, Glad to help. Please take the time to vote for getting this feature into the Shale test framework. https://issues.apache.org/struts/browse/SHALE-382 Dennis Byrne On 2/6/07, Werner Punz [EMAIL PROTECTED] wrote: Ok guys, especially Dennis and Martin thanks to you I finally could

Re: Question regarding adding a new verification task

2007-02-06 Thread Werner Punz
Btw. speaking of unit tests, I am not fully familiar with the specs in this area, but some app servers choke on non class String definitions in the tld attributes. There is no test case for that at least in the sandbox, I am not sure if there is one for Tomahawk. Any ideas, if I just missed it?

Re: Question regarding adding a new verification task

2007-02-06 Thread Dennis Byrne
You want to have a test to that would fail for non String class TLD attributes? It may be a good idea for us in terms of interoperability. Which ASs do this BTW? Dennis Byrne On 2/6/07, Werner Punz [EMAIL PROTECTED] wrote: Btw. speaking of unit tests, I am not fully familiar with the specs

Re: Question regarding adding a new verification task

2007-02-06 Thread Cagatay Civici
Which ASs do this BTW? I'm not sure but it may be weblogic. Cagatay On 2/7/07, Dennis Byrne [EMAIL PROTECTED] wrote: You want to have a test to that would fail for non String class TLD attributes? It may be a good idea for us in terms of interoperability. Which ASs do this BTW? Dennis