datatable and groupBy enhancements

2007-05-21 Thread Mario Ivankovits
Hi! I'd like to make the following two enhancements to the tomahawk datatable/column: 1) add a new attribute groupByValue to the column This allows to configure a valueBinding to be used as value to check if there is a group change instead of scanning the children. The old behavior still works,

Re: datatable and groupBy enhancements

2007-05-21 Thread Martin Marinschek
No, sounds good to me. regards, Martin On 5/21/07, Mario Ivankovits [EMAIL PROTECTED] wrote: Hi! I'd like to make the following two enhancements to the tomahawk datatable/column: 1) add a new attribute groupByValue to the column This allows to configure a valueBinding to be used as value to

Re: datatable and groupBy enhancements

2007-05-21 Thread Zdeněk Sochor
Hi, i don't think either of suggestions are right. Sugesstion 1 has disadvatage: if you change one property of children in group, which is not defined as groupByValue or taken in account when computing value of checking value, you don't get whole group as changed. Suggestion 2 has

Re: datatable and groupBy enhancements

2007-05-21 Thread Martin Marinschek
Hi Zdenek, ad 1 - that's exactly what Mario wants to do - he wants to make sure that the group doesn't change if only an attribute, but not the id changes. ad 2 - why does sorting have anything to do with the grouping functionality? regards, Martin On 5/21/07, Zdeněk Sochor [EMAIL PROTECTED]

Re: datatable and groupBy enhancements

2007-05-21 Thread Mario Ivankovits
Hi! Sugesstion 1 has disadvatage: if you change one property of children in group, which is not defined as groupByValue or taken in account when computing value of checking value, you don't get whole group as changed. Notice, this change is backward compatible, so if you do NOT use

Re: datatable and groupBy enhancements

2007-05-21 Thread Paul Spencer
Mario, I am already thinking of places to use the enhancements. +1 - add a new attribute groupByValue to the column +1 - use objects instead of StringBuffer to create the compare string Paul Spencer Mario Ivankovits wrote: Hi! I'd like to make the following two enhancements to the tomahawk