Re: bug+patch: Read By Group Type Response

2016-07-25 Thread Christopher Collins
On Mon, Jul 25, 2016 at 02:17:40PM -0700, Christopher Collins wrote: > On Mon, Jul 25, 2016 at 12:09:13PM -0700, Mike Ryan wrote: > > I discovered and patched a bug in the Read Group Type Response message > > when using small MTUs. The details are recorded in the following pull > > request: > > >

Re: bug+patch: Read By Group Type Response

2016-07-25 Thread Christopher Collins
On Mon, Jul 25, 2016 at 12:09:13PM -0700, Mike Ryan wrote: > I discovered and patched a bug in the Read Group Type Response message > when using small MTUs. The details are recorded in the following pull > request: > > https://github.com/apache/incubator-mynewt-core/pull/79 > > This issue

bug+patch: Read By Group Type Response

2016-07-25 Thread Mike Ryan
I discovered and patched a bug in the Read Group Type Response message when using small MTUs. The details are recorded in the following pull request: https://github.com/apache/incubator-mynewt-core/pull/79 This issue appears to affect both master and develop.

Re: [PATCH] apps/blehci: Fix compilation error

2016-07-25 Thread Johan Hedberg
Hi Chris, On Mon, Jul 25, 2016, Christopher Collins wrote: > > If the project will continue accepting patches via email it'd be good if > > all maintainers know how to correctly use git for this process. > > Requiring contributors to stick to github is also fine, but then it > > needs to be

cbmem_init() potential bug

2016-07-25 Thread hathach
Hi, In the cbmem_init() the mutex lock is initialized then the whole struct is cleared https://github.com/apache/incubator-mynewt-core/blob/master/libs/util/src/cb mem.c#L29 It is not a big deal for now since os_mutex_init() seems to only clear the os_mutex object. However for the sake of