Re: NimBLE host advertising data API

2017-01-27 Thread Christopher Collins
Thanks Andrzej. That makes sense. Chris On Fri, Jan 27, 2017 at 04:57:48PM +0100, Andrzej Kaczmarek wrote: > Hi Chris, > > I created a pull request which also updates API to raw data for the > opposite direction, i.e. from host to app. Application can still parse this > to ble_hs_adv_fields

Re: NimBLE host advertising data API

2017-01-27 Thread Andrzej Kaczmarek
Hi Chris, I created a pull request which also updates API to raw data for the opposite direction, i.e. from host to app. Application can still parse this to ble_hs_adv_fields since helper is now public, but has to do this explicitly. The advantage is that if application prefers to work on raw

Re: NimBLE host advertising data API

2017-01-24 Thread Christopher Collins
On Tue, Jan 24, 2017 at 12:40:04PM -0800, will sanfilippo wrote: > I am not sure I have any intelligent comments on this, but that has never > stopped me from commenting in the past, so… No worries. Thanks for the feedback! > > I think a byte buffer interface is fine as long as you have

Re: NimBLE host advertising data API

2017-01-24 Thread Kevin Townsend
+1 ... raw buffer plus helpers offers the best of both worlds imho. Le mar. 24 janv. 2017 à 21:40, will sanfilippo a écrit : > I am not sure I have any intelligent comments on this, but that has never > stopped me from commenting in the past, so… > > > > I think a byte buffer

Re: NimBLE host advertising data API

2017-01-24 Thread will sanfilippo
I am not sure I have any intelligent comments on this, but that has never stopped me from commenting in the past, so… I think a byte buffer interface is fine as long as you have helper functions to create that buffer. Having folks have to figure out how to create an advertisement without any