Re: Headesup: NB23 Regression introduced by "Using LSP's ErrorProvider & another attempt at CompletionCollector" (#7579) / Revert proposed

2024-08-19 Thread Michael Bien
sorry I should have approved the revert PR earlier, when the other PR was closed i made a mental "resolved" note and kinda forgot that the revert PR was still open. -mbien On 19.08.24 20:46, Matthias Bläsing wrote: Hi all, there is still need for a review on the revert PR. Would be great if

Re: Headesup: NB23 Regression introduced by "Using LSP's ErrorProvider & another attempt at CompletionCollector" (#7579) / Revert proposed

2024-08-19 Thread Neil C Smith
On Mon, 19 Aug 2024, 20:52 Matthias Bläsing, wrote: > Hi, > > Am Montag, dem 19.08.2024 um 20:30 +0100 schrieb Neil C Smith: > > On Mon, 19 Aug 2024, 19:46 Matthias Bläsing, > > > wrote: > > > > Have added an approval, but opening a revert PR acts as a retrospective > > veto, so it's really up

Re: Headesup: NB23 Regression introduced by "Using LSP's ErrorProvider & another attempt at CompletionCollector" (#7579) / Revert proposed

2024-08-19 Thread Matthias Bläsing
Hi, Am Montag, dem 19.08.2024 um 20:30 +0100 schrieb Neil C Smith: > On Mon, 19 Aug 2024, 19:46 Matthias Bläsing, > wrote: > > Have added an approval, but opening a revert PR acts as a retrospective > veto, so it's really up to you. Also up to you whether to accept or cancel > the change reques

Re: Headesup: NB23 Regression introduced by "Using LSP's ErrorProvider & another attempt at CompletionCollector" (#7579) / Revert proposed

2024-08-19 Thread Neil C Smith
On Mon, 19 Aug 2024, 19:46 Matthias Bläsing, wrote: > Hi all, > > there is still need for a review on the revert PR. Would be great if > anyone could do it, so that it becomes part of next RC. > Have added an approval, but opening a revert PR acts as a retrospective veto, so it's really up to yo

Re: [VOTE] Releasing of nbm-archetype 1.19 netbeans-platform-app-archetype 1.24

2024-08-19 Thread Matthias Bläsing
+1 (binding) - checked sigs and SHA512 - eyeballed LICENSE, NOTICE - build from source Thank you, Matthias Am Dienstag, dem 06.08.2024 um 14:15 +0200 schrieb Eric Barboni: > Dear members of Apache NetBeans community. > > I want to call a vote on releasing the following Apache NetBeans Archetyp

Re: Headesup: NB23 Regression introduced by "Using LSP's ErrorProvider & another attempt at CompletionCollector" (#7579) / Revert proposed

2024-08-19 Thread Matthias Bläsing
Hi all, there is still need for a review on the revert PR. Would be great if anyone could do it, so that it becomes part of next RC. Thank you Matthias Am Donnerstag, dem 08.08.2024 um 22:37 +0200 schrieb Matthias Bläsing: > Hi, > > as last time pinging on github was too silent I try it here.

Re: [DISCUSS] Projects, Builds and IDE magic

2024-08-19 Thread Michael Bien
On 18.08.24 13:11, Michael Bien wrote: On 17.08.24 22:23, Svata Dedic wrote: For maven, priming was historically implemented as a "Project Problem" resolving action executing "package" or "install" goals. But I think this is wrong way: for example, we do not _need_ to install build plugins.