Re: Figuring out nbjavac in 11.2 is a doozy

2019-11-27 Thread Jan Lahoda
On Wed, Nov 27, 2019 at 10:23 PM Neil C Smith wrote: > On Wed, 27 Nov 2019 at 20:13, Emilian Bold wrote: > > An exe installer would be a derivative work imho even if it bundles > > the same bits. > > > > Calling that installer NetBeans based on nominative fair user seems an > > interesting angle

Re: Figuring out nbjavac in 11.2 is a doozy

2019-11-27 Thread Neil C Smith
On Wed, 27 Nov 2019 at 20:13, Emilian Bold wrote: > An exe installer would be a derivative work imho even if it bundles > the same bits. > > Calling that installer NetBeans based on nominative fair user seems an > interesting angle. I think it's a major stretch to call the installer derivative.

Re: Figuring out nbjavac in 11.2 is a doozy

2019-11-27 Thread Emilian Bold
> However, we can certainly have build scripts that have optional flags > that allow anyone building from the source release to include either > of those things for themselves. That's no different to providing the > option for a binary consumer to install at runtime. And means we > don't all have

Re: Figuring out nbjavac in 11.2 is a doozy

2019-11-27 Thread Neil C Smith
On Wed, 27 Nov 2019 at 17:30, Emilian Bold wrote: > I don't see what I'm doing as splitting the effort. If anything it's > complementary. Can NetBeans bundle a JDK? Can it bundle nbjavac? Depends what you mean! Can we bundle either in our binaries - at the moment, no, although there is still an

Re: Figuring out nbjavac in 11.2 is a doozy

2019-11-27 Thread Emilian Bold
> > I didn't mean to involve you too much with this, just curious if my > > patch made sense. I certainly don't want to split the efforts under > > NetBeans. > > I think that was meant that you doing it separately is splitting the > effort! Ideally something to solve here. I don't see what I'm do

Re: Figuring out nbjavac in 11.2 is a doozy

2019-11-27 Thread Neil C Smith
On Wed, 27 Nov 2019 at 08:26, Emilian Bold wrote: > I didn't mean to involve you too much with this, just curious if my > patch made sense. I certainly don't want to split the efforts under > NetBeans. I think that was meant that you doing it separately is splitting the effort! Ideally something

Re: Figuring out nbjavac in 11.2 is a doozy

2019-11-27 Thread Emilian Bold
I didn't mean to involve you too much with this, just curious if my patch made sense. I certainly don't want to split the efforts under NetBeans. It would be great if there was a single flag in the canonical build that would include nb-javac but it doesn't seem obvious to me how... Especially cons

Re: Figuring out nbjavac in 11.2 is a doozy

2019-11-26 Thread Jan Lahoda
On Mon, Nov 25, 2019 at 8:18 PM Emilian Bold wrote: > Jan, I'm curious if this patch makes sense to you: > > https://github.com/OpenBeans/OpenBeans/commit/ec4bfe3db429abd8830d750f8bc5dcc14285db37#diff-03465d6aba3fa54304c800a82884a4b9R31 Technically, yes, this is likely to work. But I wonder if

Re: Figuring out nbjavac in 11.2 is a doozy

2019-11-25 Thread Emilian Bold
Jan, I'm curious if this patch makes sense to you: https://github.com/OpenBeans/OpenBeans/commit/ec4bfe3db429abd8830d750f8bc5dcc14285db37#diff-03465d6aba3fa54304c800a82884a4b9R31 I'm just including the javacapi/impl JARs in libs.javacimpl, like we used to in 8.2. I *think* this should be sufficien

Re: Figuring out nbjavac in 11.2 is a doozy

2019-11-25 Thread Ernie Rael
On 11/25/2019 1:39 AM, Neil C Smith wrote: On Mon, 25 Nov 2019 at 08:17, Ernie Rael wrote: On 11/24/2019 11:32 PM, Jan Lahoda wrote: -there is only a single Plugin Portal for all NetBeans 11.0, 11.1 and 11.2; One way, somewhat kludgy, would be to make a clone of the portal for a new ver

Re: Figuring out nbjavac in 11.2 is a doozy

2019-11-25 Thread Emilian Bold
I know Jan that the current solution is based on the license restrictions Apache landed on us. It's actually a very neat solution but it's getting hard to follow up and harder to untangle. For OpenBeans I just want to include everything out of the box so the IDE works entirely offline, if needed, w

Re: Figuring out nbjavac in 11.2 is a doozy

2019-11-25 Thread Neil C Smith
On Mon, 25 Nov 2019 at 07:33, Jan Lahoda wrote: > If you want to add a new constraint that it must be easy to do a build > which includes nb-javac, I have nothing against that, but you may need to > design that yourself (and preferably contribute that back). I will also need to solve this problem

Re: Figuring out nbjavac in 11.2 is a doozy

2019-11-25 Thread Ernie Rael
On 11/24/2019 11:32 PM, Jan Lahoda wrote: Hello Emilian, While I understand your issue, the problem is that the space for solutions if significantly limited: -the ASF does not allow distribution of GPLv2+CPE libraries inside the Apache distribution -there is only a single Plugin Portal for all N

Re: Figuring out nbjavac in 11.2 is a doozy

2019-11-24 Thread Jan Lahoda
Hello Emilian, While I understand your issue, the problem is that the space for solutions if significantly limited: -the ASF does not allow distribution of GPLv2+CPE libraries inside the Apache distribution -there is only a single Plugin Portal for all NetBeans 11.0, 11.1 and 11.2; yet, nb-javac b

Figuring out nbjavac in 11.2 is a doozy

2019-11-24 Thread Emilian Bold
Hello, Before 11.2, nb-javac was just suggested and downloaded as a plain 3rd party plugin from the UC. Neat and clean. In 11.2 there is this rather complicated setup that's getting hard to untangle. So, following the spirit of the JavaFX plugins we use the same '3rd party' *meta* update center