OK, pushed these through, though not 'binaries-list' yet.
https://github.com/apache/incubator-netbeans/commit/a5e617426051ea4baa2ac5aaefeb6e2b78161ca5
Gj
On Mon, Sep 25, 2017 at 12:45 PM, Emilian Bold
wrote:
> Correct.
>
> Really makes no sense to add copyright headers to META-INF/ files.
> So
Hi all,
We need to discuss something, I think -- do we begin accepting pull
requests, and thereby encourage pull requests to be created -- or do we
focus very narrowly on preparing Apache NetBeans for its first incubator
release?
If we were to focus narrowly on preparing the Apache release, then
Hi,
On Mon, Sep 25, 2017 at 1:30 PM, Geertjan Wielenga wrote:
> ...
> https://cwiki.apache.org/confluence/display/NETBEANS/List+of+Modules+to+Review
The process looks good to me in general, in terms of preparing code
for an Apache release.
To be on the safe side best is probably to finish one mo
GitHub user emilianbold opened a pull request:
https://github.com/apache/incubator-netbeans/pull/9
[NETBEANS-54] Module Review openide.util.*
This branch covers:
* openide.util : no changes
* openide.util.enumerations : no changes
* openide.util.lookup : see patches / wik
On Tue, Sep 26, 2017 at 10:05 AM, Bertrand Delacretaz <
bdelacre...@apache.org> wrote:
> Hi,
>
> On Mon, Sep 25, 2017 at 1:30 PM, Geertjan Wielenga wrote:
> > ...
> > https://cwiki.apache.org/confluence/display/NETBEANS/
> List+of+Modules+to+Review
>
> The process looks good to me in general, in t
GitHub user emilianbold opened a pull request:
https://github.com/apache/incubator-netbeans/pull/10
[NETBEANS-54] Module Review openide.filesystems.*
* openide.filesystems
* openide.filesystems.nb
* openide.filesystems.compat8 (no change)
You can merge this pull request into
GitHub user emilianbold opened a pull request:
https://github.com/apache/incubator-netbeans/pull/11
Fixes bug in FileChooserBuilderTest
The tmpdir is loaded but the temporary file is not created in it, resulting
on macOS in a Permission denied IOException because java cannot write o
GitHub user ebarboni opened a pull request:
https://github.com/apache/incubator-netbeans/pull/12
properties for by module report
Hi this is a little modification to allow rat target to report only one
folder at a time. I was puzzled by the size of full rat report.
Usage exa
On Tue, Sep 26, 2017 at 10:49 AM, Geertjan Wielenga
wrote:
> ...Do you agree that if a file in the donated ZIP is licensed to Oracle or to
> Sun that it belonged to Oracle prior to the donation and that after the
> donation it belongs to Apache and can be relicensed to Apache?...
Yes that sounds
Indeed. Great.
This is where the Rat report is helpful -- it provides a list of those
files that have not been licensed to Apache.
The process here
https://cwiki.apache.org/confluence/display/NETBEANS/List+of+Modules+to+Review
is all about narrowing down that Rat report to a point where only thos
Hi,
It is great that the number of problematic files decreases drastically, but I
noticed that some of the files, E.g. in api.annotations.common, the file under
META-INF/service contains a (non-Apache) license header. Excluding them from
Rat will leave those old (Oracle) headers present, wouldn
Good point. Our rat is too aggressive.
Gj
On Tue, Sep 26, 2017 at 12:23 PM, Dave Schoorl wrote:
> Hi,
>
> It is great that the number of problematic files decreases drastically,
> but I noticed that some of the files, E.g. in api.annotations.common, the
> file under META-INF/service contains a
Github user geertjanw commented on the issue:
https://github.com/apache/incubator-netbeans/pull/12
Very cool!
---
Github user JaroslavTulach commented on the issue:
https://github.com/apache/incubator-netbeans/pull/10
Good changes. How do I merge them?
---
Github user JaroslavTulach commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/9#discussion_r141020052
--- Diff:
openide.util.ui/test/unit/src/org/openide/util/UtilitiesTranslateTest.java ---
@@ -157,6 +157,11 @@ public void testTranslateOldFo
Github user JaroslavTulach commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/2#discussion_r141021368
--- Diff: o.n.core/src/org/netbeans/core/NbAuthenticator.java ---
@@ -61,6 +63,7 @@
*/
final class NbAuthenticator extends java.ne
Github user JaroslavTulach commented on the issue:
https://github.com/apache/incubator-netbeans/pull/2
This is an API change (one can register `Authenticator` which wasn't
possible). You should also change `apichanges.xml` and `arch.xml` files. The
later one to describe the API - use
Github user JaroslavTulach commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/8#discussion_r141023560
--- Diff: api.htmlui/src/org/netbeans/api/htmlui/HTMLDialog.java ---
@@ -1,44 +1,20 @@
-/*
- * DO NOT ALTER OR REMOVE COPYRIGHT NOTIC
Github user JaroslavTulach commented on the issue:
https://github.com/apache/incubator-netbeans/pull/8
This patch is correct and can be integrated.
---
GitHub user emilianbold opened a pull request:
https://github.com/apache/incubator-netbeans/pull/13
[NETBEANS-54] Module Review openide.modules
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/emilianbold/incubator-netbeans
emi-r
Hello,
Do we really need license headers for test data?
I see all these small xml/text/properties files used to test code and they
have nothing of any significance, they are just there to test some
situation.
The way I see http://www.apache.org/legal/src-headers.html#faq-exceptions
A file witho
GitHub user emilianbold opened a pull request:
https://github.com/apache/incubator-netbeans/pull/14
[NETBEANS-54] Module Review o.n.swing.tabcontrol
Updated license, but according to
http://www.apache.org/legal/src-headers.html#faq-exceptions no license would
also be OK.
You can m
Hi all,
Made a quick 3 minute YouTube clip to help explain what and why we're
trying to achieve with this page:
https://cwiki.apache.org/confluence/display/NETBEANS/List+of+Modules+to+Review
Hope it clarifies things -- i.e., no knowledge of NetBeans APIs or even
Java is needed, for the basic rev
GitHub user ebarboni opened a pull request:
https://github.com/apache/incubator-netbeans/pull/15
[NETBEANS-54] Module Review uihandler
package.html was not updated by the tools
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ebar
On Tue, Sep 26, 2017 at 3:05 PM, Emilian Bold wrote:
> ...I see all these small xml/text/properties files used to test code and they
> have nothing of any significance,...
Can you provide the URLs of some examples?
-Bertrand
Take a look here:
https://github.com/apache/incubator-netbeans/tree/master/o.n.bootstrap/test/unit/data/jars
Eg.
https://github.com/apache/incubator-netbeans/blob/master/o.n.bootstrap/test/unit/data/jars/base-layer-mod/baselayer/layer.xml
https://github.com/apache/incubator-netbeans/blob/master/o.
Hi,
Just a quick question for my own clarity and understanding, while reviewing the
Modules list for NETBEANS-54: should a Netbeans module in incubator-netbeans
repository always contain an Apache License file in it's root? Because a module
can be released / updated on it's own and thus is an a
I suggest excluding .mf files too. These are used for MANIFEST files and
manifest files cannot have comments (and thus no licence headers).
--emi
On Tue, Sep 26, 2017 at 1:27 PM, Geertjan Wielenga <
geertjan.wiele...@googlemail.com> wrote:
> Good point. Our rat is too aggressive.
>
> Gj
>
> On
26. 9. 2017 v 17:36, Dave Schoorl :
> Hi,
>
> Just a quick question for my own clarity and understanding, while reviewing
> the Modules list for NETBEANS-54: should a Netbeans module in
> incubator-netbeans repository always contain an Apache License file in it's
> root?
That would be the rig
I think the license could be included as part of the build process, if we
start publishing individual module binaries to update centers.
So, one copy per repository is enough.
--emi
On Tue, Sep 26, 2017 at 6:36 PM, Dave Schoorl wrote:
> Hi,
>
> Just a quick question for my own clarity and und
test/**/*.ser files could also be excluded from Rat.
--emi
On Tue, Sep 26, 2017 at 6:38 PM, Emilian Bold
wrote:
> I suggest excluding .mf files too. These are used for MANIFEST files and
> manifest files cannot have comments (and thus no licence headers).
>
>
> --emi
>
> On Tue, Sep 26, 2017 a
My thinking of this so far was that the repository would contain only a
very limited information necessary for the (binary or source) build to
produce the correct LICENSE and NOTICE for the given artefact. So, for a
module whose (source) code is under Apache License without anything special
(which
Github user jlahoda commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/6#discussion_r141121602
--- Diff:
db/test/unit/src/org/netbeans/modules/db/explorer/DbDriverManagerTest.java ---
@@ -221,7 +221,7 @@ private static JDBCDriver createJDBCDr
Github user jlahoda commented on the issue:
https://github.com/apache/incubator-netbeans/pull/12
+1
---
Github user matthiasblaesing commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/6#discussion_r141124129
--- Diff:
db/test/unit/src/org/netbeans/modules/db/explorer/DbDriverManagerTest.java ---
@@ -221,7 +221,7 @@ private static JDBCDriver cre
GitHub user matthiasblaesing opened a pull request:
https://github.com/apache/incubator-netbeans/pull/16
[NETBEANS-54] Module Review db.dataview
- no external libraries
- fix Rat files:
- add missing ALv2 headers for .sql files
- move dbdata.txt to dbdata.properties a
Hey,
Am Dienstag, den 26.09.2017, 09:17 +0200 schrieb Geertjan Wielenga:
> [Discuss-Request: Focus on getting a release out or adding functions]
if I'm not mistaken, the netbeans 9 feature freeze had already happened
when the migration to apache began. I would focus on bugfixing and
blocking new
Definitely we should focus on getting an Apache NetBeans release.
Sincerely, at this point, I think we should maybe have a Apache NetBeans
9.0 Java edition, so we can have something release and then a full Apache
NB 9.0. Otherwise, sounds like we'll get no release this year, which would
be pretty s
Hi,
On Tue, Sep 26, 2017 at 7:15 PM Matthias Bläsing
wrote:
> if I'm not mistaken, the netbeans 9 feature freeze had already happened
> when the migration to apache began. I would focus on bugfixing and
> blocking new features.
>
> With the apache migration process there is enough development n
Github user svenreimers commented on the issue:
https://github.com/apache/incubator-netbeans/pull/12
Awesome +1
---
+1 (I think that if we want to get some rest and fun, we could use branches
to experiment with some new features (and I may do so at some point), but
we should limit unnecessary changes to master, and use our code
review/discussion bandwidth as much as possible for working on a release)
I personal
Hi all,
I fully agree with Jan..
Let's try to get something released first so we know the process..
Hope to have some time to review modules real soon now..
-Sven
Am 26.09.2017 22:13 schrieb "Jan Lahoda" :
> +1 (I think that if we want to get some rest and fun, we could use branches
> to expe
Github user jlahoda commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/6#discussion_r141172728
--- Diff:
db/test/unit/src/org/netbeans/modules/db/explorer/DbDriverManagerTest.java ---
@@ -221,7 +221,7 @@ private static JDBCDriver createJDBCDr
Github user mklaehn commented on the issue:
https://github.com/apache/incubator-netbeans/pull/12
great +1
---
Github user svenreimers commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/6#discussion_r141175203
--- Diff:
db/test/unit/src/org/netbeans/modules/db/explorer/DbDriverManagerTest.java ---
@@ -221,7 +221,7 @@ private static JDBCDriver createJD
Github user dschoorl commented on the issue:
https://github.com/apache/incubator-netbeans/pull/7
Thanks Jan. I restored the jsr305 license and added a jcip license. I
updated license header files according to latest insights on Rat exclusions
(files that don need a license header). I
Agree as well and really cool to see much activity and interaction.
Gj
On Tue, Sep 26, 2017 at 10:16 PM, Sven Reimers
wrote:
> Hi all,
>
> I fully agree with Jan..
>
> Let's try to get something released first so we know the process..
>
> Hope to have some time to review modules real soon now..
I have no dog in this particular hunt, but if it were up to me I'd prioritize:
getting code into repositories with clean RAT reports
getting Netbeans to build and run
creating release(s) for major platforms
...
serious bug reports
...
features (in branches)
Craig
> On Sep 26, 2017, at 1:16 PM, S
That all sounds like a good strategy to me.
+1
Wade
On Sep 26, 2017 17:44, "Craig Russell" wrote:
> I have no dog in this particular hunt, but if it were up to me I'd
> prioritize:
>
> getting code into repositories with clean RAT reports
> getting Netbeans to build and run
> creating release(
Hi all,
When you check a module for license headers and suspicious files (files that
maybe were not owned by Oracle), make changes and do a Pull Request (PR), the
PR is checked by one or more committers. On the other hand, when the person
checking a module thinks no modifications are needed, no
My preference is for trying to handle those common things via the tool,
i.e., rather than manually fixing apichanges.xml by hand, the point to me
is to identify that that needs to be fixed, or XML files in general, and
add them to the generally problematic list at the top of the page.
Gj
On Wed,
Yup -- and corresponds with what we're doing.
I love it when a plan comes together.
Gj
On Wed, Sep 27, 2017 at 12:03 AM, Wade Chandler
wrote:
> That all sounds like a good strategy to me.
>
> +1
>
> Wade
>
> On Sep 26, 2017 17:44, "Craig Russell" wrote:
>
> > I have no dog in this particular
Actually, that means I shouldn't mark those modules as "Done" but as "To
do".
Gj
On Wed, Sep 27, 2017 at 12:27 AM, Geertjan Wielenga <
geertjan.wiele...@googlemail.com> wrote:
> My preference is for trying to handle those common things via the tool,
> i.e., rather than manually fixing apichanges
Github user matthiasblaesing commented on the issue:
https://github.com/apache/incubator-netbeans/pull/6
@svenreimers @jlahoda I reverted the fix for the unittest to get this
merged at some point, but I don't agree with your assessment.
---
54 matches
Mail list logo
