[GitHub] incubator-netbeans issue #25: NETBEANS-73: Autodetect id_rsa and id_dsa keys...

Github user lkishalmi commented on the issue: https://github.com/apache/incubator-netbeans/pull/25 I've made a small change to do the detection only when the key auth is selected. ---

[GitHub] incubator-netbeans issue #33: -external library jna-platform-4.2.2.jar: dual...

Github user jlahoda commented on the issue: https://github.com/apache/incubator-netbeans/pull/33 I am no opposed to excluding binaries-list, but I'd add: -remove existing license headers from binaries-list -explain the decision at release time if needed So, are you

[GitHub] incubator-netbeans issue #41: [NETBEANS-54] Module Review c.google.guava

Github user junichi11 commented on the issue: https://github.com/apache/incubator-netbeans/pull/41 @matthiasblaesing Thanks for looking at it :) Fixed. I hope that my understanding is correct. ---

[GitHub] incubator-netbeans issue #41: [NETBEANS-54] Module Review c.google.guava

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/41 This is nitpicking but as the target is cleanup I hope you understand: - the license file should match the binary `.zip` should be accompanied by `-icense.txt` in this case

[GitHub] incubator-netbeans issue #40: [NETBEANS-54] Module Review c.googlecode.javae...

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/40 Looks good. ---

[GitHub] incubator-netbeans issue #22: [NETBEANS-54] Module Review db.mysql

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/22 Merged with 1 positive review. Thanks for having a look. ---

[GitHub] incubator-netbeans pull request #22: [NETBEANS-54] Module Review db.mysql

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/22 ---

[GitHub] incubator-netbeans pull request #30: [NETBEANS-54] Module Review defaults

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/30 ---

[GitHub] incubator-netbeans issue #30: [NETBEANS-54] Module Review defaults

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/30 Merged into master with 1 positive review. Thank you for reviewing. ---

[GitHub] incubator-netbeans issue #20: [NETBEANS-54] Module Review db.drivers

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/20 Merged with one positive review - thanks for reviewing. ---

[GitHub] incubator-netbeans pull request #20: [NETBEANS-54] Module Review db.drivers

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/20 ---

[GitHub] incubator-netbeans issue #38: [NETBEANS-54] Module Review editor.lib2

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/38 Merged with 2 positive reviews. ---

[GitHub] incubator-netbeans issue #37: [NETBEANS-54] Module Review editor.lib

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/37 Merged with 3 positive reviews - Thank you. ---

[GitHub] incubator-netbeans pull request #37: [NETBEANS-54] Module Review editor.lib

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/37 ---

[GitHub] incubator-netbeans pull request #38: [NETBEANS-54] Module Review editor.lib2

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/38 ---

[GitHub] incubator-netbeans issue #33: -external library jna-platform-4.2.2.jar: dual...

Github user emilianbold commented on the issue: https://github.com/apache/incubator-netbeans/pull/33 I don't believe there is much IP value in the binaries-list files and I would not add that huge license header in all of them when they generally have 1-2 lines. The overall project

[GitHub] incubator-netbeans issue #33: -external library jna-platform-4.2.2.jar: dual...

Github user jlahoda commented on the issue: https://github.com/apache/incubator-netbeans/pull/33 Well, I think it would be good to decide if we (really) want to solve the binaries-list issue centrally, and if yes solve it. Are you willing to resolve that? ---

Re: Wiki page on how to submit PR

Hi, On Mon, 2 Oct 2017, 15:16 Eric Barboni, wrote: > > I started a new page [1] to help people making PR. I'm novice in git and > nice workflow with GitHub. > This is a good start. From experience if this is particularly aimed at people unused to GitHub, you may want to be

goldenfiles (was Re: Testing modules after review & licenses in test files?)

On 02/10/17 19:59, Matthias Bläsing wrote: Am Montag, den 02.10.2017, 19:33 +0200 schrieb Antonio Vieiro: Are you sure the added header causes the test to fail? From the look of the file I doubt that. If it is indeed the header that causes the The licenses in headers have nothing to do with

Re: Testing modules after review & licenses in test files?

On Mon, Oct 2, 2017 at 8:11 PM, Emilian Bold wrote: > AnnotationsTest and AnnotationLoadingTest are not failing on my machine. > > But PlainDocumentCompatibilityRandomTest.test and > NbEditorToolBarTest.testActionContextLookupContainsNodeOnlyOnce *do* fail > on my

Re: Wiki page on how to submit PR

Hi Emilian, Am Montag, den 02.10.2017, 16:36 +0300 schrieb Emilian Bold: > Most important, before a master commit: > > git checkout feature > git checkout -b temporary-branch > git rebase -i master > # [Clean up the history] > git checkout master > git merge temporary-branch why do you insist

Re: Editing permissions for making changes to the Wiki.

Hi, I need permissions too. My confluence id is “borxa” Thanks > El 2 oct 2017, a las 12:33, Geertjan Wielenga > escribió: > > Done! > > Gj > > On Monday, October 2, 2017, Antonio Vieiro wrote: > >> Hi, >> >> Would someone please add

[GitHub] incubator-netbeans issue #33: -external library jna-platform-4.2.2.jar: dual...

Github user emilianbold commented on the issue: https://github.com/apache/incubator-netbeans/pull/33 The way I understood it, I will absolutely not touch "Problems to be solved centrally" because they will be dealt with entirely at some future moment. Only reason I would care

[GitHub] incubator-netbeans issue #39: [NETBEANS-54] Module Review bugzilla

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/39 The change looks good. ---

[GitHub] incubator-netbeans issue #33: -external library jna-platform-4.2.2.jar: dual...

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/33 My take: If a file needs to be edited, there is no draw back in adding the license header also. There is already a mixed set (files with and without license header), so the

Re: Testing modules after review & licenses in test files?

I restored the xml test file to the Oracle headers but the tests keep on failing. So the Apache license headers are not the reason of the failure. I'll keep those and keep going. TIA Antonio

[GitHub] incubator-netbeans issue #33: -external library jna-platform-4.2.2.jar: dual...

Github user jlahoda commented on the issue: https://github.com/apache/incubator-netbeans/pull/33 Regarding binaries-list, yes it is listed in the central problems (although all that means is that some of us will need to propose and implement a solution). Including the header for a

Re: Testing modules after review & licenses in test files?

http://www.apache.org/legal/src-headers.html#faq-exceptions Other files may make sense to have no license header. Three examples are: > Test data for which the addition of a source header would cause the tests > to fail. --emi On Mon, Oct 2, 2017 at 8:33 PM, Antonio Vieiro

[GitHub] incubator-netbeans issue #31: [NETBEANS-54] Module Review j2ee.core.utilitie...

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/31 @juneau001 please rereview this changeset - now your PR would remove headers from .form files. While your at it: rebase your changes onto the current HEAD of master and squash

Testing modules after review & licenses in test files?

Hi all, A license header has already been included in an xml test file at [1] (ide cluster, editor module). If I run tests on this module (cd editor; ant test) the tests fail. My questions: a) Should I remove the license header from the test file? b) If so, the test file would have an Oracle

[GitHub] incubator-netbeans issue #12: properties for by module report

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/12 This change introduces a problem: exclude patterns can't be defined per module anymore. @jlahoda introduced the fist such set `form/test/unit/data/goldenfiles/*` and I'll need to

Re: Licenses for user facing files & readmes?

> - User facing files (plain text template files such as [1] or [2], for example) don't require a license, right? Correct. > - README files [3] do require a license I would say no, see http://www.apache.org/legal/src-headers.html#faq-exceptions although that README is long. So perhaps the

Licenses for user facing files & readmes?

Hi all, Sorry if this has been already answered, but I need some confirmation here: - User facing files (plain text template files such as [1] or [2], for example) don't require a license, right? - README files [3] do require a license Thanks in advance, Antonio [1]

[GitHub] incubator-netbeans issue #35: -external library Apache felix. Changed coordi...

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/35 Looks good - comment from #33 about the commit message applies here as well. ---

[GitHub] incubator-netbeans issue #33: -external library jna-platform-4.2.2.jar: dual...

Github user emilianbold commented on the issue: https://github.com/apache/incubator-netbeans/pull/33 So, are we adding license to binaries-list? Isn't is part of the "Problems to be solved centrally"? ---

[GitHub] incubator-netbeans issue #34: -external library jna-4.2.2.jar: dual-licensed...

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/34 Looks good, I'd adjust the commit message though to contain something like "[NETBEANS-54] Module review libs.jna". The first line ise used as summary of the commit and now this

[GitHub] incubator-netbeans issue #33: -external library jna-platform-4.2.2.jar: dual...

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/33 Looks good. ---

Re: Wiki page on how to submit PR

Lots of useful info here https://www.atlassian.com/git/tutorials/merging-vs-rebasing Most important, before a master commit: git checkout feature git checkout -b temporary-branch git rebase -i master # [Clean up the history] git checkout master git merge temporary-branch --emi On Mon, Oct 2,

Wiki page on how to submit PR

Hi, I started a new page [1] to help people making PR. I'm novice in git and nice workflow with GitHub. Changing name and mail seems to be important but as git by default allow committing with local name you may lose a bit of time (:D) . Many thanks to Matthias and Emilian Regards

Re: Hello

Hi William, This is how to participate in Apache NetBeans: https://cwiki.apache.org/confluence/display/NETBEANS/How+to+Participate This is the current task we're working on, welcome to get involved: https://cwiki.apache.org/confluence/display/NETBEANS/List+of+Modules+to+Review Thanks, Geertjan

[GitHub] incubator-netbeans pull request #39: [NETBEANS-54] Module Review bugzilla

GitHub user junichi11 opened a pull request: https://github.com/apache/incubator-netbeans/pull/39 [NETBEANS-54] Module Review bugzilla - no external library - checked Rat report: update the license header in BugzillaRepository.java - skimmed through the module, did not

[GitHub] incubator-netbeans pull request #38: [NETBEANS-54] Module Review editor.lib2

GitHub user vieiro opened a pull request: https://github.com/apache/incubator-netbeans/pull/38 [NETBEANS-54] Module Review editor.lib2 - No external libraries. - checked Rat report: modified license header in src/org/netbeans/api/editor/caret/package.html - skimmed through

[GitHub] incubator-netbeans pull request #37: [NETBEANS-54] Module Review editor.lib

GitHub user vieiro opened a pull request: https://github.com/apache/incubator-netbeans/pull/37 [NETBEANS-54] Module Review editor.lib - no external libraries - checked Rat report: modified license header in src/org/netbeans/editor/BaseKit.java - skimmed through the module,

[GitHub] incubator-netbeans issue #12: properties for by module report

Github user ebarboni commented on the issue: https://github.com/apache/incubator-netbeans/pull/12 @emilianbold , I sorry was trying to resync but this PR is on my master branch so I go back to a usable state. ---

[GitHub] incubator-netbeans issue #12: properties for by module report

Github user emilianbold commented on the issue: https://github.com/apache/incubator-netbeans/pull/12 I don't believe you are rebasing correctly. You shouldn't see something like: >jlahoda committed with ebarboni 8 days ago ---

Re: Cannot update list of modules to review (ide/editor.lib, ide/editor.lib2)

Hello, Updated. > I cannot update the list of modules to review >From How to Participate[1] > Look around: "Once you have a user account on Confluence, please send a mail to dev@netbeans.incubator.apache.org to ask for editing permissions for making changes to the Wiki. " [1]

Cannot update list of modules to review (ide/editor.lib, ide/editor.lib2)

Hi, I cannot update the list of modules to review at https://cwiki.apache.org/confluence/display/NETBEANS/List+of+Modules+to+Review Would anyone please be so kind as to add the following entries there? Cluster (area): ide Modules: editor.lib, editor.lib2 Name: vieiro Thanks, Antonio P.S.:

Re: Introducing myself & stepping forward

Yep, these galicians are everywhere! ;-) https://en.wikipedia.org/wiki/Galicia_(Spain) Graciñas, Antonio 2017-10-02 9:44 GMT+02:00 Borxa Varela Bouzas : > Hi Antonio, > > Other spanish here! > > Saludos > >> El 2 oct 2017, a las 7:54, Antonio Vieiro

Re: Introducing myself & stepping forward

Hi Antonio, Other spanish here! Saludos > El 2 oct 2017, a las 7:54, Antonio Vieiro escribió: > > Thanks, Emilian! Thanks all! > > Un abrazo, > Antonio > > 2017-10-02 7:52 GMT+02:00 Emilian Bold : >> Welcome Antonio! You have been missed! >> >>

Re: Commit author rules?

Hi, On Sun, Oct 1, 2017 at 9:54 AM, Matthias Bläsing wrote: > ... 1. Either the change is deemed small/simple enough not to require an > ICLA >2. The author needs to have an ICLA on file > > For the first condition I'll rely on my gut feeling, for the

[GitHub] incubator-netbeans issue #7: [NETBEANS-54] Module Review api.annotations.com...

Github user jlahoda commented on the issue: https://github.com/apache/incubator-netbeans/pull/7 Description of the current -license.txt processing is here: http://wiki.netbeans.org/DevFaqExternalLibraries I think details under Apache are still somewhat unclear, but I think