Github user junichi11 commented on the issue:
https://github.com/apache/incubator-netbeans/pull/66
Thanks for fixing it.
BTW, You should create a new branch, then commit your changes. maybe, since
next time?
---
Hello,
I have been poking around the NetBeans code and had a request/idea.NetBeans is
a good size codebase and there is a lot of history in the code. One of the
challenges with such a large code base is that adding features or fixing
defects can be daunting. Where is the code for feature X, why
I see we have no issue tracker on GitHub for the Apache project.
But I can add the Hacktoberfest label to my own repository and it does
show up in searches, eg.
https://github.com/emilianbold/incubator-netbeans/issues/1
--emi
On Fri, Oct 6, 2017 at 9:16 AM, Emilian Bold wrote:
> So we should:
Github user subhash-koganti commented on the issue:
https://github.com/apache/incubator-netbeans/pull/65
Just submitted a Pull Request 66 with the fixed commit.
---
GitHub user subhash-koganti opened a pull request:
https://github.com/apache/incubator-netbeans/pull/66
[NETBEANS-54] Module Review editor.settings.lib - Added Apache License
- no external libraries
- checked Rat report and found 11 XML files that don't have any license
info def
Github user subhash-koganti commented on the issue:
https://github.com/apache/incubator-netbeans/pull/65
Ohk. I will submit a new Pull request with the updated Commit Message.
Thanks for the review.
---
Github user subhash-koganti closed the pull request at:
https://github.com/apache/incubator-netbeans/pull/65
---
So we should:
1. Call this "license header cleanup tasks"or something easy for people to
understand and
2. See if we could add issues with the hacktoberfest label. Is this possible
with our JIRA/ Github setup?
--emi
Pe 6 oct. 2017, la 08:49, Dmitry Avtonomov a
scris:
> I'd say few people h
Github user junichi11 commented on the issue:
https://github.com/apache/incubator-netbeans/pull/65
You should also fix the commit message. In your case, `[NETBEANS-54] Module
Review editor.settings.lib`
see [List of Modules to
Review](https://cwiki.apache.org/confluence/displ
Github user junichi11 commented on the issue:
https://github.com/apache/incubator-netbeans/pull/34
Thank you for your answer. I see. I'll leave it as it is.
---
I'd say few people have idea of what "module review" is.
Also on github the search: "label:hacktoberfest state:open type:issue
netbeans" brings up only 3 irrelevant issues.
- Dmitry
On Thu, Oct 5, 2017 at 2:19 PM, Emilian Bold wrote:
> Hello,
>
> I'm trying to use Twitter to attract contributor
Hello Sven.
Merging git repos (including history) is easier than splitting them (commit ids
are kept).
I think a separate git repo for an incubating^2 plugin is good idea.
-jt
Dne 6. 10. 2017 0:11 Sven Reimers napsal(a):
>
> Sure this is a no brainer...
>
> Already created a repo at github (st
Github user jlahoda commented on the issue:
https://github.com/apache/incubator-netbeans/pull/35
Merged this pull request:
https://git-wip-us.apache.org/repos/asf?p=incubator-netbeans.git;a=commit;h=3814587fcc8ae6712840b2d6c78126cb02b641e7
---
Github user jlahoda closed the pull request at:
https://github.com/apache/incubator-netbeans/pull/35
---
Github user jlahoda closed the pull request at:
https://github.com/apache/incubator-netbeans/pull/33
---
Github user jlahoda commented on the issue:
https://github.com/apache/incubator-netbeans/pull/33
Merged this pull request:
https://git-wip-us.apache.org/repos/asf?p=incubator-netbeans.git;a=commit;h=0aa49fe575905f3c3eddd47c6b95194d40115174
---
Github user jlahoda commented on the issue:
https://github.com/apache/incubator-netbeans/pull/34
Regarding the OSR field - that does not have any significance at this
point, as far as I can tell. So can be removed. But we can do a batch update at
some point and remove them all.
Github user jlahoda closed the pull request at:
https://github.com/apache/incubator-netbeans/pull/34
---
GitHub user subhash-koganti opened a pull request:
https://github.com/apache/incubator-netbeans/pull/65
Added Apache License
- no external libraries
- checked Rat report and found 11 XML files that don't have any license
info defined on them. Added the license text on to them .
Github user emilianbold commented on the issue:
https://github.com/apache/incubator-netbeans/pull/64
Perfect!
---
GitHub user juneau001 opened a pull request:
https://github.com/apache/incubator-netbeans/pull/64
[NETBEANS-54] Module Review j2ee.core.utilities
- no external libraries
- checked Rat report, added license header to project.xml, other headers
looked ok. Ignored problems to be r
Sure this is a no brainer...
Already created a repo at github (still empty) to build the plugin under
ASL license and integrate once the donation is complete..
Ok?
Or should we create a repo for incubating plugins at apache?
Sven
Am 05.10.2017 14:49 schrieb "Zoran Sevarac" :
> Hi,
>
> I've ta
Hi,
I've talked to David Blevins from TomiTribe about including TomEE support
in NetBeans and they would be pretty happy to see that. That would not be
complicated since we already have Tomcat included, and its on the line of
adding support to apache related projects to netbeans.
I think it would
Github user juneau001 closed the pull request at:
https://github.com/apache/incubator-netbeans/pull/31
---
Github user emilianbold commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/31#discussion_r143060563
--- Diff:
j2ee.core.utilities/src/org/netbeans/modules/j2ee/core/support/java/method/ExceptionsPanel.form
---
@@ -1,26 +1,5 @@
Hello,
I'm trying to use Twitter to attract contributors to NetBeans for our
modules review as part of #Hacktoberfest
(https://hacktoberfest.digitalocean.com/ )
(See, for example, https://twitter.com/emilianbold/status/916043049381195776 )
We still have about 400 modules to go from which 200 or
Github user juneau001 commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/31#discussion_r143060074
--- Diff:
j2ee.core.utilities/src/org/netbeans/modules/j2ee/core/support/java/method/ExceptionsPanel.form
---
@@ -1,26 +1,5 @@
Github user emilianbold commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/31#discussion_r143059710
--- Diff:
j2ee.core.utilities/src/org/netbeans/modules/j2ee/core/support/java/method/ExceptionsPanel.form
---
@@ -1,26 +1,5 @@
Github user juneau001 commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/31#discussion_r143059352
--- Diff:
j2ee.core.utilities/src/org/netbeans/modules/j2ee/core/support/java/method/ExceptionsPanel.form
---
@@ -1,26 +1,5 @@
Github user emilianbold commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/31#discussion_r143058559
--- Diff: j2ee.core.utilities/test/unit/data/JavaApp/build.xml ---
@@ -35,20 +56,20 @@
-For list
Github user emilianbold commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/31#discussion_r143058295
--- Diff:
j2ee.core.utilities/src/org/netbeans/modules/j2ee/core/support/java/method/MethodCustomizerPanel.form
---
@@ -1,26 +1,5 @@
Github user emilianbold commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/31#discussion_r143058376
--- Diff: j2ee.core.utilities/test/unit/data/JavaApp/build.xml ---
@@ -1,4 +1,25 @@
+
Github user emilianbold commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/31#discussion_r143058744
--- Diff:
j2ee.core.utilities/test/unit/data/JavaApp/nbproject/project.properties ---
@@ -1,3 +1,20 @@
+# Licensed to the Apache Software
Github user emilianbold commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/31#discussion_r143058582
--- Diff: j2ee.core.utilities/test/unit/data/JavaApp/build.xml ---
@@ -35,20 +56,20 @@
-For list
Github user emilianbold commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/31#discussion_r143058725
--- Diff:
j2ee.core.utilities/test/unit/data/JavaApp/nbproject/build-impl.xml ---
@@ -21,9 +41,9 @@ is divided into following sections:
Github user emilianbold commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/31#discussion_r143058252
--- Diff:
j2ee.core.utilities/src/org/netbeans/modules/j2ee/core/support/java/method/ExceptionsPanel.form
---
@@ -1,26 +1,5 @@
Github user emilianbold commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/31#discussion_r143058527
--- Diff: j2ee.core.utilities/test/unit/data/JavaApp/build.xml ---
@@ -7,9 +28,9 @@
Github user emilianbold commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/31#discussion_r143058623
--- Diff: j2ee.core.utilities/test/unit/data/JavaApp/build.xml ---
@@ -35,20 +56,20 @@
-For list
Github user emilianbold commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/31#discussion_r143058793
--- Diff: j2ee.core.utilities/test/unit/data/JavaApp/nbproject/project.xml
---
@@ -1,4 +1,24 @@
+
Github user emilianbold commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/31#discussion_r143058704
--- Diff:
j2ee.core.utilities/test/unit/data/JavaApp/nbproject/build-impl.xml ---
@@ -1,5 +1,25 @@
Github user emilianbold commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/31#discussion_r143058683
--- Diff: j2ee.core.utilities/test/unit/data/JavaApp/build.xml ---
@@ -60,10 +81,10 @@
-Notice th
Github user emilianbold commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/31#discussion_r143058334
--- Diff:
j2ee.core.utilities/src/org/netbeans/modules/j2ee/core/support/java/method/ParametersPanel.form
---
@@ -1,26 +1,5 @@
Github user juneau001 commented on the issue:
https://github.com/apache/incubator-netbeans/pull/31
Hi @matthiasblaesing is the code looking okay now? I've done what was
mentioned. That is, I rebased changes on to master, reverted my changes to
form files and genfiles.properties. Le
Github user ikysil commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/62#discussion_r143025054
--- Diff:
hibernate/src/org/netbeans/modules/hibernate/resources/HibernateRevengTemplate.xml
---
@@ -1,2 +1,24 @@
+
--- End diff --
Github user matthiasblaesing commented on the issue:
https://github.com/apache/incubator-netbeans/pull/46
Merged - thank you.
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-netbeans/pull/46
---
Github user matthiasblaesing commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/62#discussion_r143012148
--- Diff:
hibernate/src/org/netbeans/modules/hibernate/resources/HibernateRevengTemplate.xml
---
@@ -1,2 +1,24 @@
+
--- End diff
Can you/have you run the tool again, with these changes, and pushed the
changed license headers?
And must all the other pull requests be merged first because in some cases
people might have manually changed some of these headers and there could be
problems in those cases?
Thanks,
Gj
On Wed, Oct
Really awesome -- and done!
Gj
On Thu, Oct 5, 2017 at 3:44 AM, Daniel Platz
wrote:
> Hi all,
> My name is Daniel (username 38leinad) and i am a long-time Netbeans user
> and now the move to apache seems to be the perfect time to get involved and
> give back.
> I would like to pick up some modul
Hi all,
My name is Daniel (username 38leinad) and i am a long-time Netbeans user and
now the move to apache seems to be the perfect time to get involved and give
back.
I would like to pick up some modules for reaview here:
https://cwiki.apache.org/confluence/display/NETBEANS/List+of+Modules+to+
Github user junichi11 commented on the issue:
https://github.com/apache/incubator-netbeans/pull/34
@jlahoda Should we remove the OSR field in other -license.txt files?
---
Github user emilianbold closed the pull request at:
https://github.com/apache/incubator-netbeans/pull/58
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-netbeans/pull/59
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-netbeans/pull/57
---
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-netbeans/pull/60
---
55 matches
Mail list logo
