[GitHub] incubator-netbeans pull request #145: [NETBEANS-54] Module Review apisupport...

Github user geertjanw commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/145#discussion_r144708728 --- Diff: apisupport.wizards/src/org/netbeans/modules/apisupport/project/ui/wizard/action/actionListener.javx --- @@ -1,41 +1,22 @@ -<#--

[GitHub] incubator-netbeans pull request #117: [NETBEANS-54] Modeule Review j2ee.pers...

Github user juneau001 commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/117#discussion_r144708411 --- Diff: j2ee.persistence/test/unit/data/invalid_persistence.xml --- @@ -1,8 +1,27 @@ -http://www.apache.org/licenses/LICENSE-2.0

[GitHub] incubator-netbeans pull request #117: [NETBEANS-54] Modeule Review j2ee.pers...

Github user junichi11 commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/117#discussion_r144706417 --- Diff: j2ee.persistence/test/unit/data/invalid_persistence.xml --- @@ -1,8 +1,27 @@ -http://www.apache.org/licenses/LICENSE-2.0

[GitHub] incubator-netbeans issue #117: [NETBEANS-54] Modeule Review j2ee.persistence

Github user junichi11 commented on the issue: https://github.com/apache/incubator-netbeans/pull/117 Thank you for fixing them. ---

[GitHub] incubator-netbeans pull request #145: [NETBEANS-54] Module Review apisupport...

Github user junichi11 commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/145#discussion_r144706085 --- Diff: apisupport.wizards/src/org/netbeans/modules/apisupport/project/ui/wizard/action/actionListener.javx --- @@ -1,41 +1,22 @@ -<#--

[GitHub] incubator-netbeans issue #117: [NETBEANS-54] Modeule Review j2ee.persistence

Github user juneau001 commented on the issue: https://github.com/apache/incubator-netbeans/pull/117 Made all requested changes...will add those files as mentioned to the Rat report ---

[GitHub] incubator-netbeans pull request #117: [NETBEANS-54] Modeule Review j2ee.pers...

Github user juneau001 commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/117#discussion_r144706106 --- Diff: j2ee.persistence/test/unit/data/invalid_persistence.xml --- @@ -1,8 +1,25 @@ -http://java.sun.com/xml/ns/persistence;

Re: SHA-1 Ignoring case, please?

See https://github.com/apache/incubator-netbeans/pull/152 On 14/10/17 20:21, Antonio wrote: Hi, Mmm... build.xml is getting picky about SHA1 comparisons. Would it be possible to ignore case when comparing SHA1? That's a big hex number, after all... :-) Thanks, Antonio

[GitHub] incubator-netbeans pull request #151: [NETBEANS-54] Module Review o.eclipse....

GitHub user vieiro opened a pull request: https://github.com/apache/incubator-netbeans/pull/151 [NETBEANS-54] Module Review o.eclipse.core.jobs - Exact version 3.5.101 could not be found in Maven, downgrading to 3.5.100 - Updated binaries-list with maven coordinates for

SHA-1 Ignoring case, please?

Hi, Mmm... build.xml is getting picky about SHA1 comparisons. Would it be possible to ignore case when comparing SHA1? That's a big hex number, after all... :-) Thanks, Antonio /home/travis/build/apache/incubator-netbeans/nbbuild/build.xml:122: Download of

[GitHub] incubator-netbeans pull request #120: [NETBEANS-54] Module Review junitlib

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/120 ---

[GitHub] incubator-netbeans pull request #149: [NETBEANS-54] Module Review o.apache.x...

GitHub user vieiro opened a pull request: https://github.com/apache/incubator-netbeans/pull/149 [NETBEANS-54] Module Review o.apache.xmlrpc - Added three entries in binaries-list with Maven coordinates for Apache XMLRPC 3.0 files (Apache 2.0) - No notice files found at

Re: NetBeans 9 release date

I will print this and then hang it here for all to see. Thanks for this, Wade. On 14/10/17 15:51, Wade Chandler wrote: Posting on top here. Regardless of an NB 9 release date, I think 2 things can be huge factors. 1) That not everything we give users comes from Apache NetBeans, but instead we

[GitHub] incubator-netbeans pull request #148: [NETBEANS-54] Fix central problems

GitHub user matthiasblaesing opened a pull request: https://github.com/apache/incubator-netbeans/pull/148 [NETBEANS-54] Fix central problems - l10n.list - build.xml - project.xml - project.properties - platform.properties - added recursive exclusions for

Re: NetBeans 9 release date

On Oct 13, 2017 05:59, "Neil C Smith" wrote: In particular, it's no secret I think JavaFX is a dead-end. I'm not sure I foresee a time when either project moves UI to JavaFX - maybe I'm wrong. I have been pondering this as well, but I think that is for old

Re: NetBeans 9 release date

Posting on top here. Regardless of an NB 9 release date, I think 2 things can be huge factors. 1) That not everything we give users comes from Apache NetBeans, but instead we make it super easy to link to projects build artifacts from the idea of the plugin center. IMO, Visual Studio Code is

Re: Linking GitHub account to

Hey, Am Freitag, den 13.10.2017, 13:25 +0200 schrieb Geertjan Wielenga: > Or maybe we should vote on this as a community before going ahead > with it? > > Gj > > On Fri, Oct 13, 2017 at 1:23 PM, Geertjan Wielenga > wrote: > > >

[GitHub] incubator-netbeans pull request #137: [NETBEANS-54] Module Review refactorin...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/137 ---

[GitHub] incubator-netbeans issue #146: [NETBEANS-54] Add ALv2 header to l10n.list fi...

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/146 Closing - I'll regroup this into a larger set ---

[GitHub] incubator-netbeans pull request #147: [NETBEANS-54] Recursively exclude gene...

Github user matthiasblaesing closed the pull request at: https://github.com/apache/incubator-netbeans/pull/147 ---

[GitHub] incubator-netbeans issue #147: [NETBEANS-54] Recursively exclude generated p...

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/147 Closing - I'll regroup this into a larger set ---

Re: How to handle patches for external binaries?

Sounds good for me.. -Sven Am 14.10.2017 13:33 schrieb "Antonio" : On 14/10/17 11:17, Emilian Bold wrote: > 1. What’s the license of these patches? Same as the original project? Or >> Apache 2? >> > > Since it's code from Oracle, it's going to be relicensed as Apache 2. >

Re: How to handle patches for external binaries?

On 14/10/17 11:17, Emilian Bold wrote: 1. What’s the license of these patches? Same as the original project? Or Apache 2? Since it's code from Oracle, it's going to be relicensed as Apache 2. Ok. If I see something weird I'll raise my hand (patching non Apache-2 licensed binaries with an

[GitHub] incubator-netbeans pull request #147: [NETBEANS-54] Recursively exclude gene...

GitHub user matthiasblaesing opened a pull request: https://github.com/apache/incubator-netbeans/pull/147 [NETBEANS-54] Recursively exclude generated project files You can merge this pull request into a Git repository by running: $ git pull

[GitHub] incubator-netbeans pull request #146: [NETBEANS-54] Add ALv2 header to l10n....

GitHub user matthiasblaesing opened a pull request: https://github.com/apache/incubator-netbeans/pull/146 [NETBEANS-54] Add ALv2 header to l10n.list files You can merge this pull request into a Git repository by running: $ git pull

[GitHub] incubator-netbeans pull request #145: [NETBEANS-54] Module Review apisupport...

GitHub user geertjanw opened a pull request: https://github.com/apache/incubator-netbeans/pull/145 [NETBEANS-54] Module Review apisupport.wizards You can merge this pull request into a Git repository by running: $ git pull https://github.com/geertjanw/incubator-netbeans

[GitHub] incubator-netbeans pull request #132: [NETBEANS-54] Module Review mercurial

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/132 ---

[GitHub] incubator-netbeans pull request #139: [NETBEANS-54] Module Review ide.kit

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/139 ---

[GitHub] incubator-netbeans issue #118: [NETBEANS-54] Module Review o.eclipse.jgit

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/118 New binaries contain signatures - this might be a problem in the future, if so the build process need to be adjusted to strip the signatures away. Thank you. ---

[GitHub] incubator-netbeans issue #119: [NETBEANS-54] Module Review org.eclipse.jgit....

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/119 New binaries contain signatures - this might be a problem in the future, if so the build process need to be adjusted to strip the signatures away. Thank you. ---

Re: Rat violations as test failures

Wow, excellent! Gj On Sat, Oct 14, 2017 at 8:21 AM, Jaroslav Tulach wrote: > Hi team, > thanks to hard work of Eric Barboni we count the RAT violations as test > failures. See: > > https://builds.apache.org/job/incubator-netbeans-linux/ >

[GitHub] incubator-netbeans issue #70: WIP custom ant task to produce html report fro...

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/70 I think the problem is in rat - with an output file this is what happens: 1. the Report Task creates an FileWriter that writes to the target file and wraps a PrintWriter

Re: NetBeans 9 release date

@Antonio - The second one. NB already has a graphing tool similar to the first link. @Illya - Yes I do use maven for builds. The build helper maven plugin's add-source goal is exactly what we've been using. We were generating sources to say "${project.build.directory}/superplugin" and setting that

Re: How to handle patches for external binaries?

Or 3. Build a small ant project that downloads sources from Maven, applies patches as required and recreates the binaries. > El 14 oct 2017, a las 9:15, Antonio Vieiro escribió: > > Hi all, > > Some modules contain patches that must be applied to third-party source >

How to handle patches for external binaries?

Hi all, Some modules contain patches that must be applied to third-party source projects in order to generate external binaries (an example at [1]). 1. What’s the license of these patches? Same as the original project? Or Apache 2? 2. I will not add maven coordinates for these, right? Shall I

Re: Rat violations as test failures

Nice! --emi On Sat, Oct 14, 2017 at 9:21 AM, Jaroslav Tulach wrote: > Hi team, > thanks to hard work of Eric Barboni we count the RAT violations as test > failures. See: > > https://builds.apache.org/job/incubator-netbeans-linux/lastCompletedBuild/testReport/ > > As

Rat violations as test failures

Hi team, thanks to hard work of Eric Barboni we count the RAT violations as test failures. See: https://builds.apache.org/job/incubator-netbeans-linux/lastCompletedBuild/testReport/ As a result we have a dashboard to show us our progress in fixing the licenses and other tests. Thanks Eric! -jt