Re: add "-notice.txt" if needed with any required notices?

quot; branch in the main NetBeans repository) There are 3 zips there: -platform-src-dev-incubator-netbeans-generate-mandatory-files-linux-2-on-20171020.zip: platform sources -netbeans/nbbuild/NetBeans-dev-incubator-netbeans-generate-mandatory-files-linux-2-on-20171020-platform.zip: "ordinary&

[GitHub] junichi11 commented on issue #158: [NETBEANS-54] Module Review css.editor

junichi11 commented on issue #158: [NETBEANS-54] Module Review css.editor URL: https://github.com/apache/incubator-netbeans/pull/158#issuecomment-338363064 > Fixes requested thus far done. Thank you! Please exclude CascadeStyleSheet.css.template and CssExample from rat. ---

[GitHub] rosslamont commented on issue #158: [NETBEANS-54] Module Review css.editor

rosslamont commented on issue #158: [NETBEANS-54] Module Review css.editor URL: https://github.com/apache/incubator-netbeans/pull/158#issuecomment-338359896 Fixes requested thus far done. This is an automated message from the

[GitHub] junichi11 commented on issue #158: [NETBEANS-54] Module Review css.editor

junichi11 commented on issue #158: [NETBEANS-54] Module Review css.editor URL: https://github.com/apache/incubator-netbeans/pull/158#issuecomment-338352002 @matthiasblaesing @emilianbold Could you please advise anything about external libraries? ---

[GitHub] junichi11 commented on issue #158: [NETBEANS-54] Module Review css.editor

junichi11 commented on issue #158: [NETBEANS-54] Module Review css.editor URL: https://github.com/apache/incubator-netbeans/pull/158#issuecomment-338351224 > do you want the fixes squashed into the original commit Yes, maybe, it is preferred. ---

[GitHub] junichi11 commented on issue #164: [NETBEANS-54] Module Review debugger.jpda.ui

junichi11 commented on issue #164: [NETBEANS-54] Module Review debugger.jpda.ui URL: https://github.com/apache/incubator-netbeans/pull/164#issuecomment-338350808 > For the genfiles.properties I would consider not adding a header. I'll revert them. Thanks! ---

[GitHub] jlahoda commented on issue #130: Cache external binaries downloaded from maven in NetBeans' cache.

jlahoda commented on issue #130: Cache external binaries downloaded from maven in NetBeans' cache. URL: https://github.com/apache/incubator-netbeans/pull/130#issuecomment-338286298 @javydreamercsw, as @matthiasblaesing says, the name is for historical reasons (NetBeans for using Mercurial

Re: Support for (Java) Pattern Matching

To me, that is a TBD. But releasing from branches like amber(/patterns) is one of the possible approaches, IMO. Jan On Fri, Oct 20, 2017 at 11:13 PM, Ciprian Ciubotariu wrote: > Would we also have netbeans releases from the amber branch? > > On 10/20/17 23:50, Jan Lahoda wrote: > > For me, the

Re: Support for (Java) Pattern Matching

Would we also have netbeans releases from the amber branch? On 10/20/17 23:50, Jan Lahoda wrote: > For me, the main advantage of using the ASF repo is that the provenance of > the code is clear. Having a long-lived branch on GitHub may cause issues if > the code is merged into the mainline (I, of

Re: Support for (Java) Pattern Matching

For me, the main advantage of using the ASF repo is that the provenance of the code is clear. Having a long-lived branch on GitHub may cause issues if the code is merged into the mainline (I, of course, don't know if it will happen with the code this e-mail is about). So if multiple people (can) co

[GitHub] rosslamont commented on issue #158: [NETBEANS-54] Module Review css.editor

rosslamont commented on issue #158: [NETBEANS-54] Module Review css.editor URL: https://github.com/apache/incubator-netbeans/pull/158#issuecomment-338317539 Thx folks, do you want the fixes squashed into the original commit or would you like the history to match your comments? (not quite s

[GitHub] rasa-app commented on a change in pull request #166: [NETBEANS-54] Module Review java.j2seplatform

rasa-app commented on a change in pull request #166: [NETBEANS-54] Module Review java.j2seplatform URL: https://github.com/apache/incubator-netbeans/pull/166#discussion_r146059919 ## File path: java.j2seplatform/src/org/netbeans/modules/java/j2seplatform/resources/templates/default

[GitHub] rasa-app commented on a change in pull request #166: [NETBEANS-54] Module Review java.j2seplatform

rasa-app commented on a change in pull request #166: [NETBEANS-54] Module Review java.j2seplatform URL: https://github.com/apache/incubator-netbeans/pull/166#discussion_r146058601 ## File path: java.j2seplatform/src/org/netbeans/modules/java/j2seplatform/queries/Bundle.properties

[GitHub] matthiasblaesing commented on a change in pull request #166: [NETBEANS-54] Module Review java.j2seplatform

matthiasblaesing commented on a change in pull request #166: [NETBEANS-54] Module Review java.j2seplatform URL: https://github.com/apache/incubator-netbeans/pull/166#discussion_r146048893 ## File path: java.j2seplatform/src/org/netbeans/modules/java/j2seplatform/resources/templates

[GitHub] matthiasblaesing commented on a change in pull request #166: [NETBEANS-54] Module Review java.j2seplatform

matthiasblaesing commented on a change in pull request #166: [NETBEANS-54] Module Review java.j2seplatform URL: https://github.com/apache/incubator-netbeans/pull/166#discussion_r146049196 ## File path: java.j2seplatform/src/org/netbeans/modules/java/j2seplatform/queries/Bundle.prop

Re: Support for (Java) Pattern Matching

Fair enough, so but then you have people creating branches on the (for lack of a better term) 'master' repository, without any checks and balances... At least what we have now with PR's they can be easily merged. What is the proposed working solution? committers commit directly against the ASF Ne

[GitHub] matthiasblaesing closed pull request #162: [NETBEANS-54] Module Review maven.embedder

matthiasblaesing closed pull request #162: [NETBEANS-54] Module Review maven.embedder URL: https://github.com/apache/incubator-netbeans/pull/162 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] javydreamercsw commented on a change in pull request #131: [NETBEANS-54] Module Review lib.terminalemulator

javydreamercsw commented on a change in pull request #131: [NETBEANS-54] Module Review lib.terminalemulator URL: https://github.com/apache/incubator-netbeans/pull/131#discussion_r145973032 ## File path: lib.terminalemulator/examples/lib.richexecution/process_start.cat ## @

[GitHub] javydreamercsw commented on a change in pull request #131: [NETBEANS-54] Module Review lib.terminalemulator

javydreamercsw commented on a change in pull request #131: [NETBEANS-54] Module Review lib.terminalemulator URL: https://github.com/apache/incubator-netbeans/pull/131#discussion_r145973032 ## File path: lib.terminalemulator/examples/lib.richexecution/process_start.cat ## @

[GitHub] asfgit closed pull request #159: [NETBEANS-54] Module Review options.editor

asfgit closed pull request #159: [NETBEANS-54] Module Review options.editor URL: https://github.com/apache/incubator-netbeans/pull/159 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a f

[GitHub] javydreamercsw commented on issue #130: Cache external binaries downloaded from maven in NetBeans' cache.

javydreamercsw commented on issue #130: Cache external binaries downloaded from maven in NetBeans' cache. URL: https://github.com/apache/incubator-netbeans/pull/130#issuecomment-338299401 It just sounded like a new thing. If it's not I agree there's no need to change it.

Re: Support for (Java) Pattern Matching

I think the Apache Way is to keep things as close to the Apache project as possible, i.e, creating branches of Apache NetBeans is preferred over forking (even though that’s what we’re doing with the IP clearance), so I think Jan’s suggestion is in line with how it should be. Gj On Fri, 20 Oct 201

Re: Support for (Java) Pattern Matching

No objections, but it would make sense to create a fork on GitHub and then create a branch on your own fork. John On 20 October 2017 at 19:16, Jan Lahoda wrote: > Hi, > > I have a very crude sketch/prototype of support for pattern matching in > Java (as currently prototyped in OpenJDK Amber

[GitHub] matthiasblaesing commented on a change in pull request #134: [NETBEANS-54] Module Review httpserver

matthiasblaesing commented on a change in pull request #134: [NETBEANS-54] Module Review httpserver URL: https://github.com/apache/incubator-netbeans/pull/134#discussion_r146038948 ## File path: httpserver/nbproject/project.properties ## @@ -15,10 +15,11 @@ # specific lan

[GitHub] matthiasblaesing commented on a change in pull request #134: [NETBEANS-54] Module Review httpserver

matthiasblaesing commented on a change in pull request #134: [NETBEANS-54] Module Review httpserver URL: https://github.com/apache/incubator-netbeans/pull/134#discussion_r146039459 ## File path: httpserver/nbproject/project.xml ## @@ -153,7 +153,7 @@

[GitHub] matthiasblaesing commented on a change in pull request #134: [NETBEANS-54] Module Review httpserver

matthiasblaesing commented on a change in pull request #134: [NETBEANS-54] Module Review httpserver URL: https://github.com/apache/incubator-netbeans/pull/134#discussion_r146038842 ## File path: httpserver/external/tomcat-webserver-3.2-license.txt ## @@ -1,58 +0,0 @@ -Name

[GitHub] matthiasblaesing commented on a change in pull request #134: [NETBEANS-54] Module Review httpserver

matthiasblaesing commented on a change in pull request #134: [NETBEANS-54] Module Review httpserver URL: https://github.com/apache/incubator-netbeans/pull/134#discussion_r146038681 ## File path: httpserver/external/binaries-list ## @@ -14,4 +14,4 @@ # KIND, either express

[GitHub] matthiasblaesing commented on issue #131: [NETBEANS-54] Module Review lib.terminalemulator

matthiasblaesing commented on issue #131: [NETBEANS-54] Module Review lib.terminalemulator URL: https://github.com/apache/incubator-netbeans/pull/131#issuecomment-338288289 Nice work. This is an automated message from the Ap

[GitHub] matthiasblaesing closed pull request #131: [NETBEANS-54] Module Review lib.terminalemulator

matthiasblaesing closed pull request #131: [NETBEANS-54] Module Review lib.terminalemulator URL: https://github.com/apache/incubator-netbeans/pull/131 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance

[GitHub] asfgit closed pull request #127: [NETBEANS-54] Module Review javafx2.kit

asfgit closed pull request #127: [NETBEANS-54] Module Review javafx2.kit URL: https://github.com/apache/incubator-netbeans/pull/127 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a fore

[GitHub] jlahoda commented on issue #130: Cache external binaries downloaded from maven in NetBeans' cache.

jlahoda commented on issue #130: Cache external binaries downloaded from maven in NetBeans' cache. URL: https://github.com/apache/incubator-netbeans/pull/130#issuecomment-338286298 @javydreamercsw, as @matthiasblaesing says, the name is for historical reasons (NetBeans for using Mercurial

[GitHub] jlahoda commented on issue #170: Fix unittests for Netbeans Build system

jlahoda commented on issue #170: Fix unittests for Netbeans Build system URL: https://github.com/apache/incubator-netbeans/pull/170#issuecomment-338284480 I assume tests are passing after this patch. Looks very good to me. Thanks for doing this! ---

[GitHub] asfgit closed pull request #124: [NETBEANS-54] Module Review o.apache.tools.ant.module

asfgit closed pull request #124: [NETBEANS-54] Module Review o.apache.tools.ant.module URL: https://github.com/apache/incubator-netbeans/pull/124 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

Support for (Java) Pattern Matching

Hi, I have a very crude sketch/prototype of support for pattern matching in Java (as currently prototyped in OpenJDK Amber, branch patterns): http://cr.openjdk.java.net/~briangoetz/amber/pattern-match.html http://openjdk.java.net/jeps/305 The prototype requires that the runtime JDK is an OpenJDK

[GitHub] matthiasblaesing commented on issue #130: Cache external binaries downloaded from maven in NetBeans' cache.

matthiasblaesing commented on issue #130: Cache external binaries downloaded from maven in NetBeans' cache. URL: https://github.com/apache/incubator-netbeans/pull/130#issuecomment-338281528 @jlahoda I created a PR with the fixes #170 @javydreamercsw this might answer you question: htt

[GitHub] matthiasblaesing commented on issue #117: [NETBEANS-54] Modeule Review j2ee.persistence

matthiasblaesing commented on issue #117: [NETBEANS-54] Modeule Review j2ee.persistence URL: https://github.com/apache/incubator-netbeans/pull/117#issuecomment-338280505 I would expand the zip in any case. In the worst case this exposes the licenses of the files. There are four licenses p

[GitHub] matthiasblaesing commented on issue #170: Fix unittests for Netbeans Build system

matthiasblaesing commented on issue #170: Fix unittests for Netbeans Build system URL: https://github.com/apache/incubator-netbeans/pull/170#issuecomment-338277032 @jlahoda as you will base your changeset on this, could you please take a look at this?

[GitHub] matthiasblaesing opened a new pull request #170: Fix unittests for Netbeans Build system

matthiasblaesing opened a new pull request #170: Fix unittests for Netbeans Build system URL: https://github.com/apache/incubator-netbeans/pull/170 As indicated in the comment to PR #130 (cache external binaries also for downloads from maven central) [1] the change to the Netbeans Bui

[GitHub] arusinha opened a new pull request #169: [NETBEANS-54] Module Review o.apache.commons.httpclient

arusinha opened a new pull request #169: [NETBEANS-54] Module Review o.apache.commons.httpclient URL: https://github.com/apache/incubator-netbeans/pull/169 Updated to maven coordinates for external resource : commons-httpclient-3.1.jar (Apache 2.0)

Re: Request for clarification on review process on NetBeans with pngs and other odd files found

That's an ArgoUML file most likely. Don't unzip and attach headers to it. We wouldn't do the same for .odt files, no? (which are also zip files) --emi On Fri, Oct 20, 2017 at 5:12 PM, mark stephens wrote: > > >> On 13 Oct 2017, at 15:46, Antonio Vieiro wrote: >> >> Hi, >> >> - Just ignore ima

Re: Request for clarification on review process on NetBeans with pngs and other odd files found

> On 13 Oct 2017, at 15:46, Antonio Vieiro wrote: > > Hi, > > - Just ignore image files (png/jpg/gif). > - Add a comment to the xml files (you can copy it from nproject/project.xml). > > Greetings & thanks, > Antonio It is actually a zip file (TwoWaySupport.zargo) containing some xml and pg

[GitHub] juneau001 commented on issue #117: [NETBEANS-54] Modeule Review j2ee.persistence

juneau001 commented on issue #117: [NETBEANS-54] Modeule Review j2ee.persistence URL: https://github.com/apache/incubator-netbeans/pull/117#issuecomment-338216233 @matthiasblaesing @emilianbold Thanks for the info. Please let me know how you'd like for me to proceed with the .zip file cle

[GitHub] javydreamercsw commented on a change in pull request #158: [NETBEANS-54] Module Review css.editor

javydreamercsw commented on a change in pull request #158: [NETBEANS-54] Module Review css.editor URL: https://github.com/apache/incubator-netbeans/pull/158#discussion_r145965228 ## File path: css.editor/src/org/netbeans/modules/css/resources/CascadeStyleSheet.css.template ###

[GitHub] javydreamercsw commented on a change in pull request #158: [NETBEANS-54] Module Review css.editor

javydreamercsw commented on a change in pull request #158: [NETBEANS-54] Module Review css.editor URL: https://github.com/apache/incubator-netbeans/pull/158#discussion_r145965045 ## File path: css.editor/src/org/netbeans/modules/css/editor/module/main/browsers/webkit.properties ##

[GitHub] javydreamercsw commented on a change in pull request #158: [NETBEANS-54] Module Review css.editor

javydreamercsw commented on a change in pull request #158: [NETBEANS-54] Module Review css.editor URL: https://github.com/apache/incubator-netbeans/pull/158#discussion_r145965352 ## File path: css.editor/src/org/netbeans/modules/css/resources/CssExample ## @@ -1,3 +1,21 @@

[GitHub] geertjanw commented on issue #167: Renamed AutoupdateInfoParserTest class to exclude it from Test Suite run as it depends on deleted resource

geertjanw commented on issue #167: Renamed AutoupdateInfoParserTest class to exclude it from Test Suite run as it depends on deleted resource URL: https://github.com/apache/incubator-netbeans/pull/167#issuecomment-338207309 Looks good.

Enabling services

Why are free services like the following not enabled on the GitHub repository? I find they greatly useful. - Codecov - Travis CI and/or Appveyor - CodeReviewHub I use them in most of

[GitHub] geertjanw closed pull request #167: Renamed AutoupdateInfoParserTest class to exclude it from Test Suite run as it depends on deleted resource

geertjanw closed pull request #167: Renamed AutoupdateInfoParserTest class to exclude it from Test Suite run as it depends on deleted resource URL: https://github.com/apache/incubator-netbeans/pull/167 This is a PR merged from a forked repository. As GitHub hides the original diff on mer

[GitHub] javydreamercsw commented on issue #130: Cache external binaries downloaded from maven in NetBeans' cache.

javydreamercsw commented on issue #130: Cache external binaries downloaded from maven in NetBeans' cache. URL: https://github.com/apache/incubator-netbeans/pull/130#issuecomment-338204262 I guess I would ask what's the reason for the .hgexternalbinaries name? It's not straightforward at a

[GitHub] junichi11 commented on a change in pull request #158: [NETBEANS-54] Module Review css.editor

junichi11 commented on a change in pull request #158: [NETBEANS-54] Module Review css.editor URL: https://github.com/apache/incubator-netbeans/pull/158#discussion_r145956643 ## File path: css.editor/src/org/netbeans/modules/css/resources/CssExample ## @@ -1,3 +1,21 @@ +/**

[GitHub] junichi11 commented on a change in pull request #158: [NETBEANS-54] Module Review css.editor

junichi11 commented on a change in pull request #158: [NETBEANS-54] Module Review css.editor URL: https://github.com/apache/incubator-netbeans/pull/158#discussion_r145956232 ## File path: css.editor/src/org/netbeans/modules/css/resources/CascadeStyleSheet.css.template ##

[GitHub] junichi11 commented on a change in pull request #158: [NETBEANS-54] Module Review css.editor

junichi11 commented on a change in pull request #158: [NETBEANS-54] Module Review css.editor URL: https://github.com/apache/incubator-netbeans/pull/158#discussion_r145955111 ## File path: css.editor/src/org/netbeans/modules/css/editor/module/main/browsers/webkit.properties ###

[GitHub] sarveshkesharwani opened a new pull request #168: adding insane dependency for tests in keyring.fallback

sarveshkesharwani opened a new pull request #168: adding insane dependency for tests in keyring.fallback URL: https://github.com/apache/incubator-netbeans/pull/168 Adding insane dependency for the failing tests in FallbackProviderTest.java and MasterPasswordEncryptionTest.java in keyring.f

[GitHub] arusinha opened a new pull request #167: Renamed AutoupdateInfoParserTest class to exclude it from Test Suite run as it depends on deleted resource

arusinha opened a new pull request #167: Renamed AutoupdateInfoParserTest class to exclude it from Test Suite run as it depends on deleted resource URL: https://github.com/apache/incubator-netbeans/pull/167 Renamed TestFile AutoupdateInfoParserTest to AutoupdateInfoParserTestDisabled

[GitHub] arusinha commented on issue #156: Renamed AutoupdateInfoParserTest class to exclude it from Test Suite run as it depends on deleted resource

arusinha commented on issue #156: Renamed AutoupdateInfoParserTest class to exclude it from Test Suite run as it depends on deleted resource URL: https://github.com/apache/incubator-netbeans/pull/156#issuecomment-338172587 There is a conflict due to a file not present in Incubator reposito

[GitHub] arusinha closed pull request #156: Renamed AutoupdateInfoParserTest class to exclude it from Test Suite run as it depends on deleted resource

arusinha closed pull request #156: Renamed AutoupdateInfoParserTest class to exclude it from Test Suite run as it depends on deleted resource URL: https://github.com/apache/incubator-netbeans/pull/156 This is a PR merged from a forked repository. As GitHub hides the original diff on merge

Payback Time

Hi all As a long time user of Netbeans (since Version 3.5) and occasional NetCat contributor I thought time had come for me contribute a little more time to the continued success of this excellent product without which I could not have been so productive. Located in the Peak District National

Re: Payback Time

Welcome David! I don't believe it's too late to help with the IP clearance work. We still haven't released the code yet! We still have to review the external libraries and add Maven coordinates for them. There's also some code that needs to be rewritten since it's GPL. Search for example "GPL"

Payback Time

Hi all As a long time user of Netbeans (since Version 3.5) and occasional NetCat contributor I thought time had come for me contribute a little more time to the continued success of this excellent product without which I could not have been so productive. Located in the Peak District National

[mentors] please vote on the pending release

Hi NetBeans incubation mentors, Please vote on the first release that's being voted on at general@incubator.a.o : https://lists.apache.org/thread.html/b29e1081b3210b50b2889f84e3a73132aeebd2ea2be9f047280441c8@%3Cgeneral.incubator.apache.org%3E I'll be unable to help here next week, hopefully some