[GitHub] geertjanw commented on issue #129: Sort rat excludes alphabetically

geertjanw commented on issue #129: Sort rat excludes alphabetically URL: https://github.com/apache/incubator-netbeans/pull/129#issuecomment-338882553 One reason I?d like this one to be merged is that I have unit test data to be added to the Rat excludes (from schema2beans and java.hints)

[GitHub] junichi11 commented on issue #153: [NETBEANS-54] Module Review maven.osgi

junichi11 commented on issue #153: [NETBEANS-54] Module Review maven.osgi URL: https://github.com/apache/incubator-netbeans/pull/153#issuecomment-338873970 I'll close this. see https://github.com/emilianbold/incubator-netbeans/pull/325

[GitHub] junichi11 closed pull request #153: [NETBEANS-54] Module Review maven.osgi

junichi11 closed pull request #153: [NETBEANS-54] Module Review maven.osgi URL: https://github.com/apache/incubator-netbeans/pull/153 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

Preprocessing external binaries

Hi all, From time to time we need to patch external sources to generate external binaries [1]. In other situations we may need to download a Maven binary and then extract a part of it to compile against [2]. And for some other modules the Maven binaries are signed with a digital

[GitHub] vieiro commented on issue #175: [NETBEANS-54] Module Review extexecution.process (patch)

vieiro commented on issue #175: [NETBEANS-54] Module Review extexecution.process (patch) URL: https://github.com/apache/incubator-netbeans/pull/175#issuecomment-338864765 Thanks, Matthias, for your review! :-) This is an

[GitHub] junichi11 commented on issue #174: Add a license header template for new files of NetBeans modules

junichi11 commented on issue #174: Add a license header template for new files of NetBeans modules URL: https://github.com/apache/incubator-netbeans/pull/174#issuecomment-338854190 Exclude license-*.txt from rat, then, I'll merge this.

[GitHub] junichi11 commented on issue #129: Sort rat excludes alphabetically

junichi11 commented on issue #129: Sort rat excludes alphabetically URL: https://github.com/apache/incubator-netbeans/pull/129#issuecomment-338853778 I've fixed. #163 and https://github.com/emilianbold/incubator-netbeans/pull/324 have excludes. But it seems that they already conflict. If

[GitHub] matthiasblaesing opened a new pull request #181: [NETBEANS-54] Module Review libs.osgi (followup)

matthiasblaesing opened a new pull request #181: [NETBEANS-54] Module Review libs.osgi (followup) URL: https://github.com/apache/incubator-netbeans/pull/181 Maven central does not hold the original netbeans artifact osgi.cmpn-4.2, but a superset of that: org.osgi

[GitHub] geertjanw commented on issue #129: Sort rat excludes alphabetically

geertjanw commented on issue #129: Sort rat excludes alphabetically URL: https://github.com/apache/incubator-netbeans/pull/129#issuecomment-338742982 I don't think there are any PR's right now that have excludes, or am I wrong? If true, can we merge this one, have more to add to it,

Re: Broken build from org-netbeans-modules-git.jar?

Never mind. I did 'ant clean' and then did the 'ant' again, that may have cleared out the problem, everything builds fine now. Gj On Mon, Oct 23, 2017 at 2:23 PM, Geertjan Wielenga < geertjan.wiele...@googlemail.com> wrote: > > Hi all, > > Build seems to be broken, at least, when I run Ant in

Re: [GitHub] struberg commented on issue #178: [NETBEANS-54] Module Review schema2beans

Yes. Will do that. On Mon, Oct 23, 2017 at 6:24 PM, GitBox wrote: > struberg commented on issue #178: [NETBEANS-54] Module Review schema2beans > URL: https://github.com/apache/incubator-netbeans/pull/178# > issuecomment-338715597 > > >perfectly fine for me. Do we want to

[GitHub] struberg commented on issue #178: [NETBEANS-54] Module Review schema2beans

struberg commented on issue #178: [NETBEANS-54] Module Review schema2beans URL: https://github.com/apache/incubator-netbeans/pull/178#issuecomment-338715597 perfectly fine for me. Do we want to create a low-prio ticket for it so we can better track it?

[GitHub] geertjanw commented on issue #178: [NETBEANS-54] Module Review schema2beans

geertjanw commented on issue #178: [NETBEANS-54] Module Review schema2beans URL: https://github.com/apache/incubator-netbeans/pull/178#issuecomment-338715094 I would suggest not for the first incubator release of Apache NetBeans (incubating). I.e., for the first release, I propose we

Re: Review of java.hints/test/unit/data/

Right. OK. Would be great to update the Rat report for the unit test files in schema2beans and java.hints. Are the tests in java.hints.declarative also impacted? https://github.com/apache/incubator-netbeans/pull/180/commits/15b8f859cd3b2dccba017ae7b13b542666579953 Gj On Mon, Oct 23, 2017 at

Re: Review of java.hints/test/unit/data/

Some golden files include line numbers, like: java.hints/test/unit/data/goldenfiles/org/netbeans/modules/java/hints/infrastructure/ErrorHintsProviderTest/testShortErrors2.pass Other contain a modified copy of an input file, like:

Re: Review of java.hints/test/unit/data/

What's the reason the test will fail if headers are added? Gj On Mon, Oct 23, 2017 at 5:59 PM, Geertjan Wielenga < geertjan.wiele...@googlemail.com> wrote: > It seems to me that files in java.hints/test/unit/data/ are all "test data > for which the addition of a source header would cause the

[GitHub] struberg commented on issue #178: [NETBEANS-54] Module Review schema2beans

struberg commented on issue #178: [NETBEANS-54] Module Review schema2beans URL: https://github.com/apache/incubator-netbeans/pull/178#issuecomment-338711153 Or fix the test or the tested code to be ok with that header? This

Re: Apache Release 1.5 of HTML/Java API is approved - what is next?

Hi Jaroslav, all, Really great news! Congratulations to everybody involved. Regards Toni Von: im Auftrag von Jaroslav Tulach Datum: KW 43,Montag, 23. Oktober 2017 um 15:00 An:

[GitHub] junichi11 commented on issue #178: [NETBEANS-54] Module Review schema2beans

junichi11 commented on issue #178: [NETBEANS-54] Module Review schema2beans URL: https://github.com/apache/incubator-netbeans/pull/178#issuecomment-338710036 I also think so. Test data are already excluded in some modules because tests fail, probably.

Re: Review of java.hints/test/unit/data/

It seems to me that files in java.hints/test/unit/data/ are all "test data for which the addition of a source header would cause the tests to fail" -- i.e., these do not require a license header ( https://www.apache.org/legal/src-headers.html). I think these should be included in the Rat report

[GitHub] geertjanw commented on issue #178: [NETBEANS-54] Module Review schema2beans

geertjanw commented on issue #178: [NETBEANS-54] Module Review schema2beans URL: https://github.com/apache/incubator-netbeans/pull/178#issuecomment-338707204 It seems to me that these are all "test data for which the addition of a source header would cause the tests to fail" -- i.e.,

Re: Support for (Java) Pattern Matching

On Sun, Oct 22, 2017 at 10:00 PM, Neil C Smith < neilcsmith@googlemail.com> wrote: > Hi, > > On Sat, 21 Oct 2017, 15:41 Jan Lahoda, wrote: > > > > > I guess I could live with this (although it leaves it unclear how new > > feature branches would be created), but it feels

Re: Apache Release 1.5 of HTML/Java API is approved - what is next?

Hurray and congratulations! Gj On Mon, 23 Oct 2017 at 15:01, Jaroslav Tulach wrote: > Hi. > The source release is approved. The source ZIP and associated files are > currently at: > https://dist.apache.org/repos/dist/dev/incubator/netbeans/ > shall we upload them

[GitHub] vieiro commented on issue #172: [NETBEANS-54] Module Review o.apache.xml.resolver

vieiro commented on issue #172: [NETBEANS-54] Module Review o.apache.xml.resolver URL: https://github.com/apache/incubator-netbeans/pull/172#issuecomment-338665582 Mmm... I think this is a very simple use case that just compiles a jar file, not enough for a generalization?. I

Re: Support for (Java) Pattern Matching

I'd like to provide some mentor guidance to this discussion. As an Apache project we need to ensure collaboration and provenance are served and supported properly. With that in mind, new feature development, and for that matter *all* development should allow and enable collaboration by the

[GitHub] junichi11 commented on issue #178: [NETBEANS-54] Module Review schema2beans

junichi11 commented on issue #178: [NETBEANS-54] Module Review schema2beans URL: https://github.com/apache/incubator-netbeans/pull/178#issuecomment-338620579 In my environment, Before: 24 tests succeed, 8 tests fail After: 16 tests succeed, 16 tests fail So, perhaps, there are

[GitHub] junichi11 commented on issue #178: [NETBEANS-54] Module Review schema2beans

junichi11 commented on issue #178: [NETBEANS-54] Module Review schema2beans URL: https://github.com/apache/incubator-netbeans/pull/178#issuecomment-338651619 I attach results as screenshots. Sorry in Japanese UI. Before:

Apache Release 1.5 of HTML/Java API is approved - what is next?

Hi. The source release is approved. The source ZIP and associated files are currently at: https://dist.apache.org/repos/dist/dev/incubator/netbeans/ shall we upload them somewhere else? I have pushed the changes into the Git repository, and tagged them release-1.5:

[GitHub] JaroslavTulach commented on a change in pull request #172: [NETBEANS-54] Module Review o.apache.xml.resolver

JaroslavTulach commented on a change in pull request #172: [NETBEANS-54] Module Review o.apache.xml.resolver URL: https://github.com/apache/incubator-netbeans/pull/172#discussion_r146254955 ## File path: o.apache.xml.resolver/build.xml ## @@ -20,5 +20,43 @@ --> +

Re: Review of java.hints/test/unit/data/

On Mon, Oct 23, 2017 at 12:41 PM, Geertjan Wielenga < geertjan.wiele...@googlemail.com> wrote: > Hi all, > > There's about 230 unlicensed Java source files in > java.hints/test/unit/data. > > Before I manually add Apache licenses to all of them manually, is there a > reason why these weren't

Broken build from org-netbeans-modules-git.jar?

Hi all, Build seems to be broken, at least, when I run Ant in main I see this: Caught while processing /Users/geertjanwielenga/main/incubator-netbeans/nbbuild/netbeans/ide/modules/org-netbeans-modules-git.jar: java.util.zip.ZipException: zip file is empty Thanks, Gj

[GitHub] geertjanw commented on issue #178: [NETBEANS-54] Module Review schema2beans

geertjanw commented on issue #178: [NETBEANS-54] Module Review schema2beans URL: https://github.com/apache/incubator-netbeans/pull/178#issuecomment-338635407 Can you see which ones fail? I don't see a difference in terms of failed tests.

[GitHub] juneau001 commented on issue #117: [NETBEANS-54] Modeule Review j2ee.persistence

juneau001 commented on issue #117: [NETBEANS-54] Modeule Review j2ee.persistence URL: https://github.com/apache/incubator-netbeans/pull/117#issuecomment-338632856 I've expanded the zip file and committed the changes. Let me know if I need to modify the license headers after the RAT

[GitHub] junichi11 commented on issue #178: [NETBEANS-54] Module Review schema2beans

junichi11 commented on issue #178: [NETBEANS-54] Module Review schema2beans URL: https://github.com/apache/incubator-netbeans/pull/178#issuecomment-338620579 In my environment, Before: 24 tests success, 8 tests fail After: 16 tests success, 16 tests fail So, perhaps, there are

Review of java.hints/test/unit/data/

Hi all, There's about 230 unlicensed Java source files in java.hints/test/unit/data. Before I manually add Apache licenses to all of them manually, is there a reason why these weren't licensed to begin with, i.e., will tests fail if a license is added to the Java source files? Thanks, Gj

[GitHub] struberg commented on issue #178: [NETBEANS-54] Module Review schema2beans

struberg commented on issue #178: [NETBEANS-54] Module Review schema2beans URL: https://github.com/apache/incubator-netbeans/pull/178#issuecomment-338618680 Weird, the 2 commits just add ALv2 headers to a bunch of files.

[GitHub] geertjanw commented on issue #178: [NETBEANS-54] Module Review schema2beans

geertjanw commented on issue #178: [NETBEANS-54] Module Review schema2beans URL: https://github.com/apache/incubator-netbeans/pull/178#issuecomment-338618636 Failed unit tests increase because of this pull request? This is

[GitHub] junichi11 commented on issue #178: [NETBEANS-54] Module Review schema2beans

junichi11 commented on issue #178: [NETBEANS-54] Module Review schema2beans URL: https://github.com/apache/incubator-netbeans/pull/178#issuecomment-338618424 It seems that failed unit tests increase. This is an automated

Re: Review of java.hints.declarative

Done: https://github.com/apache/incubator-netbeans/pull/180 Gj On Sun, Oct 22, 2017 at 11:44 PM, Geertjan Wielenga < geertjan.wiele...@googlemail.com> wrote: > Great, thanks, will implement these insights. > > Gj > > On Sun, Oct 22, 2017 at 11:12 PM, Jan Lahoda wrote: > >>

[GitHub] geertjanw opened a new pull request #180: [NETBEANS-54] Module Review java.hints.declarative

geertjanw opened a new pull request #180: [NETBEANS-54] Module Review java.hints.declarative URL: https://github.com/apache/incubator-netbeans/pull/180 This is an automated message from the Apache Git Service. To respond to

[GitHub] struberg commented on issue #178: [NETBEANS-54] Module Review schema2beans

struberg commented on issue #178: [NETBEANS-54] Module Review schema2beans URL: https://github.com/apache/incubator-netbeans/pull/178#issuecomment-338614332 +1 to apply it. This is an automated message from the Apache Git

[RESULT]: [VOTE] Release 1.5 of NetBeans HTML/Java API

The vote started four days ago, so it is time to announce the result: Approved. Bertrand Delacretaz: +1 John D. Ament: Here's my +1 to release. Mark Struberg: +1 IPMC binding ... Ate Douma: +1 (binding) No vote against, four binding approvals, plus one extra: Wade Chandler: +1 Thanks for

[GitHub] rosslamont commented on issue #163: [NETBEANS-54] Module Review maven.indexer

rosslamont commented on issue #163: [NETBEANS-54] Module Review maven.indexer URL: https://github.com/apache/incubator-netbeans/pull/163#issuecomment-338583991 OK, I've pushed a squashed version with - copyright notice in the patch - exclusion for NOTICE-patched-indexer-core-6.0.0"

[GitHub] rosslamont commented on issue #163: [NETBEANS-54] Module Review maven.indexer

rosslamont commented on issue #163: [NETBEANS-54] Module Review maven.indexer URL: https://github.com/apache/incubator-netbeans/pull/163#issuecomment-338578153 actually on second thoughts I should add a copyright notice to the patch, so hold off merging.

[GitHub] rosslamont commented on issue #163: [NETBEANS-54] Module Review maven.indexer

rosslamont commented on issue #163: [NETBEANS-54] Module Review maven.indexer URL: https://github.com/apache/incubator-netbeans/pull/163#issuecomment-338573634 No worries Geertjan. Everything else is done. I'll log an issue regarding the patch and update the Module Review doc , but you

[GitHub] rosslamont commented on issue #163: [NETBEANS-54] Module Review maven.indexer

rosslamont commented on issue #163: [NETBEANS-54] Module Review maven.indexer URL: https://github.com/apache/incubator-netbeans/pull/163#issuecomment-338573634 No worries Geertjan. Everything else is done. I'll log an issue regarding the patch and update the APIReview doc , but you can

[GitHub] junichi11 commented on issue #158: [NETBEANS-54] Module Review css.editor

junichi11 commented on issue #158: [NETBEANS-54] Module Review css.editor URL: https://github.com/apache/incubator-netbeans/pull/158#issuecomment-338557085 Just merged license header parts. Thank you for working on this!

[GitHub] junichi11 closed pull request #158: [NETBEANS-54] Module Review css.editor

junichi11 closed pull request #158: [NETBEANS-54] Module Review css.editor URL: https://github.com/apache/incubator-netbeans/pull/158 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] geertjanw commented on issue #163: [NETBEANS-54] Module Review maven.indexer

geertjanw commented on issue #163: [NETBEANS-54] Module Review maven.indexer URL: https://github.com/apache/incubator-netbeans/pull/163#issuecomment-338555667 I think I'd leave them unchanged for the moment, i.e., we do not have to get everything from Maven, right now this minute. Do as