[GitHub] jlahoda opened a new pull request #268: Run verify libs and licenses and rat for platform for pull requests

2017-11-09 Thread GitBox
jlahoda opened a new pull request #268: Run verify libs and licenses and rat for platform for pull requests URL: https://github.com/apache/incubator-netbeans/pull/268 (Let's see if it works.) This is an automated message from

[GitHub] sarveshkesharwani commented on issue #248: adding crlf characters for the failing tests in api.templates

2017-11-09 Thread GitBox
sarveshkesharwani commented on issue #248: adding crlf characters for the failing tests in api.templates URL: https://github.com/apache/incubator-netbeans/pull/248#issuecomment-343381251 @junichi11 I haven't sent an iCLA yet, but I am definitely going to continue contributing to Apache N

[GitHub] junichi11 closed pull request #255: [NETBEANS-54] Module Review api.templates

2017-11-09 Thread GitBox
junichi11 closed pull request #255: [NETBEANS-54] Module Review api.templates URL: https://github.com/apache/incubator-netbeans/pull/255 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] geertjanw commented on issue #266: For CDDL+GPL dual licensed 'external' binaries, picking up CDDL. veri?

2017-11-09 Thread GitBox
geertjanw commented on issue #266: For CDDL+GPL dual licensed 'external' binaries, picking up CDDL. veri? URL: https://github.com/apache/incubator-netbeans/pull/266#issuecomment-343317837 Looks good to me. Ate will check once we do another attempt at a release, by looking at the outcome o

[GitHub] geertjanw closed pull request #266: For CDDL+GPL dual licensed 'external' binaries, picking up CDDL. veri?

2017-11-09 Thread GitBox
geertjanw closed pull request #266: For CDDL+GPL dual licensed 'external' binaries, picking up CDDL. veri? URL: https://github.com/apache/incubator-netbeans/pull/266 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sak

[GitHub] geertjanw closed pull request #265: [NETBEANS-128] Not adding IDE launchers when building only the platfo?

2017-11-09 Thread GitBox
geertjanw closed pull request #265: [NETBEANS-128] Not adding IDE launchers when building only the platfo? URL: https://github.com/apache/incubator-netbeans/pull/265 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sak

[GitHub] geertjanw commented on issue #265: [NETBEANS-128] Not adding IDE launchers when building only the platfo?

2017-11-09 Thread GitBox
geertjanw commented on issue #265: [NETBEANS-128] Not adding IDE launchers when building only the platfo? URL: https://github.com/apache/incubator-netbeans/pull/265#issuecomment-343317467 Merging. This is an automated messag

[GitHub] jlahoda opened a new pull request #267: [NETBEANS-129] Adding infrastructure to include README in platform source and binary zip.

2017-11-09 Thread GitBox
jlahoda opened a new pull request #267: [NETBEANS-129] Adding infrastructure to include README in platform source and binary zip. URL: https://github.com/apache/incubator-netbeans/pull/267 Please note that this is depending on: https://github.com/apache/incubator-netbeans/pull/265

Re: [GitHub] dschoorl opened a new pull request #2: Add Automatic-Module-Name attribute to manifest files

2017-11-09 Thread Dave Schoorl
@Jaroslav Tulach: I manually checked some of the manifest files if the new attribute was present and contained the expected value. And the existing tests succeed after running mvn clean package on my system. However, I don't know how to manually run/test the software or what it does (sorry). May

[GitHub] dschoorl opened a new pull request #2: Add Automatic-Module-Name attribute to manifest files

2017-11-09 Thread GitBox
dschoorl opened a new pull request #2: Add Automatic-Module-Name attribute to manifest files URL: https://github.com/apache/incubator-netbeans-html4j/pull/2 This change will provide the user with a predictable automatic module name on a JDK9 module path, that is expected to be unique. T

[GitHub] jlahoda opened a new pull request #266: For CDDL+GPL dual licensed 'external' binaries, picking up CDDL. veri?

2017-11-09 Thread GitBox
jlahoda opened a new pull request #266: For CDDL+GPL dual licensed 'external' binaries, picking up CDDL. veri? URL: https://github.com/apache/incubator-netbeans/pull/266 ?fy-libs-and-licenses should now only accept GPL if it is with CPE and compile-time/optional only. Ate, could you

[GitHub] emilianbold commented on issue #3: NETBEANS-59 - Document split actions

2017-11-09 Thread GitBox
emilianbold commented on issue #3: NETBEANS-59 - Document split actions URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-343273886 But if you instantiate the action manually with `new SplitDocumentVerticallyAction` how is the shortcut set? Maybe I'm missing something r

[GitHub] jlahoda closed pull request #263: Removing dependency on jsearch

2017-11-09 Thread GitBox
jlahoda closed pull request #263: Removing dependency on jsearch URL: https://github.com/apache/incubator-netbeans/pull/263 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

Re: Reproducible NetBeans builds [WAS: Re: HTML/Java checksums was: Release Apache NetBeans 9.0 Alpha (incubating)]

2017-11-09 Thread Neil C Smith
On Thu, Nov 9, 2017 at 6:56 PM Victor Williams Stafusa da Silva < victorwssi...@gmail.com> wrote: > Not sure if someone already mentioned or acknowledged that, but let's give > a look at this: > > > http://zlika.github.io/presentations/devoxx_fr_2016/reproducible-builds/slides_en.html > > Thanks.

[GitHub] geertjanw commented on issue #265: [NETBEANS-128] Not adding IDE launchers when building only the platfo?

2017-11-09 Thread GitBox
geertjanw commented on issue #265: [NETBEANS-128] Not adding IDE launchers when building only the platfo? URL: https://github.com/apache/incubator-netbeans/pull/265#issuecomment-343261654 +1 great This is an automated messag

[GitHub] jlahoda opened a new pull request #265: [NETBEANS-128] Not adding IDE launchers when building only the platfo?

2017-11-09 Thread GitBox
jlahoda opened a new pull request #265: [NETBEANS-128] Not adding IDE launchers when building only the platfo? URL: https://github.com/apache/incubator-netbeans/pull/265 ?rm (only platform/lib/nbexec platform launchers exist). "ant tryme" should still work, by invoking the nbexec. -

Re: Reproducible NetBeans builds [WAS: Re: HTML/Java checksums was: Release Apache NetBeans 9.0 Alpha (incubating)]

2017-11-09 Thread Emilian Bold
I assume https://github.com/emilianbold/reproducible-nextbeans and  https://nextbeans.com/reproducible.html are known already. --emi

Re: [JIRA-admin] Re: JIRA permission: Can't resolve issues

2017-11-09 Thread Geertjan Wielenga
Excellent. Thanks John McDonnell for getting it to work. Gj On Thu, Nov 9, 2017 at 7:51 PM, Matthias Bläsing wrote: > Hi John, > > Am Mittwoch, den 08.11.2017, 21:35 + schrieb John McDonnell: > > > > Sorry for the delay, I did some digging this evening and it not just > > the close permis

Re: [JIRA-admin] Re: JIRA permission: Can't resolve issues

2017-11-09 Thread Matthias Bläsing
Hi John, Am Mittwoch, den 08.11.2017, 21:35 + schrieb John McDonnell: > > Sorry for the delay, I did some digging this evening and it not just > the close permission needed in order to close a JIRA ticket... > > Please, can you give this a shot again? > thank you - it worked beautifully. I

Re: Reproducible NetBeans builds [WAS: Re: HTML/Java checksums was: Release Apache NetBeans 9.0 Alpha (incubating)]

2017-11-09 Thread Victor Williams Stafusa da Silva
Not sure if someone already mentioned or acknowledged that, but let's give a look at this: http://zlika.github.io/presentations/devoxx_fr_2016/reproducible-builds/slides_en.html Victor Williams Stafusa da Silva 2017-11-09 16:30 GMT-02:00 Antonio : > El 09/11/17 a las 13:36, Emilian Bold escribi

[GitHub] matthiasblaesing closed pull request #254: [NETBEANS-68] Fix NULL handling after fix in 1d362fa77521762a9af99792620414086b868f76

2017-11-09 Thread GitBox
matthiasblaesing closed pull request #254: [NETBEANS-68] Fix NULL handling after fix in 1d362fa77521762a9af99792620414086b868f76 URL: https://github.com/apache/incubator-netbeans/pull/254 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displ

Re: Reproducible NetBeans builds [WAS: Re: HTML/Java checksums was: Release Apache NetBeans 9.0 Alpha (incubating)]

2017-11-09 Thread Antonio
El 09/11/17 a las 13:36, Emilian Bold escribió: Every built of a jar will produce a different sha, so you're assessment is correct. Mmm that would depend on how you checksum the jar file. I imagine that we could checksum all the contents of the jar file _except_ for specific lines in th

[GitHub] vieiro commented on issue #263: Removing dependency on jsearch

2017-11-09 Thread GitBox
vieiro commented on issue #263: Removing dependency on jsearch URL: https://github.com/apache/incubator-netbeans/pull/263#issuecomment-343243939 Your word is my command! I hope I didn't break anything! This is an automated me

Re: Reproducible NetBeans builds [WAS: Re: HTML/Java checksums was: Release Apache NetBeans 9.0 Alpha (incubating)]

2017-11-09 Thread Emilian Bold
Then again a lot of the Java world uses either Ant or Maven both of which don't support reproducible builds or have any visible interest in it. --emi > Original Message >Subject: Re: Reproducible NetBeans builds [WAS: Re: HTML/Java checksums was: >Release Apache NetBeans 9.0 Al

Re: Alternative JavaHelp viewer was: Give JavaHelp a chance!

2017-11-09 Thread Oliver Rettig
Hi, are there better alternatives for JavaHelp for usage of HelpSets in netbeans- platform-based apps? For existing platform apps migrating to version 9 it should be easy to add the old JavaHelpSystem sice there is established an alternative to migrate, isnt it? best regards Oliver > Hello Jan.

[GitHub] jlahoda commented on issue #263: Removing dependency on jsearch

2017-11-09 Thread GitBox
jlahoda commented on issue #263: Removing dependency on jsearch URL: https://github.com/apache/incubator-netbeans/pull/263#issuecomment-343214973 Nice! I'd suggest to also remove the apisupport.harness/external/jsearch-2.0_05-license.txt, and run "ant -Dcluster.config=platform verify-libs

Re: [JIRA-admin] Re: JIRA permission: Can't resolve issues

2017-11-09 Thread John McDonnell
It seems to be working now, but if you have any issues log out and log back in again. Regards John On 9 November 2017 at 10:00, Eric Barboni wrote: > Hi John, > > Its issue https://issues.apache.org/jira/browse/NETBEANS-127 > > Regards > > Eric > -Message d'origine- > De : John McDonne

[GitHub] sdedic closed pull request #257: Backport of jtulach's fixes made after Apr 22, 2017

2017-11-09 Thread GitBox
sdedic closed pull request #257: Backport of jtulach's fixes made after Apr 22, 2017 URL: https://github.com/apache/incubator-netbeans/pull/257 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As t

Re: Reproducible NetBeans builds [WAS: Re: HTML/Java checksums was: Release Apache NetBeans 9.0 Alpha (incubating)]

2017-11-09 Thread Jaroslav Tulach
2017-11-09 13:36 GMT+01:00 Emilian Bold : > >> Every built of a jar will produce a different sha, so you're assessment > >> is correct. > > Another reason NetBeans builds should be reproducible. > > Rather amazed Apache does not have a foundation-wide move like Debian's > https://wiki.debian.org/R

[GitHub] junichi11 opened a new pull request #264: Check whether line endings are LF with Travis CI

2017-11-09 Thread GitBox
junichi11 opened a new pull request #264: Check whether line endings are LF with Travis CI URL: https://github.com/apache/incubator-netbeans/pull/264 - Change line endings of a few files to LF. - Add a script for Travis CI to check line endings. -

[GitHub] Chris2011 commented on issue #3: NETBEANS-59 - Document split actions

2017-11-09 Thread GitBox
Chris2011 commented on issue #3: NETBEANS-59 - Document split actions URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-343151957 > It hard to review a patch that has +320 line and ?101 lines in a single commit. This is what I didn't get yet, I didn't get your poi

[GitHub] Chris2011 commented on issue #3: NETBEANS-59 - Document split actions

2017-11-09 Thread GitBox
Chris2011 commented on issue #3: NETBEANS-59 - Document split actions URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-343151957 > It hard to review a patch that has +320 line and ?101 lines in a single commit. This is what I didn't get yet, I didn't get your point o

[GitHub] emilianbold commented on issue #3: NETBEANS-59 - Document split actions

2017-11-09 Thread GitBox
emilianbold commented on issue #3: NETBEANS-59 - Document split actions URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-343150815 I wrote a rather long message in September. Does nothing I said there make sense? It hard to review a patch that has +320 line and ?

Using the Autoupdate libraries in a non-Platform app (specifically, Apache JMeter)

2017-11-09 Thread Emilian Bold
Hello, Apache JMeter does not have a Plugin Manager and I was thinking of making one for them. They use no module system, just plain Java JARs. So, I figured a first step would be to transplant the NetBeans Platform autoupdate UI and impl, except with a simpler filesystem layout. Does this se

[GitHub] Chris2011 commented on issue #3: NETBEANS-59 - Document split actions

2017-11-09 Thread GitBox
Chris2011 commented on issue #3: NETBEANS-59 - Document split actions URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-343148391 Most of the code, was only moved out to separated the code and created actions, I only created one base class by my self. You only mean that

[GitHub] emilianbold commented on issue #3: NETBEANS-59 - Document split actions

2017-11-09 Thread GitBox
emilianbold commented on issue #3: NETBEANS-59 - Document split actions URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-343147500 @Chris2011 I don't see any new commits based on my comment from Sep 23rd. -

Re: Give JavaHelp a chance! was: Release Apache NetBeans 9.0 Alpha (incubating)

2017-11-09 Thread Emilian Bold
> All I am asking: Please give JavaHelp a chance! I believe we might figure this out and get JavaHelp under a CDDL license, ie. something Apache-compatible. That being said, JavaHelp seems to be even more ignored than Swing, so it's not a really great library to push forward for ourselves or o

Reproducible NetBeans builds [WAS: Re: HTML/Java checksums was: Release Apache NetBeans 9.0 Alpha (incubating)]

2017-11-09 Thread Emilian Bold
>> Every built of a jar will produce a different sha, so you're assessment >> is correct. Another reason NetBeans builds should be reproducible. Rather amazed Apache does not have a foundation-wide move like Debian's https://wiki.debian.org/ReproducibleBuilds --emi

[GitHub] junichi11 commented on issue #248: adding crlf characters for the failing tests in api.templates

2017-11-09 Thread GitBox
junichi11 commented on issue #248: adding crlf characters for the failing tests in api.templates URL: https://github.com/apache/incubator-netbeans/pull/248#issuecomment-343136587 @sarveshkesharwani BTW, Did you send iCLA[1]? (I'm not sure whether this change requires it.) If no and you ar

jsearch dependency (was Re: [VOTE] Release Apache NetBeans 9.0 Alpha (incubating))

2017-11-09 Thread Antonio
El 08/11/17 a las 21:36, Jan Lahoda escribió: > [...] -delete inclusion of jsearch.jar in apisupport.harness (should be trivial by itself) Jan, will something like https://github.com/apache/incubator-netbeans/pull/263 do? Cheers, Antonio

[GitHub] vieiro opened a new pull request #263: Removing dependency on jsearch

2017-11-09 Thread GitBox
vieiro opened a new pull request #263: Removing dependency on jsearch URL: https://github.com/apache/incubator-netbeans/pull/263 - Until the dependency on JavaHelp is ruled out. This is an automated message from the Apache G

Re: [RESULT]: [VOTE] Release 1.5 of NetBeans HTML/Java API

2017-11-09 Thread Dave Schoorl
Ah, I see, you are right. For most artifacts, a more complex filename is used, like “net.java.html.boot”. xhr4j and ko4j being the exceptions. Should we use the maven coordinates (groupId.artifactId) for these as Automatic-Module-Name attribute in their manifest files? Dave > Op 9 november 201

[GitHub] sarveshkesharwani commented on issue #248: adding crlf characters for the failing tests in api.templates

2017-11-09 Thread GitBox
sarveshkesharwani commented on issue #248: adding crlf characters for the failing tests in api.templates URL: https://github.com/apache/incubator-netbeans/pull/248#issuecomment-343114770 @junichi11 That makes sense. Done. Th

Re: [GitHub] lbruun commented on issue #251: [NETBEANS-126] Re-instate browser icons

2017-11-09 Thread Geertjan Wielenga
If you want mentor interaction, start a new thread and put [mentors] tag at the start of your subject line. Gj On Thu, Nov 9, 2017 at 11:19 AM, GitBox wrote: > lbruun commented on issue #251: [NETBEANS-126] Re-instate browser icons > URL: https://github.com/apache/incubator-netbeans/pull/251# >

[GitHub] lbruun commented on issue #251: [NETBEANS-126] Re-instate browser icons

2017-11-09 Thread GitBox
lbruun commented on issue #251: [NETBEANS-126] Re-instate browser icons URL: https://github.com/apache/incubator-netbeans/pull/251#issuecomment-343110052 @geertjanw. Tracked in [LEGAL-343](https://issues.apache.org/jira/browse/LEGAL-343). If this is wrong procedure, I'll withdraw LEGAL-

RE: [JIRA-admin] Re: JIRA permission: Can't resolve issues

2017-11-09 Thread Eric Barboni
Hi John, Its issue https://issues.apache.org/jira/browse/NETBEANS-127 Regards Eric -Message d'origine- De : John McDonnell [mailto:mcdonnell.j...@gmail.com] Envoyé : jeudi 9 novembre 2017 10:17 À : dev@netbeans.incubator.apache.org Objet : Re: [JIRA-admin] Re: JIRA permission: Can't res

[GitHub] Chris2011 commented on issue #251: [NETBEANS-126] Re-instate browser icons

2017-11-09 Thread GitBox
Chris2011 commented on issue #251: [NETBEANS-126] Re-instate browser icons URL: https://github.com/apache/incubator-netbeans/pull/251#issuecomment-343103760 But why not starting there first and do it incremental further? Or starting to make them looks both the same, as you can see both ope

[GitHub] lbruun commented on issue #251: [NETBEANS-126] Re-instate browser icons

2017-11-09 Thread GitBox
lbruun commented on issue #251: [NETBEANS-126] Re-instate browser icons URL: https://github.com/apache/incubator-netbeans/pull/251#issuecomment-343099165 @Chris2011. The browser icons are about 0.5% of all icons used in the Platform / IDE. Wouldn't it look strange if we replaced only those

Re: [RESULT]: [VOTE] Release 1.5 of NetBeans HTML/Java API

2017-11-09 Thread Anton Epple
As I said, the JAR-Names are sensible and will lead to a proper unique automatic module name which is unique on module path, e.g. “net.java.html.boot” . Still I think it’s good to add the manifest entry, as it indicates we care about modules. I would oppose to using org.apache.netbeans.html yet

Re: [JIRA-admin] Re: JIRA permission: Can't resolve issues

2017-11-09 Thread John McDonnell
Hi Eric, Which issue? So effectively what I did yesterday, was move the jira-users group into the committers group, since they have the 3 permissions I found JIRA needs for resolving a ticket: Close Issues Resolve Issues Transition Issues Previously all jira-users were in the contributors gr

RE: [JIRA-admin] Re: JIRA permission: Can't resolve issues

2017-11-09 Thread Eric Barboni
Hi, I encounter the same issue, as not commiter I cannot resolve issue assigned to me -Message d'origine- De : John McDonnell [mailto:mcdonnell.j...@gmail.com] Envoyé : mercredi 8 novembre 2017 22:36 À : dev@netbeans.incubator.apache.org Objet : Re: [JIRA-admin] Re: JIRA permission: Can

[GitHub] Chris2011 commented on issue #3: NETBEANS-59 - Document split actions

2017-11-09 Thread GitBox
Chris2011 commented on issue #3: NETBEANS-59 - Document split actions URL: https://github.com/apache/incubator-netbeans/pull/3#issuecomment-343084317 Smth missing here for the merge? This is an automated message from the Apach

Re: [RESULT]: [VOTE] Release 1.5 of NetBeans HTML/Java API

2017-11-09 Thread Dave Schoorl
Now, it is not my itch. I don't use the artifacts as dependency in my applications yet. It may be or become other peoples pain, now or on the future. Nevertheless, I will try to make a pull request, however, the next couple of days I have very limited time. I will try to do it over the next coup

Re: [RESULT]: [VOTE] Release 1.5 of NetBeans HTML/Java API

2017-11-09 Thread Geertjan Wielenga
Hi Dave, This is your itch, feel free to scratch it, i.e., pull request. :-) Gj On Thu, 9 Nov 2017 at 09:30, Dave Schoorl wrote: > This is the link to the presentation of Robert Scholte at Devoxx (half > hour): https://www.youtube.com/watch?v=tHTmFlVAyAc > > > > > Op 9 november 2017 om 9:0

Re: [RESULT]: [VOTE] Release 1.5 of NetBeans HTML/Java API

2017-11-09 Thread Dave Schoorl
This is the link to the presentation of Robert Scholte at Devoxx (half hour): https://www.youtube.com/watch?v=tHTmFlVAyAc > > Op 9 november 2017 om 9:00 schreef Dave Schoorl : > > That is correct. But please note, that a module name must be unique on > the module path. In order to prev

[GitHub] Chris2011 commented on issue #251: [NETBEANS-126] Re-instate browser icons

2017-11-09 Thread GitBox
Chris2011 commented on issue #251: [NETBEANS-126] Re-instate browser icons URL: https://github.com/apache/incubator-netbeans/pull/251#issuecomment-343081574 It would be great, if we can have new icons, modern, flat for example and free to use. As you can see, the icons are different, diffe

Re: [RESULT]: [VOTE] Release 1.5 of NetBeans HTML/Java API

2017-11-09 Thread Jaroslav Tulach
All HTML/Java modules are OSGi bundles. The automatic module name shall be the same as Bundle-SymbolicName, I assume. The manifest entry is defined here: https://github.com/apache/incubator-netbeans-html4j/blob/master/pom.xml#L329 Feel free to create the PR. I wanted to prepare 1.5.1 release relat

[GitHub] geertjanw commented on issue #259: Sdedic/netbeans bugfixes

2017-11-09 Thread GitBox
geertjanw commented on issue #259: Sdedic/netbeans bugfixes URL: https://github.com/apache/incubator-netbeans/pull/259#issuecomment-343079549 Great, thanks. This is an automated message from the Apache Git Service. To respond

[GitHub] geertjanw commented on issue #257: Backport of jtulach's fixes made after Apr 22, 2017

2017-11-09 Thread GitBox
geertjanw commented on issue #257: Backport of jtulach's fixes made after Apr 22, 2017 URL: https://github.com/apache/incubator-netbeans/pull/257#issuecomment-343079187 Everyone agrees that Apache NetBeans should be in line with NetBeans that is in Oracle hg. This code has been reviewed.

[GitHub] JaroslavTulach commented on issue #257: Backport of jtulach's fixes made after Apr 22, 2017

2017-11-09 Thread GitBox
JaroslavTulach commented on issue #257: Backport of jtulach's fixes made after Apr 22, 2017 URL: https://github.com/apache/incubator-netbeans/pull/257#issuecomment-343078550 I'd be thankful if somebody else from the community could take a look and merge my changes. I don't think it is cor

Re: Alternative JavaHelp viewer was: Give JavaHelp a chance!

2017-11-09 Thread Geertjan Wielenga
But I would suggest we leave these ideas for later and remove JavaHelp (jhall.jar and jsearch.jar) for the moment, so that we can release 9.0 Alpha, and also because JavaHelp is probably the least important feature of Apache NetBeans. Gj On Thu, 9 Nov 2017 at 09:08, Jaroslav Tulach wrote: > Hel

[GitHub] JaroslavTulach closed pull request #259: Sdedic/netbeans bugfixes

2017-11-09 Thread GitBox
JaroslavTulach closed pull request #259: Sdedic/netbeans bugfixes URL: https://github.com/apache/incubator-netbeans/pull/259 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pul

[GitHub] JaroslavTulach commented on issue #259: Sdedic/netbeans bugfixes

2017-11-09 Thread GitBox
JaroslavTulach commented on issue #259: Sdedic/netbeans bugfixes URL: https://github.com/apache/incubator-netbeans/pull/259#issuecomment-343077643 The code has already been reviewed. Time to integrate and bring Apache NetBeans closer to the original NetBeans source code. -

Alternative JavaHelp viewer was: Give JavaHelp a chance!

2017-11-09 Thread Jaroslav Tulach
Hello Jan. 2017-11-09 0:17 GMT+01:00 Jan Tosovsky : > Btw, what is the source for NetBeans help? > XML files. Like those at https://github.com/apache/incubator-netbeans/tree/ master/usersguide/javahelp/org/netbeans/modules/usersguide > > Some content is now distributed as JavaHelp, some is hos

Re: [RESULT]: [VOTE] Release 1.5 of NetBeans HTML/Java API

2017-11-09 Thread Dave Schoorl
That is correct. But please note, that a module name must be unique on the module path. In order to prevent name collisions, you should provide a propper name, probably containing a reverse DNS name like in packages. And if it is something in maven central, I believe there are more restrictions,