Re: Language Server Protocol client

2018-07-07 Thread Emilian Bold
Nice. This might be the only way to get support for some languages like Kotlin that intentionally don't support NetBeans. Still, I find something odd about LSP... The IDE becomes nothing more than a remote display. I'm also curious how something more complex like a refactoring that touches mul

Re: Ready for Vote Candidate 3?

2018-07-07 Thread Geertjan Wielenga
+1 for VC3! Gj On Sunday, July 8, 2018, Junichi Yamamoto wrote: > Thank you! > +1 for VC3 > > Junichi > > On Sun, Jul 8, 2018 at 3:34 PM Emilian Bold > wrote: > > > > Yeah, look good. > > > > --emi > > > > ‐‐‐ Original Message ‐‐‐ > > > > On 8 July 2018 9:24 AM, Junichi Yamamoto wrote

Re: Ready for Vote Candidate 3?

2018-07-07 Thread Junichi Yamamoto
Thank you! +1 for VC3 Junichi On Sun, Jul 8, 2018 at 3:34 PM Emilian Bold wrote: > > Yeah, look good. > > --emi > > ‐‐‐ Original Message ‐‐‐ > > On 8 July 2018 9:24 AM, Junichi Yamamoto wrote: > > > Hi Emilian, > > > > Can we merge this[1] yet? > > > > [1] https://github.com/apache/incu

Re: Ready for Vote Candidate 3?

2018-07-07 Thread Emilian Bold
Yeah, look good. --emi ‐‐‐ Original Message ‐‐‐ On 8 July 2018 9:24 AM, Junichi Yamamoto wrote: > Hi Emilian, > > Can we merge this[1] yet? > > [1] https://github.com/apache/incubator-netbeans/pull/630 > > Thanks, > > JunichiOn Sun, Jul 8, 2018 at 2:45 PM Antonio anto...@vieiro.net

Re: Ready for Vote Candidate 3?

2018-07-07 Thread Junichi Yamamoto
Hi Emilian, Can we merge this[1] yet? [1] https://github.com/apache/incubator-netbeans/pull/630 Thanks, JunichiOn Sun, Jul 8, 2018 at 2:45 PM Antonio wrote: > > +1 for VC3 instead of VC2. > > On 08/07/18 07:29, Emilian Bold wrote: > > Hello, > > > > I updated the Start Page in release90 branch

Re: Ready for Vote Candidate 3?

2018-07-07 Thread Antonio
+1 for VC3 instead of VC2. On 08/07/18 07:29, Emilian Bold wrote: Hello, I updated the Start Page in release90 branch and also imported the NETBEANS-781 fix. I see no reason to keep the VC2 vote running. Ready for VC3? --emi

Re: Language Server Protocol client

2018-07-07 Thread Antonio
This is great news! On 08/07/18 07:39, Jan Lahoda wrote: Hi, Just FYI, as there have been talks about the language server protocol some time ago, I've just opened a work-in-progress PR for a client for the language server protocol: https://github.com/apache/incubator-netbeans/pull/629 Help wit

Language Server Protocol client

2018-07-07 Thread Jan Lahoda
Hi, Just FYI, as there have been talks about the language server protocol some time ago, I've just opened a work-in-progress PR for a client for the language server protocol: https://github.com/apache/incubator-netbeans/pull/629 Help with that and/or feedback is sincerely welcome, Jan

Ready for Vote Candidate 3?

2018-07-07 Thread Emilian Bold
Hello, I updated the Start Page in release90 branch and also imported the NETBEANS-781 fix. I see no reason to keep the VC2 vote running. Ready for VC3? --emi - To unsubscribe, e-mail: dev-unsubscr...@netbeans.incubator.apac

Re: ModuleInstall.restore() seems not to be called

2018-07-07 Thread Brett Ryan
That is a great book. Has it been continually updated for 8.x? I haven’t read since the original MEAP. > On 8 Jul 2018, at 05:09, Geertjan Wielenga > wrote: > > Really suggest you buy leanpub.com/nbp4beginners > > Gj > > >> On Saturday, July 7, 2018, Peter Nabbefeld wrote: >> >> >> Found

Re: [VOTE] Release Apache NetBeans 9.0 (incubating) [vote candidate 2]

2018-07-07 Thread James Gosling
+1 I built & ran with JDK8. The whole clone/build/run process was flawless. MacOS High Sierra > On Jul 7, 2018, at 2:13 PM, Mario Schroeder wrote: > > +1 > > Build with Java 8 > Started with Java 9 > > 2018-07-07 2:49 GMT+02:00 Junichi Yamamoto : > >> +1 >> >> Verified sha1sum, User direct

Re: Welcome screen and 9.0 branding

2018-07-07 Thread Brett Ryan
This is a great start. One suggestion, could we have the navy title and footer changed to white or a light gray, the background a solid colour. Something to give a modern pop. > On 8 Jul 2018, at 04:37, Emilian Bold > wrote: > > Here is my final version: https://imgur.com/a/0wPjkDD > > Note

Re: [VOTE] Release Apache NetBeans 9.0 (incubating) [vote candidate 2]

2018-07-07 Thread Mario Schroeder
+1 Build with Java 8 Started with Java 9 2018-07-07 2:49 GMT+02:00 Junichi Yamamoto : > +1 > > Verified sha1sum, User directory(9.0), and Cache directory(9.0). > > My environments: > Apache Ant(TM) version 1.10.3 compiled on March 29 2018 > Java: 1.8.0_171; Java HotSpot(TM) 64-Bit Server VM 25.1

Re: How to define a language inheriting from HTML?

2018-07-07 Thread Peter Nabbefeld
The problem is: html.editor has a friends-only API, with 21 "friends". As this API is so widely used, couldn't it be turned into a public one? Kind regards Peter Am 07.07.2018 um 21:34 schrieb Peter Nabbefeld: I'd just like to provide as much functionality as possible.  ;-) Peter Am

Re: How to define a language inheriting from HTML?

2018-07-07 Thread Peter Nabbefeld
The problem is: html.editor has a friend-only API, with 21 "friends". Probably the API could be changed to be public, then? Kind regards Peter Am 07.07.2018 um 21:34 schrieb Peter Nabbefeld: I'd just like to provide as much functionality as possible.  ;-) Peter Am 07.07.2018 um 21:32

Re: Review commits for 9.0 Start Page

2018-07-07 Thread Geertjan Wielenga
Great. Gj On Sat, Jul 7, 2018 at 10:03 PM, Emilian Bold wrote: > Check out https://github.com/apache/incubator-netbeans/pull/628 , we can > merge into release90. > > --emi > > ‐‐‐ Original Message ‐‐‐ > > On 7 July 2018 11:00 PM, Geertjan Wielenga > > wrote: > > > On Sat, Jul 7, 2018

Re: Review commits for 9.0 Start Page

2018-07-07 Thread Emilian Bold
Check out https://github.com/apache/incubator-netbeans/pull/628 , we can merge into release90. --emi ‐‐‐ Original Message ‐‐‐ On 7 July 2018 11:00 PM, Geertjan Wielenga wrote: > On Sat, Jul 7, 2018 at 9:48 PM, Emilian Bold < > > emilian.b...@protonmail.ch.invalid> wrote: > > > I wi

Re: Review commits for 9.0 Start Page

2018-07-07 Thread Geertjan Wielenga
On Sat, Jul 7, 2018 at 9:48 PM, Emilian Bold < emilian.b...@protonmail.ch.invalid> wrote: > > > I will also add this. We were waiting on Simon to fix the way my own patch > was imported in his branch. Might be simpler to add Simon's patch to my > branch and merge that. > Nice. The 9.0 vc3 is go

Re: Review commits for 9.0 Start Page

2018-07-07 Thread Geertjan Wielenga
On Sat, Jul 7, 2018 at 9:48 PM, Emilian Bold < emilian.b...@protonmail.ch.invalid> wrote: > > > Still, it might take some time to do this and we probably have to involve > Antonio too for the website. This delays the next voting candidate. > +1 agree, let's leave it for now, good to have this li

Re: Review commits for 9.0 Start Page

2018-07-07 Thread Emilian Bold
The URLs are: URL_MoreTutorials=http://netbeans.org/kb/index.html?utm_source=netbeans&utm_campaign=welcomepage URL_Blogs=http://planetnetbeans.org/rss20.xml URL_ArticlesAndNews=http://www.netbeans.org/mtmo.xml URL_News=http://www.netbeans.org/news.xml URL_AllNews=http://netbeans.org/community/news

Re: New Version of Plugin pending

2018-07-07 Thread Geertjan Wielenga
You’re on the dev mailing list, so you’re aware there are still many loose ends and items to be resolved, one of which is the new location and process of the Plugin Portal. In the meantime, it would be appreciated if you’d join in and help release Apache NetBeans (incubating) 9.0 by participating

Re: New Version of Plugin pending

2018-07-07 Thread Mario Schroeder
Thanks a lot Geertjan! By the way, isn't there an "official process" how a reviewer can be informed about a new version of a plugin? The website doesn't seem to have a trigger to start such a process. 2018-07-07 21:23 GMT+02:00 Geertjan Wielenga < geertjan.wiele...@googlemail.com.invalid>: > Don

Re: How to define a language inheriting from HTML?

2018-07-07 Thread Peter Nabbefeld
I'd just like to provide as much functionality as possible.  ;-) Peter Am 07.07.2018 um 21:32 schrieb Geertjan Wielenga: So, use XHTML... Gj On Saturday, July 7, 2018, Peter Nabbefeld wrote: That's XHTML, so You can define namespaces. Problems arise with HTML. Peter Am 07.07.2018 um

Re: How to define a language inheriting from HTML?

2018-07-07 Thread Geertjan Wielenga
So, use XHTML... Gj On Saturday, July 7, 2018, Peter Nabbefeld wrote: > > That's XHTML, so You can define namespaces. Problems arise with HTML. > > Peter > > > Am 07.07.2018 um 21:25 schrieb Geertjan Wielenga: > >> This screenshot from the NetBeans Wicket tutorial shows no errors at all: >> >>

Re: How to define a language inheriting from HTML?

2018-07-07 Thread Peter Nabbefeld
That's XHTML, so You can define namespaces. Problems arise with HTML. Peter Am 07.07.2018 um 21:25 schrieb Geertjan Wielenga: This screenshot from the NetBeans Wicket tutorial shows no errors at all: https://netbeans.org/images_www/articles/74/web/wicket/widget-2.png Gj On Sat, Jul 7, 201

Re: Review commits for 9.0 Start Page

2018-07-07 Thread Geertjan Wielenga
Something else -- maybe, since you're making changes in the Welcome module, search for all hardcoded URLs, i.e., a lot of them are not hardcoded and are parsed from an XML file. But, if any are hardcoded, we might want to point those to somewhere on netbeans.apache.org instead. Gj On Sat, Jul 7

Re: Review commits for 9.0 Start Page

2018-07-07 Thread Geertjan Wielenga
That is brilliant, really fantastic and awesome. Makes such a difference in terms of first impression. Maybe, if it makes sense, while you're at it, include the PR about Ant version by Simon Ijskes (https://issues.apache.org/jira/browse/NETBEANS-781) unless there's a lot of work that needs to be d

Re: How to define a language inheriting from HTML?

2018-07-07 Thread Geertjan Wielenga
This screenshot from the NetBeans Wicket tutorial shows no errors at all: https://netbeans.org/images_www/articles/74/web/wicket/widget-2.png Gj On Sat, Jul 7, 2018 at 8:08 PM, Peter Nabbefeld wrote: > > Hello, > > using XHTML with wicket seems to work, but using HTML gives a bunch of > errors

Review commits for 9.0 Start Page

2018-07-07 Thread Emilian Bold
Hello, For expedience I pushed two commits for the welcome/ module (ie. the Start Page): * https://github.com/apache/incubator-netbeans/commit/e24634c2271ae3434d10d508d574aff591fac4f7 Adds an Apache Incubator logo and link in the lower-right corner * https://github.com/apache/incubator-netbe

Re: New Version of Plugin pending

2018-07-07 Thread Geertjan Wielenga
Done. Gj On Sat, Jul 7, 2018 at 7:41 PM, Mario Schroeder wrote: > Hi, > > I uploaded a new version of my plugin (suitable for NetBeans 8.2) and > deleted the old one, which was for NetBeans 8.1. However it is still > pending, waiting for verification. > > The first time I uploaded a plugin I di

Re: Welcome screen and 9.0 branding

2018-07-07 Thread Geertjan Wielenga
Awesome. Gj On Saturday, July 7, 2018, Emilian Bold wrote: > Here is my final version: https://imgur.com/a/0wPjkDD > > Note the Apache Incubator logo in the lower-right corner. > > --emi > > ‐‐‐ Original Message ‐‐‐ > > On 7 July 2018 9:19 PM, Josh Juneau wrote: > > > Thanks Emilian...

Re: ModuleInstall.restore() seems not to be called

2018-07-07 Thread Geertjan Wielenga
Really suggest you buy leanpub.com/nbp4beginners Gj On Saturday, July 7, 2018, Peter Nabbefeld wrote: > > Found the problem: > No OpenIDE-Module-Install added to manifest. > > And found a better solution for my case: > Using @OnShowing. > > Regards > Peter > > > > Am 07.07.2018 um 19:18 schrie

Re: Welcome screen and 9.0 branding

2018-07-07 Thread Emilian Bold
Here is my final version: https://imgur.com/a/0wPjkDD Note the Apache Incubator logo in the lower-right corner. --emi ‐‐‐ Original Message ‐‐‐ On 7 July 2018 9:19 PM, Josh Juneau wrote: > Thanks Emilian...I think that looks great. > > Josh Juneau > > juneau...@gmail.com > > http://

Re: Welcome screen and 9.0 branding

2018-07-07 Thread Josh Juneau
Thanks Emilian...I think that looks great. Josh Juneau juneau...@gmail.com http://jj-blogger.blogspot.com https://www.apress.com/index.php/author/author/view/id/1866 > On Jul 7, 2018, at 1:05 PM, Emilian Bold > wrote: > > Here it is with the cherry-picked commit from PR583 and my tweaks: > ht

How to define a language inheriting from HTML?

2018-07-07 Thread Peter Nabbefeld
Hello, using XHTML with wicket seems to work, but using HTML gives a bunch of errors because the namespace isn't known and so are the wicket attributes. How can I filter those like "wicket:id"? Is it possible to define a language using the HTML module, defining the wicket attributes as an

Re: Welcome screen and 9.0 branding

2018-07-07 Thread Emilian Bold
Here it is with the cherry-picked commit from PR583 and my tweaks: https://imgur.com/a/2UHAsqh I think it's looking better. --emi ‐‐‐ Original Message ‐‐‐ On 7 July 2018 8:22 PM, Emilian Bold wrote: > I was talking about something more extensive. > > I'm no designer but I could come

New Version of Plugin pending

2018-07-07 Thread Mario Schroeder
Hi, I uploaded a new version of my plugin (suitable for NetBeans 8.2) and deleted the old one, which was for NetBeans 8.1. However it is still pending, waiting for verification. The first time I uploaded a plugin I did not sign it. But this time I made sure it is signed. So that can't be the caus

Re: ModuleInstall.restore() seems not to be called

2018-07-07 Thread Peter Nabbefeld
Found the problem: No OpenIDE-Module-Install added to manifest. And found a better solution for my case: Using @OnShowing. Regards Peter Am 07.07.2018 um 19:18 schrieb Peter Nabbefeld: Hello, I tried to do some debugging of the Installer class, but the breakpoint in the restore method d

Re: Welcome screen and 9.0 branding

2018-07-07 Thread Emilian Bold
I was talking about something more extensive. I'm no designer but I could come up with this: https://imgur.com/a/9raqsSa Note the background underneath 'Learn and Discover' and the current tab being green. --emi ‐‐‐ Original Message ‐‐‐ On 7 July 2018 6:25 PM, Geertjan Wielenga wrot

ModuleInstall.restore() seems not to be called

2018-07-07 Thread Peter Nabbefeld
Hello, I tried to do some debugging of the Installer class, but the breakpoint in the restore method doesn't seem to be hit: https://github.com/OldGrumble/NBWicketSupport/blob/master/src/main/java/org/netbeans/modules/web/wicket/installer/Installer.java Could somebody tell me what I'm doing

Re: Welcome screen and 9.0 branding

2018-07-07 Thread Josh Juneau
I fully agree with Geertjan and Brett +1. I love the new icon in the dock and on the splash screen...would be great to see the new branding on the Welcome screen as well. However, it can wait if more is involved than cherry picking and easily updating the Welcome screen. Josh Juneau juneau...@gm

Re: Welcome screen and 9.0 branding

2018-07-07 Thread Geertjan Wielenga
But if I remember correctly we already have right now a PR for the Welcome screen in ‘main’, cherry pick it to ‘release90’ and we’re done. I’d vote to not do this for this release if it is more involved than cherry picking. Gj On Saturday, July 7, 2018, Emilian Bold wrote: > The designer we h

Re: Welcome screen and 9.0 branding

2018-07-07 Thread Emilian Bold
The designer we have should also help us with the welcome screen as we need some new color palette (right now the Welcome screen is using a blue color palette from an older branding) and some new image (for example, under 'What's New' there's a background image). --emi ‐‐‐ Original Message

Re: Welcome screen and 9.0 branding

2018-07-07 Thread Kai Uwe Pel
+1 I fully agree with Brett ! Kai On 7/7/2018 4:51 PM, Brett Ryan wrote: Personally I felt after seeing the new splash screen I thought it looked brilliant but did feel the welcome screen detracted the freshness. It’s highly important that branding is consistent as this is the image of netbea

Re: Welcome screen and 9.0 branding

2018-07-07 Thread Brett Ryan
Personally I felt after seeing the new splash screen I thought it looked brilliant but did feel the welcome screen detracted the freshness. It’s highly important that branding is consistent as this is the image of netbeans. I vote not to wait and have this come in ASAP. > On 8 Jul 2018, at 00:4

Welcome screen and 9.0 branding

2018-07-07 Thread Geertjan Wielenga
Hi all, I’ve been using the vote candidate 2 that Emilian announced yesterday and am becoming convinced that the only really missing aspect is the rebranding of the Welcome screen. It seems like a small thing but creates a big impact to have the correct icons there too and we have such a pull requ