Re: Modules review

2017-09-24 Thread Dave Schoorl
others: anybody willing to help? There are almost 600 modules/directories > in the repository, so the more people will help, the sooner it will be > done. I suggest we start with "platform", and then continue with "ide", > "java", etc. (as that'

Re: Another relicensing batch coming through directly

2017-09-24 Thread Dave Schoorl
or-netbeans, and not via a fork. Hope that's OK > with everyone -- I don't consider these license header changes as > something > that needs to be reviewed, hence not doing these via a fork but making > them > directly available to incubator-netbeans. > >

Re: Modules review

2017-09-24 Thread Dave Schoorl
Hi, Reviewing my first module, I have 2 questions: 1. The module I am reviewing has a file under META-INF/services. What shall we do with those? Are they considered to contain some or be part of creativity? Handle them centrally? 2. I have used 'maven coordinates' in the external/binaries-list

Re: To branch or to fork.

2017-09-24 Thread Dave Schoorl
Hi Geertjan, I assume you quote the workflow for infrastructure-puppet repo, because it also applies to Netbeans workflow? More concrete, for NETBEANS-54, will you, or another committer, create such a topic branch, and we will do PR against that branch? Kind regards, /Dave > > Op 25 se

Re: Additional Rat excludes -- files without any degree of creativity

2017-09-26 Thread Dave Schoorl
Hi, It is great that the number of problematic files decreases drastically, but I noticed that some of the files, E.g. in api.annotations.common, the file under META-INF/service contains a (non-Apache) license header. Excluding them from Rat will leave those old (Oracle) headers present, wouldn

Should every Netbeans Module contain an Apache License file in it's root?

2017-09-26 Thread Dave Schoorl
Hi, Just a quick question for my own clarity and understanding, while reviewing the Modules list for NETBEANS-54: should a Netbeans module in incubator-netbeans repository always contain an Apache License file in it's root? Because a module can be released / updated on it's own and thus is an a

How to deal with module review without modifications

2017-09-26 Thread Dave Schoorl
Hi all, When you check a module for license headers and suspicious files (files that maybe were not owned by Oracle), make changes and do a Pull Request (PR), the PR is checked by one or more committers. On the other hand, when the person checking a module thinks no modifications are needed, no

Re: [RESULT]: [VOTE] Release 1.5 of NetBeans HTML/Java API

2017-11-08 Thread Dave Schoorl
Should we not add Automatic-Module-Name attribute to the jar's manifests, now that Java9 is out? Especially since these files end up in public maven repo. Kind regards, Dave Op 8 november 2017 om 20:40 schreef Jaroslav Tulach : OK, the bits are now in https://dist.apache.org/repos/dist/releas

Re: [RESULT]: [VOTE] Release 1.5 of NetBeans HTML/Java API

2017-11-09 Thread Dave Schoorl
:39 AM, Jaroslav Tulach > > wrote: > > > Hello Dave, > > I know little about desirable changes to target JDK9. However if you > want > > to start development that would bring HTML/Java API closer to JDK9, you > are > > more

Re: [RESULT]: [VOTE] Release 1.5 of NetBeans HTML/Java API

2017-11-09 Thread Dave Schoorl
This is the link to the presentation of Robert Scholte at Devoxx (half hour): https://www.youtube.com/watch?v=tHTmFlVAyAc > > Op 9 november 2017 om 9:00 schreef Dave Schoorl : > > That is correct. But please note, that a module name must be unique on > the module pa

Re: [RESULT]: [VOTE] Release 1.5 of NetBeans HTML/Java API

2017-11-09 Thread Dave Schoorl
next couple of days. Dave > > Op 9 november 2017 om 9:32 schreef Geertjan Wielenga > : > > Hi Dave, > > This is your itch, feel free to scratch it, i.e., pull request. :-) > > Gj > > On Thu, 9 Nov 2017 at 09:30, Dave Schoorl wrote: > &g

Re: [RESULT]: [VOTE] Release 1.5 of NetBeans HTML/Java API

2017-11-09 Thread Dave Schoorl
gt; > --Toni > > > > > Am 09.11.17, 09:00 schrieb "Dave Schoorl" : > > That is correct. But please note, that a module name must be unique on > the module path. In order to prevent name collisions, you should provide a > propper name, probably con

Re: [GitHub] dschoorl opened a new pull request #2: Add Automatic-Module-Name attribute to manifest files

2017-11-09 Thread Dave Schoorl
@Jaroslav Tulach: I manually checked some of the manifest files if the new attribute was present and contained the expected value. And the existing tests succeed after running mvn clean package on my system. However, I don't know how to manually run/test the software or what it does (sorry). May