Re: PR Coding best practices

On Wed, Jan 17, 2018 at 9:58 AM, Neil C Smith wrote: > ...Sorry, confusing this > with other contributor agreements I've seen No worries! Just wanted to make sure the archive of this complicated thread reflect the truth where possible ;-) -Bertrand --

Re: PR Coding best practices

On Wed, 17 Jan 2018 at 08:46 Bertrand Delacretaz wrote: > On Tue, Jan 16, 2018 at 11:58 PM, Neil C Smith > wrote: > >...it's the first time I've ever agreed to copyright assignment > > What makes you think you have? > > The Apache iCLA and Apache License are about granting copyright > licens

Re: PR Coding best practices

On Wed, 17 Jan 2018 at 08:05 Antonio wrote: > On 16/01/18 23:58, Neil C Smith wrote: > > > > Just for clarification, the NOTICES file is not a requirement of the > > license. Correct attribution is of course. > > Source headers and copyright notices are described > I just meant that your email

Re: PR Coding best practices

On Tue, Jan 16, 2018 at 11:58 PM, Neil C Smith wrote: >...it's the first time I've ever agreed to copyright assignment What makes you think you have? The Apache iCLA and Apache License are about granting copyright licenses to the ASF, that's *very* different from copyright assignement. -Ber

Re: PR Coding best practices

On Tue, Jan 16, 2018 at 11:24 PM, Antonio wrote: > ...My concern is about the contributions of people that have not signed > a CLA and still want to hold a copyright of the code... I don't think having an iCLA makes a difference - when people contribute code to the ASF they give us a copyright li

Re: PR Coding best practices

Hi Matthias, We _must_ use the ASF headers for _all_ NetBeans code, as per [1]. Kind regards, Antonio [1] https://www.apache.org/legal/src-headers.html#header-existingcopyright On 16/01/18 19:35, Matthias Bläsing wrote: Am Dienstag, den 16.01.2018, 11:18 +0100 schrieb Bertrand Delacretaz: On

Re: PR Coding best practices

On 16/01/18 23:58, Neil C Smith wrote: then _you'll have to_ add the Apache BCEL NOTICE file in yours (APLv2#4.d). If you don't then you could be sued by copyright infringement (of course I don't think the ASF is going to do that against you, but it's ASF's right to do so). Just for clarif

Re: PR Coding best practices

On Wed, 17 Jan 2018, 05:36 cowwoc, wrote: > Clearly I am missing something... If an author assigns his code to the > public domain, why does it matter who owns the copyright? > Because there's no such thing for one - have a look at eg. CC0, and the problem section. https://creativecommons.org/s

Re: PR Coding best practices

On 2018-01-16 4:09 PM, Antonio wrote: On 16/01/18 20:42, cowwoc wrote: +1 Remember why Netbeans went to Apache in the first place: to increase the number of open-source contributors. If possible, please try erring on the side of least friction. > With respect to Daniel's specific contributi

Re: PR Coding best practices

Hi On Tue, 16 Jan 2018 at 22:24 Antonio wrote: > Long one ahead. Sorry by that. > Still digesting it, but a couple of quick comments ... > then _you'll have to_ add > the Apache BCEL NOTICE file in yours (APLv2#4.d). If you don't then you > could be sued by copyright infringement (of course

Re: PR Coding best practices

Long one ahead. Sorry by that. On 16/01/18 20:23, Matthias Bläsing wrote: Hey Antonio, I don't see your point. The ASF requires the NOTICE file, not some random contributor. If a contributor requires a personal addition to the NOTICE file, I would not merge his/her contributions. As long as he

Re: PR Coding best practices

On 16/01/18 20:42, cowwoc wrote: +1 Remember why Netbeans went to Apache in the first place: to increase the number of open-source contributors. If possible, please try erring on the side of least friction. > With respect to Daniel's specific contribution, it is my understanding that it is

Re: PR Coding best practices

+1 Remember why Netbeans went to Apache in the first place: to increase the number of open-source contributors. If possible, please try erring on the side of least friction. With respect to Daniel's specific contribution, it is my understanding that it is in the public domain. As such, I don

Re: PR Coding best practices

Hey Antonio, I don't see your point. The ASF requires the NOTICE file, not some random contributor. If a contributor requires a personal addition to the NOTICE file, I would not merge his/her contributions. As long as he /she just creates files, they can added without problem. In fact nobody can

Re: PR Coding best practices

Hi, But that being so we'll have to scan > 5.5 million files for copyright notices in order to add those to the NOTICE file, which will also increase linearly with the number of contributors. Anyway to end this discussion once and for all and move forward (the question was asked last week as

Re: PR Coding best practices

Am Dienstag, den 16.01.2018, 11:18 +0100 schrieb Bertrand Delacretaz: > On Tue, Jan 16, 2018 at 10:37 AM, Christian Lenz net> wrote: > > ...I see the nice NetBeans repo on github and I clone it and I fix > > stuff and make a PR > > is this possible without having a CLA or not?... > > Yes it is po

Re: PR Coding best practices

Hello Bertrand, Thank you for your consideration. To answer your question about my interest in commitership, I don't think that I am, at least right now in my capacity as an individual. It would be different if I were employed to work on Apache project(s), but as an individual, I am quite happy

Re: PR Coding best practices

On Tue, Jan 16, 2018 at 10:37 AM, Christian Lenz wrote: > ...I see the nice NetBeans repo on github and I clone it and I fix stuff and > make a PR > is this possible without having a CLA or not?... Yes it is possible and has always been. -Bertrand --

Re: PR Coding best practices

On Mon, Jan 15, 2018 at 9:25 PM, Matthias Bläsing wrote: > ...Is there a real position of the ASF on this? By this I mean not hidden > in an LEGAL ticket or a random mailinglist post... IMO Daniel's "avoid signing legal agreements of any kind which are not necessary for me to sign" rule is an edg

Re: PR Coding best practices

Hi, Am Montag, den 15.01.2018, 14:29 +0100 schrieb Bertrand Delacretaz: > > On Sun, Jan 14, 2018 at 9:07 AM, Antonio wrote: > > ...I started some PR coding best practices at [1]. .. > > IMO "You will need an ICLA.." belongs to the contribution guidelines, > and that should link to https://www.a

Re: PR Coding best practices

Hello Geertjan, I realize that it would be in the interests of transparency if I were able to fully discuss my concerns, particularly my legal concerns, with signing the ASF ICLA in an individual capacity. However, I am not a lawyer, and I feel that it would be legally precarious for me to discus

Re: PR Coding best practices

Just for clarity and my own understanding -- can you explain your objection to signing the ICLA? Thanks, Gj On Mon, Jan 15, 2018 at 6:28 PM, Daniel Trebbien wrote: > "For important modifications you will need to submit an Individual > Contributor License Agreement (ICLA) >

Re: PR Coding best practices

"For important modifications you will need to submit an Individual Contributor License Agreement (ICLA) ." is incorrect. http://mail-archives.apache.org/mod_mbox/www-infrastructure-dev/201112.mbox/%3ca603ffce-623b-43e9-87f8-39baa51c7...@gbiv.com%3E "Yes,

Re: PR Coding best practices

Hi, On Sun, Jan 14, 2018 at 9:07 AM, Antonio wrote: > ...I started some PR coding best practices at [1]. .. IMO "You will need an ICLA.." belongs to the contribution guidelines, and that should link to https://www.apache.org/licenses/icla.pdf -Bertrand -

Re: PR Coding best practices

Many thanks everyone involved, I think it's great and sets up clear guidelines. Gj On Sun, Jan 14, 2018 at 2:10 PM, Antonio wrote: > BTW, credit is due to Matthias for the content. I just added the typos that, > thankfully, John has since corrected. :-) > > On 14/01/18 12:19, Geertjan Wielenga w

Re: PR Coding best practices

BTW, credit is due to Matthias for the content. I just added the typos that, thankfully, John has since corrected. :-) On 14/01/18 12:19, Geertjan Wielenga wrote: Really excellent, thanks Antonio. I think something like this should be included: "As far as possible, and where relevant, start by

Re: PR Coding best practices

Hi, On Sun, 14 Jan 2018 at 09:30 Antonio wrote: > Thank you Matthias, for these. > > I've merged the guidelines as best as I could. > Great job! A couple of thoughts - * 2,3,4 (was 1,2,3) should also refer to PR title and description? It would be good to know from the PR itself what issues

Re: PR Coding best practices

+1 Feel free to edit/review as appropriate. Kind regards, Antonio On 14/01/18 12:19, Geertjan Wielenga wrote: Really excellent, thanks Antonio. I think something like this should be included: "As far as possible, and where relevant, start by creating an issue and discussing that issue on the

Re: PR Coding best practices

Really excellent, thanks Antonio. I think something like this should be included: "As far as possible, and where relevant, start by creating an issue and discussing that issue on the dev mailing list, before working on code, doing commits, and providing pull requests. In that way, the reason for t

Re: PR Coding best practices

Regarding the "Keep explicity typing" section of https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=74681408, isn't this strictly a code-smell? Meaning, what prevents one from moving the variable declaration closer to the initialization? Instead of: |ArrayList fieldGroup =||nul

Re: PR Coding best practices

Thank you Matthias, for these. I've merged the guidelines as best as I could. I've also added the requirement about the proper ASF license headers in new files, and the requirement to follow the ASF Code of Conduct in comments. Un abrazo, Antonio https://cwiki.apache.org/confluence/pages/vie

Re: PR Coding best practices

Hey Antonio, Am Sonntag, den 14.01.2018, 09:07 +0100 schrieb Antonio: > > I started some PR coding best practices at [1]. > > > [1] > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=7468 > 1408#SubmittingPullRequestonApacheNetbeans(incubating)- > PRCodingBestPractices Thank yo