[GitHub] nifi pull request: NIFI-1107 - Integrate Multipart uploads into th...

2016-01-06 Thread jskora
Github user jskora commented on the pull request: https://github.com/apache/nifi/pull/132#issuecomment-169329852 I'm closing this pull request since the general S3 changes have been incorporated by @trkurc. The remaining Multipart Upload functionality will be incorporated into a new

Re: about the debug of nifi

2016-01-06 Thread Joe Skora
+1 for remote debug. It has always worked great with IntelliJ. I originally had full integration, starting NiFi from within the IDE, working a while back in May/June. But, I think bootstrap changes at some point broke it and with remote debug working so well I haven't felt a need to investigate

Re: Redesign User Interface (UI)

2016-01-06 Thread Tony Kurc
Looks great so far! I saw the target release of 0.6, which surprised me a bit. I would have expected this significant of a change would warrant a major release increment. On Wed, Jan 6, 2016 at 1:08 PM, Rob Moran wrote: > Greetings ​​NiFi community, > > NIFI-1323 [1] has been

RE: Redesign User Interface (UI)

2016-01-06 Thread Rick Braddy
Looks like a great start! Very much like the direction. Would be ideal to also see mock up of how we would envison NIFI-951 to be factored in. Thanks Rick -Original Message- From: Rob Moran [mailto:rmo...@gmail.com] Sent: Wednesday, January 06, 2016 12:09 PM To: dev@nifi.apache.org

Re: Redesign User Interface (UI)

2016-01-06 Thread Sean Busbey
+1 to "UI redesign warrants a major version increment" I know that we're "pre 1.0", but this sounds like it's time to figure out what we need to include to go over that cliff. On Wed, Jan 6, 2016 at 12:22 PM, Tony Kurc wrote: > Looks great so far! > > I saw the target release

Re: Redesign User Interface (UI)

2016-01-06 Thread Matt Gilman
One of the items that's needed to go over the 1.0 cliff is support for multi-tenant dataflows. Scoping user authorization to portions of a dataflow will require a major bump due to API changes and the like. Part of the motivation for this UI redesign is laying the foundation for that effort.

[GitHub] nifi pull request: NIFI-1360

2016-01-06 Thread jdye64
GitHub user jdye64 opened a pull request: https://github.com/apache/nifi/pull/159 NIFI-1360 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdye64/nifi NIFI-1360 Alternatively you can review and apply these changes as the patch

Re: Redesign User Interface (UI)

2016-01-06 Thread Tony Kurc
Matt, I'm not sure I followed. I think you said we have two things: A) ui redesign B) multi-tenant dataflow We need A before B, and B will be in 1.0, so we need A in a release before 1.0. Tony On Wed, Jan 6, 2016 at 2:17 PM, Matt Gilman wrote: > One of the items

Re: Redesign User Interface (UI)

2016-01-06 Thread Matt Gilman
Tony, That is correct. The UI redesign is necessary for a 1.0 feature. Additionally, the UI changes are limited to styling and positioning of certain elements for controlling the dataflow. Matt On Wed, Jan 6, 2016 at 2:33 PM, Tony Kurc wrote: > Matt, > I'm not sure I

Redesign User Interface (UI)

2016-01-06 Thread Rob Moran
Greetings ​​NiFi community, NIFI-1323 [1] has been mentioned in (at least one) previous thread. In case you are unaware, it involves beginning work on a series of UI improvements. I'd like to point your attention to the wiki page [2] where you can read up on factors that are driving this effort.

Re: Redesign User Interface (UI)

2016-01-06 Thread Mark Payne
I must admit i hadn't considered how the layout of the graph may look if the components are made larger. I think if it would mess up the layout then 1.0 makes a lot more sense. If we can either auto-reposition the components though then it would be fine. Or perhaps, if we kept the components

[GitHub] nifi pull request: NIFI-1360

2016-01-06 Thread jdye64
Github user jdye64 closed the pull request at: https://github.com/apache/nifi/pull/159 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request: NIFI-1145 Unit tests timeout in some environmen...

2016-01-06 Thread apiri
Github user apiri commented on the pull request: https://github.com/apache/nifi/pull/160#issuecomment-169563602 Woohoo! The build even passed on here via the PR. Had me nervous :relieved: As a reminder, the Travis job does a mvn clean install -Pcontrib-check so it should

[GitHub] nifi pull request: NIFI-1145 Unit tests timeout in some environmen...

2016-01-06 Thread apiri
GitHub user apiri opened a pull request: https://github.com/apache/nifi/pull/160 NIFI-1145 Unit tests timeout in some environments In order to get more meaningful information from our integration with travis CI established in NIFI-1211, there were certain tests that had issues

[GitHub] nifi pull request: Nifi 1354

2016-01-06 Thread apiri
Github user apiri commented on the pull request: https://github.com/apache/nifi/pull/156#issuecomment-169541659 @alopresto Would you mind closing this out? I forgot to add the magic incantation with your patch when committing. Sorry! --- If your project is set up for it, you can

[GitHub] nifi pull request: Nifi 1354

2016-01-06 Thread alopresto
Github user alopresto commented on the pull request: https://github.com/apache/nifi/pull/156#issuecomment-169543379 Closing per Aldrin. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

Re: Redesign User Interface (UI)

2016-01-06 Thread Rob Moran
Echoing Matt G's last comment regarding changes, with a little more detail... These are mainly style changes. The positioning changes are taking current actions related to operating the flow into a docked panel. That appears along with a separate one housing navigation controls. The other

Re: Redesign User Interface (UI)

2016-01-06 Thread Mark Payne
I think we could certainly do that, where we create a separate branch to make all those changes. However, I do think that comes with some downsides. The UI codebase would likely be very different. Any change that is made to the 0.x baseline would have to be made in two codebases, and if the 1.x

Re: Redesign User Interface (UI)

2016-01-06 Thread Joe Witt
...I was definitely in the same camp of this is ok until Simon's email. If we do alter their existing layout in that it could look messy I do think that makes it major. To Tony's point if we make a change that would make existing custom UI extensions look different then it too is major. To

Re: Redesign User Interface (UI)

2016-01-06 Thread Jennifer Barnabee
Hi Rob, I think the UI improvements look really good, and this is very exciting. I wonder if there has been any thought around making each component type look a little more distinguishable. That is to say, processors, process groups, and remote process groups are all still very similar looking.

Re: Redesign User Interface (UI)

2016-01-06 Thread Joe Witt
Too funny Jenn "I wonder if there has been any thought around making each component type look a little more distinguishable" I said the same thing to Rob...and then realized I had no idea what else would work :-) On Wed, Jan 6, 2016 at 4:35 PM, Jennifer Barnabee

Re: Redesign User Interface (UI)

2016-01-06 Thread Tony Kurc
Is there is a possibility of folks having skinned or extended the UI? Would these changes be expected to work on minor version revisions? On Wed, Jan 6, 2016 at 4:14 PM, Simon Ball wrote: > The new UI looks fantastic, and seems to be heading in a very good > direction. >

Re: AttributesToJson

2016-01-06 Thread Joe Percivall
Hello Michael, Thanks for bringing this up but I don't it's an issue. The JSON that gets output from AttributesToJSON is a JSON object and according to RFC 7159 - The JavaScript Object Notation (JSON) Data Interchange Format[1] a JSON object is unordered: "An object is an unordered

Re: Redesign User Interface (UI)

2016-01-06 Thread Mark Payne
I think we've tried to be pretty clear about what we consider to be a "backward compatible" change in the versioning guide that we have provided. Specifically, others should be able to build upon the nifi-api, the rest api, and util packages that are commonly depended on like processor-utils

AttributesToJson

2016-01-06 Thread Michael Parco
I have found that in the AttributesToJSON processor, when you list out the attributes to convert to JSON, the order in which you list the attributes isn't always preserved. Is this a known issue?

Re: Redesign User Interface (UI)

2016-01-06 Thread Simon Ball
The new UI looks fantastic, and seems to be heading in a very good direction. One thought I have is around the upgrade experience. Given that we will likely end up with different sized elements to the existing UI, people may find existing flow layouts end up somewhat jumbled with the