Direction for Integration Tests

All, We have had a few conversations regarding integration tests in the past In part, this issue has resurfaced thanks to the work going on with NIFI-1325 in extending AWS related processors and extensions. The issue at hand is that, In this particular case, the contributor made test cases to su

[GitHub] nifi pull request: NIFI-1317 removed duplicate 'name' instance var...

Github user trkurc commented on a diff in the pull request: https://github.com/apache/nifi/pull/169#discussion_r49541089 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/controller/AbstractConfiguredComponent.java --

[GitHub] nifi pull request: NIFI-1317 removed duplicate 'name' instance var...

Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/169#discussion_r49540950 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/controller/AbstractConfiguredComponent.java ---

[GitHub] nifi pull request: NIFI-1317 removed duplicate 'name' instance var...

Github user trkurc commented on a diff in the pull request: https://github.com/apache/nifi/pull/169#discussion_r49540453 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/controller/AbstractConfiguredComponent.java --

[GitHub] nifi pull request: Nifi 1324

Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/170#discussion_r49537896 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/PGPUtil.java --- @@ -46,9 +46

[GitHub] nifi pull request: Nifi 1324

Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/170 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[GitHub] nifi pull request: Nifi 1324

Github user trkurc commented on a diff in the pull request: https://github.com/apache/nifi/pull/170#discussion_r49537793 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/PGPUtil.java --- @@ -46,9 +46,8

[GitHub] nifi pull request: Nifi 1324

Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/170#discussion_r49537490 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/PGPUtil.java --- @@ -46,9 +46

[GitHub] nifi pull request: Nifi 1324

Github user trkurc commented on a diff in the pull request: https://github.com/apache/nifi/pull/170#discussion_r49537256 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/PGPUtil.java --- @@ -46,9 +46,8

[GitHub] nifi pull request: Nifi 1324

Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/170#discussion_r49536701 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/PGPUtil.java --- @@ -46,9 +46,8 @

[GitHub] nifi pull request: NIFI-1317 removed duplicate 'name' instance var...

Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/169#issuecomment-171109933 Coo. thx @trkurc --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request: NIFI-1233 upgraded to Kafka 0.9.0.0

Github user olegz closed the pull request at: https://github.com/apache/nifi/pull/168 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled

Re: Failing Unit Test testShouldValidatePGPPublicKeyringExists

I merged in the change after confirming it tested fine on windows 10 and ubuntu 14.04 On Tue, Jan 12, 2016 at 7:19 PM, Andy LoPresto wrote: > Ok, thanks Tony. > > Andy LoPresto > alopresto.apa...@gmail.com > PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4 BACE 3C6E F65B 2F7D EF69 > > On Jan 12, 2016,

Re: Failing Unit Test testShouldValidatePGPPublicKeyringExists

Ok, thanks Tony. Andy LoPresto alopresto.apa...@gmail.com PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4 BACE 3C6E F65B 2F7D EF69 > On Jan 12, 2016, at 4:12 PM, Tony Kurc wrote: > > Andy, > Looks good so far, but I'm going to cherry-pick out the NIFI-1385 change, > tack it as a patch onto the ticke

Re: Failing Unit Test testShouldValidatePGPPublicKeyringExists

Andy, Looks good so far, but I'm going to cherry-pick out the NIFI-1385 change, tack it as a patch onto the ticket merge it in. After that I'll fix a couple merge problems with the rest of pr #170 for NIFI-1324. On Tue, Jan 12, 2016 at 6:51 PM, Tony Kurc wrote: > Yep, reviewing now. > > On Tue,

Re: Failing Unit Test testShouldValidatePGPPublicKeyringExists

Yep, reviewing now. On Tue, Jan 12, 2016 at 6:48 PM, Andy LoPresto wrote: > I have created a ticket here: > https://issues.apache.org/jira/browse/NIFI-1385 > > There was an “add-on” to the previous ticket NIFI-1324 (Upgrade BC > dependencies) to move from 1.53 (the target of the old ticket) to 1

Re: Failing Unit Test testShouldValidatePGPPublicKeyringExists

I have created a ticket here: https://issues.apache.org/jira/browse/NIFI-1385 There was an “add-on” to the previous ticket NIFI-1324 (Upgrade BC dependencies) to move from 1.53 (the target of the old ticket) to 1.54 (released during this work; s

[GitHub] nifi pull request: Nifi 1324

Github user alopresto commented on the pull request: https://github.com/apache/nifi/pull/170#issuecomment-171102561 NIFI-1385 This also fixes the failing test on Windows due to differing error messages on various OS. --- If your project is set up for it, you can reply to th

Re: Failing Unit Test testShouldValidatePGPPublicKeyringExists

There should be a ticket, it would be great to determine if there is "a better way" longer term, but I'm in favor of a fix that gets merged that gets the windows build working, and explore other options which might be less fragile. I can likely review, test and merge a patch quickly. I'm reminded

Re: Failing Unit Test testShouldValidatePGPPublicKeyringExists

James, I’ll make a Jira ticket and post it here. Thanks. Andy LoPresto alopresto.apa...@gmail.com PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4 BACE 3C6E F65B 2F7D EF69 > On Jan 12, 2016, at 3:36 PM, Andy LoPresto wrote: > > Thad, > > Yes, looking for the FQ exception name in the validation resu

Re: Failing Unit Test testShouldValidatePGPPublicKeyringExists

Thad, Yes, looking for the FQ exception name in the validation result string as it seems to be platform independent that the class name is included in the exception toString(). https://github.com/apache/nifi/commit/1e3663c8e7f7a0a33e8021e6c430271a7fb3f816

Re: Failing Unit Test testShouldValidatePGPPublicKeyringExists

Not that I understand the module, but it does seem like "java.io.FileNotFoundException" would be safer. Thank you all for your help, I'll ignore the test for now using Thad's method and move on. Should I create a ticket? On Tue, Jan 12, 2016 at 3:24 PM, Andy LoPresto wrote: > Sorry, after look

Re: Failing Unit Test testShouldValidatePGPPublicKeyringExists

Made the change and it’s in a PR with related changes. Thanks Thad and James for finding this. Andy LoPresto alopresto.apa...@gmail.com PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4 BACE 3C6E F65B 2F7D EF69 > On Jan 12, 2016, at 3:32 PM, Thad Guidry wrote: > > Andy, > > YUP ! Standard FNF exce

Re: Failing Unit Test testShouldValidatePGPPublicKeyringExists

You're proposing looking for that as a substring of the error message? On Tue, Jan 12, 2016 at 6:24 PM, Andy LoPresto wrote: > Sorry, after looking at the code, we don’t get the actual exception > instance from the validation results, but the message does contain the FQ > exception type. > > `vr

Re: Failing Unit Test testShouldValidatePGPPublicKeyringExists

Andy, YUP ! Standard FNF exception across the board works for me. Thad +ThadGuidry

Re: Failing Unit Test testShouldValidatePGPPublicKeyringExists

Sorry, after looking at the code, we don’t get the actual exception instance from the validation results, but the message does contain the FQ exception type. `vr.toString() == "'Public Keyring File' is invalid because Invalid Public Keyring File src/test/resources/TestEncryptContent/pubring.gpg.

Re: Failing Unit Test testShouldValidatePGPPublicKeyringExists

Perhaps to avoid OS-dependency on the differing messages, we could just change the inspection to `instanceof FileNotFoundException`? Andy LoPresto alopresto.apa...@gmail.com PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4 BACE 3C6E F65B 2F7D EF69 > On Jan 12, 2016, at 3:11 PM, James Wing wrote: > >

Re: Failing Unit Test testShouldValidatePGPPublicKeyringExists

Yes, my latest commit is 287d3ef5. I believe the new tests were merged in last night or this morning (https://issues.apache.org/jira/browse/NIFI-1324 or related?). On Tue, Jan 12, 2016 at 3:04 PM, Tony Kurc wrote: > James, > What commit are you building off of? 287d3ef5? I believe I did a full

Re: Failing Unit Test testShouldValidatePGPPublicKeyringExists

yeah, I just fixed it locally... but looks like a patch is needed to handle the output expected on Windows systems, as I did below. testShouldValidatePGPPublicKeyringExists() String expectedResult = " (No such file or directory)"; // String expectedResultOnWindows = " (The sys

Re: Failing Unit Test testShouldValidatePGPPublicKeyringExists

James, What commit are you building off of? 287d3ef5? I believe I did a full Windows 10 and similar java/maven yesterday, but I can try to replicate. Any chance you're using cygwin? On Jan 12, 2016 5:58 PM, "James Wing" wrote: > I'm having trouble with a failing unit test in nifi-standard-process

Failing Unit Test testShouldValidatePGPPublicKeyringExists

I'm having trouble with a failing unit test in nifi-standard-processors, new in a recent merge. Any helpful tips would be appreciated. Failed tests: TestEncryptContent.testShouldValidatePGPPublicKeyringExists:254 ''Public Keyring File' is invalid because Invalid Public Keyring File src/test/reso

[GitHub] nifi pull request: NIFI-1317 removed duplicate 'name' instance var...

Github user trkurc commented on the pull request: https://github.com/apache/nifi/pull/169#issuecomment-171089522 At first glance, looks good, will do some checks and merge unless I find something. --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] nifi pull request: NIFI-1384 Changed DocumentWriter to accept Clas...

GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/171 NIFI-1384 Changed DocumentWriter to accept Class of ConfigurableCompo… …nent NIFI-1384 removed dynamic elements writers routines fixed tests polishing NIFI-1384 polishin

[GitHub] nifi pull request: Nifi 1324

GitHub user alopresto opened a pull request: https://github.com/apache/nifi/pull/170 Nifi 1324 Upgraded BC to 1.54. Resolved contrib check issues. Cannot rebase as external changes were merged. You can merge this pull request into a Git repository by running: $

[GitHub] nifi pull request: Nifi 1365

Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/163#discussion_r49487304 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/pom.xml --- @@ -120,4 +124,99 @@ provided

[GitHub] nifi pull request: Nifi 1365

Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/163#discussion_r49487293 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/test/java/org/apache/nifi/web/security/x509/ocsp/OcspCertificateVal

[GitHub] nifi pull request: Nifi 1365

Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/163#discussion_r49487257 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/pom.xml --- @@ -120,4 +124,99 @@ provided

[GitHub] nifi pull request: Nifi 1365

Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/163#discussion_r49487334 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/pom.xml --- @@ -120,4 +124,99 @@ provided

[GitHub] nifi pull request: Nifi 1365

Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/163#discussion_r49487195 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/PGPUtil.java --- @@ -0,0 +1,8

[GitHub] nifi pull request: Nifi 1365

Github user alopresto commented on the pull request: https://github.com/apache/nifi/pull/163#issuecomment-170986937 Since the length check confused two people I'm changing it to `> -1`. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] nifi pull request: NIFI-1156: HTML Parsing Processors Bundle

Github user markap14 commented on the pull request: https://github.com/apache/nifi/pull/124#issuecomment-170978164 @jdye64 I left a lot of inline comments while doing a code review. Mostly just pointing out either naming conventions that we should strive to be consistent with, or poin

[GitHub] nifi pull request: NIFI-1156: HTML Parsing Processors Bundle

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/124#discussion_r49482412 --- Diff: nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/PutHTMLElement.java --- @@ -0,0 +1,150 @@ +/* + * Licen

[GitHub] nifi pull request: NIFI-1156: HTML Parsing Processors Bundle

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/124#discussion_r49482104 --- Diff: nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/GetHTMLElement.java --- @@ -0,0 +1,243 @@ +/* + * Licen

[GitHub] nifi pull request: NIFI-1156: HTML Parsing Processors Bundle

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/124#discussion_r49482019 --- Diff: nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/ModifyHTMLElement.java --- @@ -0,0 +1,164 @@ +/* + * Li

[GitHub] nifi pull request: NIFI-1156: HTML Parsing Processors Bundle

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/124#discussion_r49481748 --- Diff: nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/test/java/org/apache/nifi/TestGetHTMLElement.java --- @@ -0,0 +1,319 @@ +/* + * L

[GitHub] nifi pull request: NIFI-1156: HTML Parsing Processors Bundle

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/124#discussion_r49481551 --- Diff: nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/test/java/org/apache/nifi/TestGetHTMLElement.java --- @@ -0,0 +1,319 @@ +/* + * L

[GitHub] nifi pull request: NIFI-1156: HTML Parsing Processors Bundle

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/124#discussion_r49481366 --- Diff: nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/test/java/org/apache/nifi/TestGetHTMLElement.java --- @@ -0,0 +1,319 @@ +/* + * L

[GitHub] nifi pull request: NIFI-1156: HTML Parsing Processors Bundle

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/124#discussion_r49481210 --- Diff: nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/test/java/org/apache/nifi/AbstractHTMLTest.java --- @@ -0,0 +1,74 @@ +/* + * Lice

[GitHub] nifi pull request: NIFI-1156: HTML Parsing Processors Bundle

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/124#discussion_r49480961 --- Diff: nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/PutHTMLElement.java --- @@ -0,0 +1,150 @@ +/* + * Licen

[GitHub] nifi pull request: NIFI-1156: HTML Parsing Processors Bundle

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/124#discussion_r49480952 --- Diff: nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/PutHTMLElement.java --- @@ -0,0 +1,150 @@ +/* + * Licen

[GitHub] nifi pull request: NIFI-1156: HTML Parsing Processors Bundle

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/124#discussion_r49480617 --- Diff: nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/AbstractHTMLProcessor.java --- @@ -0,0 +1,120 @@ +/* +

[GitHub] nifi pull request: NIFI-1156: HTML Parsing Processors Bundle

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/124#discussion_r49480382 --- Diff: nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/GetHTMLElement.java --- @@ -0,0 +1,243 @@ +/* + * Licen

[GitHub] nifi pull request: NIFI-1156: HTML Parsing Processors Bundle

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/124#discussion_r49480407 --- Diff: nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/GetHTMLElement.java --- @@ -0,0 +1,243 @@ +/* + * Licen

[GitHub] nifi pull request: NIFI-1156: HTML Parsing Processors Bundle

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/124#discussion_r49480317 --- Diff: nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/GetHTMLElement.java --- @@ -0,0 +1,243 @@ +/* + * Licen

[GitHub] nifi pull request: NIFI-1156: HTML Parsing Processors Bundle

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/124#discussion_r49479161 --- Diff: nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/AbstractHTMLProcessor.java --- @@ -0,0 +1,120 @@ +/* +

[GitHub] nifi pull request: NIFI-1156: HTML Parsing Processors Bundle

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/124#discussion_r49480077 --- Diff: nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/GetHTMLElement.java --- @@ -0,0 +1,243 @@ +/* + * Licen

[GitHub] nifi pull request: NIFI-1156: HTML Parsing Processors Bundle

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/124#discussion_r49480004 --- Diff: nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/GetHTMLElement.java --- @@ -0,0 +1,243 @@ +/* + * Licen

[GitHub] nifi pull request: NIFI-1156: HTML Parsing Processors Bundle

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/124#discussion_r49479943 --- Diff: nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/GetHTMLElement.java --- @@ -0,0 +1,243 @@ +/* + * Licen

[GitHub] nifi pull request: NIFI-1156: HTML Parsing Processors Bundle

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/124#discussion_r49479814 --- Diff: nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/GetHTMLElement.java --- @@ -0,0 +1,243 @@ +/* + * Licen

[GitHub] nifi pull request: Nifi 1365

Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/163#discussion_r49479578 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/PGPUtil.java --- @@ -0,0 +1,89 @@

[GitHub] nifi pull request: NIFI-1233 upgraded to Kafka 0.9.0.0

Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/168#discussion_r49476929 --- Diff: nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/pom.xml --- @@ -37,12 +37,12 @@ org.apache.kafka

[GitHub] nifi pull request: NIFI-1156: HTML Parsing Processors Bundle

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/124#discussion_r49478696 --- Diff: nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/AbstractHTMLProcessor.java --- @@ -0,0 +1,120 @@ +/* +

[GitHub] nifi pull request: NIFI-1156: HTML Parsing Processors Bundle

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/124#discussion_r49478637 --- Diff: nifi-nar-bundles/nifi-html-bundle/nifi-html-processors/src/main/java/org/apache/nifi/AbstractHTMLProcessor.java --- @@ -0,0 +1,120 @@ +/* +

[GitHub] nifi pull request: NIFI-1283 Fixing ControllerStatusReportingTask ...

Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/166 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[GitHub] nifi pull request: Nifi 1365

Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/163#discussion_r49477103 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/PGPUtil.java --- @@ -0,0 +1,89 @@

[GitHub] nifi pull request: NIFI-1317 removed duplicate 'name' instance var...

Github user mattyb149 commented on the pull request: https://github.com/apache/nifi/pull/169#issuecomment-170967446 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] nifi pull request: NIFI-1233 upgraded to Kafka 0.9.0.0

Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/168#discussion_r49477478 --- Diff: nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/pom.xml --- @@ -37,12 +37,12 @@ org.apache.kafka

[GitHub] nifi pull request: NIFI-1233 upgraded to Kafka 0.9.0.0

Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/168#discussion_r49477360 --- Diff: nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/pom.xml --- @@ -37,12 +37,12 @@ org.apache.kafka

[GitHub] nifi pull request: NiFi-1356

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/158#discussion_r49476742 --- Diff: nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/test/java/org/apache/nifi/processors/kite/TestInferAvroSchemaFromCSV.java --- @@ -0,0 +1,

[GitHub] nifi pull request: NiFi-1356

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/158#discussion_r49475763 --- Diff: nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/InferAvroSchemaFromCSV.java --- @@ -0,0 +1,235

[GitHub] nifi pull request: Nifi 1365

Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/163#discussion_r49476661 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/PGPUtil.java --- @@ -0,0 +1,89 @@

[GitHub] nifi pull request: NiFi-1356

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/158#discussion_r49475867 --- Diff: nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/InferAvroSchemaFromCSV.java --- @@ -0,0 +1,235

[GitHub] nifi pull request: NiFi-1356

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/158#discussion_r49475642 --- Diff: nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/InferAvroSchemaFromJSON.java --- @@ -0,0 +1,164

[GitHub] nifi pull request: NiFi-1356

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/158#discussion_r49475535 --- Diff: nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/InferAvroSchemaFromJSON.java --- @@ -0,0 +1,164

[GitHub] nifi pull request: NIFI-1317 removed duplicate 'name' instance var...

GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/169 NIFI-1317 removed duplicate 'name' instance variable You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi NIFI-1317 Alternatively you can rev

[GitHub] nifi pull request: NiFi-1356

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/158#discussion_r49475506 --- Diff: nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/InferAvroSchemaFromJSON.java --- @@ -0,0 +1,164

[GitHub] nifi pull request: Nifi 1365

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/163#discussion_r49474698 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/pom.xml --- @@ -120,4 +124,99 @@ provided

[GitHub] nifi pull request: Nifi 1365

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/163#discussion_r49474547 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/test/java/org/apache/nifi/web/security/x509/ocsp/OcspCertificateVali

[GitHub] nifi pull request: Nifi 1365

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/163#discussion_r49474399 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/pom.xml --- @@ -120,4 +124,99 @@ provided

[GitHub] nifi pull request: Nifi 1365

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/163#discussion_r49474365 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/pom.xml --- @@ -120,4 +124,99 @@ provided

[GitHub] nifi pull request: NIFI-1233 upgraded to Kafka 0.9.0.0

GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/168 NIFI-1233 upgraded to Kafka 0.9.0.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi NIFI-1233 Alternatively you can review and apply the

[GitHub] nifi pull request: NIFI-1283 Fixing ControllerStatusReportingTask ...

Github user markap14 commented on the pull request: https://github.com/apache/nifi/pull/166#issuecomment-170953688 @jvwing - nice catch! Will merge this in shortly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi pull request: NIFI-1376 Provide access to logged messages fro...

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/165#discussion_r49469400 --- Diff: nifi-mock/src/main/java/org/apache/nifi/util/MockProcessorLog.java --- @@ -16,20 +16,57 @@ */ package org.apache.nifi.util; +imp

[GitHub] nifi pull request: NIFI-1376 Provide access to logged messages fro...

Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/165#discussion_r49470011 --- Diff: nifi-mock/src/main/java/org/apache/nifi/util/MockProcessorLog.java --- @@ -16,20 +16,57 @@ */ package org.apache.nifi.util; +import

[GitHub] nifi pull request: NIFI-1378 fixed JMS URI validation

GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/167 NIFI-1378 fixed JMS URI validation simplified JmsFactory check for SSL and scheme-less URIs ensured URI validation is handled by ActiveMqConnectionFactory ensured informative error messages are s

[GitHub] nifi pull request: Nifi 1324

Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/162#issuecomment-170932242 Code changes look good. Verified compatability existing NiFi installs. Needed to address a few minor contrib-check issues. --- If your project is set up for it, you can

[GitHub] nifi pull request: Nifi 1324

Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/162 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enable

[GitHub] nifi pull request: Nifi 1324

Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/162#issuecomment-170906614 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en