Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/17#discussion_r64796094
--- Diff:
minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/util/ConfigTransformer.java
---
@@ -616,15 +630,21 @@ private static void
GitHub user JPercivall opened a pull request:
https://github.com/apache/nifi/pull/480
NIFI-1943 added proper ReadsAttribute to PutFile
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JPercivall/nifi NIFI-1943
Alternatively you
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/349
Yup I will start an in-depth review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user JPercivall opened a pull request:
https://github.com/apache/nifi/pull/484
Nifi-1808-1.0-add-license
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JPercivall/nifi NIFI-1808-1.0-add-license
Alternatively you can
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/349#discussion_r65374220
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/AbstractAWSIoTProcessor.java
---
@@ -0,0
Github user JPercivall closed the pull request at:
https://github.com/apache/nifi/pull/467
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/349#discussion_r65385897
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/PutAWSIoT.java
---
@@ -0,0 +1,141
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/349#discussion_r65387577
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/PutAWSIoT.java
---
@@ -0,0 +1,141
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/349#discussion_r65387960
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/PutAWSIoT.java
---
@@ -0,0 +1,141
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/349
I actually already committed general MQTT processors [1] and they have some
good "best practices" with regards to publishing/consuming messages and MQTT I
think would be good to follow
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/349
The more I type out and try to easily distinguish GetAWSIoT and PutAWSIoT
the more I think MQTT should be integrated into the name and all four of the
processors should be Publish/Consume
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/349
Does AWS IoT support communicating over SSL with MQTT or shadows? If so,
that option should be added.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/349
A bit nit picky and I may be alone here, but I find putting "if" statements
and their content on the same line a bit hard to read when trying to read
someone else's code. For exam
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/349#discussion_r65405495
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/util/MqttWebSocketAsyncClient.java
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/349#discussion_r65411771
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/GetAWSIoT.java
---
@@ -0,0 +1,153
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/349#discussion_r65412507
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/util/MqttWebSocketAsyncClient.java
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/349
For the new dependencies, NOTICE/LICENSE information needs to be added if
applicable. Paho is EPL 1.0 licensed and requires being added to the nar NOTICE
like so[1]. Do the other two new deps have
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/349#discussion_r65413629
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/AbstractAWSIoTProcessor.java
---
@@ -0,0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/349#discussion_r65416412
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/AbstractAWSIoTProcessor.java
---
@@ -0,0
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/349
The Get/PutAWSIoT processors read and overwrite mqttClient many times
without a read/write lock, this can lead to problems in multi-threaded
scenarios. For example, the both processors call
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/349#discussion_r65418441
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/AbstractAWSIoTProcessor.java
---
@@ -0,0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/349#discussion_r65418924
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/GetAWSIoT.java
---
@@ -0,0 +1,153
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/349#discussion_r65419729
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/GetAWSIoT.java
---
@@ -0,0 +1,153
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/349#discussion_r65420217
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/util/IoTMessage.java
---
@@ -0,0 +1,44
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/349#discussion_r65420622
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/PutAWSIoTShadow.java
---
@@ -0,0 +1,110
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/349#discussion_r65420794
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/PutAWSIoT.java
---
@@ -0,0 +1,141
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/349#discussion_r65420897
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/PutAWSIoT.java
---
@@ -0,0 +1,141
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/349#discussion_r65421171
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/GetAWSIoT.java
---
@@ -0,0 +1,153
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/349#discussion_r65422861
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/GetAWSIoTShadow.java
---
@@ -0,0 +1,116
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/349#discussion_r65423265
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/GetAWSIoTShadow.java
---
@@ -0,0 +1,116
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/349#discussion_r65424552
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/AbstractAWSIoTProcessor.java
---
@@ -0,0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/349#discussion_r65425287
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/AbstractAWSIoTProcessor.java
---
@@ -0,0
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/349
A couple places have weird comments like "// @TRACE 252=connect to host {0}
port {1} timeout {2}". Is this a convention I'm not aware of or left over from
copy/paste?
---
If your
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/349
Currently the only tests are integration tests that rely on an AWS
instance. I would like to see more true unit tests. For inspiration, check out
the Publish/Consume MQTT unit tests[1].
[1
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/480
Thanks @trkurc, should be quite simple
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/480
@trkurc I can take care of it, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/324
Looks good +1
Will merge into master and 0.x
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/17#discussion_r67004047
--- Diff:
minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/util/schema/common/BaseSchema.java
---
@@ -51,18 +55,80 @@ public void
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/528
+1
Fixes problem and adds unit test check (which properly fails without the
fix). I will merge it into 0.x and master. Thanks @olegz
---
If your project is set up for it, you can reply
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/252
Gonna review this for potential inclusion in 0.7.0.
There are merge conflicts, @jskora can you rebase it?
---
If your project is set up for it, you can reply to this email and have your
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/458
@jskora rebased and addressed comments, @trkurc are you able to finish
reviewing this for 0.7.0?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/272
@taftster will you have time to finish up this review for 0.7.0 or do you
want me to finish it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/458
@trkurc ok, in order to get 0.7.0 as soon as possible, would you mind if
another committer took over reviewing?
---
If your project is set up for it, you can reply to this email and have your
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/252#discussion_r67190072
--- Diff:
nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java
---
@@ -0,0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/252#discussion_r67189259
--- Diff:
nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java
---
@@ -0,0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/252#discussion_r67190110
--- Diff:
nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java
---
@@ -0,0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/252#discussion_r67189960
--- Diff:
nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java
---
@@ -0,0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/252#discussion_r67187797
--- Diff:
nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java
---
@@ -0,0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/252#discussion_r67189534
--- Diff:
nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java
---
@@ -0,0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/252#discussion_r67191945
--- Diff:
nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java
---
@@ -0,0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/252#discussion_r67193966
--- Diff:
nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java
---
@@ -0,0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/252#discussion_r67193173
--- Diff:
nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java
---
@@ -0,0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/252#discussion_r67195219
--- Diff:
nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java
---
@@ -0,0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/252#discussion_r67213076
--- Diff:
nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java
---
@@ -0,0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/252#discussion_r67214948
--- Diff:
nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java
---
@@ -0,0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/252#discussion_r67216685
--- Diff:
nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java
---
@@ -0,0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/252#discussion_r67217364
--- Diff:
nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/test/java/org/apache/nifi/processors/media/TestExtractMediaMetadata.java
---
@@ -0,0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/252#discussion_r67218529
--- Diff:
nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java
---
@@ -0,0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/252#discussion_r67221005
--- Diff:
nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/test/java/org/apache/nifi/processors/media/TestExtractMediaMetadata.java
---
@@ -0,0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/252#discussion_r67221558
--- Diff:
nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/test/java/org/apache/nifi/processors/media/TestExtractMediaMetadata.java
---
@@ -0,0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/252#discussion_r67222367
--- Diff:
nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/test/java/org/apache/nifi/processors/media/TestExtractMediaMetadata.java
---
@@ -0,0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/252#discussion_r67222856
--- Diff:
nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java
---
@@ -0,0
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/252#discussion_r67227890
--- Diff: nifi-assembly/NOTICE ---
@@ -289,6 +289,11 @@ The following binary components are provided under the
Apache Software License v
Apache
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/252
I set this up to analyze all the files I have in my downloads folder to see
what happened and what errors I came across. I found a couple interesting ones.
The first should be a
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/272
@taftster I'll let you finish it up tonight if you have time since you've
already had eyes on it. If you're not able to, I'll take a look tomorrow.
---
If your project is se
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/252#discussion_r67402505
--- Diff:
nifi-nar-bundles/nifi-media-bundle/nifi-media-processors/src/main/java/org/apache/nifi/processors/media/ExtractMediaMetadata.java
---
@@ -0,0
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/252
Thanks for the updates @jskora, unless if you say otherwise I'm going to
assume you're gonna get this knocked out for 0.7.0 as soon as possible. If you
think you need more time and c
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r67433123
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-nar/src/main/resources/META-INF/LICENSE
---
@@ -0,0 +1,239
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r67435351
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/main/java/org/apache/nifi/processors/windows/event/log
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r67435751
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/main/java/org/apache/nifi/processors/windows/event/log
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r67437336
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/main/java/org/apache/nifi/processors/windows/event/log
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r67438723
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/main/java/org/apache/nifi/processors/windows/event/log
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r67438756
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/main/java/org/apache/nifi/processors/windows/event/log
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r67438939
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/main/java/org/apache/nifi/processors/windows/event/log
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r67439340
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/main/java/org/apache/nifi/processors/windows/event/log/jna
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r67439511
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/main/java/org/apache/nifi/processors/windows/event/log
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r67440149
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/main/java/org/apache/nifi/processors/windows/event/log
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r67440428
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/main/java/org/apache/nifi/processors/windows/event/log/jna
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r67442237
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/test/java/org/apache/nifi/processors/windows/event/log
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r67442458
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/test/java/org/apache/nifi/processors/windows/event/log
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r67442740
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/test/java/org/apache/nifi/processors/windows/event/log
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r67443126
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/test/java/org/apache/nifi/processors/windows/event/log
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r67443110
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/test/java/org/apache/nifi/processors/windows/event/log
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r67443261
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/test/java/org/apache/nifi/processors/windows/event/log
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r67514060
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/main/java/org/apache/nifi/processors/windows/event/log
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r67515113
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/main/java/org/apache/nifi/processors/windows/event/log
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/349
Hey @KayLerch we're starting to wrap up the 0.7.0 release, did you get a
chance to address these concerns?
---
If your project is set up for it, you can reply to this email and have your
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/536
@jjmeyer0 this was committed to 0.x but unfortunately the magic "This
closes #536." commit line only works for the master branch. Could you manually
close this PR?
---
If your project
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/349
@KayLerch unfortunate you won't be able to finish it for 0.7.0 but I'm
looking forward to having it in 1.0.0! I'm going to change the status of the
ticket from "Patch Availa
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r67525476
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/main/java/org/apache/nifi/processors/windows/event/log
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/525#discussion_r67525744
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/main/java/org/apache/nifi/processors/windows/event/log/jna
GitHub user JPercivall opened a pull request:
https://github.com/apache/nifi/pull/543
NIFI-1834 Create PutTCP Processor
Took Matt Brown's patch and applied my comments.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JPerc
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/543
@trixpan of course you can suggest it. I don't have experience using TCP in
production so I don't know exactly what a user would want. Can you provide a
use-case?
---
If your project
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/272
@taftster thanks for taking another look, yup I can merge this when I get a
chance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/543
I agree with @joewitt
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/272
Thanks for the assist @apiri
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/543#discussion_r67707310
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutTCP.java
---
@@ -0,0 +1,270
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/543#discussion_r67707758
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutTCP.java
---
@@ -0,0 +1,270
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/542#discussion_r67713339
--- Diff:
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseJSON.java
---
@@ -89,6 +89,25
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/542#discussion_r67714535
--- Diff:
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseJSON.java
---
@@ -89,6 +89,25
201 - 300 of 445 matches
Mail list logo
