[GitHub] nifi pull request: NIFI-1218 upgraded Kafka to 0.9.0.0 client API

2015-12-16 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/143#discussion_r47814729 --- Diff: nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/test/java/org/apache/nifi/processors/kafka/TestPutKafka.java --- @@ -474,6 +475,18

[GitHub] nifi pull request: NIFI-1218 upgraded Kafka to 0.9.0.0 client API

2015-12-16 Thread olegz
Github user olegz closed the pull request at: https://github.com/apache/nifi/pull/143 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi pull request: NIFI-1218 upgraded Kafka to 0.9.0.0 client API

2015-12-16 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/143#issuecomment-165296041 Merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi pull request: NIFI-1289 added support for refreshing properti...

2015-12-16 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/142 NIFI-1289 added support for refreshing properties - Added _getNewInstance()_ operation to NiFiProperties to ensure there is a way to refresh/reload NiFi properties - Fixed javadocs You can merge

[GitHub] nifi pull request: NIFI-1243 added null check for 'currentReadClai...

2015-12-02 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/137 NIFI-1243 added null check for 'currentReadClaimStream' . . .before it is being closed You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi

[GitHub] nifi pull request: NIFI-1234 Correcting container functionality fo...

2015-12-02 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/136#issuecomment-161287833 I am on the side of @apiri. I can't imagine that was the desirable behavior either, since it was simply inconsistent. If one **explicitly** requests an array, than

[GitHub] nifi pull request: added embedded Kafka server and tests

2015-11-30 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/134 added embedded Kafka server and tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi NIFI-1219 Alternatively you can review and apply

[GitHub] nifi pull request: NIFI-1192 added support for dynamic properties ...

2015-11-24 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/131#issuecomment-159345927 @markap14 @trkurc The PR comments were addressed. I was hoping to get Kafka embedded server with this commit as well (for testing), but so far it doesn't appear to be very

[GitHub] nifi pull request: NIFI-1192 added support for dynamic properties ...

2015-11-23 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/131#issuecomment-159052094 @trkurc @markap14 @joewitt Guys, this one is strictly for review as I am still working on adding the same dynamic properties logic for PutKafka. But since it contains

[GitHub] nifi pull request: NIFI-1192 added support for dynamic properties ...

2015-11-23 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/131#issuecomment-159129775 Thanks @markap14! indeed it's a bit dirty and I have to polish it for style-check, comments etc. As I mentioned in commit message somewhere this was primarily for initial

[GitHub] nifi pull request: NIFI-1192 added support for Dynamic Properties ...

2015-11-20 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/129#issuecomment-158542457 @trkurc @joewitt @markap14 Guys, please see the updated commit. This one has a bit more work as it includes some polishing since we discovered few more issues, one

[GitHub] nifi pull request: NIFI-1192 added support for Dynamic Properties ...

2015-11-20 Thread olegz
Github user olegz closed the pull request at: https://github.com/apache/nifi/pull/129 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi pull request: NIFI-1074 added initial support for IDE integra...

2015-11-18 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/108#issuecomment-157839054 After discussing it with the team we agreed (at least for now) simply keep the reference to my github - https://github.com/olegz/nifi-ide-integration and it is already

[GitHub] nifi pull request: NIFI-748 Fixed logic around handling partial qu...

2015-11-16 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/123#issuecomment-157029989 @trkurc @joewitt @apiri Guys, please see the latest commit. Didn't squash it, so its easier to read and see what's been addressed. In summary: 1. Since based

[GitHub] nifi pull request: NIFI-1164 decreased the chances of race conditi...

2015-11-16 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/126 NIFI-1164 decreased the chances of race condition Removed checks for 'if (getState() != ControllerServiceState.DISABLED)’ from StandardControllerServiceNode.verifyCanEnable(..) operations based

[GitHub] nifi pull request: NIFI-1164 decreased the chances of race conditi...

2015-11-16 Thread olegz
Github user olegz closed the pull request at: https://github.com/apache/nifi/pull/126 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi pull request: NIFI-1164 decreased the chances of race conditi...

2015-11-16 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/126#issuecomment-157173562 Pulling back, see comments in JIRA --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi pull request: NIFI-748 Fixed logic around handling partial qu...

2015-11-15 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/123#discussion_r44872287 --- Diff: nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/lucene/DocsReader.java

[GitHub] nifi pull request: NIFI-748 Fixed logic around handling partial qu...

2015-11-15 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/123#discussion_r44872756 --- Diff: nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/lucene/DocsReader.java

[GitHub] nifi pull request: NIFI-748 Fixed logic around handling partial qu...

2015-11-15 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/123#discussion_r44872506 --- Diff: nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/lucene/DocsReader.java

[GitHub] nifi pull request: NIFI-748 Fixed logic around handling partial qu...

2015-11-15 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/123#discussion_r44873446 --- Diff: nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/lucene/DocsReader.java

[GitHub] nifi pull request: NIFI-748 Fixed logic around handling partial qu...

2015-11-13 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/123 NIFI-748 Fixed logic around handling partial query results from prove… …nance repository - Ensured that failures derived form correlating Document to its actual provenance event do fail

[GitHub] nifi pull request: NIFI-1107 - Create new PutS3ObjectMultipart pro...

2015-11-12 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/121#discussion_r44715683 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3ObjectMultipart.java --- @@ -0,0 +1,550

[GitHub] nifi pull request: NIFI-1107 - Create new PutS3ObjectMultipart pro...

2015-11-12 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/121#discussion_r44713942 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3ObjectMultipart.java --- @@ -0,0 +1,550

[GitHub] nifi pull request: NIFI-1107 - Create new PutS3ObjectMultipart pro...

2015-11-12 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/121#discussion_r44716157 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3ObjectMultipart.java --- @@ -0,0 +1,550

[GitHub] nifi pull request: NIFI-1124 NIFI-1062 Fixed PutHDFS processor to ...

2015-11-11 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/119#issuecomment-155764650 @trkurc addressed, thanks for looking! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi pull request: NIFI-1143 Fixed race condition which caused int...

2015-11-11 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/120 NIFI-1143 Fixed race condition which caused intermittent failures Fixed the order of service state check in PropertyDescriptor Encapsulated the check into private method for readability Modified

[GitHub] nifi pull request: NIFI-1000 Fixed JmsFactory to properly obtain d...

2015-11-10 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/118#discussion_r44422157 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/pom.xml --- @@ -152,7 +152,8 @@ language governing permissions and limitations under

[GitHub] nifi pull request: NIFI-1000 Fixed JmsFactory to properly obtain d...

2015-11-10 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/118#discussion_r44423561 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/pom.xml --- @@ -152,7 +152,8 @@ language governing permissions and limitations under

[GitHub] nifi pull request: NIFI-1000 Fixed JmsFactory to properly obtain d...

2015-11-10 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/118#discussion_r44423704 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/pom.xml --- @@ -152,7 +152,8 @@ language governing permissions and limitations under

[GitHub] nifi pull request: NIFI-1000 Fixed JmsFactory to properly obtain d...

2015-11-10 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/118#discussion_r44432971 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestGetJMSQueue.java --- @@ -24,73

[GitHub] nifi pull request: NIFI-1024 NIFI-1062 Fixed PutHDFS processor to ...

2015-11-10 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/119 NIFI-1024 NIFI-1062 Fixed PutHDFS processor to properly route failures. Ensured that during put failures the FlowFile is routed to 'failure' relationship. Added validation test Re-enabled

[GitHub] nifi pull request: NIFI-1024 NIFI-1062 Fixed PutHDFS processor to ...

2015-11-10 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/119#issuecomment-155618292 @bbende - all done, please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi pull request: NIFI-1061 fixed deadlock caused by DBCPConnecti...

2015-11-09 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/117 NIFI-1061 fixed deadlock caused by DBCPConnectionPool.onConfigured() Current implementation of DBCPConnectionPool was attempting to test if connection could be obtained via dataSource.getConnection

[GitHub] nifi pull request: NIFI-1099 fixed the handling of InterruptedExce...

2015-11-09 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/115#issuecomment-155174624 Closing it in favor of addressing each individually instead of a blanket as was suggested --- If your project is set up for it, you can reply to this email and have your

[GitHub] nifi pull request: NIFI-1099 fixed the handling of InterruptedExce...

2015-11-09 Thread olegz
Github user olegz closed the pull request at: https://github.com/apache/nifi/pull/115 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi pull request: NIFI-1000 Fixed JmsFactory to properly obtain d...

2015-11-09 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/118 NIFI-1000 Fixed JmsFactory to properly obtain destiniation name Re-enabled JMS Tests that were annotated with @Ignore You can merge this pull request into a Git repository by running: $ git pull

[GitHub] nifi pull request: NIFI-1099 fixed the handling of InterruptedExce...

2015-11-06 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/115#issuecomment-154428329 I just want to make sure that we are all on the same page; _repeat the interrupt_ in the context of _Thread.interrupt()_ simply implies communication of something that have

[GitHub] nifi pull request: NIFI-1099 fixed the handling of InterruptedExce...

2015-11-05 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/115 NIFI-1099 fixed the handling of InterruptedException In many places current code simply swallows InterruptedException without allowing calling thread to be notified of the interrupt. We should

[GitHub] nifi pull request: NIFI-1099 fixed the handling of InterruptedExce...

2015-11-05 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/115#issuecomment-154248804 Great book, great guy and if you can't get a book here is his writeup on the subject - http://www.ibm.com/developerworks/library/j-jtp05236/. The bottom line

[GitHub] nifi pull request: Nifi 631

2015-11-03 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/113#discussion_r43741352 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListFile.java --- @@ -0,0 +1,378

[GitHub] nifi pull request: Nifi 631

2015-11-03 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/113#discussion_r43740910 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListFile.java --- @@ -0,0 +1,378

[GitHub] nifi pull request: Nifi 631

2015-11-03 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/113#discussion_r43740642 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListFile.java --- @@ -0,0 +1,378

[GitHub] nifi pull request: Nifi 631

2015-11-03 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/113#discussion_r43739796 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListFile.java --- @@ -0,0 +1,378

[GitHub] nifi pull request: [NIFI-987] Added Processor For Writing Events t...

2015-11-03 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/91#discussion_r43783354 --- Diff: nifi-nar-bundles/nifi-riemann-bundle/nifi-riemann-processors/src/main/java/org/apache/nifi/processors/riemann/PutRiemann.java --- @@ -0,0 +1,376

[GitHub] nifi pull request: Nifi 631

2015-11-03 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/113#discussion_r43782371 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListFile.java --- @@ -0,0 +1,378

[GitHub] nifi pull request: NIFI-869 Fixed formatting issue

2015-10-31 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/110#issuecomment-152734921 Pushed to the trunk --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request: NIFI-869 Fixed formatting issue

2015-10-31 Thread olegz
Github user olegz closed the pull request at: https://github.com/apache/nifi/pull/110 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi pull request: NIFI-1051 Allowed FileSystemRepository to skip ...

2015-10-29 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/111 NIFI-1051 Allowed FileSystemRepository to skip un-readable entries. The exception was caused due to basic file permissions. This fix overrides 'visitFileFailed' method of SimpleFileVisitor to log

[GitHub] nifi pull request: NIFI-1074 added initial support for IDE integra...

2015-10-27 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/108 NIFI-1074 added initial support for IDE integration Includes instructions for Eclipse You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi

[GitHub] nifi pull request: NIFI-1021 added support for Provenance event st...

2015-10-20 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/102#issuecomment-149621632 Closing after discussing it with Joe. Will resubmit once proposed implementation is realized within the context of the ReportingTask --- If your project is set up

[GitHub] nifi pull request: NIFI-1021 added support for Provenance event st...

2015-10-20 Thread olegz
Github user olegz closed the pull request at: https://github.com/apache/nifi/pull/102 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

<    1   2   3   4   5