Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/179
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enable
Github user mcgilman commented on the pull request:
https://github.com/apache/nifi/pull/179#issuecomment-174050331
Awesome @bbende great work! I'll go ahead and merge this in now. Thanks
everyone!
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user bbende commented on the pull request:
https://github.com/apache/nifi/pull/179#issuecomment-174049864
Just a quick update on the scenario where some messages get resent...
I turned on rsyslog debug and I noticed that rsyslog seemed to be queueing
up responses until
Github user bbende commented on the pull request:
https://github.com/apache/nifi/pull/179#issuecomment-173968940
@trkurc thanks for the review, i liked your idea about the
AsyncChannelDispatcher extending ChannelDispatcher so I went ahead and did
that, and addressed the other stuff as
Github user trixpan commented on the pull request:
https://github.com/apache/nifi/pull/179#issuecomment-173830226
@bbende I have been running some tests that I usually use around reliable
destinations (disconnects, repeated messages, unexpected restarts) and all
worked to expected (ex
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/179#issuecomment-173770289
@bbende - this is an awesome contribution. most of my comments are minor
and of the ilk of we should fix next chance we get, with the exception of the
'comand' typo
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/179#discussion_r50490991
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListenRELP.java
---
@@ -0,0 +1,224 @@
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/179#discussion_r50490685
--- Diff:
nifi-commons/nifi-processor-utilities/src/main/java/org/apache/nifi/processor/util/listen/dispatcher/SocketChannelDispatcher.java
---
@@ -0,0 +1,243 @
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/179#discussion_r50490353
--- Diff:
nifi-commons/nifi-processor-utilities/src/main/java/org/apache/nifi/processor/util/listen/dispatcher/DatagramChannelDispatcher.java
---
@@ -0,0 +1,164
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/179#discussion_r50490153
--- Diff:
nifi-commons/nifi-processor-utilities/src/main/java/org/apache/nifi/processor/util/listen/dispatcher/DatagramChannelDispatcher.java
---
@@ -0,0 +1,164
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/179#discussion_r50490135
--- Diff:
nifi-commons/nifi-processor-utilities/src/main/java/org/apache/nifi/processor/util/listen/dispatcher/DatagramChannelDispatcher.java
---
@@ -0,0 +1,164
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/179#discussion_r50489858
--- Diff:
nifi-commons/nifi-processor-utilities/src/main/java/org/apache/nifi/processor/util/listen/dispatcher/ChannelDispatcher.java
---
@@ -0,0 +1,39 @@
+
Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/179#discussion_r50489401
--- Diff:
nifi-commons/nifi-processor-utilities/src/main/java/org/apache/nifi/processor/util/listen/AbstractListenEventProcessor.java
---
@@ -0,0 +1,356 @@
Github user bbende commented on the pull request:
https://github.com/apache/nifi/pull/179#issuecomment-173726265
Thanks for reviewing @mcgilman and @trkurc !
I pushed up a small commit that fixed a couple of minor logging issues and
addressed the comment Matt made about the p
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/179#issuecomment-173712640
@mcgilman - I have been reviewing. I should be complete tonight. Haven't
found any show stoppers yet.
---
If your project is set up for it, you can reply to this email and
Github user mcgilman commented on the pull request:
https://github.com/apache/nifi/pull/179#issuecomment-173707708
Spent some time reviewing the patch. Overall, I think the code looks good.
Additional nit-picky item outside of my previous comment.
- I could see possibly wantin
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/179#discussion_r50451076
--- Diff:
nifi-commons/nifi-processor-utilities/src/main/java/org/apache/nifi/processor/util/listen/dispatcher/DatagramChannelDispatcher.java
---
@@ -0,0 +1,1
Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/179#issuecomment-173044611
I like the docs to help with reviewing! I good amount here to review and
test!
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/179
NIFI-1273 Adding ListenRELP Processor
This pull request adds a ListenRELP processor which includes refactoring
code that was previously part of ListenSyslog into a reusable framework for
implementing
19 matches
Mail list logo
