Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/334
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enable
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/334#issuecomment-211091503
Perfect, working on it now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user Hejki commented on the pull request:
https://github.com/apache/nifi/pull/334#issuecomment-211089956
I'm ok with @jvwing tests, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/334#issuecomment-211080536
@Hejki please let us know if you are good with the tests from @jvwing ,
then we can amend your commit with @jvwing changes and merge.
---
If your project is set up for it,
Github user jvwing commented on the pull request:
https://github.com/apache/nifi/pull/334#issuecomment-207841740
@Hejki, this looks like a solid fix to me. One thing I suggest you add is
some unit tests, which I missed when I "fixed" this a couple months ago. If
that sounds like ove
GitHub user Hejki opened a pull request:
https://github.com/apache/nifi/pull/334
NIFI-1738 - Repair logger names for ControllerStatusReportingTask
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Hejki/nifi nifi-1738
Alternativel
