Hi,
I'm canceling the vote per the licensing issue Tony found within our
LICENSE. I'm voting -1 and canceling in lieu of MINIFICPP-319 [1] . I will
create RC2 once that issue is addressed and merged.
Thank you everyone!
[1] https://issues.apache.org/jira/browse/MINIFICPP-319
On Nov 24, 2017
Hi Tony,
The version we are including is 5.7.0 ( this can be verified via
/thirdparty/rocksdb/include/rocksdb/version.h ). I think that [6] and [7]
apply to a version before, which implied to me that we were okay to include
rocksdb under the Apache License.
This version includes a few
Question about the LICENSE. When swapping in rocksdb for leveldb [1], the
leveldb LICENSE section was removed. I looked at the ticket chatter [2] and
saw "Not including RocksDB because
it is dual licensed under Apache License, Version2.0". In reviewing the
rocksdb thirdparty, it has a
+1 (non-binding)
Verified hashes, built and ran all tests, built docker and ran all integration
tests. Ran a simple test flow.
I did run into one minor issue, which is if virtualenv is configured with
python3 by default then creating the virtual environment for the pytest
integration tests
+1, binding
Built, tested, and created Docker container on OS X 10.12 and Centos 7.3
Ran a few flows and verified expected functionality on both systems.
Thanks for getting this RC together!
On Wed, Nov 22, 2017 at 10:49 AM, Jeremy Dyer wrote:
> Your right let’s not put out
Your right let’s not put out another release for this since it can be simply
fixed by using the flags you provided. I went through the build again and
validated the runtime. Everything looks good now so I’m changing my vote to a
+1
- Jeremy
> On Nov 22, 2017, at 10:31 AM, Marc
Jeremy,
Thanks for your vote.
Your version of GCC will likely cause this warnings due to spec
additions, and since RocksDB fails on any warning your build failed as well.
Please try the following before running make: *cmake -DPORTABLE=ON
-DFAIL_ON_WARNINGS= ..*
I am not in favor of
-1 Marc I'm having trouble getting this to build using Ubuntu 17.10 with
GCC version "gcc (Ubuntu 7.2.0-8ubuntu3) 7.2.0" seems to be an issue with
building RocksDB with this version of GCC. Looks like there is an update of
RocksDB where this would work however. What do you think?
On Tue, Nov 21,
Hello Apache NiFi Community,
I am pleased to be calling this vote for the source release of Apache NiFi
MiNiFi C++, nifi-minifi-cpp-0.3.0.
The source archive, signature, and digests can be located at:
Source Archive: