Re: [ANNOUNCEMENT] Call for Validation of Apache NuttX 9.0.0 (incubating) RC0

I tested Spresense and seems ok +1 On Mon, Apr 27, 2020 at 2:46 AM Adam Feuer wrote: > Brennan, > > Cool, thanks for doing that check on Cygwin and WSL. I merged your PR. > > -adam > > On Sun, Apr 26, 2020 at 5:40 PM Brennan Ashton > wrote: > > > Adam > > I have a PR for the Windows documentat

Direct commits to repository

Hi, Xiang, I am look at this merge in the incubator master https://github.com/apache/incubator-nuttx/commit/434086ff935a760d274518d79d2abcf99294fc6f along with three additional commits. These appear to have go directly to incubator_nuttx/master without going through a PR.  Was this a mistake

Re: Direct commits to repository

I am looking at this merge in the incubator master https://github.com/apache/incubator-nuttx/commit/434086ff935a760d274518d79d2abcf99294fc6f along with three additional commits. These appear to have gone directly to incubator_nuttx/master without going through a PR.  Was this a mistake? I

Re: Direct commits to repository

The PR come from Juha: https://github.com/apache/incubator-nuttx/pull/892 But this PR just change the code under libs/libc/netdb, I don't know why the commit log show: arch/mips/src/pic32mz/pic32mz_oneshot-lowerhalf.c is deleted arch/mips/src/pic32mz/pic32mz_oneshot_lowerhalf.c is modified On Mon,

Re: Direct commits to repository

The PR come from Juha: https://github.com/apache/incubator-nuttx/pull/892 Juha's PR looks clean to me. But this PR just change the code under libs/libc/netdb, I don't know why the commit log show: arch/mips/src/pic32mz/pic32mz_oneshot-lowerhalf.c is deleted arch/mips/src/pic32mz/pic32mz_ones

Re: Direct commits to repository

On Mon, Apr 27, 2020 at 10:51 PM Gregory Nutt wrote: > > > > The PR come from Juha: > > https://github.com/apache/incubator-nuttx/pull/892 > > Juha's PR looks clean to me. > > > But this PR just change the code under libs/libc/netdb, I don't know > > why the commit log show: > > arch/mips/src/pic3

Re: Direct commits to repository

Yes, here is the PR I sent from my openamp branch: https://github.com/apache/incubator-nuttx/pull/894 But merged by you two hour ago. Do you select "Create a merge commit" or "Rebase and merge"? I always select rebase and merge, but it is hard to construct what happened in the past from the

Re: Direct commits to repository

... it is hard to construct what happened in the past from the present. I forget about the commit messages. This makes it clear exactly what happened (https://mail-archives.apache.org/mod_mbox/nuttx-commits/202004.mbox/browser): From xiaoxi...@apache.org Subject [incubat

Re: Direct commits to repository

He can also see all of the merges made earlier in the day, include the merge of Juha's PR.  They did not cause the problem.  This one direct merge to incubator_nuttx caused the wild merge messages and the duplicate commits: On 4/27/2020 9:37 AM, Gregory Nutt wrote: ... it is hard to constru

nxstyle questions

I am not sure what to do about the following nxstyle complaints: (1) arch/arm/include/stm32/stm32f40xxx_irq.h:361:3: error: Invalid section for this file type Should I just remove the section? What to do with the unused __ASSEMBLY__, __cplusplus, and extern "C" stuff? (2) arch/arm/include/stm32/

Re: nxstyle questions

> (1) arch/arm/include/stm32/stm32f40xxx_irq.h:361:3: error: Invalid > section for this file type For a header file the section "Public Functions" should not exist, it's actually "Public Functions Prototypes" > (2) arch/arm/include/stm32/irq.h:81:3: warning: #include outside of > 'Included Files'

Re: nxstyle questions

Here are the supported sections: https://github.com/apache/incubator-nuttx/blob/master/tools/nxstyle.c#L131 (There is an "s" too many in what I wrote above, it's "Public Function Prototypes") On Mon, Apr 27, 2020 at 7:20 PM Abdelatif Guettouche wrote: > > > (1) arch/arm/include/stm32/stm32f40xxx_

Re: nxstyle questions

On Mon, Apr 27, 2020 at 1:29 PM Abdelatif Guettouche wrote: > Here are the supported sections: > https://github.com/apache/incubator-nuttx/blob/master/tools/nxstyle.c#L131 > (There is an "s" too many in what I wrote above, it's "Public Function > Prototypes") Thanks. More below: > On Mon, Apr 27

Re: nxstyle questions

Yes! Should I do the same workaround as Greg mentions there, namely to add an additional "Included Files" section for the conditional includes? We have just been ignoring this style error in previous PRs. If you want someone to ignore and nxstyle complaint, I think the the etiquette is to a

More Cygwin failures

I have a WIP CI run on my fork for Windows using Cygwin (it a bit ugly right now), but it has a fair amount of sim builds failing. Could someone take a look. I'll put a draft PR up tonight for CI but for now this is what I have. https://github.com/btashton/incubator-nuttx/runs/623326287?check_suit

Re: More Cygwin failures

I have a WIP CI run on my fork for Windows using Cygwin (it a bit ugly right now), but it has a fair amount of sim builds failing. Could someone take a look. I'll put a draft PR up tonight for CI but for now this is what I have. https://github.com/btashton/incubator-nuttx/runs/623326287?check_s

Re: More Cygwin failures

On Mon, Apr 27, 2020, 12:54 PM Gregory Nutt wrote: > > > I have a WIP CI run on my fork for Windows using Cygwin (it a bit ugly > > right now), but it has a fair amount of sim builds failing. Could someone > > take a look. I'll put a draft PR up tonight for CI but for now this is > what > > I hav

Re: More Cygwin failures

Makes sense. Maybe we can create a test dat file for the windows builds that only targets the sim configs we care about? Maybe another for a set of ARM targets? Thanks for helping me understand what's going on. I think we should have wpcap working windows.  It is an important feature and it

stm32/Kconfig error?

In arch/arm/src/stm32/Kconfig, config ARCH_CHIP_STM32F303RD and config ARCH_CHIP_STM32F303RE each appear twice. I think this is an error? Nathan

Re: stm32/Kconfig error?

In arch/arm/src/stm32/Kconfig, config ARCH_CHIP_STM32F303RD and config ARCH_CHIP_STM32F303RE each appear twice. I think this is an error? I haven't looked, but once is certainly enough.  A PR is probably in order.

Re: More Cygwin failures

Makes sense. Maybe we can create a test dat file for the windows builds that only targets the sim configs we care about? Maybe another for a set of ARM targets?  Thanks for helping me understand what's going on. I think we should have wpcap working windows.  It is an important feature an

Re: stm32/Kconfig error?

I opened PR #899, "arch/arm/src/stm32/Kconfig - Remove redundant ARCH_CHIP configs" to fix it. The next PR will be #900! Not bad for, what, four months?! Nathan

Re: Direct commits to repository

No sure what happen, maybe I push the wrong remote git? Does github have any configuration to enforce all merge must come from web UI? On Mon, Apr 27, 2020 at 11:47 PM Gregory Nutt wrote: > > He can also see all of the merges made earlier in the day, include the > merge of Juha's PR. They did no

Re: Direct commits to repository

There is but I don't think it is configurable via the .asf.yaml file, so I'm not sure how we could enable it. --Brennan On Mon, Apr 27, 2020, 7:33 PM Xiang Xiao wrote: > No sure what happen, maybe I push the wrong remote git? Does github > have any configuration to enforce all merge must come f

Re: Direct commits to repository

No sure what happen, maybe I push the wrong remote git? Does github have any configuration to enforce all merge must come from web UI? In this case, AFAIK no harm was done.  A little bit a odd history was added but no file changes.  So I think we are good.  We do need to be careful; all of

Re: Direct commits to repository

I think we could ask Infra to set some 'protected' branches, which means we can not do force push on these branches, but I'm not sure if it is possible to forbid a simple push... In my experience, I've pushed wrong commits to the repo when developing projects in ASF, and usually the solution is to

Re: Direct commits to repository

On Mon, Apr 27, 2020 at 11:47 PM Xiang Xiao wrote: > > The maintainer still can create a new branch and push to that branch > directly, only the master branch get the strict protection. > The setting must be done by INFRA team, I can raise a JIRA ticket if the > community agree that it's the righ

Build failed in Jenkins: NuttX-Nightly-Build #109

See Changes: -- [...truncated 4.52 MB...] sched/pthread_setaffinity.d sched/pthread_setschedparam.d sched/pthread_setschedprio.d sched/pthread_setspeci

[VOTE] Apache NuttX 9.0.0 (incubating) RC1 release

Hello all, Apache NuttX (Incubating) 9.0.0 has been staged under [1] and it's time to vote on accepting it for release. If approved we will seek final release approval from the IPMC. Voting will be open for 72hr. This release includes fixes on top of 9.0.0-RC0 mostly around documentation as well a