Thank you for your feedback, Alan!
Alan, David,
I created the pull request:
https://github.com/apache/incubator-nuttx/pull/2010/
Edi
On Fri, Oct 16, 2020 at 9:17 PM Alan Carvalho de Assis
wrote:
> Hi Eduard,
>
> Yes, the modification appears correct.
>
> Also I noticed that the "nxsem_wait_uni
Hi Eduard,
Yes, the modification appears correct.
Also I noticed that the "nxsem_wait_uninterruptible(&priv->txsem)" is
already inside a "#ifdef CONFIG_STM32H7_SPI_DMA", so your modification
will make the logic symmetric.
You just need to create a fork, do your modification and submit a PR.
BR,
Hi Edi,
You would fork https://github.com/apache/incubator-nuttx and submit a PR
from your fork.
I will have a look at the PR on Monday when I back at the computer.
David
*From:* Eduard Niesner [mailto:niesneredu...@gmail.com]
*Sent:* Friday, October 16, 2020 10:28 AM
*To:* dev@nuttx.ap
On Fri, Oct 16, 2020 at 1:28 PM Eduard Niesner
wrote:
> I attached it as .txt.
>
> *Please note:* I made the code build and the SPI seems to work
> as expected - I am communicating with an at45db flash over SPI and mounted
> smartFS on it and the communication seems to work. I am not sure if
> th
I attached it as .txt.
*Please note:* I made the code build and the SPI seems to work as expected
- I am communicating with an at45db flash over SPI and mounted smartFS on
it and the communication seems to work. I am not sure if the changes that I
did are enough or if the entire spi_interrupt func
Hi Eduard,
Unfortunately the mailing list is refusing patches with extension
.patch, we need to rename it to .txt to get it here.
BTW, you can submit a Pull Request directly to
https://github.com/apache/incubator-nuttx and we could review it.
BR,
Alan
On 10/16/20, Eduard Niesner wrote:
> Hi a
I debugged and found what my problem was. I am using a custom configuration
for a custom board and did not notice that the Make.defs and flash.ld
changed for H7 between Nuttx 9.0 and Nuttx 9.1. My configuration was still
using the old ones from 9.0.
This is why even though the build worked it was c
Hi all,
I am not familiar with the code from nuttx\arch\arm\src\stm32h7\stm32_spi.c
but I believe that there is an issue.
"txresult" is defined and used only if the CONFIG_STM32H7_SPI_DMA is
defined.
But in the spi_interrupt function, the txresult is used regardless of
whether CONFIG_STM32H7_SPI_D
