On Wed, Jan 8, 2020, 11:05 AM Nathan Hartman
wrote:
> On Wed, Jan 8, 2020 at 3:05 AM Xiang Xiao
> wrote:
>
> > Yes, all Jenkins related files should put on the Jenkins server as
> > much as possible.
>
>
> What if something happens to the Jenkins server? Will the files exist
> somewhere else too
On Wed, Jan 8, 2020 at 3:05 AM Xiang Xiao wrote:
> Yes, all Jenkins related files should put on the Jenkins server as
> much as possible.
What if something happens to the Jenkins server? Will the files exist
somewhere else too?
Thanks,
Nathan
Hi Xiang,
-Original Message-
From: Xiang Xiao [mailto:xiaoxiang781...@gmail.com]
Sent: Tuesday, January 07, 2020 6:30 PM
To: dev@nuttx.apache.org
Subject: Re: Working Effectively (was Point of Order)
David, why you think this tool promote the violation?
[DBS]
May be I do not understand
On Wed, Jan 8, 2020 at 12:01 PM Gregory Nutt wrote:
>
>
> >> Since code check part is available now, could I and Duo prepare to setup
> >> Jenkins CI job firstly?
> >> At fist, start to do the PR check stage according to the workflow option
> >> chosen, then go to the build stage in the next coup
Greg, Jenkins CI would not touch nuttx/ and apps/ end-user directories.
Gregory Nutt 于2020年1月8日周三 上午11:58写道：
> > Since code check part is available now, could I and Duo prepare to setup
> > Jenkins CI job firstly?
> > At fist, start to do the PR check stage according to the workflow option
> > c
Since code check part is available now, could I and Duo prepare to setup
Jenkins CI job firstly?
At fist, start to do the PR check stage according to the workflow option
chosen, then go to the build stage in the next couple of days.
We could optimize all the stages step by step once we start w
Since code check part is available now, could I and Duo prepare to setup
Jenkins CI job firstly?
At fist, start to do the PR check stage according to the workflow option
chosen, then go to the build stage in the next couple of days.
We could optimize all the stages step by step once we start work
like a very bad
> > choice.
> >
> > How is this being justified?
> >
> > David
> >
> >
> > -Original Message-
> > From: Alin Jerpelea [mailto:jerpe...@gmail.com]
> > Sent: Tuesday, January 07, 2020 4:18 AM
> > To: dev@nuttx.apac
..@gmail.com]
> Sent: Tuesday, January 07, 2020 4:18 AM
> To: dev@nuttx.apache.org
> Subject: Re: Working Effectively (was Point of Order)
>
> I think that we should update all code with nxstyle then we start with a
> clean code on which patches will be checked
>
> Alin
>
07, 2020 4:18 AM
To: dev@nuttx.apache.org
Subject: Re: Working Effectively (was Point of Order)
I think that we should update all code with nxstyle then we start with a
clean code on which patches will be checked
Alin
On Tue, Dec 31, 2019 at 3:42 PM Haitao Liu wrote:
> Greg, I'll fi
https://github.com/apache/incubator-nuttx/pull/47
checkpatch.sh is ready, you can invoke it like this:
tools/checkpatch.sh -p patch-list
tools/checkpatch.sh -c commit-list
tools/checkpatch.sh -f file-list
The first two just check the modified portion, the last one check the
whole content.
And with
I think that we should update all code with nxstyle then we start with a
clean code on which patches will be checked
Alin
On Tue, Dec 31, 2019 at 3:42 PM Haitao Liu wrote:
> Greg, I'll finish the nxstyle & check script these days firstly and then
> take time to handle the two issues you mentio
Yes, nxstyle check script comes at first. After it can check the PR patch,
then I'll jump into the build stage including CI setup, autobuild. As to
apache build, ZhangDuo or David may help in the process since they are
familiar with apache infra and github integration.
Gregory Nutt 于2020年1月2日周四 上
Thanks your detailed explanation to nxstyle. I'll try my best to update
nxstyle step by step.
You also have other responsibilities with the tooling for the workflow,
correct? If you need any help with nxstyle, I can also work with it.
Let me know if you need anything.
Thanks your detailed explanation to nxstyle. I'll try my best to update
nxstyle step by step.
Gregory Nutt 于2020年1月1日周三 上午4:42写道：
>
> > For (1) false negatives, I just create a few simple test files and
> > verify that nxstyle detects the error. Pretty easy.
> >
> > For (2) false positives, it i
For (1) false negatives, I just create a few simple test files and
verify that nxstyle detects the error. Pretty easy.
For (2) false positives, it is a little more difficult. I use
nuttx/sched to do these because it probably follows the coding
standard the best. ...
There is another tes
Perhaps a function called block_comment_width() could be called
for each line. It would return zero if the line is not the first or
last line of a block comment and the position of the final '*' + 1 if
is it is a block comment.
The first line of a block comment starts with "/***" (pe
Greg, I'll finish the nxstyle & check script these days firstly and then
take time to handle the two issues you mentioned if allowed. I wish I could
be competent to take over full responsibility for nxstyle.c.
I think it would be great if you took over primary responsibility for
nxstyle. Wi
Greg, I'll finish the nxstyle & check script these days firstly and then
take time to handle the two issues you mentioned if allowed. I wish I could
be competent to take over full responsibility for nxstyle.c.
Gregory Nutt 于2019年12月30日周一 下午11:31写道：
> [moved from priv...@nuttx.apache.org]
>
> Hi
the
functional change.
Exactly!
On a branch in a PR and the squash, it AFTER CI and testing.
-Original Message-
From: Nathan Hartman [mailto:hartman.nat...@gmail.com]
Sent: Monday, December 30, 2019 6:49 PM
To: dev@nuttx.apache.org
Subject: Re: Working Effectively (was Point of Order)
On
, December 30, 2019 6:01 PM
To: dev@nuttx.apache.org
Subject: Re: Working Effectively (was Point of Order)
On Tue, Dec 31, 2019 at 7:09 AM David Sidrane
wrote:
>
> Hold on!
> Having a coding standard with 4000+ files in the repo that do not pass the
> test…
> …reminds me of this grea
We have two options:
1.Ensure the changed/new code comply with the coding standard
2.Ensure the whole modified file comply with the coding standard
If the community like the 2nd option, I am fine.
I can tell you how I did this in the past as the single committer. In
the last year or so, nxs
On Mon, Dec 30, 2019 at 9:00 PM Xiang Xiao
wrote:
>
> We have two options:
> 1.Ensure the changed/new code comply with the coding standard
> 2.Ensure the whole modified file comply with the coding standard
> If the community like the 2nd option, I am fine.
I can think of one disadvantage to #2:
he weeds!
>
We have two options:
1.Ensure the changed/new code comply with the coding standard
2.Ensure the whole modified file comply with the coding standard
If the community like the 2nd option, I am fine.
> David
>
> -Original Message-
> From: Xiang Xiao [mailto:xiaoxia
che.org
Subject: Re: Working Effectively (was Point of Order)
On Mon, Dec 30, 2019 at 11:05 PM David Sidrane
wrote:
>
> >Haitao is preparing a script for style check, the feature include:
> >1.Auto build nxstyle
>
> 2.Improve nxstyle to check the partial file for su
tor don't modify that portion.
> >3.Input can be the source files, patch file or commit id
>
> -Original Message-
> From: Xiang Xiao [mailto:xiaoxiang781...@gmail.com]
> Sent: Monday, December 30, 2019 6:20 AM
> To: priv...@nuttx.apache.org
> Subject: Re: Working
[moved from priv...@nuttx.apache.org]
Hi, Xiao Xiang and Haitao Liu
Haitao is preparing a script for style check, the feature include:
1.Auto build nxstyle
2.Improve nxstyle to check the partial file for supporting patch like file
3.Input can be the source files, patch file or commit id
I men
Point of order.
Recognizing that using the ASF mailing list is all new to some of us. I
would like to ask people to keep on topic in threads.
Greg raised the issue that the PPMC is not getting things done. I think it
is impossible to organize an effort without communication that is focused
28 matches
Mail list logo
