Re: nuttx\arch\arm\src\stm32h7\stm32_spi.c uses txresult even when SPI_DMA is not defined

2020-10-16 Thread Eduard Niesner
Thank you for your feedback, Alan! Alan, David, I created the pull request: https://github.com/apache/incubator-nuttx/pull/2010/ Edi On Fri, Oct 16, 2020 at 9:17 PM Alan Carvalho de Assis wrote: > Hi Eduard, > > Yes, the modification appears correct. > > Also I noticed that the "nxsem_wait_uni

Re: nuttx\arch\arm\src\stm32h7\stm32_spi.c uses txresult even when SPI_DMA is not defined

2020-10-16 Thread Alan Carvalho de Assis
Hi Eduard, Yes, the modification appears correct. Also I noticed that the "nxsem_wait_uninterruptible(&priv->txsem)" is already inside a "#ifdef CONFIG_STM32H7_SPI_DMA", so your modification will make the logic symmetric. You just need to create a fork, do your modification and submit a PR. BR,

RE: nuttx\arch\arm\src\stm32h7\stm32_spi.c uses txresult even when SPI_DMA is not defined

2020-10-16 Thread David Sidrane
@nuttx.apache.org *Subject:* Re: nuttx\arch\arm\src\stm32h7\stm32_spi.c uses txresult even when SPI_DMA is not defined I attached it as .txt. *Please note:* I made the code build and the SPI seems to work as expected - I am communicating with an at45db flash over SPI and mounted smartFS on it and the

Re: nuttx\arch\arm\src\stm32h7\stm32_spi.c uses txresult even when SPI_DMA is not defined

2020-10-16 Thread Nathan Hartman
On Fri, Oct 16, 2020 at 1:28 PM Eduard Niesner wrote: > I attached it as .txt. > > *Please note:* I made the code build and the SPI seems to work > as expected - I am communicating with an at45db flash over SPI and mounted > smartFS on it and the communication seems to work. I am not sure if > th

Re: nuttx\arch\arm\src\stm32h7\stm32_spi.c uses txresult even when SPI_DMA is not defined

2020-10-16 Thread Eduard Niesner
I attached it as .txt. *Please note:* I made the code build and the SPI seems to work as expected - I am communicating with an at45db flash over SPI and mounted smartFS on it and the communication seems to work. I am not sure if the changes that I did are enough or if the entire spi_interrupt func

Re: nuttx\arch\arm\src\stm32h7\stm32_spi.c uses txresult even when SPI_DMA is not defined

2020-10-16 Thread Alan Carvalho de Assis
Hi Eduard, Unfortunately the mailing list is refusing patches with extension .patch, we need to rename it to .txt to get it here. BTW, you can submit a Pull Request directly to https://github.com/apache/incubator-nuttx and we could review it. BR, Alan On 10/16/20, Eduard Niesner wrote: > Hi a