Re: java 1.5 additions

2007-09-22 Thread Jacopo Cappellato
Hi Adam, Adam Heath wrote: ... ps: My work continues on adding java 1.5 features to ofbiz. I'm adding generics markup to all of framework/. I'm also using enhanced for loops, Integer.valueOf(in place of parseInt), auto-boxing, StringBuilder, etc). > pps: While doing this work, I'm also doi

Re: java 1.5 additions

2007-09-22 Thread Tim Ruppert
Adam, this amount of working thru everything is going to be a HUGE win for OFBiz IMHO. My only recommendation is to start submitting them in SMALL batches. No one is going to go thru a 20K patch file and be certain of ANYTHING that happened. And without more tests on this code base - it'

Re: UtilXml.childElementList returning null

2007-09-22 Thread Tim Ruppert
+1 Cheers, Tim -- Tim Ruppert HotWax Media http://www.hotwaxmedia.com o:801.649.6594 f:801.649.6595 On Sep 22, 2007, at 4:57 PM, Adam Heath wrote: What's the point of UtilXml.childElementList returning null, if the element to look thru is null? This causes code that calls that function to

UtilXml.childElementList returning null

2007-09-22 Thread Adam Heath
What's the point of UtilXml.childElementList returning null, if the element to look thru is null? This causes code that calls that function to have to check for a null return; wouldn't it just be better to return an empty list, and then not have to have the rest of the code base cluttered with all

java 1.5 additions

2007-09-22 Thread Adam Heath
Last week, I asked about whether using java 1.5 features was allowed; the response I got was ok. So, I've gone to town, adding lots of stuff to the framework code. While doing so, I've come upon a few questions I need to ask. First, what is the policy on read-only maps? The entity and service e

[jira] Closed: (OFBIZ-615) Re-Factor WorkEffort permissions to follow new patterns

2007-09-22 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-615. - Resolution: Fixed Fix Version/s: SVN trunk Assignee: Jacques Le Roux (was: Andrew

[jira] Assigned: (OFBIZ-1177) Products should have Roles just as ProductCategories and ProductCatalogs do

2007-09-22 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum reassigned OFBIZ-1177: -- Assignee: Adrian Crum > Products should have Roles just as ProductCategories and ProductCatalog

[jira] Updated: (OFBIZ-1245) Service Engine inconsistent in handling fail results

2007-09-22 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-1245: --- Attachment: framework_service.patch Updated patch against latest SVN. > Service Engine inconsistent

Re: Extend View Entity

2007-09-22 Thread Jacques Le Roux
If nobody see a problem, I will add these fields. Jacques De : "Chris Howe" <[EMAIL PROTECTED]> > A couple of useful fields have been left off OrderHeaderAndItems view entity. > > OI.orderItemTypId > OI.itemDescription > OI.orderItemSeqId > > Could these be added to the definition for a quick sol