[jira] Commented: (OFBIZ-2097) show organizationPartyId in header, rewrote financial history for a party in relation to the organizationParty

2008-12-23 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659057#action_12659057 ] David E. Jones commented on OFBIZ-2097: --- Using it as a default would be fine, as lon

BLOCKER: svn commit: r725053 - in /ofbiz/trunk: applications/order/entitydef/ applications/party/webapp/partymgr/WEB-INF/ applications/party/webapp/partymgr/party/ applications/party/widget/partymgr/

2008-12-23 Thread Hans Bakker
This commit (or later) causes pagination to stop working... The page numbers change but the listing does not. How to test? set the pagination in framework/widget/config/widget.properties to "1" In the latest svn go to invoice click 'find' and try to paginatethe invoiceId shown will not ch

Re: ShoppingCart.addOrIncreaseItem

2008-12-23 Thread David E Jones
It makes it easier to review if you avoid formatting changes. Usually a note along with the patch that the file had tabs in it would help the committer to know that it needs updating. BTW, the best way to generate patches is to use SVN itself, something like "svn diff > mychanges.patch".

Re: Enhancing UI

2008-12-23 Thread BJ Freeman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 the tooltips labels would be in there own file for an entity. my thoughts are that a class that is similar to the one that maintains the DB tables can be hooked into Create of the file to add the tooltips. I envision this to be set to defaults based on

Re: Follow up on SeleniumXml Test framework for OFBiz

2008-12-23 Thread David E Jones
That sounds great Brett. Thank you for your help in this area. -David On Dec 23, 2008, at 10:54 AM, Brett Palmer wrote: Update on SeleniumXml: There was an effort to replace some of the LGPL code in Selenium a few months back. I am following up with the developers to see how this is comin

[jira] Updated: (OFBIZ-1906) Allow use of HttpServletRequest.getRemoteUser() for 3rd party authentication

2008-12-23 Thread Luke Prentice (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Prentice updated OFBIZ-1906: - Attachment: ofbiz-and-CAS.pdf thanks for picking this up. to help with testing prior to committi

[jira] Commented: (OFBIZ-1906) Allow use of HttpServletRequest.getRemoteUser() for 3rd party authentication

2008-12-23 Thread Guy Gershoni (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658975#action_12658975 ] Guy Gershoni commented on OFBIZ-1906: - Hi Jacques, Thanks heaps for picking up the iss

Re: svn commit: r728855 - in /ofbiz/trunk/framework/common: webcommon/portal/listPortalPortlets.ftl webcommon/portal/portalPage.ftl widget/PortalPageForms.xml

2008-12-23 Thread Bruno Busco
What is the logic of this?

Re: svn commit: r728855 - in /ofbiz/trunk/framework/common: webcommon/portal/listPortalPortlets.ftl webcommon/portal/portalPage.ftl widget/PortalPageForms.xml

2008-12-23 Thread Bruno Busco
Hi Hans, I have not very clear the difference between mainPortalPage and originalPortalPage. I see that originalPortalPage is a field of the PortalPage indicating where (eventually) the PortalPage has been copied from. What about mainPortalPage ? Could you please describe briefly? Thank you, Bruno

Re: Follow up on SeleniumXml Test framework for OFBiz

2008-12-23 Thread Jacques Le Roux
And then maybe the issue https://issues.apache.org/jira/browse/OFBIZ-680 would still be interesting Jacques From: "Brett Palmer" Update on SeleniumXml: There was an effort to replace some of the LGPL code in Selenium a few months back. I am following up with the developers to see how this is

Re: Follow up on SeleniumXml Test framework for OFBiz

2008-12-23 Thread Brett Palmer
Update on SeleniumXml: There was an effort to replace some of the LGPL code in Selenium a few months back. I am following up with the developers to see how this is coming along. Over the holiday break I will open up a Jira issue with a patch to include all the SeleniumXml source and the build to

Re: ShoppingCart.addOrIncreaseItem

2008-12-23 Thread Stephen Rufle
Added checkItemExists to ShoppingCart.addOrIncreaseItem(... , boolean checkItemsExists) I wanted to have the group review my patch before I created a JIRA. I am new to patching so I see in my patch that it is changing tabs to spaces and adding the new code and applies to multiple files all in one

[jira] Closed: (OFBIZ-2102) Resetting OrderHeader status in ShoppingCartServices.loadCartFromOrder

2008-12-23 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-2102. -- Resolution: Fixed Assignee: Jacques Le Roux Thanks Stephen, Your patch is in trunk rev.

[jira] Issue Comment Edited: (OFBIZ-1906) Allow use of HttpServletRequest.getRemoteUser() for 3rd party authentication

2008-12-23 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658825#action_12658825 ] jacques.le.roux edited comment on OFBIZ-1906 at 12/23/08 3:24 AM: ---

[jira] Commented: (OFBIZ-1906) Allow use of HttpServletRequest.getRemoteUser() for 3rd party authentication

2008-12-23 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658825#action_12658825 ] Jacques Le Roux commented on OFBIZ-1906: I have reviewed but not tested this patch.

Re: Discussion: MyPortal vs. framework dashboard

2008-12-23 Thread Hans Bakker
Hi Bruno, currently the framework and the ERP application on top of it, have different target audiences and users. The example component is a showcase of the framework and the myPortal component is a special component showing specific portalpages with specific portlets for the specific kind of u

[jira] Assigned: (OFBIZ-1906) Allow use of HttpServletRequest.getRemoteUser() for 3rd party authentication

2008-12-23 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-1906: -- Assignee: Jacques Le Roux > Allow use of HttpServletRequest.getRemoteUser() for 3rd par

Re: Discussion: MyPortal vs. framework dashboard

2008-12-23 Thread Bruno Busco
Many thanks David and Hans for your feedbacks. Of course for "vs." I did not mean "against". I am more than happy with this collaborating experience. What I meant was: In a framework-only release (which I am now working on) it could be cool to have a "home" page where the user lands when it logs i